On Thu, 16 Dec 2021 at 15:30, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> See last patch in the series for details.
>
> Gerd Hoffmann (5):
> OvmfPkg: add PcdVideoResolutionSource
> OvmfPkg/QemuVideoDxe: simplify InitializeBochsGraphicsMode
> OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_BOCHS_MODES->ColorDepth
> OvmfPkg/QemuVideoDxe: factor out QemuVideoBochsAddMode
> OvmfPkg/QemuVideoDxe: parse edid blob, detect display resolution
>
This looks fine to me in principle, the only question I have about is
the use of a PCD PcdVideoResolutionSource to keep track of what the
height/width PCDs mean.
I don't think this is very idiomatic for EDK2, and I wonder if it
would be better to use [fixed] PCDs for build time configuration, and
perhaps expose the other width/height data (and the associated policy
of what takes precedence over what) via a protocol instead.
In general, I am not too keen on overusing PCDs for any of this, as it
does not have the implied dependency ordering that PPIs or protocols
have.
Jiewen, any thoughts?
> OvmfPkg/OvmfPkg.dec | 7 +
> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 +
> OvmfPkg/Microvm/MicrovmX64.dsc | 1 +
> OvmfPkg/OvmfPkgIa32.dsc | 1 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
> OvmfPkg/OvmfPkgX64.dsc | 1 +
> OvmfPkg/OvmfXen.dsc | 1 +
> OvmfPkg/PlatformDxe/Platform.inf | 1 +
> OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 3 +
> OvmfPkg/QemuVideoDxe/Qemu.h | 6 +-
> OvmfPkg/PlatformDxe/Platform.c | 3 +
> OvmfPkg/QemuVideoDxe/Driver.c | 14 +-
> OvmfPkg/QemuVideoDxe/Gop.c | 2 +-
> OvmfPkg/QemuVideoDxe/Initialize.c | 251 +++++++++++++++++++-------
> 14 files changed, 213 insertions(+), 80 deletions(-)
>
> --
> 2.33.1
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85001): https://edk2.groups.io/g/devel/message/85001
Mute This Topic: https://groups.io/mt/87767746/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-