From nobody Sun Apr 28 19:18:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84956+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84956+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639627050150836.2291409967567; Wed, 15 Dec 2021 19:57:30 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id N05TYY1788612xJOERD01yEd; Wed, 15 Dec 2021 19:57:29 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.117]) by mx.groups.io with SMTP id smtpd.web12.5791.1639627049019350068 for ; Wed, 15 Dec 2021 19:57:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Up1m3u8QBZReQPcNDZCz6kA70tjZGEbA99KETwGB/pu/p2yd7MXt8zpeBQJomrsTQb8mSuJdVfD+l1FnEhE63cKWsKKWonEc9TuczmMlFIjKLtH7IG1Uvnc8fpqBeRlaGkdaztsbMRoXkwtEfp9CW1N7XWBSGJlwEoPH386wUBgKM2YiP43VLZVTsc7yY4ISwwsP8ayRXhHWWlcDN0PPZ6Nk1JJ2P4qsk/oqQbJ65cvhvRi2t/+N4ULEREQcJu6z8B3Qjqt0PSx5Dg+AnpYdvhGQ9d2G0PoZ6oQlFPh8DhZgeU2jRiZyir5v7qL8cARLoE16p5q3A9BXillu+OcD4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ihQanFyamwDoxdsLM1p632g49szpQ8vT4zQ86ocjzWo=; b=P9geegeRVjdCaZMXGCNCoG4V6VrlikTkD2WXAsKSTif+qWzDz+72ELhczx4AGmK8AZdL5AAUYowAYt+p+trh5yx9InzxsxbOy/mIc4VUIoMr96PY+cL5KKVqh45ARKiIFCee0/0obiRYIM56pGn2ra+SnYcqZmMcOoJrcbBHakU2ObSy9ZgzqKeERogluQ2VdqVUPejsUnClpz1qhzz89ypVFLJXLLoetlL1zCTd8Njow4qCZQ8XT3xsbyRtuFu3Oy1W1mutRQMB53IoGS2n7bkAQ1xJUXIpq7cTn1suqP0wO6T9JV8O3ocaEOCbTd8qkpmgOvLEtYp5OgFCDJkhJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB7381.prod.exchangelabs.com (2603:10b6:510:100::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 03:57:28 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552%8]) with mapi id 15.20.4778.017; Thu, 16 Dec 2021 03:57:28 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io Cc: patches@amperecomputing.com, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Sami Mujawar Subject: [edk2-devel] [PATCH v2 1/3] ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition Date: Thu, 16 Dec 2021 10:54:53 +0700 Message-Id: <20211216035455.977400-2-nhi@os.amperecomputing.com> In-Reply-To: <20211216035455.977400-1-nhi@os.amperecomputing.com> References: <20211216035455.977400-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bda388e6-9d5d-4d60-7c6d-08d9c0482d1f X-MS-TrafficTypeDiagnostic: PH0PR01MB7381:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 4J9g3DMgLLAQO6kcToUySq4nid4axsmiq7tDiukTVqLLrnnDbqewyX42NACpF6MXWPE+ObWPIOO/2N2xaEKtbeIppR8esUm/cCXHhGAkKitngturNzr4XzaK928R129CHN0qPFRUlxmII8WvZkZY9CyI/YJ++90uVKCom5RUHtsTcl+M/nZrwsxaExZFAfIqEYoFViHM/PpCoLKqv0xZOO59xylm+jQsc6Rs4zKrlJ7d4Linhp9VC9vctZOhGMpanEq/ZPr91nU0iOXq9LZHbvPn8v63QolmnhMtpZ/A+p/7KzvxhXgWN15fcWTC57Lr3x/kLIEz0aLFVLbnogkXxupOH4INFSlzlcdIFG+ytfziy4Py16drnGS0gynUuvfrnuQCVFcmJL5oVjyOdNwBCZjpAYaN9tztgDagE3oGU9bMVY2FkMbPIFU6rILScZwAvqcBdINmeY4dgmsM1J/Zz8VPdvsG+oOuGVL9fZQrn3ikcHr0IhtpIjQzD+ai74U6hGoGskgNRBUtgmpk76O93GW+FLWG87VAbjKy77+jd8Bv0z/dyGR6k37WfgmJICe/ZbB+b2iO2/J91zHKidG8Uw3lzkg8nR/Tjtqm9u5YmIDcu3QExQYVjHHcUK37k0DTWnWCyh/xVjMI2VM1Cf/tnr3JfhdQhoy09r0uEgC9J6Q8m6qbRd1wRlhe7xFtEWVDW8/EWgSK9xpYc+kLdq/mkw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZeoNVoJUmFjoLEl5Mk9Nw7x9j/0urBaTeuswcHd++Qlbr5oiyQeDJNyPlR6u?= =?us-ascii?Q?/89r5YRBu4nSq8RcJ3RFLR4LNfXWPALVRcT7ZHKzEfJztcseVzI84UKi1qB0?= =?us-ascii?Q?9vNU8NEBLEfmvBMu6N/ShZcPD55oKIvcZ/6rtTiC3EyZPjJH1/00TLvSITV5?= =?us-ascii?Q?TIBt1b34G2yNfLynAb4VqH+GyTO3C7VrIFWEzPLlaUO82PTTK+3r4KyYMlbM?= =?us-ascii?Q?ooVLBRUDJ5jnzd8NKukTi8LVx3fEBXvbSDSq4dXeZxckkTQosbTWlSmDIOHB?= =?us-ascii?Q?61rw/nvPFhIf8durCI7krT/MGso7WVZhxWwHDvHWq+xVe7V2dXxeKgHBx7gp?= =?us-ascii?Q?aq/DiffG/tCXWUvAlvBYI2GcvMYqdb6v3QwUd6Spl0yhf696l0a7c2DkGfdD?= =?us-ascii?Q?xce06qzeV67u29CIRWNU1WwZwL5y3wvPr9/H/xXjB3RUgyaVjZ5ggQdb7wtX?= =?us-ascii?Q?3OjiZmfOArhy0nO+phybh1JsDx/Ori958b0EW2sHz9B5ZvL/NRjLlGc9UOOt?= =?us-ascii?Q?k5pSQrE4rhvSByRDTaKT9nOJ4B3wtClAFTqgl/l62AcLY72lnGqGcSoVZ5HU?= =?us-ascii?Q?Yzw0ArZf4ZGKHPASdn5rQz1inB64oX4uD+kbUV0g8jZFvkWUQhHUsbZ3XIdg?= =?us-ascii?Q?eRa1r68VlkVQ3XdVJYLJkBB5XFHPdzr5uPRQEfMytS4wL41FDNeYAh+1YbER?= =?us-ascii?Q?QHsZuYLKzlfhUhbYXxID1jFNSuM67W3vOSf4A7PuXhRupHFLDg0z/2N9aAor?= =?us-ascii?Q?H+1dwuMmPw0UM+bNWtVD6jHracH/c4ZpWkmyViXXVN1F01HoHdJ72spzTYv3?= =?us-ascii?Q?hfj3WKrSaXDU+muGzSE00TIZWjKkvCivu1Ef1zf4w34ZZWKHo6SU9Tcrf6WH?= =?us-ascii?Q?x7caZis2yRTjdVoBbbTFfDKLAp8nrzmzd31vIszsTXgeuZFF7HwENRia71cb?= =?us-ascii?Q?6zAsRtSkrCf/P+wEwQhAMVbhZihQD+VpaxgcTrOjLfnPewurcy6uqRlnVoHU?= =?us-ascii?Q?r/IwdMTjA2eQ5ihUkAXdNJ/5Z7YrXfmPtwQKfJvQiKDpvf7KGgif7l1e5CkM?= =?us-ascii?Q?v3tfUnp0YQyLQjoMLFvNVI3CnFOdY2gu07iEDtK8KLGhuEaQHUPE2X4RHzUB?= =?us-ascii?Q?6TGRdM9zIXWtKJjhB6TTW/6Mj2dHkKy/dSXnUd685wonrHx33lwwoUuihPMf?= =?us-ascii?Q?H/QH+9bYc+f9nrb1n7EseQgWMt390S66RqSANoURNtufeEfRT2v4NPxKEv1l?= =?us-ascii?Q?ieSs3q5Lln+/9w1CGNO3gctx+MF2hOLhx8XrdB29UAIiRdkxqt/CR+vI2XQa?= =?us-ascii?Q?LQz9YoOyCvqGCNrOGCyyh/Uv59BdZ4akozd4zxbPQlsrzPrqgZxp3u5WhQwm?= =?us-ascii?Q?h/jg8NAc4u74vH7vYM5ziYR8+9oXXWwaOykoDHWymRdw38X4EYR9alpbe72y?= =?us-ascii?Q?XdrKSZpI5fyiAtYqFd4HhxvxsatrkLGwXm622q0O6bMCTN9RtBw3xmQhnYPg?= =?us-ascii?Q?Quw6ZdPjBanPoX1RN55qGp4yOiZN5dVW/3bUxIYtGtRRv1Hcg+3wm4MbPVQ7?= =?us-ascii?Q?WV8r5/N7vTY3Wj0F1fuIShDxEOSPazBsNGSyZdTSiAH5yPoiCR3d4UO5uAvN?= =?us-ascii?Q?opBV70F8uZbjPz0aemg6lOiicFirsoOnGO61CD6jPMGMA4fpRf4l+Tde+wTW?= =?us-ascii?Q?trNFuU7YD2WiCqRMvoLZV3Xj+98=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: bda388e6-9d5d-4d60-7c6d-08d9c0482d1f X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 03:57:28.0769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5zb+8ZhqNS7OcRwxcX0vzOX85nvD/UHgx5jWYPW3OvBZdRlMyGXuIwa1h285PZ2hIRDdGAMs049CO5DLO+PdS2+W31wa9U62nuMwJwKGLKM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7381 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: jE3UJibsUAVZk89maeApPe99x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639627049; bh=kPh3Ym+SR9DEZ0XG0VjbXWLTW4j08u5tgedZFSplmd4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=wfSJox8uzwbwdN1uJF0Vv24Np0+DY0jiIIkm7p4LbclD95+qaEYGDtc3zB2Yf8gjMQ1 gZthqa4Tds9rOK8vsgmRowLwUjWbjvgbxxdXRy6FMqdbWnswSpiWNhl8EUtUbxGrUjGm8 RJfwNDY1oYOY0MCzCGfzKDGnGjVZLy0dkRE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639627051880100001 Content-Type: text/plain; charset="utf-8" This patch removes duplicate HII string definition in the MiscSystemManufacturer.uni. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Rebecca Cran Signed-off-by: Nhi Pham Reviewed-by: Sami Mujawar --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | = 1 - 1 file changed, 1 deletion(-) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufact= urer.uni index 8038f0e4b0bf..2b3b19cab2ea 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni @@ -13,7 +13,6 @@ =20 #string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" #string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" #string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" #string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" #string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified" --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84956): https://edk2.groups.io/g/devel/message/84956 Mute This Topic: https://groups.io/mt/87760769/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun Apr 28 19:18:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84957+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84957+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639627054209378.080792788803; Wed, 15 Dec 2021 19:57:34 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id xOvZYY1788612xRtktZumN1h; Wed, 15 Dec 2021 19:57:33 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.135]) by mx.groups.io with SMTP id smtpd.web08.5838.1639627052881437333 for ; Wed, 15 Dec 2021 19:57:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMgh0y6YFlg6FG8oIAFLbXnv3Xk+f/JyBbP1PWGr0JxMqfSHij1zAQm/kPf75LeK+aRUamzHSKeTuI4bitQ+zdIwljuRhofRGxIYP6eTbce8UEygglrEXZwnHdljv1TGO7R0YeCOdxk+mxkC7iHujb6v9Mr1tOwOyj8w03H3p3wzkB9etRC4F2wyTMea4545QBacS4hYvuM6wwjT9pU+h1RYuvr803m5KDmzd5d1laWQzFx2qIKAw3tyPSm5+qwK4KnfZ4dy6CO0Yj0p9GaXm1ekbFtP8ToPMaKY8wRd6P741vU2E22aV+oBDVSeZJJl2RMr/RT8mL/O8tDk2bIjkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzwdL1Zio1oAGyc5F/V3X9yLWaJmyLTJP4PdjTibX5U=; b=UBQ4HJxOSfH+5ltD84eBRCmxLAdTgTd+Vqt7FQxIAb8rKnf8wU8mBVqJ4P1axPewD3YKpL5+4QZlLRLhbSi1qnuTdA9Ob24JIRNfMT0DZDVUyxHrbEaRKslLTm5siYYYKNbWO89um9DFNr18AFJjimGRYm3IgVtwpGifYpvRk5sVPKDfVq6IJ9P84XjyeDNW1CJZopYa9AXtTfvKXxpKYnN0iM1KF1UUg1BLFu3Vi5EpnvEO4QQTouhom6182cXs/r9u1mHkLvDA7CHiXQ1+QmJ9LCh0JqD+Qx7995f9HdXimPdBxqev7H0O+J2IV1DuIthtJD2Hx0zQFRBcnkts+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB7381.prod.exchangelabs.com (2603:10b6:510:100::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 03:57:31 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552%8]) with mapi id 15.20.4778.017; Thu, 16 Dec 2021 03:57:31 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io Cc: patches@amperecomputing.com, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Sami Mujawar Subject: [edk2-devel] [PATCH v2 2/3] ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib Date: Thu, 16 Dec 2021 10:54:54 +0700 Message-Id: <20211216035455.977400-3-nhi@os.amperecomputing.com> In-Reply-To: <20211216035455.977400-1-nhi@os.amperecomputing.com> References: <20211216035455.977400-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eda872f8-e66a-4bc1-b660-08d9c0482ef0 X-MS-TrafficTypeDiagnostic: PH0PR01MB7381:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: o6EAVWi4QNN9YOH3YSb3xETN/UUYHC63NVMbmDdEBiTpBNabDCFxzXKwfBHViddEpnwLk2P+BIWycX9DgkyTUesF+IZ7ahvheK9ZGrkxJYSnde+djGUu4rK1198XqNKs/iC21Fc5TqC3QU9j44eT4Stz13sGt+JQ1meHF4GfoYtnbTiFbmVwTBkG/q/URkAsI3NOsn10jvBn1WwKQNZ+SifCaombiMarcMRTIN0KT8zr/bKEQjEIOcgN0TYdQZC/z5rvqliLKhWBqjLibg9eFgbRc0ZQr7va+Buq0cW2w3lmauBmAacS6Uvp8ZKOg6JxHeycJl8oabm1bJOTFJkKDpF/gjt5aPrkBxsV9IKSKtDAQjDC0v3s24IJ9QUjKcOI4YO4vUld7xobCBDd5MLuakfHF9BfQN6FcpDKABQmED0YzlGkvqIGmfLHfP5IIRHfOwrOQbxHrByIpB9juOggPZUF+6ANqABcxvFXND4N0uib6jVI8hJPjBA804xgqPd1PCeQtxDYLw9cLplnfcpukVF//p2xIlAOIlg4qe+Pp+0fePAhSH75GmcxxQKwDE2ZoClKFUe0s7e93aMBSInypKbwTxtXulnOslC5otT4/EEtj3QL4I4nUwRgqUEVWBCbQX2IiU8oIsn/ttQj751oZQdD95rmEDnEq7LXF5NT1RI6qeISdMoWlZMPtxOi3qEwk6mN7cmdjhk2hvKHl9N6yg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s9G3stedRfB9zPHWOoE3vRWLW6u6L5zi97o6HO98m4tXrv0r1Zi/awT+Sive?= =?us-ascii?Q?fFHFU+qkEFkApeXJh6mqrs0HVJeyBr7SN/rkzur1O7ylzfvCPXiuw85Nakru?= =?us-ascii?Q?02hVJQ2zJtejfBmcn6RIxgR7jM5pqEhjGRl11ALQDl4fC171tXHlB6Kt+pPI?= =?us-ascii?Q?mf5+9wmm/O6srZKd5avBFbrvo3OHDZa7eJVDuG2TtW1AF6S0k+uTigmPgO7c?= =?us-ascii?Q?LYOO6OKqnytVKUk1ATqHQoi9GyHah436hvwqNCYRp1oOa2ORY5b524iv/97E?= =?us-ascii?Q?gt2v/2/+K0gpnttHuFI4AIZUWL9cSTvPqQkhnCuv00bxNDVhDbip/vC/NYi2?= =?us-ascii?Q?MJjCn8rMuM5tLxq4M2Fs+nBkYWEmSVLPULOi22cHttkKLFq884dBga/KuVnR?= =?us-ascii?Q?VA5f9AqyGPQGeZRH226tnuGNpCE2oI6Q5DH7h9t4llxEkpJm3uWZCc2Q9iO4?= =?us-ascii?Q?phyG3mNVMS8fdg32CBeZgv/dz0Q8vrKAhWalPfCuX7JQpF/zK6FrE8oO8RlZ?= =?us-ascii?Q?cJCEYxbUEE+7IhfQCwM9NkQnYIX8iHeWGQtcc5OE+Lad7t4SBSrjdIsSXsWW?= =?us-ascii?Q?jEvOjMRqkYoWVb8hE1YMz8uKSzkx+BlG2Vck/f3QJ0oBS5hAi2eHuR5kfPt9?= =?us-ascii?Q?yLetRvbvzxjTQyE/KZFe/+oBIPCSuk0C7teKJEaAV8w8bqh1fnDu9aaQWwm0?= =?us-ascii?Q?D5axkoC40E/XX/54tNoYFSKhVeD/pu1y+ojQ0w/DqsLlDLTNhUbSS6DVTHaE?= =?us-ascii?Q?3bAoHxGjt9tZYhfa5ey/fDmLUB2AvtC5wC9Jsf7aGs50J7qvHMBZp7ROGAmi?= =?us-ascii?Q?A6DwWmHMWe1ziBb6E9VkAK5vG5Vj5Ix04xK+aryt8UuLKU28WJC8afEzxi8N?= =?us-ascii?Q?re/YnkkqAnTTcHFCK1GvFI08QH+a5OxnS8o48PSnlvRUhj4SYz3qQlmR+Kd2?= =?us-ascii?Q?0t3j8ANAsUa183PQV5GvSUm7ddckta9L3tT8KhUnXlFm1gAcT9EYZ0z2xEe8?= =?us-ascii?Q?7lH6o0J2pe17wJOZiQ4HdnmVPCJxokCl1G0MddBnoqNDDwM52evAGhmcvdTq?= =?us-ascii?Q?BJ8I1yzHhtEKm9bLW3px1v6RpUJ70nRVQvPAlulBMN8ONSq307c1aOLXlPo4?= =?us-ascii?Q?MBBTFQphUoCAGfj+Hrxbpt0zQjPP6ZdxcvMZJHrWAqjWh8VQioBLuzlqImkk?= =?us-ascii?Q?nNxeKIGDpkN6rVyDJqOpWCNEMKM7MHJK3wXrSWfwKYvvfg0SOdIScyHww+Ug?= =?us-ascii?Q?Td3krwidzBpD0vlDdQp1YaJ7EcwIyv+MRT29Nc9jz31IgD3rE0rTDGm1ZMXk?= =?us-ascii?Q?Sdvv97utA+ACeKQaz8EZOeSigrIn9LPtR/56E/pClVjO5h+aT5RXFwJhIplK?= =?us-ascii?Q?H5kt+kelH5FwjRl8uWYHtYYa9IUHWCKWwxFhwZr9wQBWPPtV3+Z/AIGjWs26?= =?us-ascii?Q?b63TbBEz+CWtVf8364tRoa6orh42lMGUZ7GCnKCL9vwSksE8UAxXqzRPsLqZ?= =?us-ascii?Q?i6Ks94wLYOKY4Tsnc2aCkBFai+uYGc4nGwrwDbwfiLrjfPR+yzZxC6XJVRgT?= =?us-ascii?Q?UjEDbzUVT+WGk1KkAVW9+6zcKMSs9Ezu4AyjNe3QhaSUf14ENRnVgdQXuP08?= =?us-ascii?Q?H/wsfECwVdS3p1cOO3//jD4YK6cyMfh3a+YZKzIBHrfkxiMXE9NOikEy+MCL?= =?us-ascii?Q?bBY37zuAUG1IzxBQ9e5hZAoLeoQ=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: eda872f8-e66a-4bc1-b660-08d9c0482ef0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 03:57:31.2965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IT2JAeGHMiNkHn5KV2eBldX5ZIcnFR9rm5PsbW5hLuuPstR9J3rf8kGSDN8+IsMs11ewlWPCjNtIDzIFXOI/hBGjLWFgt2N8ysykXO5rw2Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7381 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: zlxJ2OuUJsWQ553wHNnBm2Sxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639627053; bh=BjydHZomsrH3ei2rveAd9gBEqc1MGFJWqauCuspOjqI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=nJAV7xrGMgkfFug7PhPoOXm5l+aKBHpuN9TJLNpuV8Rdx403GnebqQNAxtARdR+O1OC 58l2P+at1KGp1vi+3bqeIcOmCamQcYm0DtT0RMzsUHVoH0a+2Jpe2aOsLkj8duErfCxGG Bjd8h6Im2oD7oM1IdHSnXeRzmYvqCREbklY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639627056142100002 Content-Type: text/plain; charset="utf-8" Typically, the information of the SMBIOS type 1/2/3 is fetched from an FRU device during UEFI booting intead of fixed PCDs. Therefore, this patch is to add more HII string fields in the OemMiscLib and support updating these SMBIOS types with the strings provided by the OemMiscLib if the PCDs are empty. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Rebecca Cran Signed-off-by: Nhi Pham Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h = | 3 +++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunctio= n.c | 12 ++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 18 ++++++++++++++++++ 3 files changed, 33 insertions(+) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 569cd5135276..f25c8f3342a9 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -40,11 +40,14 @@ typedef enum { SerialNumType01, UuidType01, SystemManufacturerType01, + VersionType01, SkuNumberType01, FamilyType01, AssertTagType02, SerialNumberType02, BoardManufacturerType02, + ProductNameType02, + VersionType02, SkuNumberType02, ChassisLocationType02, AssetTagType03, diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemMa= nufacturerFunction.c index 6d08a75580e7..5cf72644d0b2 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c @@ -74,12 +74,24 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscSystemManufacturer) { if (StrLen (Product) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_SYSTEM_PRODUCT_NAME); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Product, NULL); + } else { + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_SYSTEM_PRODUCT_NAME), + ProductNameType01 + ); } =20 pVersion =3D (CHAR16 *)PcdGetPtr (PcdSystemVersion); if (StrLen (pVersion) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_SYSTEM_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, pVersion, NULL); + } else { + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_SYSTEM_VERSION), + VersionType01 + ); } =20 OemUpdateSmbiosInfo ( diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index 99ba99e913b6..870610b17243 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -77,18 +77,36 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) { if (StrLen (BaseBoardManufacturer) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, BaseBoardManufactur= er, NULL); + } else { + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER), + BoardManufacturerType02 + ); } =20 BaseBoardProductName =3D (CHAR16 *)PcdGetPtr (PcdBaseBoardProductName); if (StrLen (BaseBoardProductName) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BASE_BOARD_PRODUCT_NAME); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, BaseBoardProductNam= e, NULL); + } else { + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BASE_BOARD_PRODUCT_NAME), + ProductNameType02 + ); } =20 Version =3D (CHAR16 *)PcdGetPtr (PcdBaseBoardVersion); if (StrLen (Version) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BASE_BOARD_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); + } else { + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BASE_BOARD_VERSION), + VersionType02 + ); } =20 OemUpdateSmbiosInfo ( --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84957): https://edk2.groups.io/g/devel/message/84957 Mute This Topic: https://groups.io/mt/87760770/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun Apr 28 19:18:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84958+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84958+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639627056157651.7371750429605; Wed, 15 Dec 2021 19:57:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id KUzcYY1788612xPnVfdCkC3W; Wed, 15 Dec 2021 19:57:35 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.99]) by mx.groups.io with SMTP id smtpd.web10.5788.1639627055010656919 for ; Wed, 15 Dec 2021 19:57:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWZOl50NJqIVKwRzOwkFDvUJ9WLBRmWvZUPH6mLbCQbGNJzT6tK5Klmtrnmkgu6v4fPTPwtmDqYA9E83QcJ7pDbVyltkb5F0hSR3R4QN16b4PCn5Hi8tfceh4DzdLUzqrPeBbA83d5FAsCy0PtfY2JZ2pa4rLYVgPP3KHHvpTnu6gcpKxE5EawVAU3bEIiGjPXEw+r7/YRCke5CntuAUZztBhJbvqG2JO2JwortiOaY16Prxj1Cbqs2EYv1zBAYbqxAAGNiW/JLDc6SrjT1E6w/d2WlXtUx6QOSM5Dcz0yV9WvW8lQ482NNUNpWzBVkXPyCdT8lu9H0v7/1D9MF7Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sp/m7iCuiVXM47MSTgyVaVeB2yJ7nea3BEIw42ahSPI=; b=XrUBc79etGgcXzNriF9RyhC/ICQCTFHPrgDWkypmv9FHOUHUtjJ2UVyB662e4KLlG0PhsLRp1mvbpU2jvk7FWj6B1VeqNcLGRY7jx80TJtctfOrYg08dDRMLNBw3vDZa9TrPzBOppkevsXTnwwVZsKOkVte3hf+zrbtqpQabTLR8nRInVRTFbc2Drj9YbSHEZOdJr7c4/whSBmfqIJK3NsaZXEWSgpYIFBlijH4Ed5MmC1UD937GpMh5Ry0XItOxvHzllNQ6aHoIv0MZ3l6aYLcIrsWiTNjhZgblNIZFizZdYxA4Jlmw7BmMxKsWsskaG+Raoe8SmxyknBiinmJg/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB7381.prod.exchangelabs.com (2603:10b6:510:100::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 03:57:33 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552%8]) with mapi id 15.20.4778.017; Thu, 16 Dec 2021 03:57:33 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io Cc: patches@amperecomputing.com, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Sami Mujawar Subject: [edk2-devel] [PATCH v2 3/3] ArmPkg/ProcessorSubClassDxe: Get serial and part number from OemMiscLib Date: Thu, 16 Dec 2021 10:54:55 +0700 Message-Id: <20211216035455.977400-4-nhi@os.amperecomputing.com> In-Reply-To: <20211216035455.977400-1-nhi@os.amperecomputing.com> References: <20211216035455.977400-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72c949a6-a8f9-4ec1-263d-08d9c04830a1 X-MS-TrafficTypeDiagnostic: PH0PR01MB7381:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: EEvmgzrQe/aJzOjwfIqZD5YPHuzbb+nZSpf2thYd6lPdm/Gwy78Dby3ZvqbfeNDGuwJ5EWS7j6SCDr1C6JqYeCOkUYXX/ySmuCgzTSrRaKQcOiyEXdxwBXWjOCys9d+hs2q/xWTXxacQoB3/lOClcsA8gcl2D+IDtdqkZrYHV+NLfTFArMlhASL91lulLWK6gNdNeR5kipUyZiUOoNQQsjpWWA081R9chALV6fTQWPKTl7MF1+Ed4NUa4gSDPcjaztGd56vAJM2x7c4SWo6adLhBilcnxs8q58KkI24BijhA4tXMqSKcYSiZZC3ikjfjr4T07wFYwH25ufbcfigNpfzahb6hYMJL85qsfFcLXsfC3SPD+WweCzoW8zzd3UKkrhLnALyQh/E0Cf7kr+HxBQfy2Jscess0RVQjknj4fYuH6GD2UsYttefHepnc/FCMUjq4BsQDcOp1lrqBfGYh2ghNbFqjlAoUVznhthBOP1oyF5UwWk941HGpk9LSLCJyXQernLxBslsuyx6XJ3k0PQNZOL2Rf2H8i2c9ZolzYXltRzDH9CrLFklDsxe/fc+4hr71QwpVXWguApxGT87lIbrF6qm0y9N0cWg2ftSJ8Iuq9AGHMzkwWFpOV4wOgaHRwYBmgjHMVGxIIWCS5s4ySNrk7wRAorOk+g7RGzDtsB1hYlnw9xfNbLjGN3GTBUih5/FnlmRT22MzYoaZaUs1ug== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UOsTVzRD5f/8Ey4yCk46CPvYhWJvMcOUH9Kl3BszJndRqpjLMkO6Pep5EbAc?= =?us-ascii?Q?VEwLY1e/gvT1uL8bP8zJMKrMKD/WcJTr0B/vx57AzR8EcRyWthCP9nFOTKvh?= =?us-ascii?Q?PwWB/a8y2C/mlRAjBBUiMiZBTWvGZwYimS4lVg8/j9yEUNyDxg/1RheMEe5h?= =?us-ascii?Q?mHdJApV1GFIocJw2bj+ijOdRPWikueR98dKL+nisuFBVXV6E+PpXdKvAD8oh?= =?us-ascii?Q?zMr5pkfFXi5if9xHbBL8bD/9ulAgG6X6RZdMeXGHosOxsZWZyhtLlB7ylKOM?= =?us-ascii?Q?l0raz0OG2bDQgI8JSx5nxR0JiilCyjawm1oVIC1+FhFGqNXQvhpm7GjBd+Xx?= =?us-ascii?Q?mz1Ljkfe0wpwDOcZgWYWbP2UWrTywBiVxR9qxi6TjaU5d73DHlcsnu9w6CwI?= =?us-ascii?Q?w3/EdJYs0nDmaFCd14YzquTtQv1o7a6Jt2F+jyozY3YcrabnpIkrPuiOqhPU?= =?us-ascii?Q?tLtSb70qmtk6jhO0i2wQugklNjDgNu2gvdCwcT1yAD7mXntAGqHX85tWY7qw?= =?us-ascii?Q?WhU7XpbrFfpm2NYCQlMkY02PBuMHyMjWq3CAQETKZQWBWZfgLvJCCqSuf4zs?= =?us-ascii?Q?4oxzCjLC941jSTgttB0bt2xpWL4nczq5c/ZJY5Xlf5umYU1tQCUOQJhdEiYC?= =?us-ascii?Q?ZqLrMLEoMoq6jJhKUiP19Sdr7L7u80fo5dmG0Wdu+6LAqgUE2ZONI4jp0kJU?= =?us-ascii?Q?wGeCI8a8ry6ARrGw8GDuzsOc1Gvuk5PG+BVQO8nd98dKkenPjz7cG1mTSgCv?= =?us-ascii?Q?qy6LWW7cn0LBlO5ipi6pNmTYNPfCWqy7cL/KHnqjBRcqnf5TiMEVcHCgFCgw?= =?us-ascii?Q?CiPPam27OmHPgu/4qjDk1q79lZUGND3ghxYLSRwYvRCX1nH16sjJ0PKBP9cG?= =?us-ascii?Q?hbjy3ws2sq4cOXRdRrAcwyqweUF4EeGK6nTJb8nxowdPes4SH/UY6cBiBfMb?= =?us-ascii?Q?k4bZZDjgtf0IN3u5vc6KpF7JYqICC8kUxxgEBlLfjbKLv7xp9SfyW5v1Qb9C?= =?us-ascii?Q?EcAaO9yC4xR13pUFW3S/2cdjeJjp1TvEjICDkYst79zsW0UCbr5WIPvy4ZrG?= =?us-ascii?Q?2aEsQ0x+qZZtMGN96wlb+mht9X6X6I2whkinM//4Mt8cEGup5njFurqe6S7K?= =?us-ascii?Q?u7mv9vN92YOSPTSRzEaDceRfyRPLc+d0j8HZEmizNchra9EGquJ6WkgTPwJl?= =?us-ascii?Q?qTlDE8TsOGmcLJ8TRuB4MWmx00C0LOK5efeGRahmKOw78IYPtDm+gi7RGv0M?= =?us-ascii?Q?PMAbwyh0vxK44/E1l31VMWa2DjK7n7JzMVHghk6jegUq+NY2byPNjNB5l9Oa?= =?us-ascii?Q?t2RFfHgGa3IoXL9kNBBp9+NrhJVU0wT1MmiJDia4f2pLYrhOpZdz73zW0GEh?= =?us-ascii?Q?876KwDoYorPTibzlAQC6GuFPrHZyt92d+MlIjwCPQW5YEn43TrpRohmyEyrQ?= =?us-ascii?Q?88qa/jpQwYd2AUeQkdQGZJZ17NwHS6fA/+AJy55vRhNtnK3R752M8z9v3L8s?= =?us-ascii?Q?IfFu46ohhs+NnWzJqOAgPHIQHmfMAxDwo3sNSL19Ams/epne7RAudaKR0Ca6?= =?us-ascii?Q?sWOPH1H4GEv2lidfRLF/cPONCz25DLVoDKYBjpEDOYIpO7gLn//BA5kFOVPC?= =?us-ascii?Q?fH8fqC6a+3tyNTBLQTE/Z4ff7X2zdWoj+6tTyt9dhK3DTNSGvZ2vUTta47Dv?= =?us-ascii?Q?6N0OrEEutKavRWjVmJbAmef0pEg=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72c949a6-a8f9-4ec1-263d-08d9c04830a1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 03:57:33.7556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TvKr0dk7XZu3WOgl9GWrMhggABd9HydnQKCVT0NiCuwys3XO1khKHc1Iiu6Z3yGylouSh4A3rtBV0kJjOkWbCXkWm7Fc1W5S0gQ902hIg6Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7381 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: JOKEu41jqMql3qcpLP75ITSix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639627055; bh=aYsAxAMPb0+16W29s7pCqvU97d874sVChBiaTOJBAAA=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=ERWw+cmpyB7Ab1bkvYDcTcuPY0nABO0ZoFxrLbNadYx5LMISa+jrtRpX4VaIEb7sFyN 6iJIEWRSAlL8+qqzez/ejeAcKf4fdcjLWiRis8rvdvbVyClo9INjOpTfGy3rkzaZToDcT V0Xe3bLetpfiBg2+UGR5lg5Wafj33qoAQqU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639627058289100006 Content-Type: text/plain; charset="utf-8" Currently, the serial and part number of a processor are filled with fixed PCDs. However, they may be updated dynamically according to the information being passed from a the pre-UEFI firmware during booting. So, this patch is to support updating these string fields from OemMiscLib if the PCDs are empty. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Rebecca Cran Signed-off-by: Nhi Pham Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h | 2 ++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++= ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index f25c8f3342a9..47cb30d84a62 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -56,6 +56,8 @@ typedef enum { ChassisTypeType03, ManufacturerType03, SkuNumberType03, + ProcessorPartNumType04, + ProcessorSerialNumType04, SmbiosHiiStringFieldMax } OEM_MISC_SMBIOS_HII_STRING_FIELD; =20 diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass= .c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c index a4f98e6a81d2..0b9af9bd7e1c 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c @@ -513,9 +513,19 @@ AllocateType4AndSetProcessorInformationStrings ( =20 SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorManufacturer, ProcessorManu= ); SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorVersion, ProcessorVersion); - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorSerialNumber, SerialNumber); SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorAssetTag, AssetTag); - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorPartNumber, PartNumber); + + if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorSerialNumber)) > 0) { + HiiSetString (mHiiHandle, SerialNumber, (CHAR16 *)FixedPcdGetPtr (PcdP= rocessorSerialNumber), NULL); + } else { + OemUpdateSmbiosInfo (mHiiHandle, SerialNumber, ProcessorSerialNumType0= 4); + } + + if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorPartNumber)) > 0) { + HiiSetString (mHiiHandle, PartNumber, (CHAR16 *)FixedPcdGetPtr (PcdPro= cessorPartNumber), NULL); + } else { + OemUpdateSmbiosInfo (mHiiHandle, PartNumber, ProcessorPartNumType04); + } =20 // Processor Designation StringBufferSize =3D sizeof (CHAR16) * SMBIOS_STRING_MAX_LENGTH; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84958): https://edk2.groups.io/g/devel/message/84958 Mute This Topic: https://groups.io/mt/87760771/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-