From nobody Mon Feb 9 11:32:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84811+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84811+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1639489328; cv=none; d=zohomail.com; s=zohoarc; b=SZHYSiNCpYrIInTWQKttzl+yWZSyT92l8Hsz4P7CPTF7BpthEwUzncT4nmUoCKDjc9dkjlCIRNcxu5AJK0UDEuZRabPOKg2Q6nJcSlv17eYMzJdGeu9leJJbvqhBfcRBKGHdVyGuC791w4wPuKVmibA0HLwn0qJLPUdHOcfEB9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639489328; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mCwdhTHZwkhcOhwza24TJOm9PeZ9LzSRGgk6ZUPhBNk=; b=K33P3+q2f9UFuYvNwI2oec4JEu4s2aKAJjcNyoYfgIFkff0TOAZaCefk22LGufcOJBEsfvlEXIBlFJN+OYoJadJRtYhwjDi+lX01evHgzGTpbTc9BSXIhUTFiMEO7/YvFEBXluul4yGUCVMM50F0PEpxY52ipi2lHWFfm98b9U0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84811+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639489328052176.64362288288362; Tue, 14 Dec 2021 05:42:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id SVvEYY1788612xYdcE92shJK; Tue, 14 Dec 2021 05:42:07 -0800 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.25742.1639489321528370744 for ; Tue, 14 Dec 2021 05:42:07 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="218993667" X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="218993667" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 05:42:05 -0800 X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="465094234" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.255.30.115]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 05:42:03 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min Xu , Michael D Kinney , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Gerd Hoffmann Subject: [edk2-devel] [PATCH 07/10] OvmfPkg: Update TdxDxe to set TDX PCDs Date: Tue, 14 Dec 2021 21:41:23 +0800 Message-Id: <20211214134126.869-8-min.m.xu@intel.com> In-Reply-To: <20211214134126.869-1-min.m.xu@intel.com> References: <20211214134126.869-1-min.m.xu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: dcDehNLJeKm4nUmMNFJWAW4bx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639489327; bh=OdIPBwQBkIWo8V5wk+BxU94MKo2dC/d6zrZusZQciFg=; h=Cc:Date:From:Reply-To:Subject:To; b=VZnJE9SE/4ftdkedscw5uZp+eOWQ80a7a5vubXNEsspP502//yHkDGitQASNBV4mArX yDwqlxvodMx5E4SoCxi02RGUdE18cYxonjahCJIGSla0/5hrBXhURVq0k8Yip80wZCR0+ Dlf+uxUR1hlQu5EeASzED4aFmpXLjtJ/Uv8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639489329161100002 Content-Type: text/plain; charset="utf-8" RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 These PCDs are set in PEI phase in Config-A. But in Config-B PEI phase is skipped. So they're set here. Cc: Michael D Kinney Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Signed-off-by: Min Xu --- OvmfPkg/Include/Library/TdxPlatformLib.h | 4 ++-- OvmfPkg/TdxDxe/TdxDxe.c | 12 ++++++++++++ OvmfPkg/TdxDxe/TdxDxe.inf | 3 +++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Include/Library/TdxPlatformLib.h b/OvmfPkg/Include/Lib= rary/TdxPlatformLib.h index a6118a0edd98..5463a6d7e55e 100644 --- a/OvmfPkg/Include/Library/TdxPlatformLib.h +++ b/OvmfPkg/Include/Library/TdxPlatformLib.h @@ -16,8 +16,8 @@ #include #include =20 -#define FW_CFG_NX_STACK_ITEM "opt/ovmf/PcdSetNxForStack" -#define FW_CFG_SYSTEM_STATE_ITEM "etc/system-states" +#define FW_CFG_NX_STACK_ITEM "opt/ovmf/PcdSetNxForStack" +#define FW_CFG_SYSTEM_STATE_ITEM "etc/system-states" =20 /** * Perform Platform initialization. diff --git a/OvmfPkg/TdxDxe/TdxDxe.c b/OvmfPkg/TdxDxe/TdxDxe.c index 36ef5c510771..63b069adefd3 100644 --- a/OvmfPkg/TdxDxe/TdxDxe.c +++ b/OvmfPkg/TdxDxe/TdxDxe.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -181,6 +182,17 @@ TdxDxeEntryPoint ( =20 SetMmioSharedBit (); =20 + #ifdef INTEL_TDX_FULL_FEATURE + PcdStatus =3D PcdSet64S (PcdConfidentialComputingGuestAttr, CCAttrIntelT= dx); + ASSERT_RETURN_ERROR (PcdStatus); + + PcdStatus =3D PcdSetBoolS (PcdIa32EferChangeAllowed, FALSE); + ASSERT_RETURN_ERROR (PcdStatus); + + PcdStatus =3D PcdSet64S (PcdTdxSharedBitMask, TdSharedPageMask ()); + ASSERT_RETURN_ERROR (PcdStatus); + #endif + PlatformInfo =3D (EFI_HOB_PLATFORM_INFO *)GET_GUID_HOB_DATA (GuidHob); =20 // diff --git a/OvmfPkg/TdxDxe/TdxDxe.inf b/OvmfPkg/TdxDxe/TdxDxe.inf index 077769bcf70c..b6335d86edbe 100644 --- a/OvmfPkg/TdxDxe/TdxDxe.inf +++ b/OvmfPkg/TdxDxe/TdxDxe.inf @@ -62,3 +62,6 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber gUefiCpuPkgTokenSpaceGuid.PcdCpuLocalApicBaseAddress gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFdBaseAddress + gEfiMdeModulePkgTokenSpaceGuid.PcdIa32EferChangeAllowed + gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr + gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84811): https://edk2.groups.io/g/devel/message/84811 Mute This Topic: https://groups.io/mt/87720801/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-