From nobody Tue Feb 10 03:37:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84542+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639020503546654.2963335786252; Wed, 8 Dec 2021 19:28:23 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lXgIYY1788612xovwNjSXOVU; Wed, 08 Dec 2021 19:28:23 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.75]) by mx.groups.io with SMTP id smtpd.web09.6935.1639020502269583467 for ; Wed, 08 Dec 2021 19:28:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PTP0ohq++rperhZYSVn45aZ77N+5xxd/tdKwPajZsayqjlWqw/XsHlEBgfrHsZWzCWzI9zwjazpjyTXiSb2wFBUsod2QBkWL1aNXf/Oah/2uOZH0iRtWD4bcAFAYVeE1pY/hhVCfujIyYq0lhyHcATViKrPn26d6Dnilbdd6umACdSeYFYxTcqLmxe/czVcGUavD5DIjp+Ah39px7RocJa4D8yrHL2f1xp6aydLlT/hI9/k15Hs4mn1xuAzOph5B6kJko+6KFoBBitPM+xxQ6iKKbsS0HqGRa43rHk/09KnMNLBnkwUjVQyB8SdaCdBsAym9YAtzH0o3ZyfjiaJuZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PVwHdPTH7w71+i9gvRPLqc4BcSc326Bp+P8UvVM6v3c=; b=TYgHWbRkKKXZhyvMg/N7RJVrb01IkiSoDM6RobmtU0+fRUQ0ewPl16VoGSR3zCAyDtqTtqstCefK+AEVR/xKJ+T3ARFT/YaQ8htsTZJ+C3+IgKJKGLkwi/x/5b/rZfJB5royBNCDNgmZY/Nit/PSM+1URqp81t1cir3dMjSzrDmET72yrRGLDRwGMRs8AEn+WToJpAJxrkLbtyLGW6DjRFjc5cIfnVHJRKoRxmA+viE3sJpwfBKFPbga3dZkAEDGcx7no8MJ/rzs0VrcVJDiwHciIZYvpkggceuQ/JQT0yDy6m/WQIHfPqAM+zLKF26njmCJVfo3boeo2MyQOjyxWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MWHPR22CA0046.namprd22.prod.outlook.com (2603:10b6:300:69::32) by CH2PR12MB3735.namprd12.prod.outlook.com (2603:10b6:610:25::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec 2021 03:28:20 +0000 X-Received: from CO1NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:300:69:cafe::17) by MWHPR22CA0046.outlook.office365.com (2603:10b6:300:69::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Thu, 9 Dec 2021 03:28:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84542+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT060.mail.protection.outlook.com (10.13.175.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4755.13 via Frontend Transport; Thu, 9 Dec 2021 03:28:19 +0000 X-Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 8 Dec 2021 21:28:17 -0600 From: "Brijesh Singh via groups.io" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , "Michael D Kinney" , Liming Gao , Zhiguang Liu , Ray Ni , Rahul Kumar , Eric Dong , Brijesh Singh , Michael Roth Subject: [edk2-devel] [PATCH v14 03/32] OvmfPkg/ResetVector: move clearing GHCB in SecMain Date: Wed, 8 Dec 2021 21:27:31 -0600 Message-ID: <20211209032800.3802995-4-brijesh.singh@amd.com> In-Reply-To: <20211209032800.3802995-1-brijesh.singh@amd.com> References: <20211209032800.3802995-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB03.amd.com (10.181.40.144) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 764afdfb-0b99-48b6-0543-08d9bac3f267 X-MS-TrafficTypeDiagnostic: CH2PR12MB3735:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: bDleo+TUopcMJhy9qvpn66TgtplPFrlFLyQJsmSrt68/lsaWwFfhFRFJ0yh7I+6AwzqAFRoQsfAtQiaUVVw6f1v8nGCW0mZnCtDDfX830WzsDyAroZkWPW3WeuV8KIK45tNUtsNPxMQcTnbfEHl05oDYV6TcIyRD7c86zyv/9Ki7aQpCHXhW2tconPjfqMFcSWuQNdY91g5yLjjn5lsYF7qysm/HmD6A8wcuNsQeBY3FJ+dQLBTp8Vt3hvwFD+67NlXBxeIW639wk5kWImpOnGXJWUCu4QoR43zkkzPknzwFJxQ9eR7eRB6rfE+1vYcZDzAmshI5zeRqoPdx/9KCkKJY3OxYmJSTA9ModWJ6zyMrs2YI8YPmmKp41KyWw7Uc2zVHG+1oJtahAq6UbQIC9cvnwiBvKD4dVjf+U17nk5223Ue4/mnrgCj3CTnInY8m1ISsTdHbxQwZF/wHGKiHd5jaqbfnDuKRoe14htHC3RQmHuqDXdrCVeVjph8bAx0DGj4k5UwVlAGt7cBL3fW3asQJhdEZChUS9uqooSQXGCQJtW+OLqzwuWCGUka5KzlDknBQdaYdPNvT7GElXsnArYeUhNHbGPCIpb584CFDmSXYwsSXMUQgBE012VF0huQGl4buRG5Hvw0wSelnt8s7OW3yT6Qy6/238EFyZpwKpboFbfmPIoD1pFvSYIGDi87sEQzacc7EOGAUTVEsK5qN8rMaGJYUsm3B9LN/9Fmr/BsEq7Q2SpRe9LxnZ7qiQycESmA71bmQL12R05zbwWD/8kO5u18aF0QX46vn7qQKJTbSsj+nZ3tpwAOpX3AuBCIOKjs6Bb94Ok2RoOFiJ5GRBxfKjc6mfAYzWly2O7X44LYfCiWxhpMXDFX2IaVsf9Tv X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 03:28:19.6300 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 764afdfb-0b99-48b6-0543-08d9bac3f267 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3735 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: 4i4GyuNVZLj1di9hU8ky6Wwux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639020503; bh=l+mXnf3tgnl8hsEcWwwu595ivH6ZfeOOUm45IsqLPV8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=jd9JGwlDZKUDj40KOUnjwry2D7p+lmRcW0fWW0rZDpOsaaBMy/wQzyO9inUb7anh1sh +U1cq67yWF5xxFJkYtFkD+nzEWJ+9jzPCEEh9ovorjvgLXHxkbklA9Up4WKqe/H5GeYLu +KbLH8fxc6iGFP8m8blJwtKREhD5xRAdYAw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639020504104100006 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 In preparation for SEV-SNP support move clearing of the GHCB memory from the ResetVector/AmdSev.asm to SecMain/AmdSev.c. The GHCB page is not accessed until SevEsProtocolCheck() switch to full GHCB. So, the move does not make any changes in the code flow or logic. The move will simplify the SEV-SNP support. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Brijesh Singh --- OvmfPkg/Sec/AmdSev.c | 2 +- OvmfPkg/ResetVector/Ia32/AmdSev.asm | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/OvmfPkg/Sec/AmdSev.c b/OvmfPkg/Sec/AmdSev.c index 27fd24fc137e..0828d090feaf 100644 --- a/OvmfPkg/Sec/AmdSev.c +++ b/OvmfPkg/Sec/AmdSev.c @@ -96,7 +96,7 @@ SevEsProtocolCheck ( AsmWriteMsr64 (MSR_SEV_ES_GHCB, Msr.GhcbPhysicalAddress); =20 Ghcb =3D Msr.Ghcb; - SetMem (Ghcb, sizeof (*Ghcb), 0); + SetMem (Ghcb, FixedPcdGet32 (PcdOvmfSecGhcbSize), 0); =20 // // Set the version to the maximum that can be supported diff --git a/OvmfPkg/ResetVector/Ia32/AmdSev.asm b/OvmfPkg/ResetVector/Ia32= /AmdSev.asm index 250ac8d8b180..48d9178168b0 100644 --- a/OvmfPkg/ResetVector/Ia32/AmdSev.asm +++ b/OvmfPkg/ResetVector/Ia32/AmdSev.asm @@ -177,12 +177,6 @@ pageTableEntries4kLoop: mov ecx, (GHCB_BASE & 0x1F_FFFF) >> 12 mov [ecx * 8 + GHCB_PT_ADDR + 4], strict dword 0 =20 - mov ecx, GHCB_SIZE / 4 - xor eax, eax -clearGhcbMemoryLoop: - mov dword[ecx * 4 + GHCB_BASE - 4], eax - loop clearGhcbMemoryLoop - SevClearPageEncMaskForGhcbPageExit: OneTimeCallRet SevClearPageEncMaskForGhcbPage =20 --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84542): https://edk2.groups.io/g/devel/message/84542 Mute This Topic: https://groups.io/mt/87605523/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-