From nobody Tue Feb 10 05:10:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84562+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639020564799238.9859709168353; Wed, 8 Dec 2021 19:29:24 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Lk1MYY1788612xeZAg7owPeB; Wed, 08 Dec 2021 19:29:24 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.67]) by mx.groups.io with SMTP id smtpd.web08.6800.1639020563649085053 for ; Wed, 08 Dec 2021 19:29:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c0f3dU8eJay4P8AS/uP9IO0RN/IJ5bwVv2+twG2xTbrkReAMCvADI4ZTyHDrLtHIQ3zjgZc6likLLNIBNSI9V/o+mm3kyilOhXVeRisrfS+oMRmYv5gR7R9pP9LB3CMLRNn3ZVquTKUJ9yvccOp4gGcu2tTy6yu+pBEf3Kx6DPoDKXUrV5cOnx1E5GjmlbAM+j2gv5ymIlS44ox9DcxqP/CJXATi36McZsShxbNrNMdYlnJQCM7OyL4yBxKlFSedSP4gzhjPATv+cKWZp2gJ+I1LI8sfa67BgFVVnueHd0pVS1Zj/5DHM6OteR/LNdl8k0caR6Q5+Tc7AxvwREzGpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Uh3G/HXouVDCETkAETXYLFlbwzk/n/7dzPG6SRI/sg=; b=YGmKNPo5yMO1wZ3kfyLUbHxohODudcRxXxHp4QrW2P5+9H1haJstSd5dUrmi11yPlTsct1pTN51i6u0MWDUktZzPS90LT6fDF9rTtefAis2HpRxWfH0d3T/C8BmKGUZ+fMiN9hPQbfL5d007gpnKjzo3sjErFsn5QpPob4xcIna+SQdDtO/p1tU5XfLARAH4t4YQRLUVBCiYGzEnEXMMCbqeTysuupKD6G6cuZIzGfbmgw7x3C/0ZZt8Ef1EHLFzOcgFavOT+KVz+Hf3HuKG8lIB9v4D/2fj1nBlLwyqSK2ba44czA9XMp69AOau7ONwDv7eOunqj3znYnlL4rZ+aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from CO2PR04CA0202.namprd04.prod.outlook.com (2603:10b6:104:5::32) by DM6PR12MB4530.namprd12.prod.outlook.com (2603:10b6:5:2aa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Thu, 9 Dec 2021 03:29:22 +0000 X-Received: from CO1NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:104:5:cafe::bd) by CO2PR04CA0202.outlook.office365.com (2603:10b6:104:5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend Transport; Thu, 9 Dec 2021 03:29:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84562+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT031.mail.protection.outlook.com (10.13.174.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4755.13 via Frontend Transport; Thu, 9 Dec 2021 03:29:21 +0000 X-Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 8 Dec 2021 21:29:17 -0600 From: "Brijesh Singh via groups.io" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , "Michael D Kinney" , Liming Gao , Zhiguang Liu , Ray Ni , Rahul Kumar , Eric Dong , Brijesh Singh , Michael Roth , Ray Ni Subject: [edk2-devel] [PATCH v14 26/32] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled Date: Wed, 8 Dec 2021 21:27:54 -0600 Message-ID: <20211209032800.3802995-27-brijesh.singh@amd.com> In-Reply-To: <20211209032800.3802995-1-brijesh.singh@amd.com> References: <20211209032800.3802995-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB03.amd.com (10.181.40.144) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4f0456d-4647-464a-1986-08d9bac41784 X-MS-TrafficTypeDiagnostic: DM6PR12MB4530:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: T83zwzTDeVzF3fx3RzJmqr3gCxj9ccgaP2fwrMyDgetdlnW6mFE6OE6Jr8+4Tc+bmEp6Xu1l/inSg1uKPlmaoniiurqdRA1WERthqOAckaMPx+3EcwkA26zCCBhzU2k6yex6OZVVmFB/rPTn09FWVdIiCCDKTBlbv2dVtyVRibg9+yJRPzo3L8LH76KPVqS98pRNTbpGOB4p+vCDGS0wp1OmvqFQ35Ur7pyJx3N+oxh6Flev8LBYT38Xz+F0I6wgeJAGUEUDjSXn11Mp2iGuotSB1iGBlXdXmFY+6AZSKuuA3nwkCYiC3IO4DmqM7mQlA5/BfoqoJnGS+GM79NGdkbwIGBhin+vTSHheRjlRBnO9cC6zoMUfD/DL9xVv6yExAyGiLY2m6L0KVH9EHBZ27oouvJGhwdSScxBBiGpbvRx3E/9M3xNpt3dnWRN3wmoPILLXw6TF+yAUT+Vegq0lECvH5YMpvBShIDkPGn7CeBJs3uDbPma5vrLCzCxyz9LmYqkLKPKQeiMGpgQkhKmcjj9TnKp3ZfzHr96vWt/ANr6JWlQ4W0S3mgZwiRVeR9FXxfrVZDxkkV/4i+fqecqhfYlCAd0taz4uX4NFdVdOvB7b4taT7JfFjdl2EY3yBNmSa0uFrbdVMxavR9QDHais8+V9LX/VD2au7eh2+NW9a07T1b9E9hjCZxU/f0bBOmP1WqBA+ODPwAxLRFs2nuzKO9mUxCiQR8z4Z1bwLrsP/7dYUzuPjpne9/J/jS6VqzpMXP2FwWHvl5tbbzeMDq8SoejZuvYuTbPw47uc3ZhZzHIXT4LMHU1DhpHSbYmhpnJLoJNyxsdCFvitfye0I2djnghWN69zFdebbKrIvfx1BxjfisK1e2QBjny0D3ggkEW5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 03:29:21.8963 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4f0456d-4647-464a-1986-08d9bac41784 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4530 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: X9u3Pt0A66gJRIAcLqMYEEUSx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639020564; bh=Ex4YHlyevNzqXRvZST4IOMqpBZKeAGuaiSGiwLgqh70=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=f7QrQ10TpFtUjqtEc/l6UDF/b9Tt+xl632uCU7AbaPUvdVNqqEhBT96dXOHN7kGDGIx hXOduvUrdO43EKoDqCagARMkulvuY+DZxDCQaOnxOipMkkDmkx8/BMjiJ/y0biGMs8Any +jszN/OGuDzFT0ad9evcrjKbAea88YhFcXk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639020565808100009 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 An SEV-SNP guest requires that the physical address of the GHCB must be registered with the hypervisor before using it. See the GHCB specification section 2.3.2 for more details. Cc: Michael Roth Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Acked-by: Ray Ni Signed-off-by: Brijesh Singh --- UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 + UefiCpuPkg/Library/MpInitLib/MpLib.c | 12 +++-- UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 1 + UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm | 54 ++++++++++++++++++++ 4 files changed, 64 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpIn= itLib/MpLib.h index a84df60519ed..56de3bfb1ccf 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -222,6 +222,7 @@ typedef struct { // BOOLEAN Enable5LevelPaging; BOOLEAN SevEsIsEnabled; + BOOLEAN SevSnpIsEnabled; UINTN GhcbBase; } MP_CPU_EXCHANGE_INFO; =20 @@ -291,6 +292,7 @@ struct _CPU_MP_DATA { BOOLEAN WakeUpByInitSipiSipi; =20 BOOLEAN SevEsIsEnabled; + BOOLEAN SevSnpIsEnabled; UINTN SevEsAPBuffer; UINTN SevEsAPResetStackStart; CPU_MP_DATA *NewCpuMpData; diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index 64fddb497e1e..44a011ba75de 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -896,8 +896,9 @@ FillExchangeInfoData ( ExchangeInfo->Enable5LevelPaging =3D (BOOLEAN)(Cr4.Bits.LA57 =3D=3D 1); DEBUG ((DEBUG_INFO, "%a: 5-Level Paging =3D %d\n", gEfiCallerBaseName, E= xchangeInfo->Enable5LevelPaging)); =20 - ExchangeInfo->SevEsIsEnabled =3D CpuMpData->SevEsIsEnabled; - ExchangeInfo->GhcbBase =3D (UINTN)CpuMpData->GhcbBase; + ExchangeInfo->SevEsIsEnabled =3D CpuMpData->SevEsIsEnabled; + ExchangeInfo->SevSnpIsEnabled =3D CpuMpData->SevSnpIsEnabled; + ExchangeInfo->GhcbBase =3D (UINTN)CpuMpData->GhcbBase; =20 // // Get the BSP's data of GDT and IDT @@ -1847,9 +1848,10 @@ MpInitLibInitialize ( CpuMpData->CpuData =3D (CPU_AP_DATA *)(CpuMpData + 1); CpuMpData->CpuInfoInHob =3D (UINT64)(UINTN)(CpuMpData->CpuData + Max= LogicalProcessorNumber); InitializeSpinLock (&CpuMpData->MpLock); - CpuMpData->SevEsIsEnabled =3D ConfidentialComputingGuestHas (CCAttrAmdSe= vEs); - CpuMpData->SevEsAPBuffer =3D (UINTN)-1; - CpuMpData->GhcbBase =3D PcdGet64 (PcdGhcbBase); + CpuMpData->SevEsIsEnabled =3D ConfidentialComputingGuestHas (CCAttrAmdS= evEs); + CpuMpData->SevSnpIsEnabled =3D ConfidentialComputingGuestHas (CCAttrAmdS= evSnp); + CpuMpData->SevEsAPBuffer =3D (UINTN)-1; + CpuMpData->GhcbBase =3D PcdGet64 (PcdGhcbBase); =20 // // Make sure no memory usage outside of the allocated buffer. diff --git a/UefiCpuPkg/Library/MpInitLib/MpEqu.inc b/UefiCpuPkg/Library/Mp= InitLib/MpEqu.inc index 2e9368a374a4..01668638f245 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpEqu.inc +++ b/UefiCpuPkg/Library/MpInitLib/MpEqu.inc @@ -92,6 +92,7 @@ struc MP_CPU_EXCHANGE_INFO .ModeHighSegment: CTYPE_UINT16 1 .Enable5LevelPaging: CTYPE_BOOLEAN 1 .SevEsIsEnabled: CTYPE_BOOLEAN 1 + .SevSnpIsEnabled CTYPE_BOOLEAN 1 .GhcbBase: CTYPE_UINTN 1 endstruc =20 diff --git a/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm b/UefiCpuPkg/Libr= ary/MpInitLib/X64/AmdSev.nasm index 0ccafe25eca4..0034920b2f6b 100644 --- a/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm +++ b/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm @@ -15,6 +15,57 @@ =20 %define SIZE_4KB 0x1000 =20 +RegisterGhcbGpa: + ; + ; Register GHCB GPA when SEV-SNP is enabled + ; + lea edi, [esi + MP_CPU_EXCHANGE_INFO_FIELD (SevSnpIsEnabled)] + cmp byte [edi], 1 ; SevSnpIsEnabled + jne RegisterGhcbGpaDone + + ; Save the rdi and rsi to used for later comparison + push rdi + push rsi + mov edi, eax + mov esi, edx + or eax, 18 ; Ghcb registration request + wrmsr + rep vmmcall + rdmsr + mov r12, rax + and r12, 0fffh + cmp r12, 19 ; Ghcb registration response + jne GhcbGpaRegisterFailure + + ; Verify that GPA is not changed + and eax, 0fffff000h + cmp edi, eax + jne GhcbGpaRegisterFailure + cmp esi, edx + jne GhcbGpaRegisterFailure + pop rsi + pop rdi + jmp RegisterGhcbGpaDone + + ; + ; Request the guest termination + ; +GhcbGpaRegisterFailure: + xor edx, edx + mov eax, 256 ; GHCB terminate + wrmsr + rep vmmcall + + ; We should not return from the above terminate request, but if we do + ; then enter into the hlt loop. +DoHltLoop: + cli + hlt + jmp DoHltLoop + +RegisterGhcbGpaDone: + OneTimeCallRet RegisterGhcbGpa + ; ; The function checks whether SEV-ES is enabled, if enabled ; then setup the GHCB page. @@ -39,6 +90,9 @@ SevEsSetupGhcb: mov rdx, rax shr rdx, 32 mov rcx, 0xc0010130 + + OneTimeCall RegisterGhcbGpa + wrmsr =20 SevEsSetupGhcbExit: --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84562): https://edk2.groups.io/g/devel/message/84562 Mute This Topic: https://groups.io/mt/87605559/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-