From nobody Tue Feb 10 04:15:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84549+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639020513308915.4911805054534; Wed, 8 Dec 2021 19:28:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jOulYY1788612xNluSVhbllE; Wed, 08 Dec 2021 19:28:33 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.46]) by mx.groups.io with SMTP id smtpd.web11.6928.1639020512158871216 for ; Wed, 08 Dec 2021 19:28:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8Di9zXfAtb75y1WB6Lg84mcFtxlOhhhs+jC/Q/tdeIm+Ik/KxHIfblxdQR7UNvRMhrZgPNxkhmw4r3Tb5uXiZqz+ZShjeHnVGnz+oWoQ2uDcfIbh51RANdVB0E9IrSDXMg+HhbTN3S7Rw4p/lbkS+kqZBLmZ7LG8dCistlL0ZOa5427GkEzknKSc9SxcxI+xzyj8Ojl1MmpOKXTeyDJ28s8sU64ESs1izS7S7E+grU0NMkVGU290sCSk47q2F7U1DVJABvk5j+zmM4BN4YP2jtcxHtmDWtcWpdml4RqGNaeY06tgIRVNoF83mOyoLSMP5grR+p8tzGxZu7rXwXg/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZ7EsoyxMZmWcIuqZz5gkP46WPQIhGMJj/k6rXRM7WM=; b=a99YknKI/OlCq5ry7WVVvxVhx6lCXYI5kduue2spJ4CmlhVF6UOh1662dt9z7nhWBv8uJhftJpuFWcEyWHJoebMINSA9nbSwatkdU1JHiNE6no+G8vWZFzzUyk43ci0cS2BvEtQHlHaK82LIFlJ8wsjLghgD/rHoSX5zCbYuwtY5Agw2usxj/cNQhlSGjFhC3R6F3kDKbLM6/ZdQMT+j3kw6Y3pNTMEIIOoRBARbu9jnGE9iuKuuuXU2GruQOPgs2IZOBHosgbpIu8ySMVdSE3YoQo7PsAean944dv/nVq+fJQJu3jLYuaIN7yQXIxqrDatme0nYiqoe9NAkMpYBHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MWHPR1401CA0005.namprd14.prod.outlook.com (2603:10b6:301:4b::15) by CH0PR12MB5169.namprd12.prod.outlook.com (2603:10b6:610:b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Thu, 9 Dec 2021 03:28:29 +0000 X-Received: from CO1NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:301:4b:cafe::9a) by MWHPR1401CA0005.outlook.office365.com (2603:10b6:301:4b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11 via Frontend Transport; Thu, 9 Dec 2021 03:28:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84549+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT016.mail.protection.outlook.com (10.13.175.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4755.13 via Frontend Transport; Thu, 9 Dec 2021 03:28:29 +0000 X-Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 8 Dec 2021 21:28:27 -0600 From: "Brijesh Singh via groups.io" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , "Michael D Kinney" , Liming Gao , Zhiguang Liu , Ray Ni , Rahul Kumar , Eric Dong , Brijesh Singh , Michael Roth , Jiewen Yao Subject: [edk2-devel] [PATCH v14 10/32] OvmfPkg/SecMain: register GHCB gpa for the SEV-SNP guest Date: Wed, 8 Dec 2021 21:27:38 -0600 Message-ID: <20211209032800.3802995-11-brijesh.singh@amd.com> In-Reply-To: <20211209032800.3802995-1-brijesh.singh@amd.com> References: <20211209032800.3802995-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB03.amd.com (10.181.40.144) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21a01343-2ec5-4f15-743f-08d9bac3f80a X-MS-TrafficTypeDiagnostic: CH0PR12MB5169:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 0r9jAMyKkJBSOfNcxEu3jxX3kYKahDkmlWdiw5xxFYcX+6+xjfpeCbJXQjFZtozGM3GO6atUkMprxZX6EE24gER0EPTSE6yeLq+GwIG6udrQ8WOhae/96y3T3LUruDNvFNuasJBmKJ38ISpwkU9S3hajOvlz4esPmyKDR5KNhRtFU6nGSM9PCnXMA1OQ0usg+rw+wPtCrLM6xdoZjySGHuA5gjZmdkEgvSAgiXXXencymDrr2+WkKcKNEPwcFlO1v+G07UayH1UCyNOBTh63ocayxITPt3Lh2xF4pJJJMZHwHD8x5sl5MDPJ04leMXXwNUG8VesezcgtpMUwyrTKmH5lDMjqaRDW2v8HlG3VeZUR3LU8aphAfLiUquqdy6Wvj416XC2TWc62RvhKTYccAQPVx+a8Pi/+FrLG1BEqngFz5YbfhdC/mTw+htT3OmNfGNn3gUhNMAe+dmE4Pr1IDXBW684IcC/KSondIOZlA/VdJG+NX10l1wh8gukA4we+0DwP5q0xrHgtroCOSj0I0uTxUc4p3iIKUo2DEkF24AyzdRNzPH9h9lzIJ+wuoOTmJlh4CmEnT9fIlm+9o1+tmfyDvjZRZNIBWBgbXqgHjWjr4kVVyGIn1dh+htxZ5cYJE5+wBWvmHaeO3fRGXZuTTkTCxZWpPXrFu51chn5ZTzTufJpPPFqPAgr2uIWANi9/B89pOZN1aqABZiPW9V4f6cadXj0+0Afetj2lCUE7faUqQRiKHu9a5bdqPB9ffKCjdhQK42B6rTA/WV0UDi/Fvjsx3+uDzyqhX7X3JaKJb0IH3KvUQFgtUbnqgRxmv00pcFJHPd9LIlMgrOwc0Pd06BscUX3Znxb0AQdV3Jlo9szwT9PPqhm93Fn/zvtfNq1+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 03:28:29.0741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21a01343-2ec5-4f15-743f-08d9bac3f80a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5169 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: PrA8OfHICrmIJkOo5LyKUh98x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639020513; bh=aR90ANiDocZTLA7tISMn+Ldu1R6I6IYW0p9FL63WclU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=qlz8L1UP0lIci4mTBo5eoRAfqs+8u44s86pkRnM/nVvfBB9bAziOFBcscU8CLzS+iHR YRr5Ce+3bFlDeAW3qCFsBk7l7Eos+Tx6kOTV0sFruOORXjPspmsTgIUUQyYxZJGxaGsED opX1lRvVgHRr2CbXytbAXYz+4vfIusCGmDk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639020515067100002 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The SEV-SNP guest requires that GHCB GPA must be registered before using. See the GHCB specification section 2.3.2 for more details. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Jiewen Yao Acked-by: Gerd Hoffmann Signed-off-by: Brijesh Singh --- OvmfPkg/Sec/AmdSev.c | 119 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 119 insertions(+) diff --git a/OvmfPkg/Sec/AmdSev.c b/OvmfPkg/Sec/AmdSev.c index 0828d090feaf..aa655fd9cbae 100644 --- a/OvmfPkg/Sec/AmdSev.c +++ b/OvmfPkg/Sec/AmdSev.c @@ -48,6 +48,104 @@ SevEsProtocolFailure ( CpuDeadLoop (); } =20 +/** + Determine if SEV-SNP is active. + + @retval TRUE SEV-SNP is enabled + @retval FALSE SEV-SNP is not enabled + +**/ +STATIC +BOOLEAN +SevSnpIsEnabled ( + VOID + ) +{ + MSR_SEV_STATUS_REGISTER Msr; + + // + // Read the SEV_STATUS MSR to determine whether SEV-SNP is active. + // + Msr.Uint32 =3D AsmReadMsr32 (MSR_SEV_STATUS); + + // + // Check MSR_0xC0010131 Bit 2 (Sev-Snp Enabled) + // + if (Msr.Bits.SevSnpBit) { + return TRUE; + } + + return FALSE; +} + +/** + Register the GHCB GPA + +*/ +STATIC +VOID +SevSnpGhcbRegister ( + EFI_PHYSICAL_ADDRESS Address + ) +{ + MSR_SEV_ES_GHCB_REGISTER Msr; + + // + // Use the GHCB MSR Protocol to request to register the GPA. + // + Msr.GhcbPhysicalAddress =3D Address & ~EFI_PAGE_MASK; + Msr.GhcbGpaRegister.Function =3D GHCB_INFO_GHCB_GPA_REGISTER_REQUEST; + AsmWriteMsr64 (MSR_SEV_ES_GHCB, Msr.GhcbPhysicalAddress); + + AsmVmgExit (); + + Msr.GhcbPhysicalAddress =3D AsmReadMsr64 (MSR_SEV_ES_GHCB); + + // + // If hypervisor responded with a different GPA than requested then fail. + // + if ((Msr.GhcbGpaRegister.Function !=3D GHCB_INFO_GHCB_GPA_REGISTER_RESPO= NSE) || + ((Msr.GhcbPhysicalAddress & ~EFI_PAGE_MASK) !=3D Address)) + { + SevEsProtocolFailure (GHCB_TERMINATE_GHCB_GENERAL); + } +} + +/** + Verify that Hypervisor supports the SNP feature. + + */ +STATIC +BOOLEAN +HypervisorSnpFeatureCheck ( + VOID + ) +{ + MSR_SEV_ES_GHCB_REGISTER Msr; + UINT64 Features; + + // + // Use the GHCB MSR Protocol to query the hypervisor capabilities + // + Msr.GhcbPhysicalAddress =3D 0; + Msr.GhcbHypervisorFeatures.Function =3D GHCB_HYPERVISOR_FEATURES_REQUEST; + AsmWriteMsr64 (MSR_SEV_ES_GHCB, Msr.GhcbPhysicalAddress); + + AsmVmgExit (); + + Msr.GhcbPhysicalAddress =3D AsmReadMsr64 (MSR_SEV_ES_GHCB); + + Features =3D RShiftU64 (Msr.GhcbPhysicalAddress, 12); + + if ((Msr.GhcbHypervisorFeatures.Function !=3D GHCB_HYPERVISOR_FEATURES_R= ESPONSE) || + (!(Features & GHCB_HV_FEATURES_SNP))) + { + return FALSE; + } + + return TRUE; +} + /** Validate the SEV-ES/GHCB protocol level. =20 @@ -89,6 +187,27 @@ SevEsProtocolCheck ( SevEsProtocolFailure (GHCB_TERMINATE_GHCB_PROTOCOL); } =20 + // + // We cannot use the MemEncryptSevSnpIsEnabled () because the + // ProcessLibraryConstructorList () is not called yet. + // + if (SevSnpIsEnabled ()) { + // + // Check if hypervisor supports the SNP feature + // + if (!HypervisorSnpFeatureCheck ()) { + SevEsProtocolFailure (GHCB_TERMINATE_GHCB_PROTOCOL); + } + + // + // Unlike the SEV-ES guest, the SNP requires that GHCB GPA must be + // registered with the Hypervisor before the use. This can be done + // using the new VMGEXIT defined in the GHCB v2. Register the GPA + // before it is used. + // + SevSnpGhcbRegister ((EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 (PcdOvm= fSecGhcbBase)); + } + // // SEV-ES protocol checking succeeded, set the initial GHCB address // --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84549): https://edk2.groups.io/g/devel/message/84549 Mute This Topic: https://groups.io/mt/87605531/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-