From nobody Tue Feb 10 01:33:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84048+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84048+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771026; cv=none; d=zohomail.com; s=zohoarc; b=JSHGfDJ1dY+w/6PzWxjUWfItR6rWqjYKDisb3uyfm11pPAQ9S5uylXlF7CCWUVW0Ij2wCbuMjXqOV4fjHm5ZhIluBxiTLT1qF7++JnjzjFE7vjR4cHDBmhJ55sg4Pv3wx1xL6mzWxg7RnUXSad/pM9+CN5RLtBWmcs9ZDJHMEQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771026; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=RHTYPzvqKdkMzolIZy3arq/C/8a1quJeiS5abFg1QYQ=; b=RMNovVO8dELMyfBn/m3/bpFZu2jhfkCel4XPyVx3GeNvTlpJT+XDtE1F4Tkd/Hlwr4DcDBDmUFECwr7D7T6433vHHmnAJLMHiL0gFB/CczN4TFeboWa0UpMCJmQ1f9BkxnvPdF1LQtQChNuwvh1KVs2iX5hZe+qio4KxBa3ZgWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84048+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771026500200.32783826220452; Wed, 24 Nov 2021 08:23:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id F7ojYY1788612xld95qxVnyS; Wed, 24 Nov 2021 08:23:46 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.193.1637771025294646572 for ; Wed, 24 Nov 2021 08:23:45 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEC5A1042; Wed, 24 Nov 2021 08:23:44 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 371C53F66F; Wed, 24 Nov 2021 08:23:44 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001 Date: Wed, 24 Nov 2021 17:23:25 +0100 Message-Id: <20211124162330.236813-6-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: aI5KiEVFISPeNcukkH8suGSDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771026; bh=jym1VJkvoASqae6CmCu0tw6qgPUo0ibmXFpANCRcceE=; h=Cc:Date:From:Reply-To:Subject:To; b=XKfwGn61NehS5ac2K23eTDGMT6OKf7taOOpifUM2CtMcVE6BJAarc+5B4SreGyrjiW8 s27O4WgOu3WYSku2nGdf7hPhhzv6IwweLNo3TLV7Z6tq5RhjkZablhP6xfHtw4rXG+xTf YpyiLi3HQX2A56ul5er5jDg9t7fEs/7Vc5A= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771027015100009 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: 'TAB' character is not allowed in source code, please replace each 'TAB' with two spaces. The patch also format and document the InstallStructures function to comply to edk2 coding style. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 38 ++++++++++--------- .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 4 +- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/P= latform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index ac18b16ca676..a5a675b2a613 100644 --- a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -743,36 +743,40 @@ InstallMemoryStructure ( } /** - Install a whole table worth of structructures + Install a whole table worth of structures. - @parm + @param [in] Smbios Smbios protocol. + @param [in] DefaultTables Default Smbios tables. + + @retval EFI_SUCCESS Record was added. + @retval EFI_OUT_OF_RESOURCES Record was not added. + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in was already in = use. **/ EFI_STATUS InstallStructures ( - IN EFI_SMBIOS_PROTOCOL *Smbios, - IN CONST VOID *DefaultTables[] + IN EFI_SMBIOS_PROTOCOL *Smbios, + IN CONST VOID *DefaultTables[] ) { EFI_STATUS Status =3D EFI_SUCCESS; EFI_SMBIOS_HANDLE SmbiosHandle; + UINTN TableEntry; - int TableEntry; - for ( TableEntry=3D0; DefaultTables[TableEntry] !=3D NULL; TableEntry+= +) - { - SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry])->H= andle; - Status =3D Smbios->Add ( - Smbios, - NULL, - &SmbiosHandle, - (EFI_SMBIOS_TABLE_HEADER*) DefaultTables[TableEntry] - ); - if (EFI_ERROR(Status)) - break; + for (TableEntry =3D 0; DefaultTables[TableEntry] !=3D NULL; TableEntry= ++) { + SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry= ])->Handle; + Status =3D Smbios->Add ( + Smbios, + NULL, + &SmbiosHandle, + (EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntr= y] + ); + if (EFI_ERROR(Status)) { + break; + } } return Status; } - /** Install all structures from the DefaultTables structure diff --git a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h b= /Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h index 601714c94387..e50c458f8c3a 100644 --- a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h +++ b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h @@ -45,7 +45,7 @@ Lan9118RawMmioRead32( UINTN Delay ); #define Lan9118MmioRead32(a) \ - Lan9118RawMmioRead32(a, a ## _RD_DELAY) + Lan9118RawMmioRead32(a, a ## _RD_DELAY) UINT32 Lan9118RawMmioWrite32( @@ -54,7 +54,7 @@ Lan9118RawMmioWrite32( UINTN Delay ); #define Lan9118MmioWrite32(a, v) \ - Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) + Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) /* ------------------ MAC CSR Access ------------------- */ -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84048): https://edk2.groups.io/g/devel/message/84048 Mute This Topic: https://groups.io/mt/87284490/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-