From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84045+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84045+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771025; cv=none; d=zohomail.com; s=zohoarc; b=nA8VY8fR5YEtfQG3B0g3zCYSZdiQ6QNp0wbWvO7zxkH0lKEgJkf0UkNJ6Y8naNPx1J3WzPZjgJCrNJROStsM4SDmep+1fLpcMqMIeq9shY5601EQKgbagzkEeWbx1GnM6LnR4ZUo9UOLsremOPBDqNqVjrzKDAFaOZpRS1Jm3zs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771025; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=9XNq4qri4adW7O5hN7y1O3KrHbWD4qjH60E4bYrUkrE=; b=VgKk+0BrsJxE1rSmZOZLYbhTT4WiLH2cJjr3Zubg45V2wpgcBCMl1YLgFj91DQT9/uIAyxdmsyEtsoi14oue88ls3uUpP6HolEQmD5OvP4Gb5CTu9Ky9Onql5sI+iARwVffbwTtQJF88U146SOwbGUCJxUdFaCmzVKCHcoOtsaw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84045+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771025129883.8374347143056; Wed, 24 Nov 2021 08:23:45 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id QAL9YY1788612xvORSfe4cA7; Wed, 24 Nov 2021 08:23:43 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.179.1637771020882915266 for ; Wed, 24 Nov 2021 08:23:41 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87B411042; Wed, 24 Nov 2021 08:23:40 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C8C843F66F; Wed, 24 Nov 2021 08:23:39 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 01/10] Platform/ARM: Modify duplicated GUID in PciHostBridgeLib Date: Wed, 24 Nov 2021 17:23:21 +0100 Message-Id: <20211124162330.236813-2-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 7h0D0DoM4Sq6nu4btJJ5NL2Ux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771023; bh=4mTUzVRs6uA9TfyH23+8HMhS/2XVE8fEEHJ9SV+fsgo=; h=Cc:Date:From:Reply-To:Subject:To; b=jPHpdJZGsBlWLt36nHKoJv/heYKe/p4Da5iS6vaLyfqlWr0vdQyrlnkQqx1u7HzMncc ct+eABBEEc46HeVnrF8WQ+6yNWp8Ht054FHGZwWyturw01p4gOL9xkvZDnkkI0xMXsCit t6nCcHM0g4GUB50mTLnEcKkxaun0kl44Kj4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771026466100001 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/Morello/Library/PciHostBridgeLib/ PciHostBridgeLibFvp.inf - Platform/ARM/SgiPkg/Library/PciHostBridgeLib/ PciHostBridgeLib.inf The module in the SgiPkg was created first. Update the GUID of the module in the Morello folder. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- .../Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLib= Fvp.inf b/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp= .inf index 1d6c5b01d13d..8524b8572af8 100644 --- a/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf +++ b/Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf @@ -10,7 +10,7 @@ [Defines] INF_VERSION =3D 0x0001001B BASE_NAME =3D PciHostBridgeLib - FILE_GUID =3D 6879CEAD-DC94-42EB-895C-096D36B8083C + FILE_GUID =3D 972E5394-AF1D-45FE-8DC4-F9E5C896E04D MODULE_TYPE =3D DXE_DRIVER VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D PciHostBridgeLib|DXE_DRIVER -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84045): https://edk2.groups.io/g/devel/message/84045 Mute This Topic: https://groups.io/mt/87284485/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84046+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84046+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771025; cv=none; d=zohomail.com; s=zohoarc; b=ajgq/MhtswAg77HKZrsi4vaOLWu9pg5i7qpdMybQIclA3zyFr148ScS3PHp3P6C1WG6yoexoLVcIF4T78gBkMNnGc/eX4qPwAfmtm4jcWJPm0aTtAp17Y27r9kl6w09R4MU45OwAdc+XHEtOuPbEds/kv4hQWb8EPvQw29Je3Sg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771025; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wj5z8KY+yVisORYYGv7HUsu68EEo0irpA36j8besZnU=; b=JzzhuuAzBkNmLtp4B0hNfWwg216WIZyV7VdTvp/tdWX0dNMVQjNUi0cT9bPce8kaW2blgU2dt8Pood/eKjsxdgxpS7mEdZjJga54ql0kNP3f8X4uXiqSoPEzytNBwf9pAvYQFXTM0puE9h4YlngHoAG88aptoi++su99/HeAifA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84046+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771025538586.309249170453; Wed, 24 Nov 2021 08:23:45 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id m2KZYY1788612xuluUZ3mghf; Wed, 24 Nov 2021 08:23:45 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.191.1637771022149076887 for ; Wed, 24 Nov 2021 08:23:42 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B5D081FB; Wed, 24 Nov 2021 08:23:41 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E7AE33F66F; Wed, 24 Nov 2021 08:23:40 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 02/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLib Date: Wed, 24 Nov 2021 17:23:22 +0100 Message-Id: <20211124162330.236813-3-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: b7Zup0HHPHybGRFkzQeMa7g9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771025; bh=bZCDP/GE2rKOIRqyz7VtC8HHcNu3dXdE32Aq9Cd5j3c=; h=Cc:Date:From:Reply-To:Subject:To; b=lPNumkNPBeHkC/WwYrr9HyuOXKCiul8jQOTgGEmO4h+zvjPrKuIEfLdUH7peVD4LJn1 R814qZdlRaj7/HKFR3fDt0XREQWw1wkfm8eaLPdnwiT2XYvCAN27IZFIQEgWt7IhnxROU Mc5/fMTe4JmBn3sVipoiUHIWwtgVPPi51sY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771026724100003 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLib.inf - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibCTA15-A7/ArmVExpressLib.inf Both files were imported at the same time. Modify the GUID of the ArmVExpressLibRTSM/ArmVExpressLib.inf. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- .../VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpres= sLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressL= ib.inf index 929dadc28a84..4b582fdfc945 100644 --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf @@ -8,7 +8,7 @@ [Defines] INF_VERSION =3D 0x00010005 BASE_NAME =3D RTSMArmVExpressLib - FILE_GUID =3D b98a6cb7-d472-4128-ad62-a7347f85ce13 + FILE_GUID =3D BCD1958C-B7D1-48E9-B7F9-5ED25F5EBE0B MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D ArmPlatformLib -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84046): https://edk2.groups.io/g/devel/message/84046 Mute This Topic: https://groups.io/mt/87284486/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84047+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84047+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771026; cv=none; d=zohomail.com; s=zohoarc; b=ZIwVJIY/l7u0B+Sfss2IdT9ZTosy2oTMsa8rtAmleS8khaVVvM5K7F4oS+eJ4IKeH1B32kM1bmqrFliYTvBN77I29Rc9qI92E6wiPhhbbYUlnlSFR58a1Ye4kayVLa5jJnuuxMm7Ks7EKQCT2+atf0pBni2wGyYG8ddoZSat700= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771026; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=I7lOd9IHxO91Kc4XrvGdNSIfwEzfFvh51fkozibDq4Y=; b=AUTcF8WefbeVzIkuy5YBr15yQeGErjjeYwPb8NztlqTUlyItQt3sgFmGpqeKZgone0T4+8YWbTIReLHiISskCSnjTgmwDGNEc3Hkn0Y4s0d22oVaKTFIhxesfz0p5mORU9LpQrJGRZfr/3lcS89i785uTcDWw8vrt1bwFoRG7Ec= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84047+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771026037466.1193925365951; Wed, 24 Nov 2021 08:23:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TsRuYY1788612xfrcXZD6bo7; Wed, 24 Nov 2021 08:23:45 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.192.1637771023031627792 for ; Wed, 24 Nov 2021 08:23:43 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8CE81042; Wed, 24 Nov 2021 08:23:42 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 127203F66F; Wed, 24 Nov 2021 08:23:41 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec Date: Wed, 24 Nov 2021 17:23:23 +0100 Message-Id: <20211124162330.236813-4-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ImcHpRMpWTEGJLAwRJ7GBKN1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771025; bh=nOq9aEaZT6zTfNP/XzDhpCsgayCmOI7TTW+P/ylOyo8=; h=Cc:Date:From:Reply-To:Subject:To; b=OJ5hLgCHOnRbanR8onjlTy7XJHhozcbNKSd68TtGywxint7CmS4ya/t76kL5ZiI6ddm u0jZzFUkJ3AojlwvF0xce894kZc7rmm3qH0nuSNMcsYKWkecXLAecRfs6465y1tPt5Yff WyBNfpJPbRVjv8n2Hia+247prgeCBjfpsEk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771026872100006 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLibSec.inf - Silicon/Hisilicon/Library/ ArmPlatformLibHisilicon/ArmPlatformLibSec.inf The inf file in the Platform/ARM/ folder is based on the one in Silicon/Hisilicon/. Modify the one in the Silicon/Hisilicon/. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones --- .../Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformL= ibSec.inf b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLi= bSec.inf index ac587deedfd8..7fd7b5183e5b 100644 --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.i= nf +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.i= nf @@ -12,7 +12,7 @@ [Defines] INF_VERSION =3D 0x00010005 BASE_NAME =3D ArmPlatformLibSec - FILE_GUID =3D a79eed97-4b98-4974-9690-37b32d6a5b56 + FILE_GUID =3D ABF3B82B-892F-438F-901F-F148C2DF89E6 MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D ArmPlatformLib -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84047): https://edk2.groups.io/g/devel/message/84047 Mute This Topic: https://groups.io/mt/87284488/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84052+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84052+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771033; cv=none; d=zohomail.com; s=zohoarc; b=k2KdrgUvc5oG8MUDv2KnvjxjVMMfxr/s0caLcTjzwOYPeMMtjZVaz7z8/z6oTvX+FicYsG3BRnw+xmUCih1kTEls6Zvl+KUpZGAKKjcxYl2UoxoqJFP3ub7RQQHosxQbGlRufe2+X95LE9k72ZCZ7hxRB35Lbxmg9dp7gcl/qgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771033; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=CrdfNo4LH04E+vMZm7En+M2p9ykw1K9WiSVD734oySE=; b=Vj4bT2J5xVEUFGXG1lpa4MvAWTy6tToa3kyWk+OvnnsDhEeIA1hu66lY1yabg2cG/DNgc39qPQqhpv9wN5I4Slv0xOBquCwcvOsuauWQXWO6bT8pVW/4xRghBig0Dm0LL9OFazwCPmZ5ySxaSWtvJyyinOhAl3k8mm/AhSofr3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84052+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771033198839.8980062369824; Wed, 24 Nov 2021 08:23:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id wNvnYY1788612xMHFXxaJmpH; Wed, 24 Nov 2021 08:23:52 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.185.1637771029385303648 for ; Wed, 24 Nov 2021 08:23:49 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB1B71FB; Wed, 24 Nov 2021 08:23:43 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 006473F66F; Wed, 24 Nov 2021 08:23:42 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 04/10] Platform/ARM: Modify duplicated GUID in ArmVExpressPkg.dec Date: Wed, 24 Nov 2021 17:23:24 +0100 Message-Id: <20211124162330.236813-5-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ucO2eyZ08Wb1yQZv83JVM6aPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771032; bh=apIRhcuaXR3msy1I3YqbnOIkoC/bZrOiEdHBcMbiBQU=; h=Cc:Date:From:Reply-To:Subject:To; b=bz32nZMOd7bgJeq8MAK7VNtzabbQfhhylleBEsTtupyZMbeMNMW877I7PYXizq/kfiE 5zJ47kZGt+IgFhlGXQDznWsiJFb3zUDlBk6f2Y/C6ofcbBACjiCjqEMWPNs6y7Qi0PNun kIBQqdnrqWICdKU6FMucjOfSswb+1l7GLXU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771035120100005 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The two following packages have the same GUID: - Platform/ARM/VExpressPkg/ArmVExpressPkg.dec - edk2/ArmPlatformPkg/ArmPlatformPkg.dec The gArmVExpressTokenSpaceGuid in Platform/ARM/VExpressPkg/ArmVExpressPkg.dec is also identical. All the GUIDs have been added at the same time, initially in the edk2 repository. Modify the GUIDs in the edk2-platforms repository. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/ARM/VExpressPkg/ArmVExpressPkg.dec b/Platform/ARM/VEx= pressPkg/ArmVExpressPkg.dec index 848510bff17e..76ba4f7f6485 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpressPkg.dec +++ b/Platform/ARM/VExpressPkg/ArmVExpressPkg.dec @@ -10,7 +10,7 @@ [Defines] DEC_SPECIFICATION =3D 0x00010005 PACKAGE_NAME =3D ArmVExpressPkg - PACKAGE_GUID =3D 9c0aaed4-74c5-4043-b417-a3223814ce76 + PACKAGE_GUID =3D 9F8DA3A6-3B84-44E4-9E36-E51972F6F688 PACKAGE_VERSION =3D 0.1 ##########################################################################= ###### @@ -29,7 +29,7 @@ [LibraryClasses] ArmPlatformSysConfigLib|Include/Library/ArmPlatformSysConfigLib.h [Guids.common] - gArmVExpressTokenSpaceGuid =3D { 0x9c0aaed4, 0x74c5, 0x4043, { 0xb4,= 0x17, 0xa3, 0x22, 0x38, 0x14, 0xce, 0x76 } } + gArmVExpressTokenSpaceGuid =3D { 0xD8D68B8E, 0x0ACE, 0x4942, { 0xA4,= 0xB9, 0x36, 0xEE, 0x9E, 0x80, 0x80, 0x9D } } [PcdsFeatureFlag.common] -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84052): https://edk2.groups.io/g/devel/message/84052 Mute This Topic: https://groups.io/mt/87284494/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84048+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84048+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771026; cv=none; d=zohomail.com; s=zohoarc; b=JSHGfDJ1dY+w/6PzWxjUWfItR6rWqjYKDisb3uyfm11pPAQ9S5uylXlF7CCWUVW0Ij2wCbuMjXqOV4fjHm5ZhIluBxiTLT1qF7++JnjzjFE7vjR4cHDBmhJ55sg4Pv3wx1xL6mzWxg7RnUXSad/pM9+CN5RLtBWmcs9ZDJHMEQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771026; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=RHTYPzvqKdkMzolIZy3arq/C/8a1quJeiS5abFg1QYQ=; b=RMNovVO8dELMyfBn/m3/bpFZu2jhfkCel4XPyVx3GeNvTlpJT+XDtE1F4Tkd/Hlwr4DcDBDmUFECwr7D7T6433vHHmnAJLMHiL0gFB/CczN4TFeboWa0UpMCJmQ1f9BkxnvPdF1LQtQChNuwvh1KVs2iX5hZe+qio4KxBa3ZgWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84048+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771026500200.32783826220452; Wed, 24 Nov 2021 08:23:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id F7ojYY1788612xld95qxVnyS; Wed, 24 Nov 2021 08:23:46 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.193.1637771025294646572 for ; Wed, 24 Nov 2021 08:23:45 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEC5A1042; Wed, 24 Nov 2021 08:23:44 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 371C53F66F; Wed, 24 Nov 2021 08:23:44 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001 Date: Wed, 24 Nov 2021 17:23:25 +0100 Message-Id: <20211124162330.236813-6-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: aI5KiEVFISPeNcukkH8suGSDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771026; bh=jym1VJkvoASqae6CmCu0tw6qgPUo0ibmXFpANCRcceE=; h=Cc:Date:From:Reply-To:Subject:To; b=XKfwGn61NehS5ac2K23eTDGMT6OKf7taOOpifUM2CtMcVE6BJAarc+5B4SreGyrjiW8 s27O4WgOu3WYSku2nGdf7hPhhzv6IwweLNo3TLV7Z6tq5RhjkZablhP6xfHtw4rXG+xTf YpyiLi3HQX2A56ul5er5jDg9t7fEs/7Vc5A= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771027015100009 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: 'TAB' character is not allowed in source code, please replace each 'TAB' with two spaces. The patch also format and document the InstallStructures function to comply to edk2 coding style. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 38 ++++++++++--------- .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 4 +- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/P= latform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index ac18b16ca676..a5a675b2a613 100644 --- a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -743,36 +743,40 @@ InstallMemoryStructure ( } /** - Install a whole table worth of structructures + Install a whole table worth of structures. - @parm + @param [in] Smbios Smbios protocol. + @param [in] DefaultTables Default Smbios tables. + + @retval EFI_SUCCESS Record was added. + @retval EFI_OUT_OF_RESOURCES Record was not added. + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in was already in = use. **/ EFI_STATUS InstallStructures ( - IN EFI_SMBIOS_PROTOCOL *Smbios, - IN CONST VOID *DefaultTables[] + IN EFI_SMBIOS_PROTOCOL *Smbios, + IN CONST VOID *DefaultTables[] ) { EFI_STATUS Status =3D EFI_SUCCESS; EFI_SMBIOS_HANDLE SmbiosHandle; + UINTN TableEntry; - int TableEntry; - for ( TableEntry=3D0; DefaultTables[TableEntry] !=3D NULL; TableEntry+= +) - { - SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry])->H= andle; - Status =3D Smbios->Add ( - Smbios, - NULL, - &SmbiosHandle, - (EFI_SMBIOS_TABLE_HEADER*) DefaultTables[TableEntry] - ); - if (EFI_ERROR(Status)) - break; + for (TableEntry =3D 0; DefaultTables[TableEntry] !=3D NULL; TableEntry= ++) { + SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry= ])->Handle; + Status =3D Smbios->Add ( + Smbios, + NULL, + &SmbiosHandle, + (EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntr= y] + ); + if (EFI_ERROR(Status)) { + break; + } } return Status; } - /** Install all structures from the DefaultTables structure diff --git a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h b= /Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h index 601714c94387..e50c458f8c3a 100644 --- a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h +++ b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h @@ -45,7 +45,7 @@ Lan9118RawMmioRead32( UINTN Delay ); #define Lan9118MmioRead32(a) \ - Lan9118RawMmioRead32(a, a ## _RD_DELAY) + Lan9118RawMmioRead32(a, a ## _RD_DELAY) UINT32 Lan9118RawMmioWrite32( @@ -54,7 +54,7 @@ Lan9118RawMmioWrite32( UINTN Delay ); #define Lan9118MmioWrite32(a, v) \ - Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) + Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) /* ------------------ MAC CSR Access ------------------- */ -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84048): https://edk2.groups.io/g/devel/message/84048 Mute This Topic: https://groups.io/mt/87284490/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84049+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84049+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771030; cv=none; d=zohomail.com; s=zohoarc; b=jCzolUeYeQND0OjOa/CGWfP/vZy6fMy5SHHWBfW1CVHE6c5iWuVPn+ZV8VVJE1SisZv+5Xo2eOEaYnHcjXllGtVV0OVb9gEakJ2OQDdn/I+bKvXVa9oYvEpHPlAi1d69NHX/EjzqnDK39rrNzIxLdcVuwu4CNAxI0XthVx/deHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771030; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=0Ih98Yhb/1LdlcyIFR41wI3m3zz9Ht5xNiemogAXL8A=; b=LlRu+qLef0xQ277T1KwvtgUFd0d3KHsTbe1WmXGKCd9a1gyhvKvAbmAIe2pll7YOM7b1zm01f/uNXwjqVTP3wmpWGHtVnHCN4eJG0at+17Cg5YHZTrkSy3AhCr5aGR30OBn5b8GOgIQfLwZvvVXWXws5AvK5G1dMybUkyKYgsmA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84049+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771030468397.6266375730263; Wed, 24 Nov 2021 08:23:50 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id WAZeYY1788612xV8uoSQIlfO; Wed, 24 Nov 2021 08:23:48 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.196.1637771027060681758 for ; Wed, 24 Nov 2021 08:23:47 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 156941042; Wed, 24 Nov 2021 08:23:46 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3D1D83F66F; Wed, 24 Nov 2021 08:23:45 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008 Date: Wed, 24 Nov 2021 17:23:26 +0100 Message-Id: <20211124162330.236813-7-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: BhqEmBHK7fSAuxkC3sTfcElGx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771028; bh=f28iLQ9ubE0+/FCDC+MDDgUZsrnBjkjFhQBLO9sJm2c=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=uWvDH4z6xzGTrJMtVeojKOrubRWQQgpMP8VMVSAM0+jVZSGym51N7MnkD7HqAyJlPI4 pgoclswzg/B0GuRHQ3ESeyT98cOfBEGMbtByYYXhoUjLYPCUHv+lGvAfXTXC7Lk2hPy8r XTshNEYX6rhk+MvbUx+Ge2GSBuSjxxI72/U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771032061100002 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: File has invalid Non-ACSII char. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- .../Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevi= ce.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c index b51e2b3fa1a6..90907bc19a8f 100644 --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c @@ -259,7 +259,7 @@ UpdateMemorySize ( } /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134, - Table 75 =E2=80=93 Memory Device (Type 17) structure, description for= Size field. + Table 75 - Memory Device (Type 17) structure, description for Size fi= eld. If the value is 0, no memory device is installed in the socket; if the size is unknown, the field value is FFFFh. */ @@ -276,13 +276,13 @@ UpdateMemorySize ( } /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134, - Table 75 =E2=80=93 Memory Device (Type 17) structure, description for= Size field. + Table 75 - Memory Device (Type 17) structure, description for Size fi= eld. If the size is 32 GB-1 MB or greater, the field value is 7FFFh and the actual size is stored in the Extended Size field. */ if (MemorySize < (SIZE_32GB - SIZE_1MB)) { /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP01= 34, - section 7.18.5 Memory Device =E2=80=94 Extended Size + section 7.18.5 Memory Device - Extended Size For compatibility with older SMBIOS parsers, memory devices smaller than (32 GB - 1 MB) should be represented using their size in the Size field, leaving the Extended Size field set to 0. @@ -290,7 +290,7 @@ UpdateMemorySize ( Type17Table->ExtendedSize =3D 0; /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP01= 34, - Table 75 =E2=80=93 Memory Device (Type 17) structure, description f= or Size field. + Table 75 - Memory Device (Type 17) structure, description for Size = field. The granularity in which the value is specified depends on the sett= ing of the most-significant bit (bit 15). If the bit is 0, the value is specified in megabyte units; if the bit is 1, the value is specified @@ -308,7 +308,7 @@ UpdateMemorySize ( } /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134, - section 7.18.5 Memory Device =E2=80=94 Extended Size + section 7.18.5 Memory Device - Extended Size The Extended Size field is intended to represent memory devices larger than 32,767 MB (32 GB - 1 MB), which cannot be described using the Size field. This field is only meaningful if the value @@ -317,12 +317,12 @@ UpdateMemorySize ( Type17Table->Size =3D 0x7FFF; /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134, - section 7.18.5 Memory Device =E2=80=94 Extended Size + section 7.18.5 Memory Device - Extended Size Bit 31 is reserved for future use and must be set to 0. Bits 30:0 represent the size of the memory device in megabytes. EXAMPLE: 0000_8000h indicates a 32 GB memory device (32,768 MB), 0002_0000h represents a 128 GB memory device (131,072 MB), a= nd - 0000_7FFFh represents a 32,767 MB (32 GB =E2=80=93 1 MB) dev= ice. + 0000_7FFFh represents a 32,767 MB (32 GB - 1 MB) device. */ Type17Table->ExtendedSize =3D (MemorySize >> 20) & (~BIT31); return EFI_SUCCESS; -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84049): https://edk2.groups.io/g/devel/message/84049 Mute This Topic: https://groups.io/mt/87284491/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84050+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84050+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771030; cv=none; d=zohomail.com; s=zohoarc; b=H90le/FwOj/iercBI3oHW1eLrpbY52uZ6mpRzTZgO2PHz3X/nusCTGhzMYFkQ9ZMDIZYX+Q4CpjOpmdYKOOkYBzvthLkw0VLF6i6oGaytkoDULowx4kE0b9ZXnf+dSUU5PLycdaAu2sEh3jmV4AFNYXmmWKMToq2daV/gPc9ZOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771030; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=8+QVeaIhAGUPiSUWu5rvBd2Qh9t9v/NkSQ6enOk1Muw=; b=N0VbFfRJIBQuM6gpewAE6LeL69K1PmKPm/QSQ1Cg1v+7OHCsUOSOoN2WISoNyqFVY4nY8Mdxd8DQz7rdhjAbzIR78bPP8IM4iJuMuGPPLtj3C97A/uUu34VuBGB2nIu9qhJ48atJmNvsXC7oBkgY6rSnaGPjgP2r2Gpm96Bz8K8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84050+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771030723597.7340884090562; Wed, 24 Nov 2021 08:23:50 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id C4UvYY1788612xiPVIpngrKx; Wed, 24 Nov 2021 08:23:50 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.183.1637771027607872039 for ; Wed, 24 Nov 2021 08:23:47 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 338E111FB; Wed, 24 Nov 2021 08:23:47 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 74FAF3F66F; Wed, 24 Nov 2021 08:23:46 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 07/10] Platform/ARM: Fix Ecc error 1012 Date: Wed, 24 Nov 2021 17:23:27 +0100 Message-Id: <20211124162330.236813-8-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: R0ZE5NBLfZGOF5AtaFnbuDfvx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771030; bh=DzGo4VvXVG4KjeM0FINRE0B6S7XB5CUMWVVPfOZvD+o=; h=Cc:Date:From:Reply-To:Subject:To; b=PvDT8gyZXdre8/qm2TW0RYpDTXXxD7AHzeIT40WrpEqGAOie7mqAB1jBpfrIoZXkgdT 9UNK2BWdqiF79/f7zzAYuW4HT0U26GlHiqqwZniM6R/O9fNisSShuTcMRzHN+pGeMBHxv gOByBApfv78loEG5q5/8BqspsVVv3I6zuXE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771032166100003 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no trailing white space in one line. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/P= latform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index a5a675b2a613..76084279a558 100644 --- a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -797,7 +797,7 @@ InstallAllStructures ( // Fixup some table values mArmDefaultType0.Base.SystemBiosMajorRelease =3D (PcdGet32 ( PcdFirmware= Revision ) >> 16) & 0xFF; mArmDefaultType0.Base.SystemBiosMinorRelease =3D PcdGet32 ( PcdFirmwareR= evision ) & 0xFF; - if ( JunoRevision =3D=3D JUNO_REVISION_R1 ) + if ( JunoRevision =3D=3D JUNO_REVISION_R1 ) { mArmDefaultType2.Base.Version =3D 6; } -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84050): https://edk2.groups.io/g/devel/message/84050 Mute This Topic: https://groups.io/mt/87284492/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84051+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84051+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771032; cv=none; d=zohomail.com; s=zohoarc; b=Gz4FLbD4v05WrNaGX9T39DHwKmXCvsJswpyjjx3du2KC30jPv7ucBdn7nxzJvOJd0cJdV/Re2dI43SdWOe78mxgk1P2SmYUKKhZ7J+S3xcnduDkiIjTIDUKuWjkkWzD7ylitVe1j9RctNGHfIwTTNSqiSiNMx6KTcb/4+GtMk4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771032; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=bLo50JHO9PnXAmyfvN2XOcnecJ/tQV5uDQlGRDH30G8=; b=gTyN9s1ROqDVnNh9JAJMY7d9qR+qkgjk/Nwzhb3TIsTdzH+/YEW8in7m3LPw44JNQOM3pwIw4A2n6VCiQK2dEvRmFqyhNElaw8taQO0US2TLYf7I+cAW/buqa11gczIu1WXWoNkvHdk+LfS0KEFE7j7oWG+DcBYwY2pel5XerZI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84051+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771032786430.1587823179789; Wed, 24 Nov 2021 08:23:52 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id u1DrYY1788612xYeRiZ7NrKb; Wed, 24 Nov 2021 08:23:50 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.196.1637771027060681758 for ; Wed, 24 Nov 2021 08:23:48 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 52AEC1042; Wed, 24 Nov 2021 08:23:48 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7ACDD3F66F; Wed, 24 Nov 2021 08:23:47 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 08/10] Platform/ARM: Fix Ecc error 3003 Date: Wed, 24 Nov 2021 17:23:28 +0100 Message-Id: <20211124162330.236813-9-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 0QVtXED6Jxs3XQUthieEzXhxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771030; bh=DTn8vIjW8Hy+TCECcqUkhJv4uMElaX5t+DxUEERDKRw=; h=Cc:Date:From:Reply-To:Subject:To; b=hRyf1y/OvrjP2EbP12oCT9hrnBNG9xbOAO1ayRbidPLChMjFDfwKE0puY3iV0kEkLYh ajR59Ep9zveMCShZzWH8stDgbw7IXXNdG9AA/bnEXaL9rV3tyD6JgChCj4hHZ4cnnN0dU 55LfXm3h/nHWFwwTpXZFBYjZenBHrvo9L+c= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771035000100001 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: A comparison of any pointer to zero must be done via the NULL type Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 4 ++-- .../ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c b/Pl= atform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c index ad7cc1cd75a1..6f2ce401b3cc 100644 --- a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c +++ b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c @@ -91,7 +91,7 @@ SataSiI3132Constructor ( SATA_SI3132_INSTANCE *Instance; EFI_ATA_PASS_THRU_MODE *AtaPassThruMode; - if (!SataSiI3132Instance) { + if (SataSiI3132Instance =3D=3D NULL) { return EFI_INVALID_PARAMETER; } @@ -223,7 +223,7 @@ SataSiI3132Initialization ( UINTN Index; EFI_PCI_IO_PROTOCOL* PciIo; - if (!SataSiI3132Instance) { + if (SataSiI3132Instance =3D=3D NULL) { return EFI_INVALID_PARAMETER; } diff --git a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru= .c b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c index f15b59788310..0ec53782835b 100644 --- a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c +++ b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c @@ -260,7 +260,7 @@ SiI3132AtaPassThruCommand ( // Clear Command Complete SATA_PORT_WRITE32 (SataPort->RegBase + SII3132_PORT_INTSTATUS_REG, SII= 3132_PORT_INT_CMDCOMPL << 16); - if (PciAllocMapping) { + if (PciAllocMapping !=3D NULL) { Status =3D PciIo->Unmap (PciIo, PciAllocMapping); ASSERT (!EFI_ERROR (Status)); } -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84051): https://edk2.groups.io/g/devel/message/84051 Mute This Topic: https://groups.io/mt/87284493/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84053+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84053+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771033; cv=none; d=zohomail.com; s=zohoarc; b=aml66ifydNkePreqep6PcL5tYUrejsOTKZWMFzWK72gdF3OzciusHOkI3CTYafDNwGzoDWd7dtyFF5uWDQxTE4FhhrHWMOFQVV70kbFTGhLfILNeVqawYS2rQNuLest4fPd3YWYaDn8eD7ycAq7tmMtELc/o0LKAUEyoICW2QFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771033; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FwK5F+OtedZImh3fTTcd4Kpk0QIinByMJyK3waLzGys=; b=J8fKXlxaue4CpQc7ASr3AhRMkHoey9Wgx7Nc9UevdzgJu3GJfYoU1HE6/3wL0KQg70EiiPTR/LnMPKEamtk4UKcCtyQNJtPyhvnoKukRyVzTC+UdiuUfq5VIUwQ0J6Xu8RjGsiPjOQWac1tbeXvmigByZ42SpOQkz+Hs0BT0i38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84053+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771033602103.74168892959813; Wed, 24 Nov 2021 08:23:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id mUSnYY1788612xB4BVI8JB9d; Wed, 24 Nov 2021 08:23:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.196.1637771027060681758 for ; Wed, 24 Nov 2021 08:23:49 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 714841042; Wed, 24 Nov 2021 08:23:49 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B2A293F66F; Wed, 24 Nov 2021 08:23:48 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 09/10] Platform/ARM: Fix Ecc error 9005 Date: Wed, 24 Nov 2021 17:23:29 +0100 Message-Id: <20211124162330.236813-10-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Cycy5tue5ZwzdO7jsG7RfL5bx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771033; bh=12Tc94zocvLVUyi3vLxPZpIcOxkld7yXnDA6rKZOBW0=; h=Cc:Date:From:Reply-To:Subject:To; b=dsfkCFv7Fq4ojkFQcwGe1nPEIaWBz6eZpLAC/+eEr4FcSf6AIN6Vwk9SA2lml8i4mf9 ZadsJkr0+pqUMkIeGHg2PAX6pLCKWWsKNK42zFYf+I/Ewjnmooy0y1K78TAVOYBb/2lFU Zr5FWOX9WPldyrt1XegdU03AbGFTEwhau+Y= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771035240100007 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@param', '@post', '@pre', '@retval', '@return', '@sa', '@since', '@test', '@note', '@par', '@endcode', '@code', '@{', '@}' are allowed to mark the code Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- .../ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/A= rmVExpressPciHostBridgeLib.c b/Platform/ARM/VExpressPkg/Library/ArmVExpress= PciHostBridgeLib/ArmVExpressPciHostBridgeLib.c index 54add33b8912..4f6e0c5c44b8 100644 --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpr= essPciHostBridgeLib.c +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpr= essPciHostBridgeLib.c @@ -106,7 +106,7 @@ STATIC CONST CHAR16 mAcpiAddrSpaceTypeStr[][4] =3D { @param [out] Count Return the count of root bridge instances. - @returns All the root bridge instances in an array. + @return All the root bridge instances in an array. The array should be passed into PciHostBridgeFreeRootBridges() when it's not used. **/ -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84053): https://edk2.groups.io/g/devel/message/84053 Mute This Topic: https://groups.io/mt/87284495/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Mar 29 11:06:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84054+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84054+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1637771035; cv=none; d=zohomail.com; s=zohoarc; b=inkwGyleAW8iKAByJ0NyDWT2mxzoR6JBvW4HdY7ds5rmcnK+XpxDcHQIfCQUj0yxU3F4EuBzDi3D3/wlaWtz49Ffgbh6AOHY6//i5iuCGwK9jcr0+CPnlHGrljGv5wCOJOQScuC9JTGaX1cXE+AR0MoFVV/Jgvsko2EOhF0/YSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637771035; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=SmEfjZTtrF9g/fENPdmafu97PdvSPqeRy/y5skcmoKk=; b=hbp8RGPEpD3q6/RHRlvOiECXuREIxFPuWvy1+n3jbHXyHvOOSWDnvYan694yHEZ/+QhGp/H146sQYj4Q6CJdtPibO6r+RR4wfi1sFl0vg+6sR1647n02JpMGZzKQ9Veb4jSmlBAvpiRcxAk+J2j8leS8YMpw/tavXSgZXHyX1Ik= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84054+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637771035782858.1396945433742; Wed, 24 Nov 2021 08:23:55 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 45WSYY1788612xjac2zNIhjT; Wed, 24 Nov 2021 08:23:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.186.1637771030898391667 for ; Wed, 24 Nov 2021 08:23:51 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 902F71FB; Wed, 24 Nov 2021 08:23:50 -0800 (PST) X-Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D17E63F66F; Wed, 24 Nov 2021 08:23:49 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [edk2-devel] [PATCH edk2-platforms v1 10/10] Platform/ARM: Fix Ecc error 5005 Date: Wed, 24 Nov 2021 17:23:30 +0100 Message-Id: <20211124162330.236813-11-Pierre.Gondois@arm.com> In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: URPTv3WMd5WR0j6FRgPD9qwbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637771033; bh=vZtHwUe2gwXpf2uoCIt1nQ89ZUQMLvQmAjot+Ti/Opo=; h=Cc:Date:From:Reply-To:Subject:To; b=ddHGmE/GMNU19vf7TEuy6YfM/SSS//c4W/aIRCaFA7s7bv0uHIeD0OoTg/yM73gvdz/ tHTdAxVQLo2eaYK6OYyNwsE3fe38ZYmeT7cOBa+tFRLpVU93A2j75vfawhYNOuxZPcz3D Z8iZNOMxygqBq4hRpaEfpZvWj0RBkkyV4LE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637771037652100002 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: The body of a function should be contained by open and close braces that must be in the first column. Signed-off-by: Pierre Gondois Reviewed-by: Chris Jones Reviewed-by: Sami Mujawar --- .../ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru= .c b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c index 0ec53782835b..c54291220348 100644 --- a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c +++ b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c @@ -23,7 +23,8 @@ GetSataDevice ( IN SATA_SI3132_INSTANCE* SataInstance, IN UINT16 Port, IN UINT16 PortMultiplierPort -) { + ) +{ LIST_ENTRY *List; SATA_SI3132_PORT *SataPort; SATA_SI3132_DEVICE *SataDevice; -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84054): https://edk2.groups.io/g/devel/message/84054 Mute This Topic: https://groups.io/mt/87284496/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-