From nobody Fri Mar 29 09:09:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83802+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=none dis=none) header.from=groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637152146535875.4276449834318; Wed, 17 Nov 2021 04:29:06 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Bx3NYY1788612xf2lNNIucCD; Wed, 17 Nov 2021 04:29:06 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.86]) by mx.groups.io with SMTP id smtpd.web10.6243.1637152145291650222 for ; Wed, 17 Nov 2021 04:29:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H4KbpGb2FQGT1ABYHYlhLXY96DkDuLG/EKhTB2hcVJ1wCBT7eZQGCTXNbdEMEU7Lw8EbKuZo900gJb67ZoGcXC736nKW/ZW+dCvCL0UIYZhXaCiGpfPv8y9FCn11rX6F1MnA8ud+q0CtBTwjDq7MlFXgapOaZkqjaDasqFedpAEXNZ2C+V7Ssl+15p+Mp5Y1e954mlFMwaxR+Uu14XoG3pqKtTuaLJDUX7xuCDefxvzbwf3wYq51L6hiIt7iPwUvtphQUR5GpCHL8FMUOM5iWwlUV0++0SgJuvqHmOaSYmLdZuaOFfE5uG1oczTj5pS6k5K2PjjY1EZOPFD0OUB/9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5HN/08b1vTk++161kBLv9WPWCXG0lp/JBls6fL1cILg=; b=fnbYvUFuQKprkz5u4qS23DqwzPGjXn+1pOrpvjlJuTtULEClIA3SKtEe8ks93bImekv2Kl1peSc6pmn/NfgBG4XaLF3qCPVeMTpTe73EPUeVUAySjKrKxxm4KsUKgTlt/fPN1bv6lL5emRup8P7+2DT4twSsNyGcQZlBgJ/li7jtAs8XfV0u5LBtei8O6yHknBX/9NUGn7Lg2WlCdQibzg1lITeGkR5BrfusELPLSmvewnL64p9t+mtnVrtOlalW/XcLDmxKiFLu940g1FYUBZX33tQzCJQoNFkWDzpDFi9IpR9Ift55COkhE86ff7rbzXpDi76EiBc2d3HMKg9NaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MWHPR21CA0051.namprd21.prod.outlook.com (2603:10b6:300:db::13) by DM6PR12MB4893.namprd12.prod.outlook.com (2603:10b6:5:1bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Wed, 17 Nov 2021 12:29:03 +0000 X-Received: from CO1NAM11FT019.eop-nam11.prod.protection.outlook.com (2603:10b6:300:db:cafe::7d) by MWHPR21CA0051.outlook.office365.com (2603:10b6:300:db::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.5 via Frontend Transport; Wed, 17 Nov 2021 12:29:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83802+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT019.mail.protection.outlook.com (10.13.175.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4690.15 via Frontend Transport; Wed, 17 Nov 2021 12:29:03 +0000 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 17 Nov 2021 06:29:02 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 17 Nov 2021 06:29:00 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Ray Ni , Zhichao Gao , Sami Mujawar Subject: [edk2-devel] [PATCH v2 1/1] ShellPkg/AcpiView: PrintFormatter for FADT Flags field Date: Wed, 17 Nov 2021 17:59:23 +0530 Message-ID: <20211117122923.30182-2-abdattar@amd.com> In-Reply-To: <20211117122923.30182-1-abdattar@amd.com> References: <20211117122923.30182-1-abdattar@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f42e5ec4-7378-4fe1-4f07-08d9a9c5d722 X-MS-TrafficTypeDiagnostic: DM6PR12MB4893: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1091; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: y1MzZqaii6uX03inMcs7vGk9F/WzGxCBWF0AEiue2qifWEQUqBifOg45IHJyUqmeHiVxoogrMrmM2rhLEtEeorXRt+23+s1EDlKLXf/J6hedl+mxJCed+NcHnsK8ztWx2Bvx4Am3mySLcm92aRkA7w71M8dx1uE0U/fjivJmyu1L4WkeQe3DnTNa9kj5RwE04eVVxZEUA2qbvYSg8/xWv+rUIQDo242n2CiTPmpZtpvRCD8tS9b50vOI1q37i+87ybPQGv7PItqJbh1aSJFZD0icWFOo26A24s6kRSy80gE+bpNfnayR8cnLrY4yGmiPFwU3o4J9XTrhj0VPoe0TIp+n7+s/iSvANuWOlpMXa2bfXVW+Kdj7or7ybeVQ+1McLsrnR54GCCAXlyWmV3VL0HHZHl6jw7fcZDgGmMqen6MI78kmXGpABivvQVGAnnOO5Axf/o0g2vEoIq03da4UV40AkMxVUjLNdBMVezLI2dDLFnxpI+08hWYccUrQL2G2WJdgiihWjtX/0sRanKYAYJpuKx1qVtT6aHPIi7v2dwNDnXXremwfAHBQwh20LvAjeudW5OZ+7GXzLSXUITPBFFPDa62it+eTtVlPRGQ2gFC74TCaf4YJMhoS7byLPnG5EDfeEnhXyGP8pKoB9XeXe5OGP/yK28rWQpl6YNro4Ojzz8VObUhB/3tonLAFYY9/Wa3ytfG+OLjE+lQgmRjeZj3oNm5wLDV1KzOuWGKME+E= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 12:29:03.1058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f42e5ec4-7378-4fe1-4f07-08d9a9c5d722 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT019.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4893 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abdattar@amd.com X-Gm-Message-State: 9ZgiacLA6uG0AptDkVuCCVRYx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637152146; bh=k64VRzPivQ+cY6OVXFLQCMfO+lEjfVxPnYFURy7Ce+M=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=qwRjzuXPorigFdy75/KtxT6phnIAj8fhSblYv1v8s2QfTrj3KBeDYKFcTZ5YGn1nCMO ihv8vyUow6t9QEGE4/fss/BRUO2ALziSiXWdYHHDi9GPnm2nqXzoIm1qpUvuTtwb4V5bl fSHRK0J6KY5fwjAmLz8BXBR24nICACLRaJc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637152148670100005 Content-Type: text/plain; charset="utf-8" Adds PrintFormatter function to the FADT flags field. Prints indivisual flag name along with flag value. Adds new parser function ParseAcpiBitFields() to handle bit fields. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | = 38 +++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 1= 77 ++++++++++++++++++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | = 59 ++++++- 3 files changed, 273 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index 5e34a70c8bae..444a977aced8 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -2,6 +2,7 @@ Header file for ACPI parser =20 Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. + Copyright (c) 2021, AMD Incorporated. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -365,6 +366,43 @@ ParseAcpi ( IN UINT32 ParserItems ); =20 +/** + This function is used to parse an ACPI table bitfield buffer. + + The ACPI table buffer is parsed using the ACPI table parser information + specified by a pointer to an array of ACPI_PARSER elements. This parser + function iterates through each item on the ACPI_PARSER array and logs th= e ACPI table bitfields. + + This function can optionally be used to parse ACPI tables and fetch spec= ific + field values. The ItemPtr member of the ACPI_PARSER structure (where use= d) + is updated by this parser function to point to the selected field data + (e.g. useful for variable length nested fields). + + @param [in] Trace Trace the ACPI fields TRUE else only parse the + table. + @param [in] Indent Number of spaces to indent the output. + @param [in] AsciiName Optional pointer to an ASCII string that descri= bes + the table being parsed. + @param [in] Ptr Pointer to the start of the buffer. + @param [in] Length Length of the buffer pointed by Ptr. + @param [in] Parser Pointer to an array of ACPI_PARSER structure th= at + describes the table being parsed. + @param [in] ParserItems Number of items in the ACPI_PARSER array. + + @retval Number of bits parsed. +**/ +UINT32 +EFIAPI +ParseAcpiBitFields ( + IN BOOLEAN Trace, + IN UINT32 Indent, + IN CONST CHAR8* AsciiName OPTIONAL, + IN UINT8* Ptr, + IN UINT32 Length, + IN CONST ACPI_PARSER* Parser, + IN UINT32 ParserItems +); + /** This is a helper macro to pass parameters to the Parser functions. =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 74056e72c359..33a9e3d1e97a 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -2,12 +2,14 @@ ACPI parser =20 Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. + Copyright (c) 2021, AMD Incorporated. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 #include #include #include +#include #include "AcpiParser.h" #include "AcpiView.h" #include "AcpiViewConfig.h" @@ -738,3 +740,178 @@ ParseAcpiHeader ( =20 return BytesParsed; } + +/** + This function is used to parse an ACPI table bitfield buffer. + + The ACPI table buffer is parsed using the ACPI table parser information + specified by a pointer to an array of ACPI_PARSER elements. This parser + function iterates through each item on the ACPI_PARSER array and logs th= e ACPI table bitfields. + + This function can optionally be used to parse ACPI tables and fetch spec= ific + field values. The ItemPtr member of the ACPI_PARSER structure (where use= d) + is updated by this parser function to point to the selected field data + (e.g. useful for variable length nested fields). + + @param [in] Trace Trace the ACPI fields TRUE else only parse the + table. + @param [in] Indent Number of spaces to indent the output. + @param [in] AsciiName Optional pointer to an ASCII string that descri= bes + the table being parsed. + @param [in] Ptr Pointer to the start of the buffer. + @param [in] Length Length in bytes of the buffer pointed by Ptr. + @param [in] Parser Pointer to an array of ACPI_PARSER structure th= at + describes the table being parsed. + @param [in] ParserItems Number of items in the ACPI_PARSER array. + + @retval Number of bits parsed. +**/ +UINT32 +EFIAPI +ParseAcpiBitFields ( + IN BOOLEAN Trace, + IN UINT32 Indent, + IN CONST CHAR8* AsciiName OPTIONAL, + IN UINT8* Ptr, + IN UINT32 Length, + IN CONST ACPI_PARSER* Parser, + IN UINT32 ParserItems +) +{ + UINT32 Index; + UINT32 Offset; + BOOLEAN HighLight; + UINTN OriginalAttribute; + + UINT64 Data; + UINT64 BitsData; + + if (Length <=3D 0 || Length > 8) { + IncrementErrorCount (); + Print ( + L"\nERROR: Bitfield Length(%d) is exceeding the 64bits limit \n", + Length + ); + return 0; + } + // + // set local variables to suppress incorrect compiler/analyzer warnings + // + OriginalAttribute =3D 0; + Offset =3D 0; + + // Increment the Indent + gIndent +=3D Indent; + + CopyMem ((VOID *)&BitsData, (VOID *)Ptr, Length); + if (Trace && (AsciiName !=3D NULL)){ + HighLight =3D GetColourHighlighting (); + + if (HighLight) { + OriginalAttribute =3D gST->ConOut->Mode->Attribute; + gST->ConOut->SetAttribute ( + gST->ConOut, + EFI_TEXT_ATTR(EFI_YELLOW, + ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)) + ); + } + Print ( + L"%*a%-*a :\n", + gIndent, + "", + (OUTPUT_FIELD_COLUMN_WIDTH - gIndent), + AsciiName + ); + if (HighLight) { + gST->ConOut->SetAttribute (gST->ConOut, OriginalAttribute); + } + } + + for (Index =3D 0; Index < ParserItems; Index++) { + if ((Offset + Parser[Index].Length) > (Length * 8)) { + // For fields outside the buffer length provided, reset any pointers + // which were supposed to be updated by this function call + if (Parser[Index].ItemPtr !=3D NULL) { + *Parser[Index].ItemPtr =3D NULL; + } + + // We don't parse past the end of the max length specified + continue; + } + + if (Parser[Index].Length =3D=3D 0) { + // don't parse the bitfield whose length is zero + continue; + } + + if (GetConsistencyChecking () && + (Offset !=3D Parser[Index].Offset)) { + IncrementErrorCount (); + Print ( + L"\nERROR: %a: Offset Mismatch for %s\n" + L"CurrentOffset =3D %d FieldOffset =3D %d\n", + AsciiName, + Parser[Index].NameStr, + Offset, + Parser[Index].Offset + ); + } + + // extract Bitfield data for the current item + Data =3D (BitsData >> Parser[Index].Offset) & ~(~0ULL << Parser[Index]= .Length); + + if (Trace) { + // if there is a Formatter function let the function handle + // the printing else if a Format is specified in the table use + // the Format for printing + PrintFieldName (2, Parser[Index].NameStr); + if (Parser[Index].PrintFormatter !=3D NULL) { + Parser[Index].PrintFormatter (Parser[Index].Format, (UINT8 *)&Data= ); + } else if (Parser[Index].Format !=3D NULL) { + // convert bit length to byte length + switch ((Parser[Index].Length / 8) + (Parser[Index].Length % 8)) { + // print the data depends on byte size + case 1: + DumpUint8 (Parser[Index].Format, (UINT8 *)&Data); + break; + case 2: + DumpUint16 (Parser[Index].Format, (UINT8 *)&Data); + break; + case 3: + case 4: + DumpUint32 (Parser[Index].Format, (UINT8 *)&Data); + break; + case 5: + case 6: + case 7: + case 8: + DumpUint64 (Parser[Index].Format, (UINT8 *)&Data); + break; + default: + Print ( + L"\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length =3D %d\= n", + AsciiName, + Parser[Index].Length + ); + } // switch + } + // Validating only makes sense if we are tracing + // the parsed table entries, to report by table name. + if (GetConsistencyChecking () && + (Parser[Index].FieldValidator !=3D NULL)) { + Parser[Index].FieldValidator ((UINT8 *)&Data, Parser[Index].Contex= t); + } + Print (L"\n"); + } // if (Trace) + + if (Parser[Index].ItemPtr !=3D NULL) { + *Parser[Index].ItemPtr =3D (VOID*)(UINT8 *)&Data; + } + + Offset +=3D Parser[Index].Length; + } // for + + // Decrement the Indent + gIndent -=3D Indent; + return Offset; +} diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/Fadt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPa= rser.c index d86718bab67d..3b59864d2c7e 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c @@ -2,6 +2,7 @@ FADT table parser =20 Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2021, AMD Incorporated. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -127,6 +128,62 @@ ValidateFlags ( #endif } =20 +STATIC CONST ACPI_PARSER FadtFlagParser [] =3D { + {L"WBINVD", 1, 0, L"%d", NULL, NULL, NULL, NULL}, + {L"WBINVD_FLUSH", 1, 1, L"%d", NULL, NULL, NULL, NULL}, + {L"PROC_C1", 1, 2, L"%d", NULL, NULL, NULL, NULL}, + {L"P_LVL2_UP", 1, 3, L"%d", NULL, NULL, NULL, NULL}, + {L"PWR_BUTTON", 1, 4, L"%d", NULL, NULL, NULL, NULL}, + {L"SLP_BUTTON", 1, 5, L"%d", NULL, NULL, NULL, NULL}, + {L"FIX_RTC", 1, 6, L"%d", NULL, NULL, NULL, NULL}, + {L"RTC_S4", 1, 7, L"%d", NULL, NULL, NULL, NULL}, + {L"TMR_VAL_EXT", 1, 8, L"%d", NULL, NULL, NULL, NULL}, + {L"DCK_CAP", 1, 9, L"%d", NULL, NULL, NULL, NULL}, + {L"RESET_REG_SUP", 1, 10, L"%d", NULL, NULL, NULL, NULL}, + {L"SEALED_CASE", 1, 11, L"%d", NULL, NULL, NULL, NULL}, + {L"HEADLESS", 1, 12, L"%d", NULL, NULL, NULL, NULL}, + {L"CPU_SW_SLP", 1, 13, L"%d", NULL, NULL, NULL, NULL}, + {L"PCI_EXP_WAK", 1, 14, L"%d", NULL, NULL, NULL, NULL}, + {L"USE_PLATFORM_CLOCK", 1, 15, L"%d", NULL, NULL, NULL, NULL}, + {L"S4_RTC_STS_VALID", 1, 16, L"%d", NULL, NULL, NULL, NULL}, + {L"REMOTE_POWER_ON_CAPABLE", 1, 17, L"%d", NULL, NULL, NULL, NULL}, + {L"FORCE_APIC_CLUSTER_MODEL", 1, 18, L"%d", NULL, NULL, NULL, NULL}, + {L"FORCE_APIC_PHYSICAL_DESTINATION_MODE", 1, 19, L"%d", NULL, NULL, NULL= , NULL}, + {L"HW_REDUCED_ACPI", 1, 20, L"%d", NULL, NULL, NULL, NULL}, + {L"LOW_POWER_S0_IDLE_CAPABLE", 1, 21, L"%d", NULL, NULL, NULL, NULL}, + {L"Reserved", 10, 22, L"%d", NULL, NULL, NULL, NULL} +}; + +/** + This function traces FADT Flags fields. + If no format string is specified the Format must be NULL. + + @param [in] Format Optional format string for tracing the data. + @param [in] Ptr Pointer to the start of the buffer. +**/ +VOID +EFIAPI +DumpFadtFlags ( + IN CONST CHAR16* Format OPTIONAL, + IN UINT8* Ptr + ) +{ + if (Format !=3D NULL) { + Print (Format, *(UINT32*)Ptr); + return; + } + + Print (L"0x%X\n", *(UINT32*)Ptr); + ParseAcpiBitFields ( + TRUE, + 2, + NULL, + Ptr, + 4, + PARSER_PARAMS (FadtFlagParser) + ); +} + /** An ACPI_PARSER array describing the ACPI FADT Table. **/ @@ -170,7 +227,7 @@ STATIC CONST ACPI_PARSER FadtParser[] =3D { {L"CENTURY", 1, 108, L"0x%x", NULL, NULL, NULL, NULL}, {L"IAPC_BOOT_ARCH", 2, 109, L"0x%x", NULL, NULL, NULL, NULL}, {L"Reserved", 1, 111, L"0x%x", NULL, NULL, NULL, NULL}, - {L"Flags", 4, 112, L"0x%x", NULL, (VOID**)&Flags, ValidateFlags, NULL}, + {L"Flags", 4, 112, NULL, DumpFadtFlags, (VOID**)&Flags, ValidateFlags, N= ULL}, {L"RESET_REG", 12, 116, NULL, DumpGas, NULL, NULL, NULL}, {L"RESET_VALUE", 1, 128, L"0x%x", NULL, NULL, NULL, NULL}, {L"ARM_BOOT_ARCH", 2, 129, L"0x%x", NULL, NULL, NULL, NULL}, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83802): https://edk2.groups.io/g/devel/message/83802 Mute This Topic: https://groups.io/mt/87117964/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-