From nobody Fri Apr 26 18:14:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83767+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83767+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1637031221; cv=none; d=zohomail.com; s=zohoarc; b=Eki+2FmwEkG1/f1andFLM8YpVF0NRjk/oHoXQ4AZmjeNd97sQe9y8aUYFjwFzh2nXX4BrWGJIzgXjgfOOu1t8NFXCiD/Xjalyua6PFzGMNRxqXOOBTOnE2N4WxhmBzFvoHFQypsXpGjIV/j5vmne5v9h/S6G0D3GMd0dwWqmLWs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637031221; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=EnNAD6wFmyFapM5kgWBO9VzRnqVQ2ogOy140M3qlcmw=; b=GLBoaO5f18WLcyl3AT3b+QrejFgD5fNLeR0qJs+HzqUicJXfxLADkRiNR+YCc+J7eXfcxlzCKNLWplCVnZR0OePrhWY55dXW1c/fZdanTl4D3xL/zC/PRLREkCMh/W4P596gWSAPdu5g+9BcgO4ExX2hi5BquU1C2iNoiC9ecsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83767+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637031221515159.61101450018577; Mon, 15 Nov 2021 18:53:41 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8eJVYY1788612xQa5ZG0Jjui; Mon, 15 Nov 2021 18:53:41 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.4811.1637031219366176058 for ; Mon, 15 Nov 2021 18:53:40 -0800 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 16 Nov 2021 10:53:36 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni Subject: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Skip the potential NULL pointer access Date: Tue, 16 Nov 2021 10:53:28 +0800 Message-Id: <20211116025328.1604-1-gaoliming@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: 5r0GtyyXgZfaygV6x1PukE7Zx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637031221; bh=Gy+Rbr4Y92z3ct+IwwNo8/pl56V0gvy6XFZO9VBA/0U=; h=Cc:Date:From:Reply-To:Subject:To; b=rrkXqh99iAcgIEQI6aSYFjrtKRYWx9bLYoXS/12GcGIQ2iigLABHLpq7eL/24u6M2sA 0slZS/zWwnj7dErjq0CNfzeIvr4WGj4eb+1/kDLuLEFsGzGQxnakBI1czem5I21kAeaCG V5skSbZzZP1xdOXQMqlyAs5BgbKMU0l6CtY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637031222229100002 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3732 Recent change c974257821208fc6191779d1ddea918499f165b8 exposes this potenti= al issue. Signed-off-by: Liming Gao Cc: Hao A Wu Cc: Ray Ni Acked-by: Rebecca Cran Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.c index 7626bac38d..bda900a161 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c @@ -885,6 +885,13 @@ AhciPrintStatusBlock ( IN UINT32 DebugLevel ) { + // + // Skip NULL pointer + // + if (AtaStatusBlock =3D=3D NULL) { + return; + } + // // Only print status and error since we have all of the rest printed as // a part of command block print. --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83767): https://edk2.groups.io/g/devel/message/83767 Mute This Topic: https://groups.io/mt/87086877/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-