From nobody Sun Feb 8 13:45:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83749+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83749+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=hpe.com ARC-Seal: i=1; a=rsa-sha256; t=1636948568; cv=none; d=zohomail.com; s=zohoarc; b=fHBYwAcktiUZ0NOEwLMTJG3cnw5M/nHqChZULEmduLIg5WoZ8wxZpk8Beaooj2Ouy7zuuultvwGIF5EqJjdswoWVJuOv3LSPo5MjLchMZsd0S2ea6IfR8coYwh8cL8eilBHdzIweQEeWROfo5vk0wsmrzgp8OcOmrAzOhq4tiqQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636948568; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=pGChKCWzv0fWAUBXRCT1kxZD0+BNzSow1M115j4orJ4=; b=lctRxgHKIZ75xqF8JpuIgKGYKFHGRGvQNAjWH8EO7224nDx83vosyP7m7SXYjWnswtixRk/S4tIyPA5ARGVuIIp+J2hea5O5HG4bujQ6A1k85SVEhkbnwGW14P9Z8GVuBiS7vJp+ixyBT9Jdm337klfhS81RxCCQzQfPFK9AFSQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83749+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 163694856821926.700004025111866; Sun, 14 Nov 2021 19:56:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jjUlYY1788612xhLC5AqvXOH; Sun, 14 Nov 2021 19:56:07 -0800 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.17945.1636948562260591146 for ; Sun, 14 Nov 2021 19:56:05 -0800 X-Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AF1mrUo024631; Mon, 15 Nov 2021 03:56:02 GMT X-Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0a-002e3701.pphosted.com with ESMTP id 3cbe7bgk1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 03:56:01 +0000 X-Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2352.austin.hpe.com (Postfix) with ESMTP id 6BBAA63; Mon, 15 Nov 2021 03:56:01 +0000 (UTC) X-Received: from UB16Abner.asiapacific.hpqcorp.net (ub16abner.asiapacific.hpqcorp.net [15.119.209.229]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id 5AB553A; Mon, 15 Nov 2021 03:56:00 +0000 (UTC) From: "Abner Chang" To: devel@edk2.groups.io Cc: abner.chang@hpe.com, Daniel Schaefer , Sunil V L Subject: [edk2-devel] [edk2-platforms][PATCH 13/14] Platform/RISC-V: Add debug message to SecMain.c Date: Mon, 15 Nov 2021 10:56:39 +0800 Message-Id: <20211115025640.12897-14-abner.chang@hpe.com> In-Reply-To: <20211115025640.12897-1-abner.chang@hpe.com> References: <20211115025640.12897-1-abner.chang@hpe.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: Lqw2d6yHkRgtqVJ7b7arEQBtq0Lcwb4c X-Proofpoint-GUID: Lqw2d6yHkRgtqVJ7b7arEQBtq0Lcwb4c X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@hpe.com X-Gm-Message-State: peu2uK2W5ITOLvPYEljkcP8qx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1636948567; bh=kV7Z3X/R48/YilFVCsfLWxV6d4qYHBP09DjkgOyYH3k=; h=Cc:Date:From:Reply-To:Subject:To; b=bsz5+aT1jRPF+dodJmQevCOFs2qoya0KhnvRjqyIahlZwYjI6jRvsgog4BmU8//6yja Z/F4n7Ci2+Xnedye4lxXfTjO5dmqk4iWfGLCAF4aT9cq3Iee80haij6zPBLUbof2wAZSm RSSm8j/XjcE4+xwP4sYWo+J8lVA6jAN0+Xg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1636948568650100013 Content-Type: text/plain; charset="utf-8" Add more debug messages when search FFS in SEC phase. Signed-off-by: Abner Chang Cc: Daniel Schaefer Cc: Sunil V L --- .../RISC-V/PlatformPkg/Universal/Sec/SecMain.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c b/Platform= /RISC-V/PlatformPkg/Universal/Sec/SecMain.c index 17f33a02cc..05f228c44d 100644 --- a/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c +++ b/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c @@ -166,6 +166,8 @@ FindFfsFileAndSection ( UINT32 Size; EFI_PHYSICAL_ADDRESS EndOfFile; =20 + DEBUG ((DEBUG_INFO, "%a: DBT FV at 0x%x\n", __FUNCTION__, Fv)); + if (Fv->Signature !=3D EFI_FVH_SIGNATURE) { DEBUG ((DEBUG_ERROR, "%a: FV at %p does not have FV header signature\n= ", __FUNCTION__, Fv)); return EFI_VOLUME_CORRUPTED; @@ -181,17 +183,20 @@ FindFfsFileAndSection ( =20 CurrentAddress =3D (EndOfFile + 7) & ~(7ULL); if (CurrentAddress > EndOfFirmwareVolume) { + DEBUG ((DEBUG_ERROR, "%a: FV corrupted\n", __FUNCTION__)); return EFI_VOLUME_CORRUPTED; } =20 File =3D (EFI_FFS_FILE_HEADER*)(UINTN) CurrentAddress; Size =3D *(UINT32*) File->Size & 0xffffff; if (Size < (sizeof (*File) + sizeof (EFI_COMMON_SECTION_HEADER))) { + DEBUG ((DEBUG_ERROR, "%a: FV corrupted\n", __FUNCTION__)); return EFI_VOLUME_CORRUPTED; } =20 EndOfFile =3D CurrentAddress + Size; if (EndOfFile > EndOfFirmwareVolume) { + DEBUG ((DEBUG_ERROR, "%a: FV corrupted\n", __FUNCTION__)); return EFI_VOLUME_CORRUPTED; } =20 @@ -199,6 +204,7 @@ FindFfsFileAndSection ( // Look for the request file type // if (File->Type !=3D FileType) { + DEBUG ((DEBUG_INFO, "%a: (File->Type !=3D FileType), find next FFS\n= ", __FUNCTION__)); continue; } =20 @@ -208,9 +214,15 @@ FindFfsFileAndSection ( SectionType, FoundSection ); - if (!EFI_ERROR (Status) || (Status =3D=3D EFI_VOLUME_CORRUPTED)) { + if (!EFI_ERROR(Status)) { + DEBUG ((DEBUG_INFO, "%a: Get firmware file section\n", __FUNCTION__)= ); + return Status; + } + if (Status =3D=3D EFI_VOLUME_CORRUPTED) { + DEBUG ((DEBUG_ERROR, "%a: FV corrupted\n", __FUNCTION__)); return Status; } + DEBUG ((DEBUG_INFO, "%a: Find next FFS\n", __FUNCTION__)); } } =20 --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83749): https://edk2.groups.io/g/devel/message/83749 Mute This Topic: https://groups.io/mt/87062629/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-