From nobody Mon Feb 9 05:41:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83614+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83614+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1636590285; cv=none; d=zohomail.com; s=zohoarc; b=RDM7sO7gtiY53rCBjN6bNc4LikkMzH3l2N0Ut9q+eczpoKjM8lUWNTvrEVFSRXOZBbo+iXi/PVnSc/InH1rz6sfxFfKVPT9C+WJz8iAcz76FvVvEigRUIsqBQa1RGwiD6LN6x0eCy0eXbttCGYXxz6PC2XleqN2MReKTEs579tM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636590285; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FnO9fp6cGdLmLZrtuiJ5CDba1XMq6icnPRKaK1XU0xg=; b=PWViMVw6dAl/JrBg7Y0EgQPv96a+OvrILqk6xyTDxASxDjwIyZlgIe7QekTls0ZcaTnFhK9OT1413ikpv73KM5DMYzTSdyWvOR8RbdSBfbuQkNOAIVmpzcpUJ3ubUAeNbwmxq5a+LSG7nqL4/fRDy84Snbhd6LQbTYULJJ74M4o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83614+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1636590285412870.4253550397547; Wed, 10 Nov 2021 16:24:45 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id fG06YY1788612xYwAgx2UGUq; Wed, 10 Nov 2021 16:24:45 -0800 X-Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mx.groups.io with SMTP id smtpd.web08.4013.1636590284537974835 for ; Wed, 10 Nov 2021 16:24:44 -0800 X-Received: by mail-pf1-f171.google.com with SMTP id m26so4086738pff.3 for ; Wed, 10 Nov 2021 16:24:44 -0800 (PST) X-Gm-Message-State: tzSJ8ZcRTE5d1syWmxE71Sc6x1787277AA= X-Google-Smtp-Source: ABdhPJzsVd/6484I2MrwCf5IVveo4l8GkgLnf8PFtCW5yVH7tjEVN4LzxQIDG8Im1cENk1+Nx3m+2A== X-Received: by 2002:a63:86c8:: with SMTP id x191mr684922pgd.390.1636590283835; Wed, 10 Nov 2021 16:24:43 -0800 (PST) X-Received: from localhost.localdomain (174-21-94-94.tukw.qwest.net. [174.21.94.94]) by smtp.gmail.com with ESMTPSA id e14sm838890pfv.18.2021.11.10.16.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 16:24:43 -0800 (PST) From: "Bret Barkelew" X-Google-Original-From: "brbarkel@microsoft.com" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Sean Brogan Subject: [edk2-devel] [PATCH v3 02/14] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib Date: Wed, 10 Nov 2021 16:24:04 -0800 Message-Id: <20211111002416.1770-3-brbarkel@microsoft.com> In-Reply-To: <20211111002416.1770-1-brbarkel@microsoft.com> References: <20211111002416.1770-1-brbarkel@microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bret@corthon.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1636590285; bh=lNo8J6NKmMmMZJhljp36HuRAubhbUDTEmdmKqQoBYH0=; h=Cc:Date:From:Reply-To:Subject:To; b=ZgNKAlz+ShuqDs5HRUFYdME3dWS+9F88AeNwx+RwFrHVJPb+5lirFIxtVo3SBQUmf5V 8N5KSRZvemOQQg18uf984WSyA59zrnVH9DgxbpKKhtptRB92frqEXEZkQzQnkJjnFjcF6 79ZUdEgpqQjwubOIgImao8o3z48P2wjCbXI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1636590286822100006 Content-Type: text/plain; charset="utf-8" From: Bret Barkelew Drop switch from the custom "StandaloneMmMmuLib" class to the more generic "ArmMmuLib" class and add the missing functions to fulfill that interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm --- ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 67 +++++++++= +++++++++++ ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 2 +- 2 files changed, 68 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/Ar= mPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c index 20f873e6802c..dde623f8ec69 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c @@ -325,3 +325,70 @@ ArmClearMemoryRegionReadOnly ( } return Status; } + +/** + Placeholder function to fulfill API. + + @param [in] MemoryTable + @param [out] TranslationTableBase + @param [out] TranslationTableSize + + @retval EFI_UNSUPPORTED This function is not implemented by the + callee. + +**/ +EFI_STATUS +EFIAPI +ArmConfigureMmu ( + IN ARM_MEMORY_REGION_DESCRIPTOR *MemoryTable, + OUT VOID **TranslationTableBase OPTIONAL, + OUT UINTN *TranslationTableSize OPTIONAL + ) +{ + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); + ASSERT (FALSE); + return EFI_UNSUPPORTED; +} + +/** + Placeholder function to fulfill API. + + @param [in] Entry + @param [in] Value + @param [in] RegionStart + +**/ +VOID +EFIAPI +ArmReplaceLiveTranslationEntry ( + IN UINT64 *Entry, + IN UINT64 Value, + IN UINT64 RegionStart + ) +{ + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); + ASSERT (FALSE); +} + +/** + Placeholder function to fulfill API. + + @param [in] BaseAddress + @param [in] Length + @param [in] Attributes + + @retval EFI_UNSUPPORTED This function is not implemented by the + callee. + +**/ +EFI_STATUS +ArmSetMemoryAttributes ( + IN EFI_PHYSICAL_ADDRESS BaseAddress, + IN UINT64 Length, + IN UINT64 Attributes + ) +{ + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); + ASSERT (FALSE); + return EFI_UNSUPPORTED; +} diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf b/= ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf index ff20e5898051..d34086853d32 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf @@ -13,7 +13,7 @@ [Defines] FILE_GUID =3D 44a741c2-655f-41fc-b066-179f5a9aa78a MODULE_TYPE =3D MM_CORE_STANDALONE VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D StandaloneMmMmuLib + LIBRARY_CLASS =3D ArmMmuLib | MM_CORE_STANDALONE MM_STA= NDALONE PI_SPECIFICATION_VERSION =3D 0x00010032 =20 [Sources] --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83614): https://edk2.groups.io/g/devel/message/83614 Mute This Topic: https://groups.io/mt/86971553/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-