From nobody Mon Feb 9 02:28:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83626+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83626+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1636590362; cv=none; d=zohomail.com; s=zohoarc; b=B5c3/N/R5smpBBIPcCpwjb/RGJAy2V++gAKZlQsGvoiPQgpV5D6tX7Wao+PUFzR9d+TJamRhjw1Ov4jsjTiu9Ea0OToeOXBGnmeyRBxbIehBuzvozjYGb11fHZdQSGczirMSuWCoFwKjwUq3JkMnpK5OE+qkkq8/TChRiJasmP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636590362; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=p86fvnWKSQQVPNw6wo1Xnvtg9Iy/xg80Q+4mRbH4wD0=; b=StNctd3wqCVrvlz9CkZfd2yYo92XOORIeyPMuRzVGJ1QtttG1Y8LK8bqvDD7i0wMwwxOMNNdNrkHkauAPsLZVe4h1iOsTBSakZmP6irxWwJq7rXENpY/WlhVF9WpWpZEHwT1Jea/y9eWqEQobKGV3zDu8T2fH/6H8fsAMIZgDWw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83626+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1636590362077232.804614834223; Wed, 10 Nov 2021 16:26:02 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id vzGGYY1788612x2r7LM9MiFc; Wed, 10 Nov 2021 16:26:01 -0800 X-Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mx.groups.io with SMTP id smtpd.web12.3955.1636590355488743678 for ; Wed, 10 Nov 2021 16:25:55 -0800 X-Received: by mail-pj1-f51.google.com with SMTP id j6-20020a17090a588600b001a78a5ce46aso3216350pji.0 for ; Wed, 10 Nov 2021 16:25:55 -0800 (PST) X-Gm-Message-State: VPFmoPpDjUHkJpYsXSAoQNplx1787277AA= X-Google-Smtp-Source: ABdhPJyZnvplFLpzk33T6bSCiWVX6pUYkoxvEdvwl9wZ+AHkYqHFZDkUIwxoK2C2iyOngXpGNi/6BQ== X-Received: by 2002:a17:90b:1b03:: with SMTP id nu3mr3572323pjb.47.1636590354837; Wed, 10 Nov 2021 16:25:54 -0800 (PST) X-Received: from localhost.localdomain (174-21-94-94.tukw.qwest.net. [174.21.94.94]) by smtp.gmail.com with ESMTPSA id e14sm838890pfv.18.2021.11.10.16.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 16:25:54 -0800 (PST) From: "Bret Barkelew" X-Google-Original-From: "brbarkel@microsoft.com" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Sean Brogan Subject: [edk2-devel] [PATCH v3 14/14] ArmPkg: Create an Arm-specific version of StandaloneMmCoreEntryPoint Date: Wed, 10 Nov 2021 16:24:16 -0800 Message-Id: <20211111002416.1770-15-brbarkel@microsoft.com> In-Reply-To: <20211111002416.1770-1-brbarkel@microsoft.com> References: <20211111002416.1770-1-brbarkel@microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bret@corthon.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1636590361; bh=HwUPYG8cTYVC1sFviRuaVfrCbaFJ+Kwv5bjuZez+ejs=; h=Cc:Date:From:Reply-To:Subject:To; b=WBzLqYy/zcUnc3GMXtaMeCdSwob8UhezpK4Oygtv5/enDl/W6lKb5t50F6Vp2NQn4Mn DVkz0Hv8B8Hnk2X2USXQglUdBUwRKLBn+8pI9Qg3QA9hLhLvuUrC9GpNY0ggUp62maaFO FhxqNV/55FPxowvIC+oz1QMfsqc0IlnsRpA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1636590363392100026 Content-Type: text/plain; charset="utf-8" From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- {StandaloneMmPkg =3D> ArmPkg}/Library/StandaloneMmCoreEntryPoint/Arm/Creat= eHobList.c | 0 {StandaloneMmPkg =3D> ArmPkg}/Library/StandaloneMmCoreEntryPoint/Arm/SetPe= rmissions.c | 0 {StandaloneMmPkg =3D> ArmPkg}/Library/StandaloneMmCoreEntryPoint/Arm/Stand= aloneMmCoreEntryPoint.c | 0 ArmPkg/ArmPkg.ci.yaml = | 3 ++- ArmPkg/ArmPkg.dsc = | 3 +++ {StandaloneMmPkg =3D> ArmPkg}/Library/StandaloneMmCoreEntryPoint/Standalon= eMmCoreEntryPoint.inf | 6 ++--- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPo= int.inf | 25 -------------------- 7 files changed, 7 insertions(+), 30 deletions(-) diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateH= obList.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c similarity index 100% rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHo= bList.c rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPerm= issions.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c similarity index 100% rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermi= ssions.c rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Standal= oneMmCoreEntryPoint.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Stand= aloneMmCoreEntryPoint.c similarity index 100% rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Standalo= neMmCoreEntryPoint.c rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEnt= ryPoint.c diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml index a0d6a75fe881..de6926c82e67 100644 --- a/ArmPkg/ArmPkg.ci.yaml +++ b/ArmPkg/ArmPkg.ci.yaml @@ -46,7 +46,8 @@ "EmbeddedPkg/EmbeddedPkg.dec", "MdeModulePkg/MdeModulePkg.dec", "MdePkg/MdePkg.dec", - "ShellPkg/ShellPkg.dec" + "ShellPkg/ShellPkg.dec", + "StandaloneMmPkg/StandaloneMmPkg.dec" ], # For host based unit tests "AcceptableDependencies-HOST_APPLICATION":[ diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index 04462c355922..4cd6a5879713 100644 --- a/ArmPkg/ArmPkg.dsc +++ b/ArmPkg/ArmPkg.dsc @@ -166,6 +166,9 @@ [Components.common] ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf =20 + ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf + ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf + [Components.AARCH64] ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneM= mCoreEntryPoint.inf b/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneM= mCoreEntryPoint.inf similarity index 85% copy from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCo= reEntryPoint.inf copy to ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoin= t.inf index a0629cbc1a6f..c6b283653882 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf +++ b/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.= inf @@ -10,8 +10,8 @@ =20 [Defines] INF_VERSION =3D 0x0001001A - BASE_NAME =3D StandaloneMmCoreEntryPoint - FILE_GUID =3D C97AC593-109A-4C63-905C-675FDE2689E8 + BASE_NAME =3D ArmStandaloneMmCoreEntryPoint + FILE_GUID =3D 0D7C6883-E1A8-4A7A-A35C-E0C200775B43 MODULE_TYPE =3D MM_CORE_STANDALONE VERSION_STRING =3D 1.0 PI_SPECIFICATION_VERSION =3D 0x00010032 @@ -26,8 +26,6 @@ [Sources.AARCH64, Sources.ARM] Arm/SetPermissions.c Arm/CreateHobList.c =20 -[Sources.X64] - X64/StandaloneMmCoreEntryPoint.c =20 [Packages] MdePkg/MdePkg.dec diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneM= mCoreEntryPoint.inf b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/St= andaloneMmCoreEntryPoint.inf index a0629cbc1a6f..1c6af4d7a4a8 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf @@ -21,11 +21,6 @@ [Defines] # VALID_ARCHITECTURES =3D IA32 X64 IPF EBC (EBC is for build on= ly) # =20 -[Sources.AARCH64, Sources.ARM] - Arm/StandaloneMmCoreEntryPoint.c - Arm/SetPermissions.c - Arm/CreateHobList.c - [Sources.X64] X64/StandaloneMmCoreEntryPoint.c =20 @@ -34,32 +29,12 @@ [Packages] MdeModulePkg/MdeModulePkg.dec StandaloneMmPkg/StandaloneMmPkg.dec =20 -[Packages.ARM, Packages.AARCH64] - ArmPkg/ArmPkg.dec - [LibraryClasses] BaseLib DebugLib =20 -[LibraryClasses.ARM, LibraryClasses.AARCH64] - ArmMmuLib - ArmSvcLib - [Guids] gMpInformationHobGuid gEfiMmPeiMmramMemoryReserveGuid gEfiStandaloneMmNonSecureBufferGuid gEfiArmTfCpuDriverEpDescriptorGuid - -[FeaturePcd.ARM, FeaturePcd.AARCH64] - gArmTokenSpaceGuid.PcdFfaEnable - -# -# This configuration fails for CLANGPDB, which does not support PIE in the= GCC -# sense. Such however is required for ARM family StandaloneMmCore -# self-relocation, and thus the CLANGPDB toolchain is unsupported for ARM = and -# AARCH64 for this module. -# -[BuildOptions] - GCC:*_*_ARM_CC_FLAGS =3D -fpie - GCC:*_*_AARCH64_CC_FLAGS =3D -fpie --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83626): https://edk2.groups.io/g/devel/message/83626 Mute This Topic: https://groups.io/mt/86971575/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-