From nobody Fri Dec 19 20:15:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83605+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=none dis=none) header.from=groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1636582538804936.1274249604224; Wed, 10 Nov 2021 14:15:38 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id bWKnYY1788612xjoFq3SQPCb; Wed, 10 Nov 2021 14:15:38 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.40]) by mx.groups.io with SMTP id smtpd.web08.2426.1636582536503301380 for ; Wed, 10 Nov 2021 14:15:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U0HwilrQzrTDZh7CrNurTV0Vk3/pBxmEnKvVWoGVWKsy45P4VQAS4gnHAdPftbiatxSjpUsMTb6f9BPROe91AR5oBRn4FkQ6Kb46UJALINDsOIabePUih9GTYU/e1kNcN3BE2DbFfm5LAhN6ToyffRtlXGej6ZTP7AeZ77iHGtRJj3AxbxoVOm1ZqYvAgkmZRjAm5FrV3gS1RZRMHaBuikuOX/cjMaXpNl+9+tsbRzPCbAnAy20UPdQjQ3lDSOyDuzaqjM7Q7lx+xGrwU3Phvsug/m1niKF12zJ4qTolJaCQytnWIIm+50fEMKbrkTh9goIBHfeC2ohOvLAjdxaAVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oMctcOtIeTQj92ywG7bJsh7OcgCIv1l6OfNWVL8ygi8=; b=QomPeNVPfk0TBryQVkQXvyxviPlR38Jn+BrtQRs8jVhytV0vQM1ID77YFQhIfN6Ib1AyVKOhS4qhaFADzSNY9mRryRvvm95P0YSrUqzqavK0OOY89SfQXDSfj08TT//5UIbeip0i0cWkFZa7z5CZQmKotVto0MHGPt4JRmK6LIKAYJAGnkp30Zl1x/ZV/WEzxqEpclvMegEAyDv43TaD5i6p7mJujt75/xVna/b03CP1idN75PXoJRg+DU1t0p3LJSMV1ZlQO+kxpA8xUAnuALS3a8Mmj7ARSrpApj5LvR5JneACcKP09mFg4qLHnpQC8f1h3TsgNlLVh1YR2dChbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from BN6PR2001CA0005.namprd20.prod.outlook.com (2603:10b6:404:b4::15) by MN2PR12MB3520.namprd12.prod.outlook.com (2603:10b6:208:100::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Wed, 10 Nov 2021 22:15:32 +0000 X-Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:404:b4:cafe::9) by BN6PR2001CA0005.outlook.office365.com (2603:10b6:404:b4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13 via Frontend Transport; Wed, 10 Nov 2021 22:15:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83605+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; X-Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 22:15:32 +0000 X-Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 10 Nov 2021 16:15:31 -0600 From: "Brijesh Singh via groups.io" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , "Michael D Kinney" , Liming Gao , Zhiguang Liu , Ray Ni , Rahul Kumar , Eric Dong , Brijesh Singh , Michael Roth , Jiewen Yao Subject: [edk2-devel] [PATCH v12 29/32] OvmfPkg/MemEncryptSevLib: skip page state change for Mmio address Date: Wed, 10 Nov 2021 16:14:54 -0600 Message-ID: <20211110221457.2397234-30-brijesh.singh@amd.com> In-Reply-To: <20211110221457.2397234-1-brijesh.singh@amd.com> References: <20211110221457.2397234-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09a5075c-cab4-4486-74eb-08d9a4979cb9 X-MS-TrafficTypeDiagnostic: MN2PR12MB3520: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: CrzewNIT25grNF0zsx+hzZCovDgQWvK/wxKbQ976MW2PGMZUt/xhDm32bZn77q26xHPZxCJ3GuBN5O4EW7KAeU5gHJRBv6z4AqcoE2CcZ3Z3GfNlqmFLdTPi3aJgUsqscIbf1kwYQvhIEA/4bll5lptbBzPgAyfBLdNbVGtWB5753OvI3dIVwVYvZKUvCKBrHlnt/8+LIP9CMSgtdVq6QvVETrNfdYWPtItAJBXkWOjUN2wI11lBy6by57kdZ8UyhqmZIkmzlcyA7061aNhJk1ViTAb3ZWUL1abdDvTOj5FKrN9ydmbYuKqbxhhMBxTLu1C+2pA4fzg1XirPcorSdJFChe3pbk5rIIaYbQ0KXlwzJY9dJL5cAwiiqgKqbq2Ys9mrEcPDurkmSLOoM6UCC38s7nSDSFrbBDqPwwJTxaUzLCZIl9R3wccJ3bHiOH9rz3D/oM0jN9gH8WhME7VKvEjRlrL73mMiEIx7ucEjgSC+oW3I8zfFuTGQbaGyLr7Dw+dYGWTixpq6wYjtbu87KNMuDnwYUNV+kV+ABOlqu7PEgedgzN1rs5yl1jUJzo7eOovRmu7bFlBpvq4OiBNggzAsUixejnpdHEzJiMqNu9FogwFSYHJHz/JMrU91F82EawRmNd69DK41Wiv9WIrLddxrpVuGK0frVSgjAPuiAQY6SUxZPzOsqge4keY15uvx7dLEFcK5ZAtF0dUZFZgHG+8Qb5CX/LuCiXbds8Hdou0= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 22:15:32.5622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09a5075c-cab4-4486-74eb-08d9a4979cb9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3520 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: hO2FVFFnqK7qgCJzA6mrlgrHx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1636582538; bh=bVyOaoVQ6P1ygrguobkRjs+3K38rDXh3srQquXs5xT4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=b/872WCvP/lj4echjJd8tcYaYg/KPBx3cvp/DZnsdH3gsFJsslyuzOcnOyvrAhdSKei og3201SLOtclBAvIUqUrbnY1g2jgQSDZ9nBWs8lMfXxv0bPweUPTZI+NxiEdPtuwcNiEf xNQGfG8CuYxrWqInQDMovPwK2KZzAhGHoVc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1636582539250100065 Content-Type: text/plain; charset="utf-8" The SetMemoryEncDec() is used by the higher level routines to set or clear the page encryption mask for system RAM and Mmio address. When SEV-SNP is active, in addition to set/clear page mask it also updates the RMP table. The RMP table updates are required for the system RAM address and not the Mmio address. Add a new parameter in SetMemoryEncDec() to tell whether the specified address is Mmio. If its Mmio then skip the page state change in the RMP table. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Acked-by: Jiewen Yao Signed-off-by: Brijesh Singh --- .../X64/PeiDxeVirtualMemory.c | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c= b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c index 56db1e4b6ecf..0bb86d768017 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c @@ -673,6 +673,7 @@ InternalMemEncryptSevCreateIdentityMap1G ( @param[in] Mode Set or Clear mode @param[in] CacheFlush Flush the caches before applying the encryption mask + @param[in] Mmio The physical address specified is Mm= io =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -688,7 +689,8 @@ SetMemoryEncDec ( IN PHYSICAL_ADDRESS PhysicalAddress, IN UINTN Length, IN MAP_RANGE_MODE Mode, - IN BOOLEAN CacheFlush + IN BOOLEAN CacheFlush, + IN BOOLEAN Mmio ) { PAGE_MAP_AND_DIRECTORY_POINTER *PageMapLevel4Entry; @@ -711,14 +713,15 @@ SetMemoryEncDec ( =20 DEBUG (( DEBUG_VERBOSE, - "%a:%a: Cr3Base=3D0x%Lx Physical=3D0x%Lx Length=3D0x%Lx Mode=3D%a Cach= eFlush=3D%u\n", + "%a:%a: Cr3Base=3D0x%Lx Physical=3D0x%Lx Length=3D0x%Lx Mode=3D%a Cach= eFlush=3D%u Mmio=3D%u\n", gEfiCallerBaseName, __FUNCTION__, Cr3BaseAddress, PhysicalAddress, (UINT64)Length, (Mode =3D=3D SetCBit) ? "Encrypt" : "Decrypt", - (UINT32)CacheFlush + (UINT32)CacheFlush, + (UINT32)Mmio )); =20 // @@ -760,7 +763,7 @@ SetMemoryEncDec ( // // The InternalSetPageState() is used for setting the page state in the = RMP table. // - if ((Mode =3D=3D ClearCBit) && MemEncryptSevSnpIsEnabled ()) { + if (!Mmio && (Mode =3D=3D ClearCBit) && MemEncryptSevSnpIsEnabled ()) { InternalSetPageState (PhysicalAddress, EFI_SIZE_TO_PAGES (Length), Sev= SnpPageShared, FALSE); } =20 @@ -998,7 +1001,8 @@ InternalMemEncryptSevSetMemoryDecrypted ( PhysicalAddress, Length, ClearCBit, - TRUE + TRUE, + FALSE ); } =20 @@ -1031,7 +1035,8 @@ InternalMemEncryptSevSetMemoryEncrypted ( PhysicalAddress, Length, SetCBit, - TRUE + TRUE, + FALSE ); } =20 @@ -1064,6 +1069,7 @@ InternalMemEncryptSevClearMmioPageEncMask ( PhysicalAddress, Length, ClearCBit, - FALSE + FALSE, + TRUE ); } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83605): https://edk2.groups.io/g/devel/message/83605 Mute This Topic: https://groups.io/mt/86969155/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-