From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83297+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83297+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980411; cv=none; d=zohomail.com; s=zohoarc; b=mbGJStyjyrvbKInLrDAlq0cdnbQrLFTmsxe62hKlyXOtC5JJ3LiTZ016310EwRiJfTgX9ZithZ5uwdMWKVe99k65I5LoCzzbu/Cl+VWk6YJ8l03lx9gWe8x1fwer4aR0zoA5fo4RUx6HXBGEWUk3hdcyVNKq849SH+H9c9vf7z0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980411; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mvNFM3W0drshhxkoG+IfvhhfEY2SYEE/4Sx1mPYmYes=; b=G8yUyNI6QVnLmQEAI4LjgGnKIcA+zPD3JAtWiEOqHOVAPXwaMhN+tnGwC93oPAbWAeJz/RIGKTX0D6t45QAcTqmJoLeUY2gVYFDMJVBD99cNaui9dFWRWh1+57MEc3+ncKXoIamSPBHiDVQ+Ujwv4LK5ZBWpC4PBI02FhBskVj4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83297+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635980411767335.6595580192336; Wed, 3 Nov 2021 16:00:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dNuCYY1788612xs0Tz2pArqN; Wed, 03 Nov 2021 16:00:11 -0700 X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.4321.1635980410461176844 for ; Wed, 03 Nov 2021 16:00:10 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231564106" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="231564106" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:09 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813024" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:06 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Sami Mujawar , Alexei Fedorov , Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [Patch V2 1/7] DynamicTablesPkg: Add missing BaseStackCheckLib instance Date: Wed, 3 Nov 2021 15:59:48 -0700 Message-Id: <20211103225954.1680-2-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: IYSxRHvO0QoHENia8fWRI7PIx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980411; bh=204kDUrSJm3nkq86HfdSCHGbl06RszGODow4rVWdrqc=; h=Cc:Date:From:Reply-To:Subject:To; b=tTaqOGLHLEL86YH+oS8+w2Kuh8cXSll80sxFSTxU52UjfAei+FNQLyu879cZoKiFc5u mKfyVzMSgPJ2JJpUkYEX5fo07GiVFbN942vwriUul3/cMPVsTmBgLfX3jOQIrbrAYI5Zo d8T7ev1nqJNDw1+YqPYrVtf3mQFNsL+BPUw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635980412657100003 Content-Type: text/plain; charset="utf-8" Fix ARM and AARCH64 build issues by adding the BaseStackCheckLib instance. Cc: Sami Mujawar Cc: Alexei Fedorov Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney Reviewed-by: Sami Mujawar --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dynam= icTablesPkg.dsc index 46b2e667fd25..e1439a130143 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -35,6 +35,7 @@ [LibraryClasses] =20 [LibraryClasses.ARM, LibraryClasses.AARCH64] NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf =20 [Components.common] @@ -51,4 +52,3 @@ [BuildOptions] # Inhibit C6305: Potential mismatch between sizeof and countof quantitie= s. *_VS2017_*_CC_FLAGS =3D /wd6305 /analyze !endif - --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83297): https://edk2.groups.io/g/devel/message/83297 Mute This Topic: https://groups.io/mt/86804619/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83298+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83298+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980412; cv=none; d=zohomail.com; s=zohoarc; b=Dxi3kZB8ywrLeigkQ7qI80Awn2039F0G6yEkJMioWk/eyVVAjh66aHe96ydKOAIGdCBeH95Znp3cTgSOVMYrY0BYoGdWB/J7lmlv4/gtfiuVPKnpqdKRqZqqu8NKyexABh2PSJc/UbhZa0GRSvE22P4VdnzFoWTM325C6V5mWtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980412; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7ROdbC+lECI19SVPXAIdv7eGpnJrPi5AZDojOIwTw8w=; b=jCneGVwJb7Zxni+e9IVQa8fYU8+XQbvZDHpd7HhwYe2YmsX2vIZUTNq6T5W6CJY1qfXG8kwnooR5U/eFxiwNgNJmFDIrysHnFgNsvDpk74KA5xWBf9fe+tTlPz7dLuJ1PWdDFXSFrbI69EkRc6k94KRQSAwGltDA6cE7JUlHk6w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83298+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635980412321145.44148350911462; Wed, 3 Nov 2021 16:00:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id W1d7YY1788612xmmU5huOSA5; Wed, 03 Nov 2021 16:00:12 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.4276.1635980410682439692 for ; Wed, 03 Nov 2021 16:00:10 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="212361998" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="212361998" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:09 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813068" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:07 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ard Biesheuvel , Abner Chang , Daniel Schaefer Subject: [edk2-devel] [Patch V2 2/7] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64 Date: Wed, 3 Nov 2021 15:59:49 -0700 Message-Id: <20211103225954.1680-3-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: 2Oefp0f1zoyei7bwTlwQZYDbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980412; bh=4DQ+7iXAfM454fe3YPc1P3ZEX0Y8M84buFS1GHrELpA=; h=Cc:Date:From:Reply-To:Subject:To; b=cRr3uPyohSbathqc7Y4NOj1lDiZUmA5N6JjikZZqLQUUcDOFj4SMDd70hvAvcrl8Wvl g4cin0Kq0NcLct8NkM2pE65w2NWl44Y5PlmDNW7QxrXG90NBCxjmi+B7/+8FXydFicUpW /bBvR/GZ9chTBQM5UK9M1McxciXNN7er8aw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635980412665100005 Content-Type: text/plain; charset="utf-8" Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney Reviewed-by: Daniel Schaefer Reviewed-by: Maciej Rabeda Reviewed-by: Abner Chang --- NetworkPkg/NetworkPkg.dsc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index cf2164aefe25..8691a0f5d07a 100644 --- a/NetworkPkg/NetworkPkg.dsc +++ b/NetworkPkg/NetworkPkg.dsc @@ -79,6 +79,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64] NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf =20 +[LibraryClasses.ARM] + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + +[LibraryClasses.RISCV64] + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + [PcdsFeatureFlag] gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83298): https://edk2.groups.io/g/devel/message/83298 Mute This Topic: https://groups.io/mt/86804620/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83299+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83299+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980412; cv=none; d=zohomail.com; s=zohoarc; b=Fe6EqrsmYylKle1zkCZnD7cW0Ye0NtwMKbdsYwUL8kx9inTVswzCo0UZcAG5Wk7AceGYygDB9i9ab34Jo+IHn7C1y0vq/mpkMT8RV0JsnFB7h9Gyjkj3RFcCkomWpchwOiIZ1vKXrNN6HmxHQI4d2sNWASdFRtRdlMQDEdJfjic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980412; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZIuUAATH5IKow0J5tUk5ntIgioPZuKDk+MnvoF0uhkw=; b=j8/8XdyIaun+mGgMwhMgn+2ycCKBQ81NRg7st5PvUUvZcbKTo/RbREPUrC3J5QAKVdSEM94ffqCQD0mKu4XjeLpu0UGolfJPBB7XEKhEQ3Q04hp9coPexHyKl4y0F7Bd4+cj1ozG4Y4QC/dt95x/CM1eLI5SM/uIjGeGLsY2OdI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83299+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635980412659489.8652647267993; Wed, 3 Nov 2021 16:00:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id bY0RYY1788612x3a9l2RGgBD; Wed, 03 Nov 2021 16:00:12 -0700 X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.4275.1635980409729376762 for ; Wed, 03 Nov 2021 16:00:10 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231564110" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="231564110" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:09 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813071" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:08 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Jiewen Yao Subject: [edk2-devel] [Patch V2 3/7] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64 Date: Wed, 3 Nov 2021 15:59:50 -0700 Message-Id: <20211103225954.1680-4-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: zI17DMblOGQhGFJ0TTHVZcKXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980412; bh=KmnrgUX04zYLgDFiFPcdZu532REO2xPXHLbc/SIKL7s=; h=Cc:Date:From:Reply-To:Subject:To; b=cKdKxmlY/8KZRZqZwfXfWu8TuT8gKNneOd4otV+9SNOL8+lA9OKZZmArWKQtXu7gcte 3GcoOh5SCD9+FK2KOBvbCgXgbBy8QvaELz6cOYWk7YQmQNsPK4HlPVLF6/CogTuBH55I0 sXmASRR78n9SAQD1VQPYVtrdHV4hlSDFsp0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635981315694100002 Content-Type: text/plain; charset="utf-8" Fix SecurityPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Jiewen Yao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney Acked-by: Jiewen Yao Reviewed-by: Daniel Schaefer Acked-by: Abner Chang --- SecurityPkg/SecurityPkg.dsc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index 37318c64c59f..73a93c2285b1 100644 --- a/SecurityPkg/SecurityPkg.dsc +++ b/SecurityPkg/SecurityPkg.dsc @@ -84,6 +84,14 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64] # Add support for GCC stack protector NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf =20 + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf + +[LibraryClasses.ARM] + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + +[LibraryClasses.RISCV64] + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + [LibraryClasses.common.PEIM] PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf @@ -381,4 +389,3 @@ [BuildOptions] MSFT:*_*_IA32_DLINK_FLAGS =3D /ALIGN:256 INTEL:*_*_IA32_DLINK_FLAGS =3D /ALIGN:256 *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES - --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83299): https://edk2.groups.io/g/devel/message/83299 Mute This Topic: https://groups.io/mt/86804622/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83300+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83300+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980413; cv=none; d=zohomail.com; s=zohoarc; b=CspT8EPUUxgLf25c/+OoZl1mhQgZID/3EFK4sGDzwKoUhMUiHhAa788feJ07L2NI+jOije6W6utx5Xd8t8r09lDm9Vr9FrWzkcOojLKcJyw362NtHeyKUHA+I3cBizftOe4eg9ShmXgE/U7OCN+0BXbOPoP7FdtYiZgCM4O6na4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980413; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=VlIM28dh5+EA8h04i8GR+eDF8S/TCo9KOxfAHBb/9gc=; b=nm7w20Wdruv+tQI/RZsjDNEFeRBNaAJyrlpO+ukDPl1y1+ad/ohQieljfKV05Q18d9Jsn6Vfgnsy3z1ZuxhUqd4eI7iqjClg9N4XzIChutlCYegIfaEGyQry9CkbsMzrIz5e5joSRcmVDRLMhV/A6tP1zOkV1UOJth3BI89FJ8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83300+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635980413110812.3156300430448; Wed, 3 Nov 2021 16:00:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tMozYY1788612xYYgEfq0XC6; Wed, 03 Nov 2021 16:00:12 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.4277.1635980411005838808 for ; Wed, 03 Nov 2021 16:00:11 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="229070026" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="229070026" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:10 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813075" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:08 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Jian J Wang , Ard Biesheuvel , Abner Chang , Daniel Schaefer Subject: [edk2-devel] [Patch V2 4/7] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping Date: Wed, 3 Nov 2021 15:59:51 -0700 Message-Id: <20211103225954.1680-5-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: QGGaPiEOZUSZntLLCi1KuGFrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980412; bh=EcnLRlAA1edzUNcbsp5zBaHvpBSIxaYEaLhe9Lyw7gA=; h=Cc:Date:From:Reply-To:Subject:To; b=UAqo5uj8nmRk5DvFlYO/cKP/s6Cc0W4XxnQP/XSEbKAajtEa9Ri9gdvvbK/Lreii5QV XbfYRws+QPuizqTxnEfHkAkv9/9ZZJeQ6G9WeISdrb1szteYpBvHXO3ID83SyfxsK2u7I ppx8migPhe5hwf8xUu+7WoVHGPP9imiGe3A= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635981315723100006 Content-Type: text/plain; charset="utf-8" Fix build breaks for all architectures by adding RngLib mapping. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney Reviewed-by: Daniel Schaefer Acked-by: Abner Chang --- SignedCapsulePkg/SignedCapsulePkg.dsc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/Signe= dCapsulePkg.dsc index 2152d3d15668..8a27207a6f20 100644 --- a/SignedCapsulePkg/SignedCapsulePkg.dsc +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc @@ -93,6 +93,7 @@ [LibraryClasses] EdkiiSystemCapsuleLib|SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/Edk= iiSystemCapsuleLib.inf IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf PlatformFlashAccessLib|SignedCapsulePkg/Library/PlatformFlashAccessLibNu= ll/PlatformFlashAccessLibNull.inf + RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf =20 [LibraryClasses.ARM] ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf @@ -108,6 +109,12 @@ [LibraryClasses.AARCH64, LibraryClasses.ARM] # Add support for GCC stack protector NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf =20 +[LibraryClasses.ARM] + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + +[LibraryClasses.RISCV64] + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + [LibraryClasses.common.PEI_CORE] HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83300): https://edk2.groups.io/g/devel/message/83300 Mute This Topic: https://groups.io/mt/86804625/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83301+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83301+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980413; cv=none; d=zohomail.com; s=zohoarc; b=OsKxGxxnMEJCv4j6qSvW5yeFLA07Rqee11srlUF8wECA/MesXrNpJc6DkBQK58IK3HlJ4cVHZIFPqKnlcHV88mexhWMt/NfJL8hxnK7Udut6JfRoOfjJeBQmrGA0Z1CSkulS69+9cay5X+c0f8fvEA6fxFBv+Qi21Pxhs4pTg6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980413; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dgQoDEWDzQqjFVZ6LKhuPg4Wz6pFsO0N8nqDKTAerHY=; b=fG5IcOrttwqdjsPr2W5WPeHQXiuSa5ovgmQiMNIMTkjSAvSPTuy5yxukD2RSZl/E3dKNsPL0gb4GDSnqkAiUdETbcIvQIPqayO1Gss5gxqoVy8Z28Mt8qDDU1/3Z/SKnAFONWCnaGNcsFz36PBH0FBrghHOTZqGGAu+xRbSkILs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83301+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635980413481991.6869998494652; Wed, 3 Nov 2021 16:00:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id s3SGYY1788612xw3UtTytbVz; Wed, 03 Nov 2021 16:00:13 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.4277.1635980411005838808 for ; Wed, 03 Nov 2021 16:00:11 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="229070027" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="229070027" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:10 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813078" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:09 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar , Philippe Mathieu-Daude Subject: [edk2-devel] [Patch V2 5/7] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues Date: Wed, 3 Nov 2021 15:59:52 -0700 Message-Id: <20211103225954.1680-6-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: PsFfRXAT2fC6SRAtBn5ytnQtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980413; bh=QS4RofjB/KwPVIOuHOagCd4hdoIGicLGS5CyluyqfRM=; h=Cc:Date:From:Reply-To:Subject:To; b=LU9HB4yL79Pn3K1ZWkTJImfhQelj9lxM2QxD4bttPJRRA3hoOsU8WZkYwjWyWUE+qag DLNhJrrLYfL8xTgisw4joI9heVa3EzXVPSgJndzdWVkeyOFocZa10r7t268mZEQaf9X6i eU/F6TOsEB62yyQGqdR4SHo3W9Mko/zNY2U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635981315713100003 Content-Type: text/plain; charset="utf-8" When using UT_ASSERT_EQUAL() on a pointer value, it must be cast to UINTN. This follows the samples provided with the UnitTestFrameworkPkg. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Michael D Kinney Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c b/UefiCp= uPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c index 30ee1dc32522..e84b9390601d 100644 --- a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c +++ b/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c @@ -599,7 +599,7 @@ UnitTestMtrrGetFixedMtrr ( } =20 Result =3D MtrrGetFixedMtrr (&FixedSettings); - UT_ASSERT_EQUAL (Result, &FixedSettings); + UT_ASSERT_EQUAL ((UINTN)Result, (UINTN)&FixedSettings); UT_ASSERT_MEM_EQUAL (&FixedSettings, &ExpectedFixedSettings, sizeof (F= ixedSettings)); } =20 @@ -612,7 +612,7 @@ UnitTestMtrrGetFixedMtrr ( ZeroMem (&FixedSettings, sizeof (FixedSettings)); ZeroMem (&ExpectedFixedSettings, sizeof (ExpectedFixedSettings)); Result =3D MtrrGetFixedMtrr (&FixedSettings); - UT_ASSERT_EQUAL (Result, &FixedSettings); + UT_ASSERT_EQUAL ((UINTN)Result, (UINTN)&FixedSettings); UT_ASSERT_MEM_EQUAL (&ExpectedFixedSettings, &FixedSettings, sizeof (Exp= ectedFixedSettings)); =20 return UNIT_TEST_PASSED; @@ -653,7 +653,7 @@ UnitTestMtrrGetAllMtrrs ( AsmWriteMsr64 (MSR_IA32_MTRR_PHYSMASK0 + (Index << 1), VariableMtrr[In= dex].Mask); } Result =3D MtrrGetAllMtrrs (&Mtrrs); - UT_ASSERT_EQUAL (Result, &Mtrrs); + UT_ASSERT_EQUAL ((UINTN)Result, (UINTN)&Mtrrs); UT_ASSERT_MEM_EQUAL (Mtrrs.Variables.Mtrr, VariableMtrr, sizeof (MTRR_VA= RIABLE_SETTING) * SystemParameter.VariableMtrrCount); =20 // @@ -665,7 +665,7 @@ UnitTestMtrrGetAllMtrrs ( SystemParameter.MtrrSupported =3D FALSE; InitializeMtrrRegs (&SystemParameter); Result =3D MtrrGetAllMtrrs (&Mtrrs); - UT_ASSERT_EQUAL (Result, &Mtrrs); + UT_ASSERT_EQUAL ((UINTN)Result, (UINTN)&Mtrrs); UT_ASSERT_MEM_EQUAL (&ExpectedMtrrs, &Mtrrs, sizeof (ExpectedMtrrs)); =20 // @@ -718,7 +718,7 @@ UnitTestMtrrSetAllMtrrs ( GenerateRandomMtrrPair (SystemParameter.PhysicalAddressBits, GenerateR= andomCacheType (), &Mtrrs.Variables.Mtrr[Index], NULL); } Result =3D MtrrSetAllMtrrs (&Mtrrs); - UT_ASSERT_EQUAL (Result, &Mtrrs); + UT_ASSERT_EQUAL ((UINTN)Result, (UINTN)&Mtrrs); =20 UT_ASSERT_EQUAL (AsmReadMsr64 (MSR_IA32_MTRR_DEF_TYPE), Mtrrs.MtrrDefTyp= e); for (Index =3D 0; Index < SystemParameter.VariableMtrrCount; Index++) { --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83301): https://edk2.groups.io/g/devel/message/83301 Mute This Topic: https://groups.io/mt/86804627/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83302+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83302+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980413; cv=none; d=zohomail.com; s=zohoarc; b=PW8Cy7S4pe80d4/1SZzH1jrYWVpyM478b3G8A7/d+3Fqtw2RRnK+tZ/M3vm8WfZtgDmhHNR/858O6M2j4tzkDHB2gogFnxd/njheTwm9dhdtRlkfVU2OD9UIoXTM20Yea954dVwk5I3h/zDkFmV4+aRlwzzW7AfR5xF9FI8/xwg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980413; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=OmdVCQnmqQzpH3FhVLA2gRz5skTNkSIOD0lq0uAP1Zo=; b=XnxRbqs8u7i+GQxAYzvogNksehizwpGqlKOICaJVYtQp/1QKohxF635kCtAjUXLaQ30C/4xQTlSKLMgWVehYXo7T4AL5m/DZbrxO/BB4hg6fvU9kTOCGY8+dfYFXC9DE00kaS1gt/SagkDAht9yNfAGH3F9GJ+7PlbF+qv7qxv0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83302+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635980413875477.1563290996929; Wed, 3 Nov 2021 16:00:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id im8iYY1788612x2b0xY2NrBf; Wed, 03 Nov 2021 16:00:13 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.4277.1635980411005838808 for ; Wed, 03 Nov 2021 16:00:11 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="229070030" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="229070030" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:10 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813081" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:10 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Hao A Wu , Liming Gao , Bret Barkelew , Philippe Mathieu-Daude Subject: [edk2-devel] [Patch V2 6/7] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds Date: Wed, 3 Nov 2021 15:59:53 -0700 Message-Id: <20211103225954.1680-7-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: Py9RJoVlJ5Jue5VTobmBtvDDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980413; bh=DtnVJXynbFPU53PCnIVj+ryWtjFaXE6PKldME7SqpnA=; h=Cc:Date:From:Reply-To:Subject:To; b=GWOsv+CwOx8/gDIg7KAg5T5Qm7L4mTqxyZmEHMtT5t2BmMMoKIGlrYOOGBlKP/13q5o jehKeX73kXOPgLjeHXjhCLNzE3vW4b3ogEuWQ27olQOa/iJsTOJM6V0Wn2pniUdYgyxLh ERPS84uG+fBxpTuJWN6TAqhg0N2tV7WXbq0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635980414814100020 Content-Type: text/plain; charset="utf-8" When using will_return() on a pointer value, it must be cast to UINTN to be compatible with 32-bit GCC builds. This uses the same approach in samples provided in the UnitTestFramworkPkg when passing pointer values to UT_ASSERT_EQUAL(). Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by: Michael D Kinney Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Bret Barkelew Reviewed-by: Hao A Wu --- .../RuntimeDxeUnitTest/VariableLockRequestToLockUnitTest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/RuntimeDxeUnitTest/= VariableLockRequestToLockUnitTest.c b/MdeModulePkg/Universal/Variable/Runti= meDxe/RuntimeDxeUnitTest/VariableLockRequestToLockUnitTest.c index 44d70e639d77..880994fe71fc 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/RuntimeDxeUnitTest/Variabl= eLockRequestToLockUnitTest.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/RuntimeDxeUnitTest/Variabl= eLockRequestToLockUnitTest.c @@ -287,7 +287,7 @@ LockingAnUnlockedVariableShouldFail ( // With a policy, make sure that writes still work, since the variable d= oesn't exist. will_return( StubGetVariableNull, TEST_POLICY_ATTRIBUTES_NULL ); // A= ttributes will_return( StubGetVariableNull, 0 ); // S= ize - will_return( StubGetVariableNull, NULL ); // D= ataPtr + will_return( StubGetVariableNull, (UINTN)NULL ); // D= ataPtr will_return( StubGetVariableNull, EFI_NOT_FOUND); // S= tatus =20 Status =3D VariableLockRequestToLock (NULL, TEST_VAR_1_NAME, &mTestGuid1= ); @@ -342,7 +342,7 @@ LockingALockedVariableWithMatchingDataShouldSucceed ( Data =3D 1; will_return( StubGetVariableNull, TEST_POLICY_ATTRIBUTES_NULL ); // A= ttributes will_return( StubGetVariableNull, sizeof (Data) ); // S= ize - will_return( StubGetVariableNull, &Data ); // D= ataPtr + will_return( StubGetVariableNull, (UINTN)&Data ); // D= ataPtr will_return( StubGetVariableNull, EFI_SUCCESS); // S= tatus =20 Status =3D VariableLockRequestToLock (NULL, TEST_VAR_1_NAME, &mTestGuid1= ); @@ -397,7 +397,7 @@ LockingALockedVariableWithNonMatchingDataShouldFail ( Data =3D 2; will_return( StubGetVariableNull, TEST_POLICY_ATTRIBUTES_NULL ); // A= ttributes will_return( StubGetVariableNull, sizeof (Data) ); // S= ize - will_return( StubGetVariableNull, &Data ); // D= ataPtr + will_return( StubGetVariableNull, (UINTN)&Data ); // D= ataPtr will_return( StubGetVariableNull, EFI_SUCCESS); // S= tatus =20 Status =3D VariableLockRequestToLock (NULL, TEST_VAR_1_NAME, &mTestGuid1= ); --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83302): https://edk2.groups.io/g/devel/message/83302 Mute This Topic: https://groups.io/mt/86804630/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 21:22:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83303+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83303+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635980414; cv=none; d=zohomail.com; s=zohoarc; b=SikPt5csNpCDtugLJ+sYTJ064Fuu6S12+dzxlkznj91ycbYCLuk828+2yvsRJV74NTuBDBCFg4QIcYkHmUnU0xZY+SxGB8rr7q/qosW1Oq+Bue6heNduHDf7L3yC0vcupzrsek/MaQyePMTqpeTSEuI8Q9DXfrRFIhRcaZdLO20= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635980414; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=zyzTrxeAmleRnDYLgdmE+NN6kLH854C+wRFUlW++TBI=; b=N8ZQ8gKr5DwtKPa4NscUo//RnMX+6xA0jdnm7PpcMR4tJs5dizn/AfT+N3rvxgo4ZeOqo0QCvEu030Dt/wgxPm3OhQ9Rf9nmhi0cIoyN5hKBqG3dHhDhXVU0jg+kgjp4zzvEs80T6/7h45mddKPgK1w2CWwIns6Z3/GCpMzzYz8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83303+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 163598041426125.189883100936868; Wed, 3 Nov 2021 16:00:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id YcC1YY1788612x2mCgxgdW25; Wed, 03 Nov 2021 16:00:13 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.4296.1635980412177963548 for ; Wed, 03 Nov 2021 16:00:12 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="229070038" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="229070038" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:11 -0700 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="729813084" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.88.80]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 16:00:10 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [Patch V2 7/7] BaseTools/Conf: Fix Linux GCC ARM build issues with HII Date: Wed, 3 Nov 2021 15:59:54 -0700 Message-Id: <20211103225954.1680-8-michael.d.kinney@intel.com> In-Reply-To: <20211103225954.1680-1-michael.d.kinney@intel.com> References: <20211103225954.1680-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: 0jlcyBDdHehbztOZckIGU0nNx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635980413; bh=1qcXLY014qw/74D9tc2lH4BsTC/ltmvtp7c21dZFviY=; h=Cc:Date:From:Reply-To:Subject:To; b=DeM2VHtq86ch2xw90wEahBgj0Ronoqzh6O0Avy5tM9h5rfOPgiETBWEIMv+HCuS9JWf O886daXb2aEjorrKT0hUbMeOqBuOIUI2Licou7XtmiMGvuOZi5Rk+CLdB8IRexoVmkqTc mwXxKX9tmVBauSuW7t2pMB4mxjEyyasz3oc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635981315739100007 Content-Type: text/plain; charset="utf-8" Update builds_rules.template to add $(SLINK) to the GCC steps for processing HII resources to produce a static library instead of an object file. This improves linker compatibility and specifically fixes a link failure seen on Linux GCC ARM builds of the MdeModulePkg due to mismatched ABI types between the HII resource section and the rest of the libraries. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney Reviewed-by: Leif Lindholm --- BaseTools/Conf/build_rule.template | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index 3add1029f276..5f59044da36d 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -668,6 +668,8 @@ =20 "$(GENFW)" -o $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc -g $(MODULE_GUI= D) --hiibinpackage $(HII_BINARY_PACKAGES) $(GENFW_FLAGS) - "$(RC)" $(RC_FLAGS) $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc ${dst} + "$(RC)" $(RC_FLAGS) $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc $(OUTPUT_= DIR)(+)$(MODULE_NAME)hii.rc.obj + "$(SLINK)" cr ${dst} $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc.obj + "$(GENFW)" -o $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc -g $(MODULE_GUI= D) --hiibinpackage $(HII_BINARY_PACKAGES) $(GENFW_FLAGS) --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83303): https://edk2.groups.io/g/devel/message/83303 Mute This Topic: https://groups.io/mt/86804632/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-