From nobody Sun Apr 28 22:54:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83260+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83260+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1635950741; cv=none; d=zohomail.com; s=zohoarc; b=XaPKCowDuxRhbVZz3FXhqgi/05y6hNuiTXajIKWCKPy0LKbYGBKQyhOk8svSwo5L5Z9OSXz8n1pEwCZfw8T8uynWDVg6KectJC2cRKWy4yje3eMM48mJZKeHelBTqV5wo/2Fq5zLgglKzr4cv3GMq3Y5483blN1aU8m2mDrK7pA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635950741; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=4LFfGWEuUpWx2iN9CiBFqpdFYILzmVhyQPuf9GZq5uo=; b=Bo894d16t6Kq5K/sTTXAt4xQVMNWGTFSCuqVszVnmpb2nvpcgkt+5cU6YPw/kdEafYX2hbt0zchfFuiajotUHFuLzaOZFkIqU6Gwr8nRemHyzTv/OB07cKYQ+DulW2vNpfO6whv7utIDz133rGmU2dS4HC8bjnc/maaugXRT3mQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83260+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635950741728694.3405630014606; Wed, 3 Nov 2021 07:45:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id T1iSYY1788612xpsVCLkPMJ9; Wed, 03 Nov 2021 07:45:41 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.8627.1635950740265454130 for ; Wed, 03 Nov 2021 07:45:40 -0700 X-Received: from localhost.localdomain (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id EF26820A8623; Wed, 3 Nov 2021 07:45:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EF26820A8623 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Rangasai V Chaganty , Deepika Kethi Reddy , Kathappan Esakkithevar Subject: [edk2-devel] [PATCH v1 1/3] CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Remove unneeded SPI header Date: Wed, 3 Nov 2021 10:44:52 -0400 Message-Id: <20211103144454.2508-2-mikuback@linux.microsoft.com> In-Reply-To: <20211103144454.2508-1-mikuback@linux.microsoft.com> References: <20211103144454.2508-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: oOaAtXrhS49ssp7hrVch8G0sx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635950741; bh=4LFfGWEuUpWx2iN9CiBFqpdFYILzmVhyQPuf9GZq5uo=; h=Cc:Date:From:Reply-To:Subject:To; b=G26/itFWzKJAh48ax6jtK/Do+/Wtt7cHyIqKw+eIyT0erdI8v42ubR7+XlWBzHpS41I 2tgDPCCpKEe60FfXh+y6Pa47r4/r9G21dtQu48Sy+YoE66AxGrz7wUxf2FeIn6Q9RNMcn u4GpaNN27JeHwDH2HagviQAU364B/8hrFDE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635950742563100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki This contents of the header file are not referenced in this source file. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Sai Chaganty --- Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/Pei= PchPolicyUpdate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyU= pdateLib/PeiPchPolicyUpdate.c b/Platform/Intel/CometlakeOpenBoardPkg/Policy= /Library/PeiPolicyUpdateLib/PeiPchPolicyUpdate.c index 4a8ffa7226da..76de6e90c728 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi= b/PeiPchPolicyUpdate.c +++ b/Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi= b/PeiPchPolicyUpdate.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83260): https://edk2.groups.io/g/devel/message/83260 Mute This Topic: https://groups.io/mt/86792798/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun Apr 28 22:54:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83261+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83261+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1635950745; cv=none; d=zohomail.com; s=zohoarc; b=Ltuky5Ll2iwtBHBakorBrLkS9qp640BDynlYlG0myjLs5k4JsLk37CC3mkRIEpUWzC0hE0hBaF+JWSaovzVOFhfKS2kMDuJxvzHg4+UhGO3ey5jbKAw8+8zFq7yfjvav2dV2hksqzLpy41LoM++lJrG6ZWlHk52iqQFKaElChwk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635950745; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=38bjF5tsn19wUsQoHtbb1Mh3DVrKX6XEZrt+7ShWzHs=; b=ePcGJVrIJuqC/hSVv2VCTIPDOog1omOIpidRVaY5cPl88QMk0b65kc2BdhTEwwRwqsPCxc65erGteHH4k6YmpWuO5btuiFeKbJBymYF5O6YJyO5bpYqoCXf5is+J/+1Gp1YwhaDK2/fUgzxqvED5HWxsP6/EWRw3t0C6IoXL46Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83261+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635950745396773.0235687410735; Wed, 3 Nov 2021 07:45:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id cAPuYY1788612xZGLvrNw5ua; Wed, 03 Nov 2021 07:45:45 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.8607.1635950744376843784 for ; Wed, 03 Nov 2021 07:45:44 -0700 X-Received: from localhost.localdomain (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id 9C3A820B9CE9; Wed, 3 Nov 2021 07:45:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9C3A820B9CE9 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-devel] [PATCH v1 2/3] WhiskeylakeOpenBoardPkg/PeiPolicyUpdateLib: Remove unneeded SPI header Date: Wed, 3 Nov 2021 10:44:53 -0400 Message-Id: <20211103144454.2508-3-mikuback@linux.microsoft.com> In-Reply-To: <20211103144454.2508-1-mikuback@linux.microsoft.com> References: <20211103144454.2508-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: B5so78PEN4sGMMuAR51Hw63Wx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635950745; bh=74Zpx0ZhPk4noDaKUtSTo/zEGdyVnUtkOCiHhNgdIx4=; h=Cc:Date:From:Reply-To:Subject:To; b=egblEaGkicMHKVWW02E5YykKkOleQAMeLvyi9cRhcmnD+m81vQJRa9tuCiJm+SkBrYV 56nuvuOgZxodmFIZD/7B+ecCV3jXGg2o3mO5pUuIHu4ACKi2F0ypP8H4V4LwZ6DWDJUdF pdZeVHArKPRIR2vMUXnLk4Ptfdp9txwncYg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635950746194100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki This contents of the header file are not referenced in this source file. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Sai Chaganty --- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPchPolicyUpdate.c | 1 - Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf | 1 - 2 files changed, 2 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPchPolicyUpdate.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Po= licy/Library/PeiPolicyUpdateLib/PeiPchPolicyUpdate.c index ebce9b271a2d..049ca6a604bd 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdate.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdate.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPolicyUpdateLib.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/= Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf index e44cf5f02ac7..af5d4dfeb7ca 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPolicyUpdateLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPolicyUpdateLib.inf @@ -266,7 +266,6 @@ [Sources] =20 [Ppis] gWdtPpiGuid ## CONSUMES - gPchSpi2PpiGuid ## CONSUMES gSiPolicyPpiGuid ## CONSUMES gSiPreMemPolicyPpiGuid ## CONSUMES gPeiTbtPolicyPpiGuid ## CONSUMES --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83261): https://edk2.groups.io/g/devel/message/83261 Mute This Topic: https://groups.io/mt/86792799/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun Apr 28 22:54:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83262+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83262+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1635950749; cv=none; d=zohomail.com; s=zohoarc; b=ZjNYnxsBqTatJhRm7NcY3kFv85g/cHw9GrVY3Ruw1GKaQuc/1fYLsSLn5yGSssXJLy7hvngV7lEoRenVEcDSBu2EDYzYtZkN9Di7xOiYMvZnnf/1wlcl+BGSpOpl8/n0b6FLR7hu1UNsuLO15JMojREUTQaUkKJfIeKSL0F9opo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635950749; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=s4DCS0zafzVMlXWr7iVIIt6ELWaIkGI5PKNz7H+uG4w=; b=W/Na5QqHxXVDDwDCirL+NawuAyBF3cobe6o27DnP5LInkjXW5no9NOPTt0araia7mnpEYfKmWif9m3PMidG6NEmNrlFeq3cyNGCywmrHs+y75FLyWfHjFh+l7EeTqbVcZZiX+YV4Ch05teqnE6nhpa7HDgGVMrO9sQK9j8imwmI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83262+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16359507499151012.9404692033917; Wed, 3 Nov 2021 07:45:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RP1eYY1788612xBO7FSmzd0A; Wed, 03 Nov 2021 07:45:49 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.8804.1635950748824389388 for ; Wed, 03 Nov 2021 07:45:49 -0700 X-Received: from localhost.localdomain (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id BA31820B9D56; Wed, 3 Nov 2021 07:45:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BA31820B9D56 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ray Ni , Rangasai V Chaganty , Nate DeSimone , Isaac Oram Subject: [edk2-devel] [PATCH v1 3/3] IntelSiliconPkg: Remove SPI v1 PPI and Protocol definitions Date: Wed, 3 Nov 2021 10:44:54 -0400 Message-Id: <20211103144454.2508-4-mikuback@linux.microsoft.com> In-Reply-To: <20211103144454.2508-1-mikuback@linux.microsoft.com> References: <20211103144454.2508-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 7eNNUPhRzagEtCPPtlEhziw5x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635950749; bh=45YGwDl7+fpgOq1TEY+ciwcgfHUovCW/+vxEDFVtqeQ=; h=Cc:Date:From:Reply-To:Subject:To; b=pzkEdbFTYdBkJlYsBGZCXq+bRAPKuWm6AOFB3yi/hKI7EdKNi1cUOr/hRtNdR85QT8h ra/TW+YhRD2lnrPChmOKXBck32B4Gp+wNsOJMBcVEccHy5qceZaGw7Lje1oH5SqYJso39 SRGVUqtkcy5VyOSvAl2pxfktwz4PNWzLa30= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635950751123100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3717 V2 of the PCH SPI PPI and PCH SPI Protocol were recently added to IntelSiliconPkg. This change removes the v1 definitions. V2 is intended to better support multiple silicon generations which aligns with the goals of IntelSiliconPkg. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Nate DeSimone Cc: Isaac Oram Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Sai Chaganty --- Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h | 25 -- Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h | 301 ---------------= ----- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 7 - 3 files changed, 333 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h b/Silicon/Inte= l/IntelSiliconPkg/Include/Ppi/Spi.h deleted file mode 100644 index b2410bd17300..000000000000 --- a/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h +++ /dev/null @@ -1,25 +0,0 @@ -/** @file - This file defines the PCH SPI PPI which implements the - Intel(R) PCH SPI Host Controller Compatibility Interface. - - Copyright (c) 2019, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ -#ifndef _PCH_SPI_PPI_H_ -#define _PCH_SPI_PPI_H_ - -#include - -// -// Extern the GUID for PPI users. -// -extern EFI_GUID gPchSpiPpiGuid; - -/** - Reuse the PCH_SPI_PROTOCOL definitions - This is possible becaues the PPI implementation does not rely on a PeiSe= rvice pointer, - as it uses EDKII Glue Lib to do IO accesses -**/ -typedef PCH_SPI_PROTOCOL PCH_SPI_PPI; - -#endif diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h b/Silicon= /Intel/IntelSiliconPkg/Include/Protocol/Spi.h deleted file mode 100644 index c13dc5a5f5f5..000000000000 --- a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h +++ /dev/null @@ -1,301 +0,0 @@ -/** @file - This file defines the PCH SPI Protocol which implements the - Intel(R) PCH SPI Host Controller Compatibility Interface. - - Copyright (c) 2021, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ -#ifndef _PCH_SPI_PROTOCOL_H_ -#define _PCH_SPI_PROTOCOL_H_ - -// -// Extern the GUID for protocol users. -// -extern EFI_GUID gPchSpiProtocolGuid; -extern EFI_GUID gPchSmmSpiProtocolGuid; - -// -// Forward reference for ANSI C compatibility -// -typedef struct _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL; - -// -// SPI protocol data structures and definitions -// - -/** - Flash Region Type -**/ -typedef enum { - FlashRegionDescriptor, - FlashRegionBios, - FlashRegionMe, - FlashRegionGbE, - FlashRegionPlatformData, - FlashRegionDer, - FlashRegionSecondaryBios, - FlashRegionuCodePatch, - FlashRegionEC, - FlashRegionDeviceExpansion2, - FlashRegionIE, - FlashRegion10Gbe_A, - FlashRegion10Gbe_B, - FlashRegion13, - FlashRegion14, - FlashRegion15, - FlashRegionAll, - FlashRegionMax -} FLASH_REGION_TYPE; -// -// Protocol member functions -// - -/** - Read data from the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] FlashRegionType The Flash Region type for flash cycle wh= ich is listed in the Descriptor. - @param[in] Address The Flash Linear Address must fall withi= n a region for which BIOS has access permissions. - @param[in] ByteCount Number of bytes in the data portion of t= he SPI cycle. - @param[out] Buffer The Pointer to caller-allocated buffer c= ontaining the dada received. - It is the caller's responsibility to mak= e sure Buffer is large enough for the total number of bytes read. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_READ) ( - IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, - IN UINT32 Address, - IN UINT32 ByteCount, - OUT UINT8 *Buffer - ); - -/** - Write data to the flash part. Remark: Erase may be needed before write t= o the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] FlashRegionType The Flash Region type for flash cycle wh= ich is listed in the Descriptor. - @param[in] Address The Flash Linear Address must fall withi= n a region for which BIOS has access permissions. - @param[in] ByteCount Number of bytes in the data portion of t= he SPI cycle. - @param[in] Buffer Pointer to caller-allocated buffer conta= ining the data sent during the SPI cycle. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_WRITE) ( - IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, - IN UINT32 Address, - IN UINT32 ByteCount, - IN UINT8 *Buffer - ); - -/** - Erase some area on the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] FlashRegionType The Flash Region type for flash cycle wh= ich is listed in the Descriptor. - @param[in] Address The Flash Linear Address must fall withi= n a region for which BIOS has access permissions. - @param[in] ByteCount Number of bytes in the data portion of t= he SPI cycle. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_ERASE) ( - IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, - IN UINT32 Address, - IN UINT32 ByteCount - ); - -/** - Read SFDP data from the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] ComponentNumber The Componen Number for chip select - @param[in] Address The starting byte address for SFDP data = read. - @param[in] ByteCount Number of bytes in SFDP data portion of = the SPI cycle - @param[out] SfdpData The Pointer to caller-allocated buffer c= ontaining the SFDP data received - It is the caller's responsibility to mak= e sure Buffer is large enough for the total number of bytes read - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_READ_SFDP) ( - IN PCH_SPI_PROTOCOL *This, - IN UINT8 ComponentNumber, - IN UINT32 Address, - IN UINT32 ByteCount, - OUT UINT8 *SfdpData - ); - -/** - Read Jedec Id from the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] ComponentNumber The Componen Number for chip select - @param[in] ByteCount Number of bytes in JedecId data portion = of the SPI cycle, the data size is 3 typically - @param[out] JedecId The Pointer to caller-allocated buffer c= ontaining JEDEC ID received - It is the caller's responsibility to mak= e sure Buffer is large enough for the total number of bytes read. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_READ_JEDEC_ID) ( - IN PCH_SPI_PROTOCOL *This, - IN UINT8 ComponentNumber, - IN UINT32 ByteCount, - OUT UINT8 *JedecId - ); - -/** - Write the status register in the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] ByteCount Number of bytes in Status data portion o= f the SPI cycle, the data size is 1 typically - @param[in] StatusValue The Pointer to caller-allocated buffer c= ontaining the value of Status register writing - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_WRITE_STATUS) ( - IN PCH_SPI_PROTOCOL *This, - IN UINT32 ByteCount, - IN UINT8 *StatusValue - ); - -/** - Read status register in the flash part. - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] ByteCount Number of bytes in Status data portion o= f the SPI cycle, the data size is 1 typically - @param[out] StatusValue The Pointer to caller-allocated buffer c= ontaining the value of Status register received. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_FLASH_READ_STATUS) ( - IN PCH_SPI_PROTOCOL *This, - IN UINT32 ByteCount, - OUT UINT8 *StatusValue - ); - -/** - Get the SPI region base and size, based on the enum type - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] FlashRegionType The Flash Region type for for the base a= ddress which is listed in the Descriptor. - @param[out] BaseAddress The Flash Linear Address for the Region = 'n' Base - @param[out] RegionSize The size for the Region 'n' - - @retval EFI_SUCCESS Read success - @retval EFI_INVALID_PARAMETER Invalid region type given - @retval EFI_DEVICE_ERROR The region is not used -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_GET_REGION_ADDRESS) ( - IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, - OUT UINT32 *BaseAddress, - OUT UINT32 *RegionSize - ); - -/** - Read PCH Soft Strap Values - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] SoftStrapAddr PCH Soft Strap address offset from FPSBA. - @param[in] ByteCount Number of bytes in SoftStrap data portio= n of the SPI cycle - @param[out] SoftStrapValue The Pointer to caller-allocated buffer c= ontaining PCH Soft Strap Value. - If the value of ByteCount is 0, the data= type of SoftStrapValue should be UINT16 and SoftStrapValue will be PCH Sof= t Strap Length - It is the caller's responsibility to mak= e sure Buffer is large enough for the total number of bytes read. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_READ_PCH_SOFTSTRAP) ( - IN PCH_SPI_PROTOCOL *This, - IN UINT32 SoftStrapAddr, - IN UINT32 ByteCount, - OUT VOID *SoftStrapValue - ); - -/** - Read CPU Soft Strap Values - - @param[in] This Pointer to the PCH_SPI_PROTOCOL instance. - @param[in] SoftStrapAddr CPU Soft Strap address offset from FCPUS= BA. - @param[in] ByteCount Number of bytes in SoftStrap data portio= n of the SPI cycle. - @param[out] SoftStrapValue The Pointer to caller-allocated buffer c= ontaining CPU Soft Strap Value. - If the value of ByteCount is 0, the data= type of SoftStrapValue should be UINT16 and SoftStrapValue will be PCH Sof= t Strap Length - It is the caller's responsibility to mak= e sure Buffer is large enough for the total number of bytes read. - - @retval EFI_SUCCESS Command succeed. - @retval EFI_INVALID_PARAMETER The parameters specified are not valid. - @retval EFI_DEVICE_ERROR Device error, command aborts abnormally. -**/ -typedef -EFI_STATUS -(EFIAPI *PCH_SPI_READ_CPU_SOFTSTRAP) ( - IN PCH_SPI_PROTOCOL *This, - IN UINT32 SoftStrapAddr, - IN UINT32 ByteCount, - OUT VOID *SoftStrapValue - ); - -/** - These protocols/PPI allows a platform module to perform SPI operations t= hrough the - Intel PCH SPI Host Controller Interface. -**/ -struct _PCH_SPI_PROTOCOL { - /** - This member specifies the revision of this structure. This field is us= ed to - indicate backwards compatible changes to the protocol. - **/ - UINT8 Revision; - PCH_SPI_FLASH_READ FlashRead; ///< Read data fro= m the flash part. - PCH_SPI_FLASH_WRITE FlashWrite; ///< Write data to= the flash part. Remark: Erase may be needed before write to the flash part. - PCH_SPI_FLASH_ERASE FlashErase; ///< Erase some ar= ea on the flash part. - PCH_SPI_FLASH_READ_SFDP FlashReadSfdp; ///< Read SFDP dat= a from the flash part. - PCH_SPI_FLASH_READ_JEDEC_ID FlashReadJedecId; ///< Read Jedec Id= from the flash part. - PCH_SPI_FLASH_WRITE_STATUS FlashWriteStatus; ///< Write the sta= tus register in the flash part. - PCH_SPI_FLASH_READ_STATUS FlashReadStatus; ///< Read status r= egister in the flash part. - PCH_SPI_GET_REGION_ADDRESS GetRegionAddress; ///< Get the SPI r= egion base and size - PCH_SPI_READ_PCH_SOFTSTRAP ReadPchSoftStrap; ///< Read PCH Soft= Strap Values - PCH_SPI_READ_CPU_SOFTSTRAP ReadCpuSoftStrap; ///< Read CPU Soft= Strap Values -}; - -/** - PCH SPI PPI/PROTOCOL revision number - - Revision 1: Initial version -**/ -#define PCH_SPI_SERVICES_REVISION 1 - -#endif diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dec index 1704f9e02541..f950c3d1c72b 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -93,9 +93,6 @@ [Guids] gFlashRegionMaxGuid =3D { 0x74c2e3c1, 0x8faa, 0x4659, {0xa= 7, 0xbb, 0x87, 0x1f, 0xbb, 0x61, 0xd3, 0xb4 } } =20 [Ppis] - ## Include/Ppi/Spi.h - gPchSpiPpiGuid =3D { 0x104c7177, 0xc2e6, 0x44f0, { 0xae, 0xe3, 0x9d, 0x0= d, 0x9a, 0x52, 0xca, 0xdf } } - ## Include/Ppi/Spi2.h gPchSpi2PpiGuid =3D { 0x63c40580, 0x10c4, 0x4a8e, { 0xb4, 0x16, 0x86, 0x= 85, 0x25, 0x7e, 0xce, 0x04 } } =20 @@ -105,10 +102,6 @@ [Ppis] [Protocols] ## Protocols that provide services for the Intel(R) PCH SPI Host Control= ler Compatibility Interface =20 - # Include/Protocol/Spi.h - gPchSpiProtocolGuid =3D { 0xe007dec0, 0xccc3, 0x4c90, { 0x9c, 0xd0, 0x= ef, 0x99, 0x38, 0x83, 0x28, 0xcf } } - gPchSmmSpiProtocolGuid =3D { 0x4840e48e, 0xc264, 0x4fef, { 0xb9, 0x34, 0= x14, 0x84, 0x0c, 0x95, 0xd8, 0x3f } } - # Include/Protocol/Spi2.h gPchSpi2ProtocolGuid =3D { 0x3a99abd1, 0x096c, 0x4399, { 0xb1, 0x68, 0x5= 2, 0xaa, 0x52, 0x64, 0xce, 0x70 } } gPchSmmSpi2ProtocolGuid =3D { 0x2d1c0c43, 0x20d3, 0x40ae, { 0x99, 0x07, = 0x2d, 0xf0, 0xe7, 0x91, 0x21, 0xa5 } } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83262): https://edk2.groups.io/g/devel/message/83262 Mute This Topic: https://groups.io/mt/86792801/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-