From nobody Fri May 3 12:34:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82732+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82732+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1635317859; cv=none; d=zohomail.com; s=zohoarc; b=ENKuSt5XNlCFJcdlqodEnBjXpX/uiRhPdmz5y5yfXzYBtX9MHS3lYKXh0lpQ2nIdOe6XwZPKxObGJyOWxkRGTSC3oA4SXhCSgVpuD8lpFSi7cuJHBa1/rUuqK4nN1PLJ6NvY+waqTk5uVJiZcU/Y+LsxXayaRYbi5ZgwqRPkZyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635317859; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=ZGvBgstpyqWsgUpgnwONbqSUePYflqMG8qaTUFd/UIk=; b=O7FV+uvXC78ZXp6TmtY+p03MiIt/kOw6iJAp9kNRcjRC/bWrv14o6eXqOeRB6a8oHpGUgXzZggWFs8y+a/TwETB2+oWNCH4C42oOdTgTQe2cPuPYLx3MPYkrIVqrIgCv8vCiGlb2czWzLwCO6B5CUGj3ye87PULmHMvO+ipTlas= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82732+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1635317859702573.7853959573904; Tue, 26 Oct 2021 23:57:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id TddMYY1788612xabHQQMwRpp; Tue, 26 Oct 2021 23:57:39 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.8261.1635317858541256498 for ; Tue, 26 Oct 2021 23:57:38 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="217000176" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="217000176" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 23:57:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="497730606" X-Received: from shwdejointlab96.ccr.corp.intel.com ([10.239.132.208]) by orsmga008.jf.intel.com with ESMTP; 26 Oct 2021 23:57:36 -0700 From: "Tan, Ming" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Date: Wed, 27 Oct 2021 14:56:53 +0800 Message-Id: <20211027065653.6579-1-ming.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ming.tan@intel.com X-Gm-Message-State: keTESXffuZKSF4UZ90bVymxGx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1635317859; bh=sBju5bswgAZpweb2DymF5j0PxfDSseQVrc2M/ZU7bNg=; h=Date:From:Reply-To:Subject:To; b=VtntaNVsxfciSPlFK6GJqRWuUhLK/Fug6Cku+BYC9SRiqKRD7oSITK0s97cMr7Gv8ql 0bAqQJcmjgEE0GCpJ4YbSdqBRV/QQTEBs7VCqw96TglNDVfjcRkSk5ZsgKFrv1U6ZJPLU a/eHaeAtckkfpbdyLPVknCDacV/htKOMsu0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1635317861575100002 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3708 The original code will cause FWTS V21.08.00 testing failed. spcr: SPCR PC-AT compatible IRQ 0xff is invalid spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device Now modify the SpcrAcpi for following: 1. Disable the support of PC-AT compatible IRQ support. Now only support IO-APIC interrupt type. 2. Set irq to 0. 3. Set the GSI to the value read from PCI device cfg space 0x3C. 4. Set PCI Flags to 1. Signed-off-by: Ming Tan Reviewed-by: Nate DeSimone --- V2: Fix a typo .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 86c40e90b8..7ad0c058c8 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c @@ -324,7 +324,9 @@ GetPciTypeInfo ( } =20 gSpcrInfo.BaseAddress.Address =3D BaseAddress; - gSpcrInfo.Irq =3D (UINT8) Irq; + gSpcrInfo.InterruptType =3D EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TAB= LE_INTERRUPT_TYPE_APIC; + gSpcrInfo.Irq =3D 0; + gSpcrInfo.GlobalSystemInterrupt =3D (UINT32)Irq; =20 gSpcrInfo.PciDeviceId =3D DeviceId; gSpcrInfo.PciVendorId =3D VendorId; @@ -332,6 +334,7 @@ GetPciTypeInfo ( gSpcrInfo.PciDeviceNumber =3D (UINT8) Device; gSpcrInfo.PciFunctionNumber =3D (UINT8) Function; gSpcrInfo.PciSegment =3D (UINT8) SegNum; + gSpcrInfo.PciFlags =3D 1; =20 Done: if (Resources !=3D NULL) { --=20 2.29.2.windows.3 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82732): https://edk2.groups.io/g/devel/message/82732 Mute This Topic: https://groups.io/mt/86622293/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-