From nobody Fri May 3 14:53:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82412+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82412+1787277+3901457@groups.io; dmarc=pass(p=none dis=none) header.from=groups.io ARC-Seal: i=1; a=rsa-sha256; t=1634707284; cv=none; d=zohomail.com; s=zohoarc; b=DGARMtlIXE8T/Xpt+L+rTCXNyabSPKyIaemC7BZImSAUge+/KvAY4cPyzqvbGXlEzqpRMfSLd1DBeR2nixa/4YAOaoPSS2L+q1PTEO3MowPkrZu7GxyfzPCJ4HVk0U+YcGtTyrSQOm3bBfHjXzmbaiTMR04PicTV9ziCDdyZnmY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634707284; h=Content-Type:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=RMD/EGw/Ab8uQ8XJjcAddcapaVe7p9ZiZMyxrLV6NJc=; b=jW4BI73ZX6wRiCGLsMRlogIdLliRDDjlJVIvyLElV5/A56D1+L20LNsrNn8Zlu4XVi0Oas/N+SmSOpympM+YbvIhHicm1B9zLphDJ6FGVcqxSe7UX8q27HLzSgHNBJsnLLvJZeHEYXd8mWMQMAtTKaGRRyqxs5JEWUL3biZT8OE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82412+1787277+3901457@groups.io; dmarc=pass header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1634707284262502.97164661420084; Tue, 19 Oct 2021 22:21:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sEMPYY1788612xcNTN4cUMfr; Tue, 19 Oct 2021 22:21:23 -0700 X-Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by mx.groups.io with SMTP id smtpd.web09.3927.1634707283065267307 for ; Tue, 19 Oct 2021 22:21:23 -0700 X-Received: by mail-yb1-f202.google.com with SMTP id y16-20020a2586d0000000b005b752db8f97so28636064ybm.18 for ; Tue, 19 Oct 2021 22:21:22 -0700 (PDT) X-Gm-Message-State: qE0lBqlb0wZMbXTlmpihuGamx1787277AA= X-Google-Smtp-Source: ABdhPJxpAgM5vwMZeIfk0d7c3AKUOckusNYMA9IIC/+VRchPJApFw3BhfCfkrSx6qWAwVkVQa8YdFBbQf1Uu X-Received: from morats.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:6c]) (user=moritzf job=sendgmr) by 2002:a25:dac5:: with SMTP id n188mr41245008ybf.85.1634707281746; Tue, 19 Oct 2021 22:21:21 -0700 (PDT) Date: Tue, 19 Oct 2021 22:21:18 -0700 Message-Id: <20211020052118.1227640-1-moritzf@google.com> Mime-Version: 1.0 Subject: [edk2-devel] [PATCH] DynamicTablesPkg: Fix unitialized variable use From: "Moritz Fischer via groups.io" To: devel@edk2.groups.io Cc: Sami Mujawar , Alexei Fedorov Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,moritzf@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634707283; bh=OKpS5EV7BqOnfRmQEluzUZfgugQJ4Z9dcgnGRXnJEWc=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=IJpD7XXhAPkxygqzQjzhSug/OCX6fQcx4T9mCH+ImAa0VwpJvGsiSRSYkxnQK0Pvp2i KZ7rUzQ8QkD5+URLCaJW4oWzml4jEEuF7jVcXidFr2dnmARJVxJ7i1pChIcCV8idyvTsG abc0eN+t7MH0yMwhaQeW40j5ajoLvAsyKkc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634707286078100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the success case we should return EFI_SUCCESS rather than returning a potentially unitialized value of Status. Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Moritz Fischer Reviewed-by: Sami Mujawar --- .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 0bdb6c24c5bb..e9e1a85ede63 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -91,7 +91,7 @@ LinkRdNode ( *NewRdNode =3D RdNode; } =20 - return Status; + return EFI_SUCCESS; =20 error_handler: Status1 =3D AmlDeleteTree ((AML_NODE_HEADER*)RdNode); --=20 2.33.0.1079.g6e70778dc9-goog -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82412): https://edk2.groups.io/g/devel/message/82412 Mute This Topic: https://groups.io/mt/86458612/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-