From nobody Sat Feb 7 08:22:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82276+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82276+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1634615440112808.4133236780706; Mon, 18 Oct 2021 20:50:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id JDE9YY1788612xMVzym74h5P; Mon, 18 Oct 2021 20:50:39 -0700 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.5101.1634615430759354911 for ; Mon, 18 Oct 2021 20:50:38 -0700 X-Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19IMalUH016922; Tue, 19 Oct 2021 03:50:30 GMT X-Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0a-002e3701.pphosted.com with ESMTP id 3bs9b3nn0s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Oct 2021 03:50:30 +0000 X-Received: from G9W8456.americas.hpqcorp.net (g9w8456.houston.hp.com [16.216.161.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 7CB4E60; Tue, 19 Oct 2021 03:50:29 +0000 (UTC) X-Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 19 Oct 2021 03:50:29 +0000 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (15.241.52.10) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Tue, 19 Oct 2021 03:50:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/LCHqR8uJunfc92j+rh3iNuaYZeaTcnc4Y6dTBIAKdXLFrxHRVHoO8pysK6INveGriuxNEf4Nf6d28Z+mL0ZtcfFNHMpqqdcvRi5C7Z4fd8BwFF/B8hcm6nUFoHMltnRVoda719NL5iu2yp+efCgtA6yH9VgJSHHEsmMPTlZCUvLK5pYnQfRUFIemi/oWDwato8asyWWx1fX3RafUhpoleJ19xifMD+bNlfP3zro9J0887tpNGLYoA6eZOpplfLyhLFrn4OnD+z50RZIjarsYHGEwQAkoXJd+CMI9DiV9zCfs3M8KzF8IDDMgxmF0sybQ15SnXYA11HI2XEQw7T4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZm+/B/f2q7utnL28ANRxq99AlPK7r3fIDXr73uAlwU=; b=Te+cWskvzyN1fdA172mUuZbkxyEtTRUbsP1mccu34bAFgoZ9toziVBCtccwUTn3GorAKn7fCbfDbJvc+Kw5EDvIXRhFwDu7jeflcWb54FhxzDl1m/LieCjfdCBOPXmefX3HDKPRL9jtWDzHHm8U5N+nl40qK2jhVUHDMaKN8aMsrAfuTY/ZZaBg3HYs9ivL8zndHD2MH0PyobKKfgx6ds6V4y34mT4ifGF9/3acaE7AV4tDR7aQgISvcmrypbhuoN4H4VsjLVcmBGyziZT1QlQLrl29plqoM9iTDr1rXeJru/5xOB7UFZFha6hApYgbL295EelXOttgTog6zQ5FXPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) by DF4PR8401MB0921.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct 2021 03:50:28 +0000 X-Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469]) by DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469%3]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 03:50:28 +0000 From: "Daniel Schaefer" To: CC: Daniel Schaefer , Abner Chang , Sunil V L Subject: [edk2-devel] [edk2-platforms] [PATCH v3 08/14] RISC-V/PlatformPkg: Build DeviceTree and use that in SEC Date: Tue, 19 Oct 2021 11:48:43 +0800 Message-ID: <20211019034849.16847-9-daniel.schaefer@hpe.com> In-Reply-To: <20211019034849.16847-1-daniel.schaefer@hpe.com> References: <20211019034849.16847-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: SG2PR03CA0134.apcprd03.prod.outlook.com (2603:1096:4:c8::7) To DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) MIME-Version: 1.0 X-Received: from zbook-nix.wireless.hpe.com (15.211.146.34) by SG2PR03CA0134.apcprd03.prod.outlook.com (2603:1096:4:c8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.11 via Frontend Transport; Tue, 19 Oct 2021 03:50:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23f77ec7-2caa-44dc-d2b8-08d992b396da X-MS-TrafficTypeDiagnostic: DF4PR8401MB0921: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: OfNojmlf1fARB/9dbyWo57wPwTf/Xm6IzNxvNXU2S4hww5U8eAF/Y+pqNrHywx4pbk8dGOKsQsR7a/aIJpx+o2tc9n127VOQigJgMGD7a1jmN0j8QN8gC9wasmXFx6rv6BU8CaJdQeGqCVJQ1df41hqpQQsQIwMwge0+phwIAs8zk3atahL+Gm+LfnwnHGsTHug+yKXVYCJJrhTxS3T5E1IYq3qPyOdm5kdkh+4W+VlqTVXk9P4egrV4m+YfB8mgzn7DLLYRESywkIIIf6Tlp9mMPNKQRwGpvH2Vei1awPEEiWPK5mkU7n61YSqsXEmvGRkMv7geQnWhBeZ2ChRD1c5BlPGNHPoFZKXJHHzFyUpeJCpH3fEctMvZjgzuYolziKWoTSmdYCl82Z+61n28Y2rlv+mKOyRwV/blymro8GxEtuLSEDENyjCeKw3IOY6uhQGkOPtBnF5L6LeIq0yRMi1P9pMPC3e5vkqahSjenH1OThOl3UEtoKhEXImWxzqu3VmEP4AX+d9sEH3NAugArnYHelUWTJQ3XNAlgSlbGXarzZyZj5+zNanW9b35PdouYXjECYoSvo/8/RbP/7/QfMZewXOxmwJjEZ1LmmottPneNxmz4RCtGeEf8M0vE+kyLZRB1tfMsUPaNXcRLhDKO5EunkUKAxljTtYDquhc15cZpoYh3HSKE/ad/P7GAsb+OL7D6ynn0QcTGyirsxlGBw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zq5zfoNZPwpUUqMJllUSvOBTKkblDHz+aEKFeJTMcAWgNgG4W1xpp0hqb0I+?= =?us-ascii?Q?p/Q+SIQl8TLJpIoVErhzldrLLfGXYBlZZKhmh4XFoBqezOwyyICsjvG6XI41?= =?us-ascii?Q?LCCReSOXAFSVx1G1Oax0x2YiBvvTlBI9n0xZq9HPLIbC4ITT7my+Q11++Y+h?= =?us-ascii?Q?8rd7YFg58BTveMTNh2gk0N+kr1M9aQY4nnwaS7kXhEioC0aUmq6jGRRFBbyv?= =?us-ascii?Q?iWqhLEC0aYTOYzjwXoLuXWSgsrugyDyTULixHDv+kU74pj8EL25FGhO+PakC?= =?us-ascii?Q?2T2CsKrJRdbOU8RqRNLyezbphIKmPd0ALd4Hc5UqtxHI+FMcF5vvpb7WHfXX?= =?us-ascii?Q?XYA73TfC3K5l8fQCv8WjXcLIc2927LNkfs8IIn8MfbrWRoZBm+QTNGTE7WsF?= =?us-ascii?Q?be3sGsOduWfhmSm+HudKmpaQfxF3KQ1IJxy+9RCjutMImytzAizc3jhydXEE?= =?us-ascii?Q?I0Tqokgd6bYSgxLPvK/P+wbr1s0h94PKZ7Km+1cqOMrpb7RH2pLHb5PX44Ts?= =?us-ascii?Q?sEIRfHBw0dKUz6jQ2RtbGeLu1HmwpNJ3X1ioxl6lEvA3ae8FN11oHaA54BqL?= =?us-ascii?Q?agyBh4z23j65gBeZ5j31iywFOBH2FXG/KTFHzOj6LSAvbLZ4BfC4CqDUs/v5?= =?us-ascii?Q?653KH2xQ5Psrj8UKBNx8CcSFLeXtWsz0ZXD41G+6XqxFQBLGRmQ4np6HhpbJ?= =?us-ascii?Q?RiMZhZtiVJvekU7veGJxjUEphVhBJYUIE6gd2rz4REzhx4OBkTY7KEoce30F?= =?us-ascii?Q?Y5aU2wwbnPWuzEZELaH8yvwzmwXRZvsiZ31k4v3pBCmYrr4m86UjAWq6iyaR?= =?us-ascii?Q?RSUNT7MYqbG6stt3tDaOc4qw/opp8zFGZBkd8oZH7TxVzKeldsatLtIyM06w?= =?us-ascii?Q?SbDD54rt1GaJ8IwGg+jPUFKCKpS3vaqHZT2pNG6EnuuFdElX8kCozVPCAqQU?= =?us-ascii?Q?+7a/Vp892ekYMf3djDMlKcjLKS3BTfrRajC99zR0r3X3Sq5Mx6i5m8+o9ULl?= =?us-ascii?Q?Hvr9KtZ1oIKRTGwPk3coB14gSYhoe6fZQqtEUnyVziGL2KhMZFFyQKkujP6P?= =?us-ascii?Q?s+3ynOrnS8hyk/vQmxUvq+horFnIhmYE1afU1xg6ZrbtDvberFyHPmXQdjiG?= =?us-ascii?Q?gG5q5zC869R2v0zeOM5BmdvmTFAie1g0ckojomQ9p08AiTwcUapIMrFTqyJH?= =?us-ascii?Q?mx3HI8SedvMW6CxtFZEgUnGW92wqwb1TkaMoNfRUQINCB1DSSWiZa2cjxwBB?= =?us-ascii?Q?MKvv7b7DreBJFKybXidIcYjdqhy2DD/80CumHsPtWlagmuwMs9+dhh+bdHhr?= =?us-ascii?Q?pj7KFIX4YZPyET7BnxIoXXfa?= X-MS-Exchange-CrossTenant-Network-Message-Id: 23f77ec7-2caa-44dc-d2b8-08d992b396da X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 03:50:27.9239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oTUvRtUit2G5WYbUm+FT0tekFbtzNnXZPeGfzKeAXavxbTTID7fZMlrpYXqfxGqFYqfumzJZp2//gLDDPJkP3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0921 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: RmLcbrlt1ULwx6ocvBNWMzq5lTz4R9RL X-Proofpoint-ORIG-GUID: RmLcbrlt1ULwx6ocvBNWMzq5lTz4R9RL X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: LkZnmraueek4tzDb1AlATp5rx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634615439; bh=EAJiSAJlcB2RxrmyewohNCyjqHc3vLADJqEEj4pb7Oo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=TOZOj8A6jkgaAxfG1KcBkYboL4XAe39M1nIW4ExH6y8J+gxiPV3/0vfnI+zA5D0xkPY 1bwOPFKOHBbuIbhNPtCX3hCNqRiqEEU8sEtMrpYq8XqHOOnBNk7oz/HieXzI9DoSf+5iv ibr2ElQvhZox1UwzxQqXO3e1BejsFH1o+XE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634615440915100002 Content-Type: text/plain; charset="utf-8" OpenSBI uses the device tree for platform specific initialization, so we need to have it already in SEC. Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec | 4 ++ Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.inf | 2 + Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h | 1 + Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c | 49 += +++++++++++++++++++ Platform/RISC-V/PlatformPkg/Universal/Sec/Riscv64/SecEntry.S | 22 -= -------- 5 files changed, 56 insertions(+), 22 deletions(-) diff --git a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec b/Platform/RI= SC-V/PlatformPkg/RiscVPlatformPkg.dec index 48aeb97431d7..ad15a155fe31 100644 --- a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec +++ b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec @@ -31,6 +31,8 @@ gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVPeiFvSize|0x0|UINT32|0x00001= 003 gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVDxeFvBase|0x0|UINT32|0x00001= 004 gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVDxeFvSize|0x0|UINT32|0x00001= 005 + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVDtbFvBase|0x0|UINT32|0x00001= 016 + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVDtbFvSize|0x0|UINT32|0x00001= 017 =20 # # Definition of EFI Variable region @@ -66,6 +68,8 @@ gUefiRiscVPlatformPkgTokenSpaceGuid.PcdTemporaryRamSize|0|UINT32|0x00001= 104 gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPeiCorePrivilegeMode|0|UINT32|0x0= 0001105 =20 + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdDeviceTreeAddress|0|UINT32|0x0000= 1106 + [PcdsPatchableInModule] =20 [PcdsFeatureFlag] diff --git a/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.inf b/Platfo= rm/RISC-V/PlatformPkg/Universal/Sec/SecMain.inf index 89bcb039a6ab..78bd75e3ac11 100644 --- a/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.inf +++ b/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.inf @@ -57,6 +57,8 @@ [FixedPcd] gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVPeiFvBase gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVPeiFvSize + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVDtbFvBase + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdDeviceTreeAddress =20 [Pcd] gUefiRiscVPlatformPkgTokenSpaceGuid.PcdBootHartId diff --git a/Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpen= sbi.h b/Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h index 2dab696af84d..e7ac6d26ee85 100644 --- a/Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h +++ b/Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h @@ -47,6 +47,7 @@ typedef struct { =20 typedef struct { VOID *PeiServiceTable; // PEI Service table + UINT64 FlattenedDeviceTree; // Pointer to Flattened Device t= ree EFI_RISCV_FIRMWARE_CONTEXT_HART_SPECIFIC *HartSpecific[RISC_V_MAX_HART_= SUPPORTED]; } EFI_RISCV_OPENSBI_FIRMWARE_CONTEXT; =20 diff --git a/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c b/Platform= /RISC-V/PlatformPkg/Universal/Sec/SecMain.c index fa9ecd789a57..0af0b4bac831 100644 --- a/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c +++ b/Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c @@ -557,6 +557,12 @@ VOID EFIAPI PeiCore ( &FirmwareContext )); ThisSbiPlatform->firmware_context =3D (unsigned long)&FirmwareContext; + + // + // Save Flattened Device tree in firmware context + // + FirmwareContext.FlattenedDeviceTree =3D FuncArg1; + // // Set firmware context Hart-specific pointer // @@ -647,6 +653,42 @@ RiscVOpenSbiHartSwitchMode ( sbi_hart_switch_mode(FuncArg0, FuncArg1, NextAddr, NextMode, NextVirt); } =20 +/** + Get device tree address + + @retval The address of Device Tree binary. +**/ +VOID * +EFIAPI +GetDeviceTreeAddress ( + VOID + ) +{ + EFI_STATUS Status; + EFI_COMMON_SECTION_HEADER *FoundSection; + + if (FixedPcdGet32 (PcdDeviceTreeAddress)) { + return (VOID *)*((unsigned long *)FixedPcdGet32 (PcdDeviceTreeAddres= s)); + } else if (FixedPcdGet32 (PcdRiscVDtbFvBase)) { + Status =3D FindFfsFileAndSection ( + (EFI_FIRMWARE_VOLUME_HEADER *)FixedPcdGet32 (PcdRiscVDtbF= vBase), + EFI_FV_FILETYPE_FREEFORM, + EFI_SECTION_RAW, + &FoundSection + ); + if (EFI_ERROR(Status)) { + DEBUG ((DEBUG_ERROR, "Platform Device Tree is not found from FV.\n= ")); + return NULL; + } + FoundSection ++; + return (VOID *)FoundSection; + } else { + DEBUG ((DEBUG_ERROR, "Must use DTB either from memory or compiled in= FW. PCDs configured incorrectly.\n")); + ASSERT (FALSE); + } + return NULL; +} + /** This function initilizes hart specific information and SBI. For the boot hart, it boots system through PEI core and initial SBI in t= he DXE IPL. @@ -686,6 +728,13 @@ VOID EFIAPI SecCoreStartUpWithStack( UINT64 NonBootHartMessageLockValue; EFI_RISCV_FIRMWARE_CONTEXT_HART_SPECIFIC *HartFirmwareContext; =20 + Scratch->next_arg1 =3D (unsigned long)GetDeviceTreeAddress (); + if (Scratch->next_arg1 =3D=3D (unsigned long)NULL) { + DEBUG ((DEBUG_ERROR, "Platform Device Tree is not found\n")); + ASSERT (FALSE); + } + DEBUG ((DEBUG_INFO, "DTB address: 0x%08x\n", Scratch->next_arg1)); + // // Setup EFI_RISCV_FIRMWARE_CONTEXT_HART_SPECIFIC for each hart. // diff --git a/Platform/RISC-V/PlatformPkg/Universal/Sec/Riscv64/SecEntry.S b= /Platform/RISC-V/PlatformPkg/Universal/Sec/Riscv64/SecEntry.S index 8434d1a4e0e9..0e3940180d44 100644 --- a/Platform/RISC-V/PlatformPkg/Universal/Sec/Riscv64/SecEntry.S +++ b/Platform/RISC-V/PlatformPkg/Universal/Sec/Riscv64/SecEntry.S @@ -75,11 +75,6 @@ _scratch_init: sd a4, SBI_SCRATCH_FW_START_OFFSET(tp) sd a5, SBI_SCRATCH_FW_SIZE_OFFSET(tp) =20 - /* - * Note: fw_next_arg1() uses a0, a1, and ra - */ - call fw_next_arg1 - sd a0, SBI_SCRATCH_NEXT_ARG1_OFFSET(tp) /* Save agr1 in scratch buffe= r*/ /* Note: fw_next_addr()uses a0, a1, and ra */ @@ -500,23 +495,6 @@ _reset_regs: csrw CSR_MSCRATCH, 0 ret =20 - .align 3 - .section .entry, "ax", %progbits - .global fw_prev_arg1 -fw_prev_arg1: - - /* We return previous arg1 in 'a0' */ - add a0, zero, zero - ret - - .align 3 - .section .entry, "ax", %progbits - .global fw_next_arg1 -fw_next_arg1: - /* We return next arg1 in 'a0' */ - li a0, FixedPcdGet32(PcdRiscVPeiFvBase) - ret - .align 3 .section .entry, "ax", %progbits .global fw_next_addr --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82276): https://edk2.groups.io/g/devel/message/82276 Mute This Topic: https://groups.io/mt/86432326/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-