From nobody Tue May 7 17:21:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82057+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82057+1787277+3901457@groups.io; dmarc=pass(p=none dis=none) header.from=groups.io ARC-Seal: i=1; a=rsa-sha256; t=1634250598; cv=none; d=zohomail.com; s=zohoarc; b=CuHJkaxW8ER2GeTPXvyXsW95+ayCyekJc9Vp1LZCyPfUPkkd12FyDR2zFfYAKzOqWoow10wXkkuVsvX+isVm6Oebt/cLyA8ausiBvEdKYHLAlowMfok78MkfQgzuSG3/I0QWXHZPbhtj7fb7b0a/APT2kVx1MSclkmYDXc3/xnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634250598; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=94UdPLxqq1r8sAnAUmcG79n4lSwM9fDaKcmLHYUaZNY=; b=T69y8kJJnFNvQVuCeeQniB2EklI+rcursYcFlHyXfALrrH1ZYPzSNpFa15arx64EEyVXb5HnTBBRPnxG9m2l5BO4gyYdVBpJnaTUIg4Ft9GszOMXDJ5wu9u7o228Jj4B5TsN6ZeChqbapDr8JN7orF/FPdjBPf6RNq0QsZ39W9s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82057+1787277+3901457@groups.io; dmarc=pass header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 163425059815894.27969409033301; Thu, 14 Oct 2021 15:29:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 95DhYY1788612xcYPUteHRtB; Thu, 14 Oct 2021 15:29:57 -0700 X-Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web09.2015.1634250596594490085 for ; Thu, 14 Oct 2021 15:29:56 -0700 X-AuditID: ac1060b2-d15ff700000017be-9b-6168af63ee2c X-Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id FE.68.06078.36FA8616; Thu, 14 Oct 2021 18:29:55 -0400 (EDT) X-Received: from MANIC-WIN10.us.megatrends.com (172.16.98.169) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.498.0; Thu, 14 Oct 2021 18:29:54 -0400 From: "manickavasakam karpagavinayagam via groups.io" To: CC: , , , , , , Subject: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Date: Thu, 14 Oct 2021 18:29:52 -0400 Message-ID: <20211014222952.1651-1-manickavasakamk@ami.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsWyRiBhgm7y+oxEg4NLpSzaJ8xms+hfcYzV 4vivD8wOzB7bv19g9Fi85yVTAFNUA6NNYl5efkliSapCSmpxsq1SQFFmWWJypZJCZoqtkqGS QkFOYnJqbmpeia1SYkFBal6Kkh2XAgawASrLzFNIzUvOT8nMS7dV8gz217WwMLXUNVSyC8lI VcjMS8svyk0syczPU0jOzysBqk5NAYoqJHRzZry4fpCx4DN3RdfKEywNjOc5uxg5OSQETCTO vupgAbGFBHYxSSw+Gd3FyAVkb2OU+PJ9DxNIgk3AXmL71NnsILaIgJTElAMzmUCKmAXWMUos fNEGViQskCMx4fULoCIODhYBVYm1izlBTF4Ba4m9R2QhdmlKXJ15jQ3E5hUQlDg58wnYXmYB bYllC18zQ9gSEgdfvGAGaRUSUJF4csxhAiPfLCQds5B0zELSsYCReRWjUGJJTm5iZk56uaFe Ym6mXnJ+7iZGSFxt2sHYctH8ECMTB+MhRgkOZiUR3ncH0hOFeFMSK6tSi/Lji0pzUosPMToB XT+RWYobFHzA+Ig3NjCQEoVxDE3MTMyNzA0tTcyNjZXEeVe5H40XEkgHxmt2ampBahHMECYO TqkGxpNeqp4V6dOlV5Sb3V17fr+LQYC3go2lwyqf35syc3oOC9/ZVa2lsq6KoSy987WQucf9 5lZ+U6cMPwWtSq4f6/ZZbmX7tLqSTchwbnXItu+NByx1L2yNzL/U2MK+PCah1mrBWuY1P0QZ vjpemNRYrZ7e+5/hu0j0jTpHxl2PtT2iAh4rnH+txFKckWioxVxUnAgA6kdGMcACAAA= Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,manickavasakamk@ami.com X-Gm-Message-State: 3Q06NUOUPO6tkFomc0VILL2ax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634250597; bh=5wewf2xP0bTP133uMtJBnG4/gwq84vErYyjCplAbjt8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=rBGU/ydsTIyDSGrVtGpIkprwKp+cihpp8sJjfjpvajX8Fdw9p9zlDPNAWzPUQYWyqKY AtnLhDhJQgCVkOrB70zTuQBGY4e2Cy6/MtLNhFFnu2pMEQUk0DCyRrRuV2ClVVx6xGDXk IG+bjAfHvae7EHixtvNEGD2oZtidKrAbvYU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634250599775100002 Content-Type: text/plain; charset="utf-8" Fix to resolve the OS boot issue when booting on WilsonCitySMT board. ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code= and not with TRUE or FALSE. Replaced ASSERT_EFI_ERROR with ASSERT. Signed-off-by: Manickavasakam Karpagavinayagam Reviewed-by: Isaac Oram Reviewed-by: Nate DeSimone --- Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | 12 += ++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInit= Dxe.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c index d8274fa7ad..212103f483 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry ( ASSERT_EFI_ERROR (Status); break; =20 + case TypeWilsonCitySMT: + Status =3D gBS->InstallProtocolInterface( + &Handle, + &gEfiPlatformTypeWilsonCitySMTProtocolGuid, + EFI_NATIVE_INTERFACE, + NULL + ); + ASSERT_EFI_ERROR(Status); + break; + case TypeCooperCityRP: Status =3D gBS->InstallProtocolInterface ( &Handle, @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry ( =20 default: // CAN'T GO TO HERE. - ASSERT_EFI_ERROR (FALSE); + ASSERT (FALSE); } =20 return Status; -- 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82057): https://edk2.groups.io/g/devel/message/82057 Mute This Topic: https://groups.io/mt/86326587/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-