From nobody Tue Feb 10 14:32:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+81695+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81695+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1633704410; cv=none; d=zohomail.com; s=zohoarc; b=e5eWqoyoagKJwb96kiXZ80Ho59HhNI04Af2izN+T/qX9rBVtuFjAR+UnCon5SK0B6T61bPVIb6zXqbDfgQ0Ocm+UxGD95z6Kv3tzkMMI3Td1qYsw46NCNLfxsdKwJcWcqTfXXH+LsJlCNybrV0tcft9d7TzcXqmlcbrnprDKYTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633704410; h=Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=AffKYW/bbO8bNeeNY3P5/5fDuhDFzGcnncemYnWVJCE=; b=FZcoddju12jaLhGWCN1fRrs9WMiKgKwniCpp6ow0OmvnaSo4kM54XP+UXZzFiD9liLZRCKbJAWPKequ/OOA4HjL0vbxaoiJTKJ1QfNS9XOyjxBGQDgKK4oxvQYoKK8vuyoDzyHWdmu0t6mq2ARuVf/sCq6/ZPk55tsC0kkSKuZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81695+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 163370440984261.14551138114791; Fri, 8 Oct 2021 07:46:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id nLBbYY1788612x88T15ACdA4; Fri, 08 Oct 2021 07:46:49 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.10571.1633704405766240838 for ; Fri, 08 Oct 2021 07:46:49 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A95D1063; Fri, 8 Oct 2021 07:46:48 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.73.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2C5673F66F; Fri, 8 Oct 2021 07:46:46 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, Sami Mujawar , Alexei.Fedorov@arm.com Subject: [edk2-devel] [PATCH v3 08/21] DynamicTablesPkg: Update error handling for node creation Date: Fri, 8 Oct 2021 15:46:19 +0100 Message-Id: <20211008144632.31894-9-Pierre.Gondois@arm.com> In-Reply-To: <20211008144632.31894-1-Pierre.Gondois@arm.com> References: <20211008144632.31894-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: trTnq6BfRN4Qu5yWgqpb26fvx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1633704409; bh=wmJHPoBmKyE4yp3/YDm0okUjAg27FEsZeb9XWbOkqaA=; h=Date:From:Reply-To:Subject:To; b=AdSCxM2uUBGjHJTBRgRieyIKfm0yjc8+uVoSHfXZeMfiQEFgRbISht0z3JV1JSKO2P0 PCBx4SXkDzfZ1am9k57ubiUCjiinCkmeUp1bps1tTjql+H2fResl942Oazl/x5nodN/u2 3cv3dYi3Clka/qizCr4neCwXRTMSRbaKDDs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1633704410766100014 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The node creation functions: - AmlCreateRootNode() - AmlCreateObjectNode() - AmlCreateDataNode() are now resetting the input pointer where the created node is stored. Thus, it is not necessary to set some local variables to NULL or check a node value before trying to delete it. Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 6 +----- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlClone.c | 2 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index 4775b68cd974..cbfd9cbb68b6 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -148,7 +148,6 @@ AmlCodeGenString ( return EFI_INVALID_PARAMETER; } =20 - ObjectNode =3D NULL; DataNode =3D NULL; =20 Status =3D AmlCreateObjectNode ( @@ -187,10 +186,7 @@ AmlCodeGenString ( return Status; =20 error_handler: - if (ObjectNode !=3D NULL) { - AmlDeleteTree ((AML_NODE_HEADER*)ObjectNode); - } - + AmlDeleteTree ((AML_NODE_HEADER*)ObjectNode); return Status; } =20 diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlClone.c b/Dynam= icTablesPkg/Library/Common/AmlLib/Tree/AmlClone.c index e09372b039f1..7aafa957a8c4 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlClone.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlClone.c @@ -43,8 +43,6 @@ AmlCloneNode ( return EFI_INVALID_PARAMETER; } =20 - *ClonedNode =3D NULL; - if (IS_AML_DATA_NODE (Node)) { DataNode =3D (AML_DATA_NODE*)Node; Status =3D AmlCreateDataNode ( --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81695): https://edk2.groups.io/g/devel/message/81695 Mute This Topic: https://groups.io/mt/86172101/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-