From nobody Tue Feb 10 04:08:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+81593+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81593+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1633620777; cv=none; d=zohomail.com; s=zohoarc; b=AN79x1vF5M+X20KgByDBN9qVHeeDVX6sif/22WkGlXZ2XR1eV2tCZnGoll6kzjsA4RsZdl9Uvl4J9BUPcCliIDdnaGFJpqDSlkPRgqRdhNVWuNYzcZMNOpnZE1DKA5/1buI4yF2Kz9Cy4DprUfjd0eNgu1IOHz9/tXhKjrOLmUk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633620777; h=Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=UKMw67vig0CyJnp1J8ApvP0zO4VPMPrt+7mrNJuJKc4=; b=YlCuW0Kdd10Su5Drzv5XTjUbXVFl5vOBJHLi55ATt0wOvrN3HHYWOGtwNd0zKilUmO06iJDNpElDrNo7niLcBEoq9S7gmTLMgXTupZs/xM+K1PUH1MoLl/pDAANDGvlgyJZvvLIg56nSN40Zv1B9tIwmtkefaqr1EDQPdzL+TDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81593+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1633620777640909.2219800216347; Thu, 7 Oct 2021 08:32:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Ijb2YY1788612xGvDtH2fqVA; Thu, 07 Oct 2021 08:32:57 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.13549.1633620774286143033 for ; Thu, 07 Oct 2021 08:32:54 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 040F4ED1; Thu, 7 Oct 2021 08:32:54 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.72.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EE3253F66F; Thu, 7 Oct 2021 08:32:52 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, Sami Mujawar , Alexei.Fedorov@arm.com Subject: [edk2-devel] [PATCH v2 12/21] DynamicTablesPkg: AML code generation for a Package Date: Thu, 7 Oct 2021 16:32:01 +0100 Message-Id: <20211007153210.26608-13-Pierre.Gondois@arm.com> In-Reply-To: <20211007153210.26608-1-Pierre.Gondois@arm.com> References: <20211007153210.26608-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: lfQIO0bC8viQLk0U6jyhfvgQx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1633620777; bh=IsniY8QzQjvQtij+VlOhP32vUN9OJy46mPHvYuP/ghU=; h=Date:From:Reply-To:Subject:To; b=BJNP78d2JjOOTpZIXbIs34pCItoH2skrL+JfecLWeRLDv3OlS7ep/IVnMAnrReUlknZ FswrGeoKD50nxZ6CBLxiKc0l4ayRRD1ILSD+jjslgTaZLcZQSoPA+jxwToBc1VxvXeYz1 4cH628++TTMt0qDK2+LzI2YBEUgMqjb7VXk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1633620780210100025 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Add AmlCodeGenPackage() to generate AML code for declaring a Package() object. This function generates an empty package node. New elements can then be added to the package's variable argument list. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Common/AmlLib/CodeGen/AmlCodeGen.c | 81 ++++++++++++++++++- 1 file changed, 80 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index cbfd9cbb68b6..a4cd2502dc56 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -1,7 +1,7 @@ /** @file AML Code Generation. =20 - Copyright (c) 2020, Arm Limited. All rights reserved.
+ Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -237,6 +237,85 @@ AmlCodeGenInteger ( return Status; } =20 +/** AML code generation for a Package object node. + + The package generated is empty. New elements can be added via its + list of variable arguments. + + @param [out] NewObjectNode If success, contains the created + Package object node. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. +**/ +STATIC +EFI_STATUS +EFIAPI +AmlCodeGenPackage ( + OUT AML_OBJECT_NODE ** NewObjectNode + ) +{ + EFI_STATUS Status; + AML_DATA_NODE * DataNode; + UINT8 NodeCount; + + if (NewObjectNode =3D=3D NULL) { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + NodeCount =3D 0; + + // Create an object node. + // PkgLen is 2: + // - one byte to store the PkgLength + // - one byte for the NumElements. + // Cf ACPI6.3, s20.2.5 "Term Objects Encoding" + // DefPackage :=3D PackageOp PkgLength NumElements PackageElementList + // NumElements :=3D ByteData + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_PACKAGE_OP, 0), + 2, + NewObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + return Status; + } + + // NumElements is a ByteData. + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeUInt, + &NodeCount, + sizeof (NodeCount), + &DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + goto error_handler; + } + + Status =3D AmlSetFixedArgument ( + *NewObjectNode, + EAmlParseIndexTerm0, + (AML_NODE_HEADER*)DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + goto error_handler; + } + + return Status; + +error_handler: + AmlDeleteTree ((AML_NODE_HEADER*)*NewObjectNode); + if (DataNode !=3D NULL) { + AmlDeleteTree ((AML_NODE_HEADER*)DataNode); + } + return Status; +} + /** AML code generation for a Name object node. =20 @param [in] NameString The new variable name. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81593): https://edk2.groups.io/g/devel/message/81593 Mute This Topic: https://groups.io/mt/86148204/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-