From nobody Tue Feb 10 06:27:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+81023+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81023+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1632387555; cv=none; d=zohomail.com; s=zohoarc; b=ToETMTOynWGe8iW4QlxFPyZBADwTe71KRUyVJeKKBQ8uCxusizFzcCUVdcgitZqz1Y+Vmd5K5ecERbBhNa2Eaubvrw4GN1zAj3VVg0ReMlHeMlJLAQwdgwRotb+RmrOw/MlYijR2DSdrbGOZcfuk105ALfy6gaT3ZCNBMfydIaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632387555; h=Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=L4KGn7Yvb3JoEYoe+nbfquQ4MiYNH6EajiHPunI4a+s=; b=QZP7N5qBN8f43fhxLZjJrYlWKSLWl2WysyV1irxbpC8R7K9s4CqaGTmaMqhtpW71GmZVrWKS3yHTI3pvr6/yCWJ51REOUU71mDY/4C92a/D0Fku4ndRGFWq+/wdFKEGHbtwUEmqcH4aHav1hh59QQxHkYHFFoJSY2iOg4+EhvNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81023+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1632387555008538.1062505108013; Thu, 23 Sep 2021 01:59:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xTNcYY1788612xKWcOaspZnk; Thu, 23 Sep 2021 01:59:14 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.1966.1632387554027835248 for ; Thu, 23 Sep 2021 01:59:14 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9663312FC; Thu, 23 Sep 2021 01:59:13 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.87.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5B59B3F59C; Thu, 23 Sep 2021 01:59:12 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, Bob Feng , Liming Gao , Sami Mujawar Subject: [edk2-devel] [PATCH v1 3/4] BaseTools: Remove Makefile/MakefileName fields Date: Thu, 23 Sep 2021 09:59:02 +0100 Message-Id: <20210923085903.15966-4-Pierre.Gondois@arm.com> In-Reply-To: <20210923085903.15966-1-Pierre.Gondois@arm.com> References: <20210923085903.15966-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: QnpyqTa3j3inJWQI8JYoqdy3x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1632387554; bh=kur5la/I76iI+qSUuGbFxSfO8HAHR7Y6Eyjl/Hbrcwc=; h=Date:From:Reply-To:Subject:To; b=da4mkxzVmBdlku2Bl8MbOfzeO4z5/BY4nvf5rf749jWFpyZ/tO5zIOtNLM++WTD9uL2 Y+jDghPlNmTCk06iHsuIH6QkzpWjWJNgQj3Y8GgF9Uy8orF+Le2KewuAUjoMZ+dYPE+7I O1UZKH/2axM1K3JbOIRQRJ9nVxvozxI1fkE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1632387556212100014 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The Makefile and MakefilName fields are never set/used. Remove them. To check this, the following commands can be used: - grep -rIn "\.Makefile" - grep -rIn "\.MakefileName" Signed-off-by: Pierre Gondois --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 1 - BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 -- BaseTools/Source/Python/build/build.py | 2 -- 3 files changed, 5 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/S= ource/Python/AutoGen/ModuleAutoGen.py index d70b0d7ae828..368a31047e82 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -254,7 +254,6 @@ class ModuleAutoGen(AutoGen): self.AutoGenDepSet =3D set() self.ReferenceModules =3D [] self.ConstPcd =3D {} - self.Makefile =3D None self.FileDependCache =3D {} =20 def __init_platform_info__(self): diff --git a/BaseTools/Source/Python/Workspace/BuildClassObject.py b/BaseTo= ols/Source/Python/Workspace/BuildClassObject.py index 88a1d1582cd8..ef873720f455 100644 --- a/BaseTools/Source/Python/Workspace/BuildClassObject.py +++ b/BaseTools/Source/Python/Workspace/BuildClassObject.py @@ -590,7 +590,6 @@ class PackageBuildClassObject(BuildData): # @var OutputDirectory: To store value for OutputDirectory # @var FlashDefinition: To store value for FlashDefinition # @var BuildNumber: To store value for BuildNumber -# @var MakefileName: To store value for MakefileName # @var SkuIds: To store value for SkuIds, it is a set structure= as # { 'SkuName' : SkuId, '!include' : includefilenam= e, ...} # @var Modules: To store value for Modules, it is a list structu= re as @@ -614,7 +613,6 @@ class PlatformBuildClassObject(BuildData): self.OutputDirectory =3D '' self.FlashDefinition =3D '' self.BuildNumber =3D '' - self.MakefileName =3D '' =20 self.SkuIds =3D {} self.Modules =3D [] diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index 58081361c38d..e4969d863f6e 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -2186,8 +2186,6 @@ class Build(): Pa.CreateLibModuelDirs() # Fetch the MakeFileName. self.MakeFileName =3D Pa.MakeFileName - if not self.MakeFileName: - self.MakeFileName =3D Pa.MakeFile =20 Pa.DataPipe.DataContainer =3D {"LibraryBuildDirectoryList":Pa.= LibraryBuildDirectoryList} Pa.DataPipe.DataContainer =3D {"ModuleBuildDirectoryList":Pa.M= oduleBuildDirectoryList} --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81023): https://edk2.groups.io/g/devel/message/81023 Mute This Topic: https://groups.io/mt/85809773/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-