From nobody Tue Feb 10 05:10:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+80617+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+80617+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1631572393; cv=none; d=zohomail.com; s=zohoarc; b=I4rjLKIdiOyPtlp0zU9JDdkdGbgfUYJdA4X8yHAQcLz3ij0Qyo9E6wLSNQ8DdAwEeK9DzevRb1WHpJBNfPt84uaf08hd/7Gpv1kS1+B45xaHG+6UjmoaRiwHrBT1B2FSHQ0/EE18zOKO0vvglFNZUucpUO4hFHfELAufDZBjnoc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631572393; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=yl0YvPx97VdC/2W3BYzNz8/q6+gsgQxGhBh1OL3ffjo=; b=LcwkZA+rNdFdUlqgUSWoWLTQPKebskSecUrb1dNunoySIQ3ZgXxQ6VjKtL01vz6uJ2p3JkB7RjNS3IEM5IQednjDsSZrcs3duQYNStoWmDdceumjdYYyr2peVSPW3vyfj6oUE8vCf8/xETheKcAJxDnp7NGNJZjfXL3byMeM4ZY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+80617+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1631572393634371.12358426272465; Mon, 13 Sep 2021 15:33:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KdrPYY1788612xW3Ifkg2HdU; Mon, 13 Sep 2021 15:33:13 -0700 X-Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web10.618.1631566650634063191 for ; Mon, 13 Sep 2021 13:57:31 -0700 X-Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18DIDmBQ032981; Mon, 13 Sep 2021 16:57:29 -0400 X-Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b232j9dtg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 16:57:28 -0400 X-Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18DKWq7n028117; Mon, 13 Sep 2021 16:57:28 -0400 X-Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b232j9dt4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 16:57:28 -0400 X-Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18DKvNGL029689; Mon, 13 Sep 2021 20:57:27 GMT X-Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma04wdc.us.ibm.com with ESMTP id 3b0m3ahq16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 20:57:27 +0000 X-Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18DKvReS43319658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 20:57:27 GMT X-Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0AADEAE063; Mon, 13 Sep 2021 20:57:27 +0000 (GMT) X-Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F09E9AE066; Mon, 13 Sep 2021 20:57:26 +0000 (GMT) X-Received: from sbct-2.pok.ibm.com (unknown [9.47.158.152]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 13 Sep 2021 20:57:26 +0000 (GMT) From: "Stefan Berger" To: devel@edk2.groups.io Cc: mhaeuser@posteo.de, spbrogan@outlook.com, marcandre.lureau@redhat.com, kraxel@redhat.com, jiewen.yao@intel.com, Stefan Berger , Stefan Berger Subject: [edk2-devel] [RFC PATCH v1 2/4] OvmfPkg: Handle TPM 2 physical presence codes much earlier Date: Mon, 13 Sep 2021 16:57:20 -0400 Message-Id: <20210913205722.2553473-3-stefanb@linux.vnet.ibm.com> In-Reply-To: <20210913205722.2553473-1-stefanb@linux.vnet.ibm.com> References: <20210913205722.2553473-1-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: H2uyp9bURFjDS9RRL8loL__augGqo9KR X-Proofpoint-ORIG-GUID: JJ-gyljy0oRmjj5fHkufj7yZgNbp0eUN Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,stefanb@linux.vnet.ibm.com X-Gm-Message-State: KRDXabH7A5Dj7tHQxVLm2DCVx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1631572393; bh=Z82DkQKZiuvu94NLpqroz/Zh+fbpfBVird1N96nKJfk=; h=Cc:Date:From:Reply-To:Subject:To; b=GjRSeA+o1q8+9cV/Sw2Rr7IYDhc0wfXJa//p2iUfiKI6FMLzuWHSBL4xtR/ERXK+onB RB27ZkSVqQnG8ZS2m6skGTI+nJTn7VdItXTad8RxPpvaIyl+wlBdnYjnR5tTfct6HDY7+ I1iikRcQtJ5GO/UFoPrc14D9S45lBdmjKzI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1631572395629100012 Content-Type: text/plain; charset="utf-8" Handle the TPM 2 physical presence interface (PPI) opcodes in PlatformBootManagerBeforeConsole() before the TPM 2 platform hierarchy is disabled. Since the handling of the PPI opcodes may require inter- action with the user, initialize the keyboard before handling PPI codes. Signed-off-by: Stefan Berger --- .../PlatformBootManagerLib/BdsPlatform.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg= /Library/PlatformBootManagerLib/BdsPlatform.c index 71f63b2448..5c1603ac19 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -387,8 +387,17 @@ PlatformBootManagerBeforeConsole ( SaveS3BootScript (); } =20 + PlatformInitializeConsole ( + XenDetected() ? gXenPlatformConsole : gPlatformConsole); + + // + // Process TPM PPI request; this may require keyboard input + // + Tcg2PhysicalPresenceLibProcessRequest (NULL); + // // Prevent further changes to LockBoxes or SMRAM. + // Any TPM 2 Physical Presence Interface opcode must be handled before. // Handle =3D NULL; Status =3D gBS->InstallProtocolInterface (&Handle, @@ -402,9 +411,6 @@ PlatformBootManagerBeforeConsole ( // EfiBootManagerDispatchDeferredImages (); =20 - PlatformInitializeConsole ( - XenDetected() ? gXenPlatformConsole : gPlatformConsole); - FrontPageTimeout =3D GetFrontPageTimeoutFromQemu (); PcdStatus =3D PcdSet16S (PcdPlatformBootTimeOut, FrontPageTimeout); ASSERT_RETURN_ERROR (PcdStatus); @@ -1511,11 +1517,6 @@ PlatformBootManagerAfterConsole ( // PciAcpiInitialization (); =20 - // - // Process TPM PPI request - // - Tcg2PhysicalPresenceLibProcessRequest (NULL); - // // Process QEMU's -kernel command line option // --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80617): https://edk2.groups.io/g/devel/message/80617 Mute This Topic: https://groups.io/mt/85588961/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-