From nobody Tue Feb 10 19:14:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+80614+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+80614+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1631572392; cv=none; d=zohomail.com; s=zohoarc; b=cPSzZs/KC5PoczycgZ+RFfcI7flFSiNM7MVicATlJVMFeLvIRkBQFd5ttFiBqBBsXDZHRyutR2lTOuppDTbEpmwH/C+xfWB5FWL7t0I9HrRQboWYKcmuV7otS5F1diVzsdL2DzgV5w72CGsZPzHmgELcPNBR0frv22mTJQxQjQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631572392; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=QGDMLwzpBk1lxC7d7p4pHIW47h1z+dKQt3PUGb2l3tU=; b=PYAU+x32eJOf4GDxsAxF20foSmxCtWkPolWv0ac00rQNzM5cVW6r42g1nNJTHy9KeaoZQzFJ7XBI39VgaP+fXmfKmkd9lRM6cWo+ExigjyYcuA2ZaNWKaVXFzD4jxyei+rmtxySwnhbJQ0U5KSKc44iMmRL0VKWPLpYzgQ3gas0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+80614+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1631572392175186.84407034104345; Mon, 13 Sep 2021 15:33:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id DlPiYY1788612xdvp6s5SwkT; Mon, 13 Sep 2021 15:33:11 -0700 X-Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web09.614.1631566650172454262 for ; Mon, 13 Sep 2021 13:57:30 -0700 X-Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18DI8ffk012955; Mon, 13 Sep 2021 16:57:29 -0400 X-Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b24fvptet-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 16:57:29 -0400 X-Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18DKv89h001123; Mon, 13 Sep 2021 16:57:28 -0400 X-Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b24fvpteg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 16:57:28 -0400 X-Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18DKpkRc030871; Mon, 13 Sep 2021 20:57:27 GMT X-Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma03dal.us.ibm.com with ESMTP id 3b0m3abu9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 20:57:27 +0000 X-Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18DKvRZE23658872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 20:57:27 GMT X-Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5BF9AE062; Mon, 13 Sep 2021 20:57:26 +0000 (GMT) X-Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D73B6AE067; Mon, 13 Sep 2021 20:57:26 +0000 (GMT) X-Received: from sbct-2.pok.ibm.com (unknown [9.47.158.152]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 13 Sep 2021 20:57:26 +0000 (GMT) From: "Stefan Berger" To: devel@edk2.groups.io Cc: mhaeuser@posteo.de, spbrogan@outlook.com, marcandre.lureau@redhat.com, kraxel@redhat.com, jiewen.yao@intel.com, Stefan Berger , Stefan Berger Subject: [edk2-devel] [RFC PATCH v1 1/4] OvmfPkg/TPM PPI: Connect default consoles for user interaction Date: Mon, 13 Sep 2021 16:57:19 -0400 Message-Id: <20210913205722.2553473-2-stefanb@linux.vnet.ibm.com> In-Reply-To: <20210913205722.2553473-1-stefanb@linux.vnet.ibm.com> References: <20210913205722.2553473-1-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: JfnfKSiLmGojunTo1FJzo_4qoALkwCCE X-Proofpoint-ORIG-GUID: 53pQlze9LbFWALBEtHOGORZUZyycOaZp Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,stefanb@linux.vnet.ibm.com X-Gm-Message-State: qxARSVVNTTdeJA5yyHO18VHdx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1631572391; bh=WcQtpLSuc6bpqVpgk+lIX6PzRjwCl1dVf9Ie9ubtfAc=; h=Cc:Date:From:Reply-To:Subject:To; b=bOSKmSCeP0mlYIsCfr54eUHO/A6RTYBPhdFj47zzXEF20B27yHeB7lF72cz0lKQ5kno IWDETpc0wZrXIB5tDUN8aiaJIZpdT6NuRars9E5s1+kN4FLVZ+jlIaHS9GyhvudwW8Khq Vh4Rp/GFVmFo9bXrzwgeZvXkIY0CFOeZ2X0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1631572393429100001 Content-Type: text/plain; charset="utf-8" Activate the default console when user interaction is required for the processing of TPM 2 physical presence interface opcodes. Background: TPM 2 physical presence interface (PPI) opcodes need to be handled before the TPM 2 platform hierarchy is disabled. Due to this requirement we will move the function call to handle the PPI opcodes into PlatformBootManagerBeforeConsole() which runs before the initialization of the consoles. However, since for interaction with the user we need the console to be available, activate it now before displaying any message to the user. Signed-off-by: Stefan Berger --- .../Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLib.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPre= senceLib.c b/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPre= senceLib.c index 00d76ba2c2..8834a71eff 100644 --- a/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLi= b.c +++ b/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLi= b.c @@ -32,6 +32,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include +#include =20 #include =20 @@ -591,6 +592,9 @@ Tcg2UserConfirm ( return FALSE; } =20 + // Console for user interaction + EfiBootManagerConnectAllDefaultConsoles (); + if (TpmPpCommand < TCG2_PHYSICAL_PRESENCE_STORAGE_MANAGEMENT_BEGIN) { if (CautionKey) { TmpStr1 =3D Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CAU= TION_KEY)); --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80614): https://edk2.groups.io/g/devel/message/80614 Mute This Topic: https://groups.io/mt/85588958/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-