From nobody Sat Apr 27 07:54:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79914+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79914+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1630179728; cv=none; d=zohomail.com; s=zohoarc; b=SkIvEYmmAuQ+w6mcq+teNZcbp4zZxRTbUbrQ0j0010OS/vXBjL6lutBJLCSZUuhSYjrQWiA1rlk7+UqH/i7gWo8UTUPkg9e4QpyByM5CC6bVNtrUNO3tflSF6VG4aElPBLToQR2pSK0GnLVoA7PXN+DVMttj/AriYyKb+wBKrV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630179728; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=EKmOEDgPYmIU0/DJIegY/k0fgH15a5m/ndVE4zvNi+c=; b=kCk3wOIqj4+ZtomU26A/62LAI8TGfbrsayUVsRIseJaZr4z9fggpRPFQzviyWARChq4DXzapOp9apBJO1tzmxgL/gLF1dF1dDKcpbF2PYzvzKujjRAB5lIPxbxwwpOt4X79/GVLQTNkwdpaINEpLJ7n4LSKfRebI2MNjF2x80Mc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79914+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1630179728944499.6745743088603; Sat, 28 Aug 2021 12:42:08 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PKnAYY1788612xFbcoOpJvF2; Sat, 28 Aug 2021 12:42:08 -0700 X-Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mx.groups.io with SMTP id smtpd.web11.1145.1630179727940424535 for ; Sat, 28 Aug 2021 12:42:08 -0700 X-Received: by mail-qt1-f176.google.com with SMTP id x5so8217814qtq.13 for ; Sat, 28 Aug 2021 12:42:07 -0700 (PDT) X-Gm-Message-State: b32lddY8leIZ6PDo58tRVavbx1787277AA= X-Google-Smtp-Source: ABdhPJxMnOuet9XeYuDGpr2vTKsMiZrk3uT6ZHN7qRhky4upythBv/uflpI+O0MRd/2IWoMztn7KMA== X-Received: by 2002:aed:2029:: with SMTP id 38mr14026039qta.71.1630179726994; Sat, 28 Aug 2021 12:42:06 -0700 (PDT) X-Received: from benjamind-benjamindomain.. ([2607:f2c0:e98c:24:a8c6:887f:fc2d:64af]) by smtp.gmail.com with ESMTPSA id a22sm5709177qtw.59.2021.08.28.12.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Aug 2021 12:42:06 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Eric Dong , Liming Gao , Nate DeSimone Subject: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check Date: Sat, 28 Aug 2021 15:42:05 -0400 Message-Id: <20210828194205.6083-1-benjamin.doron00@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1630179728; bh=xiMl9H6YImJQTCwwPlY5NC0aCTMF927DlQffvQtAgrQ=; h=Cc:Date:From:Reply-To:Subject:To; b=UGirVC5boj2XR0bVaTpXhC0ETlzsdm8sO9mfrBRl1sjRWA8uQrO3jvcc2DZiNTAhKeJ Wf8EWUZaLkjGK61KAQ9pjI2PoPpa9jfl1SM+C+PFBTCZ94jPp7w9Sl/JaxnYUA/UVN/M/ ga19om4Ga+92rcXuObOpcqELSr+RJX6B88o= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1630179730835100002 Content-Type: text/plain; charset="utf-8" If CreateFvBootOption() fails, RegisterFvBootOption() will return LoadOptionNumberUnassigned, which is non-zero. Therefore, correct the check when attempting to register hotkeys, to be able to detect if UiApp is not present. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron Reviewed-by: Nate DeSimone --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | = 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBoo= tOption.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBoot= Option.c index a07abb214913..1fd0de3961cc 100644 --- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption= .c +++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption= .c @@ -440,7 +440,7 @@ RegisterStaticHotkey ( // // [F2]/[F7] // - if (mSetupOptionNumber) { + if (mSetupOptionNumber !=3D LoadOptionNumberUnassigned) { F2.Key.ScanCode =3D SCAN_F2; F2.Key.UnicodeChar =3D CHAR_NULL; F2.KeyState.KeyShiftState =3D EFI_SHIFT_STATE_VALID; --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79914): https://edk2.groups.io/g/devel/message/79914 Mute This Topic: https://groups.io/mt/85215635/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-