[edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0

Gerd Hoffmann posted 7 patches 2 years, 7 months ago
Failed in applying to current master (apply log)
OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
.../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
.../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
.../VirtioMmioDeviceFunctions.c               | 71 ++++++++++++++++---
4 files changed, 92 insertions(+), 13 deletions(-)
[edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
Posted by Gerd Hoffmann 2 years, 7 months ago
This little series adds virtio 1.0 support for the virtio-mmio
transport.  For the mmio transport the difference between 0.9.5 and 1.0
is rather small (when compared to the pci transport), it is just a bunch
of new registers for the changed virtio queue initialization.  So the
patch series is small too ...

v2 changes:
 - Added review tags for patches #1 + #2.
 - Add a patch to make sure we have a valid QueueNum.
 - Add a patch to support all 64 virtio 1.0 feature bits.
v3 changes:
 - Add #defines for virtio-mmio version field.
v4 changes:
 - split patches into smaller ones.
 - enable virtio 1.0 at the end when everything is in place.
v5 changes:
 - Added review tags.
 - Fixed 32bit arm build failure.

take care,
  Gerd

Gerd Hoffmann (7):
  OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
  OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.
  OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.
  OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress
  OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum
  OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling
  OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0

 OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
 .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
 .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
 .../VirtioMmioDeviceFunctions.c               | 71 ++++++++++++++++---
 4 files changed, 92 insertions(+), 13 deletions(-)

-- 
2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79900): https://edk2.groups.io/g/devel/message/79900
Mute This Topic: https://groups.io/mt/85185902/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
Posted by Yao, Jiewen 2 years, 7 months ago
Hi Gerd
Have you run CI and ensure this patch series can pass CI ?

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Friday, August 27, 2021 9:45 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen,
> Jordan L <jordan.l.justen@intel.com>
> Subject: [PATCH v5 0/7] add support for virtio-mmio 1.0
> 
> This little series adds virtio 1.0 support for the virtio-mmio
> transport.  For the mmio transport the difference between 0.9.5 and 1.0
> is rather small (when compared to the pci transport), it is just a bunch
> of new registers for the changed virtio queue initialization.  So the
> patch series is small too ...
> 
> v2 changes:
>  - Added review tags for patches #1 + #2.
>  - Add a patch to make sure we have a valid QueueNum.
>  - Add a patch to support all 64 virtio 1.0 feature bits.
> v3 changes:
>  - Add #defines for virtio-mmio version field.
> v4 changes:
>  - split patches into smaller ones.
>  - enable virtio 1.0 at the end when everything is in place.
> v5 changes:
>  - Added review tags.
>  - Fixed 32bit arm build failure.
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (7):
>   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
>   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling
>   OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0
> 
>  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
>  .../VirtioMmioDeviceFunctions.c               | 71 ++++++++++++++++---
>  4 files changed, 92 insertions(+), 13 deletions(-)
> 
> --
> 2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79911): https://edk2.groups.io/g/devel/message/79911
Mute This Topic: https://groups.io/mt/85185902/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
Posted by Yao, Jiewen 2 years, 7 months ago
Pushed 94e465e5cbb65c47d9e98f5c4c61f3a5e008ee5d..77d5fa80246e8784f89e109ff9dadfeb7089ff85

PR: https://github.com/tianocore/edk2/pull/1926

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Friday, August 27, 2021 9:45 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen,
> Jordan L <jordan.l.justen@intel.com>
> Subject: [PATCH v5 0/7] add support for virtio-mmio 1.0
> 
> This little series adds virtio 1.0 support for the virtio-mmio
> transport.  For the mmio transport the difference between 0.9.5 and 1.0
> is rather small (when compared to the pci transport), it is just a bunch
> of new registers for the changed virtio queue initialization.  So the
> patch series is small too ...
> 
> v2 changes:
>  - Added review tags for patches #1 + #2.
>  - Add a patch to make sure we have a valid QueueNum.
>  - Add a patch to support all 64 virtio 1.0 feature bits.
> v3 changes:
>  - Add #defines for virtio-mmio version field.
> v4 changes:
>  - split patches into smaller ones.
>  - enable virtio 1.0 at the end when everything is in place.
> v5 changes:
>  - Added review tags.
>  - Fixed 32bit arm build failure.
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (7):
>   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
>   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling
>   OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0
> 
>  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
>  .../VirtioMmioDeviceFunctions.c               | 71 ++++++++++++++++---
>  4 files changed, 92 insertions(+), 13 deletions(-)
> 
> --
> 2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79928): https://edk2.groups.io/g/devel/message/79928
Mute This Topic: https://groups.io/mt/85185902/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
Posted by gaoliming 2 years, 7 months ago
Gerd:
  This is a new feature. Can you submit BZ (https://bugzilla.tianocore.org/ ) for it? Then, I can add it to edk2 feature list. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen
> 发送时间: 2021年8月30日 9:22
> 收件人: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io
> 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>
> 主题: Re: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
> 
> Pushed
> 94e465e5cbb65c47d9e98f5c4c61f3a5e008ee5d..77d5fa80246e8784f89e109
> ff9dadfeb7089ff85
> 
> PR: https://github.com/tianocore/edk2/pull/1926
> 
> > -----Original Message-----
> > From: Gerd Hoffmann <kraxel@redhat.com>
> > Sent: Friday, August 27, 2021 9:45 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann
> > <kraxel@redhat.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Justen,
> > Jordan L <jordan.l.justen@intel.com>
> > Subject: [PATCH v5 0/7] add support for virtio-mmio 1.0
> >
> > This little series adds virtio 1.0 support for the virtio-mmio
> > transport.  For the mmio transport the difference between 0.9.5 and 1.0
> > is rather small (when compared to the pci transport), it is just a bunch
> > of new registers for the changed virtio queue initialization.  So the
> > patch series is small too ...
> >
> > v2 changes:
> >  - Added review tags for patches #1 + #2.
> >  - Add a patch to make sure we have a valid QueueNum.
> >  - Add a patch to support all 64 virtio 1.0 feature bits.
> > v3 changes:
> >  - Add #defines for virtio-mmio version field.
> > v4 changes:
> >  - split patches into smaller ones.
> >  - enable virtio 1.0 at the end when everything is in place.
> > v5 changes:
> >  - Added review tags.
> >  - Fixed 32bit arm build failure.
> >
> > take care,
> >   Gerd
> >
> > Gerd Hoffmann (7):
> >   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
> >   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.
> >   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.
> >   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress
> >   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum
> >   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling
> >   OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0
> >
> >  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
> >  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
> >  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
> >  .../VirtioMmioDeviceFunctions.c               | 71
> ++++++++++++++++---
> >  4 files changed, 92 insertions(+), 13 deletions(-)
> >
> > --
> > 2.31.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79936): https://edk2.groups.io/g/devel/message/79936
Mute This Topic: https://groups.io/mt/85243105/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: 回复: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
Posted by Gerd Hoffmann 2 years, 7 months ago
On Mon, Aug 30, 2021 at 11:17:21AM +0800, gaoliming wrote:

> This is a new feature. Can you submit BZ (https://bugzilla.tianocore.org/ ) for it? Then, I can add it to edk2 feature list. 

https://bugzilla.tianocore.org/show_bug.cgi?id=3597

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79945): https://edk2.groups.io/g/devel/message/79945
Mute This Topic: https://groups.io/mt/85243105/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0
Posted by Yao, Jiewen 2 years, 7 months ago
Series: reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Friday, August 27, 2021 9:45 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen,
> Jordan L <jordan.l.justen@intel.com>
> Subject: [PATCH v5 0/7] add support for virtio-mmio 1.0
> 
> This little series adds virtio 1.0 support for the virtio-mmio
> transport.  For the mmio transport the difference between 0.9.5 and 1.0
> is rather small (when compared to the pci transport), it is just a bunch
> of new registers for the changed virtio queue initialization.  So the
> patch series is small too ...
> 
> v2 changes:
>  - Added review tags for patches #1 + #2.
>  - Add a patch to make sure we have a valid QueueNum.
>  - Add a patch to support all 64 virtio 1.0 feature bits.
> v3 changes:
>  - Add #defines for virtio-mmio version field.
> v4 changes:
>  - split patches into smaller ones.
>  - enable virtio 1.0 at the end when everything is in place.
> v5 changes:
>  - Added review tags.
>  - Fixed 32bit arm build failure.
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (7):
>   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
>   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling
>   OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0
> 
>  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
>  .../VirtioMmioDeviceFunctions.c               | 71 ++++++++++++++++---
>  4 files changed, 92 insertions(+), 13 deletions(-)
> 
> --
> 2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79927): https://edk2.groups.io/g/devel/message/79927
Mute This Topic: https://groups.io/mt/85185902/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-