From nobody Thu May 2 15:03:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79830+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79830+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1629950151; cv=none; d=zohomail.com; s=zohoarc; b=E+12ZrBOuQj2myezIS5lGuvzy3g9w/z8g8samwnUhGyN+PjY9+qJ2Kve5T+ihnFXHpFXDzlvfvgehpKpu7ECp3h4PU/qzyn0Ql6IA+h/XjOd4nwKx2ngKk6N4CQqG/a88BKbPck+1/6CklQDEymybf8/QYrgKc2VkMdm1YpVQCM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629950151; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=7Uxdk6UTznxr2XAngz3/Hn09PJP5LUXz79BxGwKTadI=; b=Y+KQ42NF5OtZM/XmcVmPv/xvX295krtK4QWD7viA+F5Hi2+dYX3FyfF5UWKFjrcx/tUnIKR1UfA3VKbFt/aE0RIKCotfjgUDx0+a7HIbDjsxZYwEqoIcdb1lsVpSs7ZxzKpYvWRW0pDQsLCzdWjC28gvZ55p73gDBDobpdxf+aY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79830+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629950151198361.7241891252107; Wed, 25 Aug 2021 20:55:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hFSsYY1788612x3TUcgFPqEr; Wed, 25 Aug 2021 20:55:50 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.26097.1629950150118424816 for ; Wed, 25 Aug 2021 20:55:50 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="197897575" X-IronPort-AV: E=Sophos;i="5.84,352,1620716400"; d="scan'208";a="197897575" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2021 20:55:49 -0700 X-IronPort-AV: E=Sophos;i="5.84,352,1620716400"; d="scan'208";a="494904496" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.209.35.181]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2021 20:55:49 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Michael Kubacki , Benjamin Doron Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value Date: Wed, 25 Aug 2021 20:55:46 -0700 Message-Id: <20210826035546.1771-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: ZB4ABPJH71BSjlCnAnnzpMMmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629950150; bh=BidDD8lETbI1cMDOiuaUpv5woLIf1jPh2AGEqx8JFKo=; h=Cc:Date:From:Reply-To:Subject:To; b=n2Vwphy2OrnRJy+WwSKl+x2xyhTheYERngBLS9VExThFWgYFPJZRGu6elECx9cXQsnw cEoIJ4fqK4DP6mVnogeQhufljV1IgsjrO6kQrqEO5ghfTKFS3Dg6i7jexH2LK5paxNyAq Q4xXtrjX22ccqZmZ1TDOp578onjue1gEzkI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629950152780100001 Content-Type: text/plain; charset="utf-8" Added EFI_INVALID_PARAMETER to the EcRead() function's list of return values. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by: Nate DeSimone Reviewed-by: Chasel Chiu Reviewed-by: Michael Kubacki --- .../Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h | 9 +++++---- .../KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h b/= Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h index 7c58e592d9..e95accc465 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h @@ -7,7 +7,7 @@ Make sure you meet the requirements for the library (protocol dependenci= es, use restrictions, etc). =20 -Copyright (c) 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -109,9 +109,10 @@ LpcEcInterface ( @param[in] Address Address to read @param[out] Data Data received =20 - @retval EFI_SUCCESS Command success - @retval EFI_DEVICE_ERROR Command error - @retval EFI_TIMEOUT Command timeout + @retval EFI_SUCCESS Command success + @retval EFI_INVALID_PARAMETER Data is NULL + @retval EFI_DEVICE_ERROR Command error + @retval EFI_TIMEOUT Command timeout **/ EFI_STATUS EcRead ( diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcComman= ds.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c index d14edb75de..14a746172b 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c @@ -1,7 +1,7 @@ /** @file Common EC commands. =20 -Copyright (c) 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -16,9 +16,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent @param[in] Address Address to read @param[out] Data Data received =20 - @retval EFI_SUCCESS Command success - @retval EFI_DEVICE_ERROR Command error - @retval EFI_TIMEOUT Command timeout + @retval EFI_SUCCESS Command success + @retval EFI_INVALID_PARAMETER Data is NULL + @retval EFI_DEVICE_ERROR Command error + @retval EFI_TIMEOUT Command timeout **/ EFI_STATUS EcRead ( --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79830): https://edk2.groups.io/g/devel/message/79830 Mute This Topic: https://groups.io/mt/85153845/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-