From nobody Mon Feb 9 04:03:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79710+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79710+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629702620319971.4112968476308; Mon, 23 Aug 2021 00:10:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id FV6fYY1788612xyHCjBxoMx4; Mon, 23 Aug 2021 00:10:20 -0700 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.20532.1629702611205024974 for ; Mon, 23 Aug 2021 00:10:19 -0700 X-Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17N73Y0H028739; Mon, 23 Aug 2021 07:10:10 GMT X-Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 3ajq0ep0aq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 07:10:10 +0000 X-Received: from G9W8455.americas.hpqcorp.net (g9w8455.houston.hp.com [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 7118583; Mon, 23 Aug 2021 07:10:09 +0000 (UTC) X-Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 23 Aug 2021 07:10:09 +0000 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.12) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 23 Aug 2021 07:10:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXIaA2C6CQA4gGCxHdHmcPghcHuVOs8M/YoIwYyAfuQN7yatNp+KPV7H6xxkrVMMBLeeLsp+GPeofyXwPdU0mq+p7AdPV8i0vd2tnS/5p//4BSP1WESWr1w2E0oLb0zZnvKkjbfxom8nXJjkB6HTJ0r3AMwtNBwwjcOZtApGjwhf7NorL9AIbATMC1luCt6vf9xPFHL0WvJgKOYMmE03oko9BcAQnkl1aXY2i0Eq3cU1PwxtRQ8yyUddWIYta6o1guaqx7lTuaupvBr2X1/Io2J1cvvMWZgPnIurCG1IAa97Bs3nmlkkOfP6iZPjP4GcqJhOUV/fvRD57FTO1pNXqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lEClfpZoyD0wUko2aGNUczw79D4K/8oVLObQolLLRA4=; b=VWe4CWGEls4yyLLnRl7arQaBt0oXO+Wgr+v4SiOVUytpRARJoZ39G/ReURw9dq2KnChN7RTiEB2nbB7ST/oxA8aiDQ0X4maaCe1Y2ImRIMxVD9h+EcmQ5j4AuG4/vla5mTU3ETdp7ibmHQofOzr+vB19ORjvMKohlFxo6qD1Xg8uT9DzDM0Yk/Flbh2RZSCPBoGtG20+HtSJHNuLFCz4AFSVg3qad9Rhzk7Px7RCOuh0kGjV5rH/gvE33eGhp7oFMAKC8kO5K/vfZ+JI7wGpJzM9bkrYZ2ERqz2Lp004zj295vHvhaz64P6lDo45RhX1sa9rXtFWMaScvDXnsa6u2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB1106.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7421::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Mon, 23 Aug 2021 07:10:08 +0000 X-Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4436.019; Mon, 23 Aug 2021 07:10:08 +0000 From: "Lin, Gary (HPS OE-Linux)" To: CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Jim Fehlig , Joey Li Subject: [edk2-devel] [PATCH v3 3/4] OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support Date: Mon, 23 Aug 2021 15:09:24 +0800 Message-ID: <20210823070925.10095-4-gary.lin@hpe.com> In-Reply-To: <20210823070925.10095-1-gary.lin@hpe.com> References: <20210823070925.10095-1-gary.lin@hpe.com> X-ClientProxiedBy: HK2PR02CA0175.apcprd02.prod.outlook.com (2603:1096:201:21::11) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from localhost (111.240.132.81) by HK2PR02CA0175.apcprd02.prod.outlook.com (2603:1096:201:21::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Mon, 23 Aug 2021 07:10:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a13fcddf-1a3f-44d2-0cf0-08d966050a29 X-MS-TrafficTypeDiagnostic: AT5PR8401MB1106: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:843; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: dEs/tZYF6l37/5bt4sYbBOo02tJOMWySUr6ZiwaMQfdeasjxlkeHKMOqSU10MbLuooVsR3byyE5XOSbfeJ3AqzEjZRhOCyA8b14cJDXti5MHMT43qe3ETWHyzHqslbaIPS3bT+dEWmtJCMRA4al8fitt705Ci5mGHu42g3OLkU52gr4SLXd0AeB8JpQsL8wgMFyuWZY4D7T5uCzTXeYL9631KPVzPFRzLkrMdYFlYRDAiLIAOlcftEDB0Hbl8W21qDEw+KF4wReaErV+L7prRS6PDPtan9wAH6OQYrOLIf1F4imABSnEfNseMPY27YsZhGbDIUJforeuqqth3Cwg9vxSOok+LXEk1y93Q6T81OcXnxK0D9snUijohTy+oRkMdlmo/FiG7wOkRiiSHL+PravETWBYj+DzcrBdb3qLb3sutPNNS+jI8bjkMuSn2V2wRwLSa+ci846v6r6jeTh+IMTyqGkGTM+isvbCmNZN4aPBAncvqHmGGUKlw+Mbpac7S1pCPBpUfYGAqT3OI3jL3kXHllU2Aqsf44DQDUp5rZ6oYDYMEiiEmgxyBD0MEW5w+0HZ6DpbT0t3XM8Q686+IYiBUWgEPe8XdF6ZQbFAfz0mlL2dUzgcBAjtzNqtLmkWpRD3UMwf7BjxeMqC3U2kPj38KlhuXJhOLtqdLAc0YHsytUpDZZ5kD6Kmu+tEOvSprBqTU0xeAQ867UQjqwc0jpaiwJ3P4g/4t57GvziP5cI= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lBhJI1miVZVV9diP0452vwsvGGDVdjOZFrQFCxMl59mqkd8wpFfd5B67F1vo?= =?us-ascii?Q?bqQLTcC0zln1s5hhU8HKYhGFtKwmKFmkXIqBhhqYpr/RIAPnCiVzg7pXLgqk?= =?us-ascii?Q?XysJDr7LVZDScyE9tZdAjw2TuoBuzekN9WLkKMJitPrVO7wHKnYXOYT/jZdo?= =?us-ascii?Q?xWhAiotETutXIzYk72+VPyMJawpXBSdDzA2P8vKzG7cTfux/lef06+lDzexP?= =?us-ascii?Q?Rd1y6a+PsCY2a+9poC7/jpriOwLWU98uATFvJFTQq3Gsx1+HmqnkEOyIGZMk?= =?us-ascii?Q?nBseWQpXiYOK9xWtuHMwT91xDll6fmeg3Y/nWnqcmkYFVrOMiGw2cFDKF6IC?= =?us-ascii?Q?tRGN/mtjrK20zm9RzUc/+YYa6RqW5rXhFxYdYhHw9IrekNm88YtcntkuS4af?= =?us-ascii?Q?g0sC6n3wTyG1fcQBkas6RBIoY7II9FggzIdqqs47//uS+ee9tovtOBOCXOMQ?= =?us-ascii?Q?VQ9DjzewXXLy04Z1tPM92iXojyni06C8WQ48v3eOrKEjl2YTMDlY4vnIk7kT?= =?us-ascii?Q?9Xl3UNphJPefxLnBl1sopVfoEEGGqw7leA3pMkYyH2NfqrH3iUgy6DfhU0cs?= =?us-ascii?Q?BfQO15SqljPmiJp+Zz0N7LJq3e58GFZsNV8zNZVc+qpFkVReNRlK1uAWNZqr?= =?us-ascii?Q?1ugjnoR/QYY5cmJlsnAn2YeRvHNBdqtF04wEuI5oMtRw++dXD1WQow+6YoLb?= =?us-ascii?Q?JFG4dULaO27FSv4FsiX5YflgLgh19TZLYnZgbWvnu7a0LxKRmAIFrE58GX+o?= =?us-ascii?Q?u69+xNYwV2wfXvC/CrHYvNv12FRvGk9dm9FyeOdIwGaja4+Si25Qc5XgZXf0?= =?us-ascii?Q?54mkUZ7bdZbR85oHsrlylQgN/uY/kH0TbVL9W0QsYrzhEgQjA9zTcmYdAawX?= =?us-ascii?Q?Kzg5Bxj7C7qwYDp4om4/QmW41gnevWlcMyvHDTbs5sefT6tT5QTCWViwdhM+?= =?us-ascii?Q?uA8VgevZjapVBtZP0LBddu78nbCpiYtbT8u6wA4Q5jQy8gwy/n+q9irN1Eou?= =?us-ascii?Q?jqWjR+5Wq2+gZhHX6X6Pqk2ypO+3oWstIyDwoYanjjxBwtFMt00C/IirTl5o?= =?us-ascii?Q?twLJ7mtxYMuWbYfdEQuLyN5mblTAUSX5FBg/myMP7s16/SC4KsRLnLyGCaQa?= =?us-ascii?Q?JiAhVhbzf+nDeXChayZBg9bXUNnn8pAMCAr1TdkXPcitKtRGDxVThdUWWuU4?= =?us-ascii?Q?Dt/XMtO7nM47kNTNMi2vrOzza2hlFlk0d0v4ECMEKNlTzIb8Vsp4MCN7xXDa?= =?us-ascii?Q?2hAU4GEXxtYyEWk4EKniUOLpWMRDeApXPg8GE2pPw9Pdka3O4fs8kQVe8Bpo?= =?us-ascii?Q?6Alz8NUx3N3EFsP8qgaDwn6U?= X-MS-Exchange-CrossTenant-Network-Message-Id: a13fcddf-1a3f-44d2-0cf0-08d966050a29 X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 07:10:08.2187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lqFncww//JKFMwMV+3ZtZhS1iDjsdlx+eSk4856s2Dk48Hm+1b4FTyIVOtFrmpAqS7NaDKYVRp7K07rX/tyekw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB1106 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: b77iiAEiM-xECW5moLvp0ehiBV3J5ZBw X-Proofpoint-ORIG-GUID: b77iiAEiM-xECW5moLvp0ehiBV3J5ZBw X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gary.lin@hpe.com X-Gm-Message-State: kRhudmgOOolwOhQp1vAScwgsx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629702620; bh=XRxkn4gy06qjGwco24D2KtueyPmh6UHYsUCOSdaqHnc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=suueu1KucfF+eelj84f0HdvGzUN8YHF88+E2cynAUDOOOh55k5dqvFkU1Ng4k1GY5uK rS0TOzBQY6KKdnwI0bKubmBEmzt9yY+qiS/2fnR8fCq1DHCjOUaAmy9xpqcQ7HzIqge1e 48CNiusyr6mPipZ+ANVY1FgkkNwGUpeoWGk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629702622406100001 Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D3573 To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. v3: - Add the bugzilla link Cc: Ard Biesheuvel Cc: Jiewen Yao cc: Jordan Justen Cc: Jim Fehlig Cc: Joey Li Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann --- .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.= inf b/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf index e470b9a6a3e5..c249a3cf1e35 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf @@ -61,6 +61,7 @@ [Pcd] gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate ## CONSUMES gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits ## CONSUMES diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg= /Library/PlatformBootManagerLib/BdsPlatform.c index b0e97429372b..71f63b244828 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -379,7 +379,7 @@ PlatformBootManagerBeforeConsole ( // EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); =20 - if (QemuFwCfgS3Enabled ()) { + if (PcdGetBool (PcdAcpiS3Enable)) { // // Save the boot script too. Note that this will require us to emit the // DxeSmmReadyToLock event just below, which in turn locks down SMM. --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79710): https://edk2.groups.io/g/devel/message/79710 Mute This Topic: https://groups.io/mt/85080303/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-