From nobody Mon Feb 9 04:29:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79708+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79708+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629702602159544.17556821407; Mon, 23 Aug 2021 00:10:02 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id BY2DYY1788612xYr37G5xby1; Mon, 23 Aug 2021 00:10:01 -0700 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web08.20249.1629702592897015850 for ; Mon, 23 Aug 2021 00:10:01 -0700 X-Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17N73iVY008781; Mon, 23 Aug 2021 07:09:50 GMT X-Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 3ajtsvmuxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 07:09:50 +0000 X-Received: from G9W8456.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 0B0DC59; Mon, 23 Aug 2021 07:09:50 +0000 (UTC) X-Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 23 Aug 2021 07:09:49 +0000 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.11) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 23 Aug 2021 07:09:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ex3yl42y4OC1pIdhsss0WzloS49u6JfNyDwJ3v8A0mbGU/0w4GPcQM7YSoJCLdMC/7h9RfBtmwnEE3Q8rDOLhSvozk7LmIMJElr/y3YfGGQsu8XxhHujdHiw4gtMloGrkIgmhgUfleWbQV3oWf7d95ERFpR9zeubuvtSdbuA3Bvs9PBWShOpx2GZxY7D0MCqRhslahlQOVN6XkCcBpjCLI2B1aEMBWINQw3a3kuhnCwAkM44c1yrsxEf8Oka5KIGmynbK19Sf1G3/3ie7qP/myORrv87vpWUX01Ru5jjqVZERn05z9kWe1fri4fUl9eHJvop7z8FGtJMBL2CkQsnrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEAEWivEjYFB1vasRm10+/D4rLrIq38Rtio8l1UNsxg=; b=nCckhTGogG+ah9S6SHwh8vSsaZMrhbA7CHaL22WRog/9RJ3JwkUBgfAWBr321DMhKqFfzv5DcD9qgLvF94W6eoQnMA9yclZzeHWIid0QeT1rZO4mqR9WUYiKWgcAe8ELGk4rs62+XXdj/mv/93L1Fe4SDckYTDFRsUEZrCkKZGy1fZl+a8G6Ft/kTmhtZHPg7+90MsWpszEc5tTQTA+ws9RvDnYJa0SjgE4wqtaR8U+wI0i5iFm3NSQ2yXUqUYtNIRfkJSmWi3fok+B5FgdLG487U7kAWTPogCyOUYaXLdPRDd7aYYMw9oFdRPYaNbo0b96kUpVw9FPGyfD4nxPgHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB1106.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7421::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Mon, 23 Aug 2021 07:09:48 +0000 X-Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4436.019; Mon, 23 Aug 2021 07:09:48 +0000 From: "Lin, Gary (HPS OE-Linux)" To: CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Jim Fehlig , Joey Li Subject: [edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization Date: Mon, 23 Aug 2021 15:09:22 +0800 Message-ID: <20210823070925.10095-2-gary.lin@hpe.com> In-Reply-To: <20210823070925.10095-1-gary.lin@hpe.com> References: <20210823070925.10095-1-gary.lin@hpe.com> X-ClientProxiedBy: HK2PR03CA0062.apcprd03.prod.outlook.com (2603:1096:202:17::32) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from localhost (111.240.132.81) by HK2PR03CA0062.apcprd03.prod.outlook.com (2603:1096:202:17::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.5 via Frontend Transport; Mon, 23 Aug 2021 07:09:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a733964-bd4d-4489-ee17-08d96604fe50 X-MS-TrafficTypeDiagnostic: AT5PR8401MB1106: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: TD7cbegkcujFvOO55IZgemU+zjWCE9Bj7/mxbTwjKNmFZW7b/NClUmtwjhtfcwrDj66kcQ84Iv6QJhLGbaI0/dUwvoeGjIsyLnRccuvy+sQClx2I3IvVKQ/qFD/ZLGKcK7gY7gGRtSXRC8K2jiV4l+Uhq6Qjzq21i4kq+TOeIZCpcyUmhKzMpkvLsFlCSH/zp2L4/jqgIDK8jcLWLnOa2xE9IMeblPo1XFJmMvsksCdQa8THRH7ot+jAf+w8A2bWkMEIHZBmppP82J2nWXjo3EQLg0PfmLz8buk9jBPL7Oj2H23ih3yJQJca9Yz9K70JZUOGQcjxVPdI04+znv9F+Gk8sauRQqpM2w0S8SJ/MweQokc348lPnxW7QzYt21vf5I1qF5Fi2LogDq+7+pLRebID6/lfo+YHzfHwny+Ak5wcG9JQ7VRDCJn7kOJJmV208+xtiOy6xYNbVtQyypL/zNevJdGl7F68FYLxfUJa4/yxkmocmPH2/OQuxhD3iiQfBiHjc/zyICJdsT5Fp+9d/IP/kHzduiHJgyU7gB6nmnOfmiqLHAkylaKIvyrCMDOqT4wDv/p3848MHffpA6CLJzEFmMLILNYtZ8exnOuAhBmDZ85nS7SsRphPgeySzETTMeW2AQB2vkkku08ccFJust2bpDNVr1vY9HGvfxvm1zddTzirvyEGcIvLO8OrFKS4dTCm9HPUYgMsmtwP3ohUggw2MhSVTj6nDo3HgszPf9Y= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HlcEzOh6Bmb7suyq47gqXa5nyQieTjgXoXiZpYSHtyvww+2TO05bF+fr28qC?= =?us-ascii?Q?NrSrbC/JhALkaU1nvdwwl+w3eboH/+DyGYUGYce2nFgk6WxE2u6zQcY2ZT/o?= =?us-ascii?Q?KYx48xblWpFHAy9uM5MEQd6n1e4Snr1+t36OZj71K2pvTF09Uclb+uzz4DpN?= =?us-ascii?Q?82Kxcu/yLzo+dYyiK0q/lzQ6NyGscpIa+De16YY9gOsTsxyPD4jQjJ/vN8cH?= =?us-ascii?Q?aYYbmm8Crpnf7jXFkOJD9hf9XlqqkVAcGzw1OaOIYBEsQ5eZXSQ86GxVrq1E?= =?us-ascii?Q?48IwSGt4AwXVOu+j7WWz98YMjdZgtwFGhDagFhHsqXpwN6REzhGJ3xCKPxTh?= =?us-ascii?Q?lhY7hW6qAyARS/9jKbEsCJSL0KAMx/ScN6CejGmfcFmNN2IryJoeErhCoN56?= =?us-ascii?Q?YTfZkR08p2sDyvJN1EIcMriSq6sLuElbrQy7LxZSyqoosGum5H7D9yuEDXvQ?= =?us-ascii?Q?7JQ9Mil+YcEc5XTxutjewc/KnDxXGvDvEFr0ZPHxquYvqu/jlkWu7CcDrh1t?= =?us-ascii?Q?5lynmx6SsT42pjKFaVU8SFzz+cVb8DOEA3k+0YqM3o09WHJFNqHTfxYwLkLB?= =?us-ascii?Q?kUsMfBB0qlW07koHOL4WRnF/7BrVSqMbaN5vJ7P2IcUFEPoWJ4O3utUE48V9?= =?us-ascii?Q?8XHe7iUjW8cu6ctvoPYNxCl2HsSN7bFruMfdN+SrdBqN4wa6Hp5OKziE9JqS?= =?us-ascii?Q?2mU4vOgQrhmpKkkDYRQixKLHPZ8F1D2DkgIZcVV9XhKRAjjEYsuBBfxv2nSZ?= =?us-ascii?Q?dzh504EZKhkm8uqfqpCX4oHQJInUqBz9vdfgd8n4rxyv+jIMFFpUXkjgPsXa?= =?us-ascii?Q?BwlhtnaUEFCat568R0nLG/wOqka1fQNEEXRIR1e6AkXluyDbj0XxshlKioHv?= =?us-ascii?Q?IOWWW/3xGpRiISiGvbEUxZtBDldtCUu2qiAoNQdD+g7fhp6JjnJxqtD8t4jU?= =?us-ascii?Q?SYqzJma4Y6p9JWHJObARWDtE2q/E2SvZswVTbwnE2QuS8s7jfRPqEFaKIj2G?= =?us-ascii?Q?o3LyPptuZMy9F4uhE1cp8X8/XYqtSu1KopcEvRedQefnatvTHNln+cEvL69G?= =?us-ascii?Q?++Jx4QRAHGIKkUivjniHCAG7v0btFqX2uv8/TPpJXHV6/mit/HqbrCb+4i8i?= =?us-ascii?Q?LVkOiMQeLWSR6d8pTmqBvA8qVeptc+UcmMe4JyPRql2S4UT8KAOmEbAA5Tu4?= =?us-ascii?Q?+OgTeApEw8RcbKoRqhJ/ir8DE90/wcmGGh+9hZL1xqgZM+1Z7bZ7v6L8X641?= =?us-ascii?Q?/NF0T9176NNFuxSsDa4HfOSruMmhAVT/bqUyNdBJ+/+d6WDaXmrcP1yU8xrW?= =?us-ascii?Q?hcDq4I1eq9F9HutjkVdSzQxA?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9a733964-bd4d-4489-ee17-08d96604fe50 X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 07:09:48.3464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gozxNkzDPjKm+bF2VG5ua3vPCywUWsZ+SQgGGLumXS36oS4qfT6uEzxyZs2/tjsU/6auHiprnpIRfG+ALT8ZTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB1106 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: 4jOqqRNYSddnjTNvKYC6MlQjRaHYBxxM X-Proofpoint-ORIG-GUID: 4jOqqRNYSddnjTNvKYC6MlQjRaHYBxxM X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gary.lin@hpe.com X-Gm-Message-State: StmGjf810FTTJAWKxHwx2Rgtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629702601; bh=wnTeFiRHI4iwtyltpLHmtW198ytX5H+nq5mto7NqFWI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=LCSPDdK13kB5W2BFHSTLCmce6SxZvNl1OyVkpqrtWT7yMYTF9LMDluW7jTdou7Lyas0 v4dNyBk/dzJ3sVYd2XdVhPkAf6SE47WqPqws69SEJbVIBVuB5RX47SWA/47tqk4HwtoGP ZGQY1srgotQAHZBf9NBzmLhy5q8u24pjpck= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629702602589100005 Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D3573 There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. v3: - Update the description per Anthony's suggestion - Add the bugzilla link v2: - Amend the description and address "HVM Direct Kernel Boot" - Add the comment for the conditional test of QemuFwCfgS3Enabled() - Remove unused QemuFwCfgLib Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Anthony Perard Cc: Julien Grall Cc: Jim Fehlig Cc: Joey Li Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann --- OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/OvmfPkg/XenPlatformPei/XenPlatformPei.inf b/OvmfPkg/XenPlatfor= mPei/XenPlatformPei.inf index 597cb6fcd7ff..20c27ff34b6c 100644 --- a/OvmfPkg/XenPlatformPei/XenPlatformPei.inf +++ b/OvmfPkg/XenPlatformPei/XenPlatformPei.inf @@ -57,6 +57,7 @@ [LibraryClasses] ResourcePublicationLib PeiServicesLib PeimEntryPoint + QemuFwCfgS3Lib MtrrLib MemEncryptSevLib PcdLib @@ -79,6 +80,7 @@ [Pcd] gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Base gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size gUefiOvmfPkgTokenSpaceGuid.PcdQ35TsegMbytes + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode diff --git a/OvmfPkg/XenPlatformPei/Platform.c b/OvmfPkg/XenPlatformPei/Pla= tform.c index a811e72ee301..e60478fdb493 100644 --- a/OvmfPkg/XenPlatformPei/Platform.c +++ b/OvmfPkg/XenPlatformPei/Platform.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -423,6 +424,8 @@ InitializeXenPlatform ( IN CONST EFI_PEI_SERVICES **PeiServices ) { + EFI_STATUS Status; + DEBUG ((DEBUG_INFO, "Platform PEIM Loaded\n")); =20 DebugDumpCmos (); @@ -433,6 +436,16 @@ InitializeXenPlatform ( CpuDeadLoop (); } =20 + // + // This S3 conditional test is mainly for HVM Direct Kernel Boot since + // QEMU fwcfg isn't really supported other than that. + // + if (QemuFwCfgS3Enabled ()) { + DEBUG ((DEBUG_INFO, "S3 support was detected on QEMU\n")); + Status =3D PcdSetBoolS (PcdAcpiS3Enable, TRUE); + ASSERT_EFI_ERROR (Status); + } + XenConnect (); =20 BootModeInitialization (); --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79708): https://edk2.groups.io/g/devel/message/79708 Mute This Topic: https://groups.io/mt/85080301/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-