From nobody Fri May 3 09:30:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79633+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79633+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1629444109; cv=none; d=zohomail.com; s=zohoarc; b=Qwhpm6z7XwwlqeHugMU23UwgX6pbYtk0GN4eVF1FOfos0lv0qnvsm5pSrELPgp1ZnKNX/Mn4wxYlL0dZ4QzsU96mH50mnQjcS/BzL01Lbs2nMfDesl5Aq2HVB4YpZPZmrFtUbrLuiOeAi1Zy9N7EiJ5tSNkxEhEHJz/6fRXG7mg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629444109; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=O0S7n2RKuX9kSFGPUKyqNprfWCJtaui+TXHRCQS9yi4=; b=O0dI/P6NATMqJ48bTF8tF5EWmX5s6HbT5o7Su1iiYxhRdXvfZfAJe8NernPKtOOUxRY1eFRoXO6IzGdX5EdUNkSYOQyX0D05tKoUtJgtNd25mKq/7ukKrC7Ey084H1h4YT5F9ByFLYgXBoTLlqaY/5QbM0klrCR1ODjMxoLKNKk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79633+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 162944410952167.00246617438665; Fri, 20 Aug 2021 00:21:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ffLKYY1788612xY0Nis0LlzT; Fri, 20 Aug 2021 00:21:49 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.80988.1629444108583559485 for ; Fri, 20 Aug 2021 00:21:48 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10081"; a="216455779" X-IronPort-AV: E=Sophos;i="5.84,336,1620716400"; d="scan'208";a="216455779" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2021 00:21:47 -0700 X-IronPort-AV: E=Sophos;i="5.84,336,1620716400"; d="scan'208";a="523107245" X-Received: from duntan-mobl.ccr.corp.intel.com ([10.238.1.156]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2021 00:21:45 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Maurice Ma , Benjamin You , DunTan Subject: [edk2-devel] [Patch V2] UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg Date: Fri, 20 Aug 2021 15:20:40 +0800 Message-Id: <20210820072040.346-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com X-Gm-Message-State: 7BCqCe3ZNGOW4omm8i926wMzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629444109; bh=la3h+VzA1oCvKJjLRJ1HBRDNyZkWtGKueuspaMDbnFA=; h=Cc:Date:From:Reply-To:Subject:To; b=JxDVRKvZR+3B3Isx90PQ4Ngq5dTrdnBBPm7QRGLmfj8NTmAUTKhBAFgXtVS5I+RSDOU 2GqrXFB4NLv9WCv9wB+AGtcLgnhzdFO6IeOjU8Qe4vwcY+2ZRChBIUknRPu8RlYJahsXJ M2A9GxwkvBAwuv6ZmLTyqmwIyHfS3IRFQFs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629444110721100002 Content-Type: text/plain; charset="utf-8" V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size er= ror. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni --- UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c | 6 +++--- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- UefiPayloadPkg/UefiPayloadPkg.fdf | 16 ---------------- 3 files changed, 4 insertions(+), 20 deletions(-) diff --git a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c b/UefiPayloadP= kg/Library/PayloadEntryHobLib/Hob.c index 768c3db770..dd25ac2682 100644 --- a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c +++ b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c @@ -77,9 +77,9 @@ HobConstructor ( Hob->Version =3D EFI_HOB_HANDOFF_TABLE_VERSION; Hob->BootMode =3D BOOT_WITH_FULL_CONFIGURATION; =20 - Hob->EfiMemoryTop =3D (EFI_PHYSICAL_ADDRESS) EfiMemoryTop; - Hob->EfiMemoryBottom =3D (EFI_PHYSICAL_ADDRESS) EfiMemoryBottom; - Hob->EfiFreeMemoryTop =3D (EFI_PHYSICAL_ADDRESS) EfiFreeMemoryTop; + Hob->EfiMemoryTop =3D (EFI_PHYSICAL_ADDRESS) (UINTN) EfiMemoryTop; + Hob->EfiMemoryBottom =3D (EFI_PHYSICAL_ADDRESS) (UINTN) EfiMemoryBot= tom; + Hob->EfiFreeMemoryTop =3D (EFI_PHYSICAL_ADDRESS) (UINTN) EfiFreeMemor= yTop; Hob->EfiFreeMemoryBottom =3D (EFI_PHYSICAL_ADDRESS) (UINTN) (HobEnd+1); Hob->EfiEndOfHobList =3D (EFI_PHYSICAL_ADDRESS) (UINTN) HobEnd; =20 diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index b4a30be381..856d5ea786 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -415,7 +415,7 @@ # ##########################################################################= ###### =20 -!if "IA32" in $(ARCH) +!if "IA32" in "$(ARCH)" [Components.IA32] !if $(UNIVERSAL_PAYLOAD) =3D=3D TRUE UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayload= Pkg.fdf index b2cfb6b405..5871d71dbb 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf @@ -201,22 +201,6 @@ INF ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamic= Command.inf INF ShellPkg/Application/Shell/Shell.inf !endif =20 -!if $(SHELL_TYPE) =3D=3D MIN_BIN -!if $(ARCH) =3D=3D IA32 -INF RuleOverride =3D BINARY USE =3D IA32 ShellBinPkg/MinUefiShell/MinUefi= Shell.inf -!else -INF RuleOverride =3D BINARY USE =3D X64 ShellBinPkg/MinUefiShell/MinUefiS= hell.inf -!endif -!endif - -!if $(SHELL_TYPE) =3D=3D UEFI_BIN -!if $(ARCH) =3D=3D IA32 -INF RuleOverride =3D BINARY USE =3D IA32 ShellBinPkg/UefiShell/UefiShell.= inf -!else -INF RuleOverride =3D BINARY USE =3D X64 ShellBinPkg/UefiShell/UefiShell.i= nf -!endif -!endif - =20 ##########################################################################= ###### # --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79633): https://edk2.groups.io/g/devel/message/79633 Mute This Topic: https://groups.io/mt/85016173/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-