From nobody Thu May 2 08:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79543+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79543+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1629330325; cv=none; d=zohomail.com; s=zohoarc; b=BCdPIFMaCgwRMu9m9COZrZ46dQKjhb9ATMfIJGyWEOvbvFuoNC6+yLsH7GZfJGhenvMF4o4Ob63iiyJPxw7g2BfaWvNTBbEHmoxKSk8lTxkQ3bQCnkjsXfrZIMbJRIAISiZHlbpUtGei8Wp18zEln9uU1GoSQPzGTgxsw7nD9iU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629330325; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=M5WE+Q4LlArN1XoDhzuWOJAWgtGzQxH2GDjTXzsuoNQ=; b=L1UPxTRjNIz5lr8WjL85fXK3Z/UKjMuWXRVNlDYQGYR9Qf/xk/Gfppv5h6ELdCfi4H/vypfhUIIB8WeyplkyUZ2FhNoj/qYA7F6Ho5n8oBMRx8Kkkve3xyOq9t2uNaDzEcaiM50PqcLO2lkBHSfW/0InFrevRL12KD/c8XXhjus= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79543+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629330325438370.2064191299819; Wed, 18 Aug 2021 16:45:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id uIySYY1788612xhKUx3Zi6ft; Wed, 18 Aug 2021 16:45:24 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.63179.1629330322649603814 for ; Wed, 18 Aug 2021 16:45:23 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10080"; a="216180089" X-IronPort-AV: E=Sophos;i="5.84,333,1620716400"; d="scan'208";a="216180089" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2021 16:45:21 -0700 X-IronPort-AV: E=Sophos;i="5.84,333,1620716400"; d="scan'208";a="531894410" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.212.191.175]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2021 16:45:21 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran Subject: [edk2-devel] [edk2-libc Patch] StdLib/LibC/Uefi/Devices/Utility: Fix use after free Date: Wed, 18 Aug 2021 16:45:13 -0700 Message-Id: <20210818234513.571-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: zEBekudQsDMnk1iAL7g7dZGCx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629330324; bh=ZZ4tH7ERB9fxVsI5ULbbdhLFzsvr7nnEAHXJWNdv6pE=; h=Cc:Date:From:Reply-To:Subject:To; b=iNMCDu68LsI7MnLiXLT4h+fSCnrqYmWi4VrXjpqsri5kV7GHSweLlvfo9tTkqnIYDZ8 9PAllen8tZkyvnlLELSl3a6JUw+7NLxNkiF4lpRXg9pdjf3Cn8SXgQq6KLrRcf7kG/y76 4BWOwUCis42S6SunRudQRpVZG18wgh4x2xo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629330327428100001 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D38 Set MPath to NULL after free(MPath) to guarantee that MPath is not used after the free() call. Cc: Rebecca Cran Signed-off-by: Michael D Kinney Reviewed-by: Rebecca Cran --- StdLib/LibC/Uefi/Devices/Utility/Path.c | 1 + 1 file changed, 1 insertion(+) diff --git a/StdLib/LibC/Uefi/Devices/Utility/Path.c b/StdLib/LibC/Uefi/Dev= ices/Utility/Path.c index d6728d3..fe19196 100644 --- a/StdLib/LibC/Uefi/Devices/Utility/Path.c +++ b/StdLib/LibC/Uefi/Devices/Utility/Path.c @@ -359,6 +359,7 @@ reclassify: } else if(MPath !=3D NULL) { free(MPath); /* Caller doesn't want it so let MPath go free */ + MPath =3D NULL; } =20 /* At this point, WPath is an absolute path, --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79543): https://edk2.groups.io/g/devel/message/79543 Mute This Topic: https://groups.io/mt/84985779/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-