From nobody Sun Nov 10 21:18:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79463+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79463+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1629265346; cv=none; d=zohomail.com; s=zohoarc; b=XcmHvgLD2K7EVP4+q4oB2Z7xmwyFsgUxPIE3iFJ1+mmcBdUS226YVovOzEDB+UqIHAU2HeAKllwSvNE4p/mQFdGwvWqrKUiv9zl49a8OaROEh4Po4kOQKN4x+0p9iXihk7+LogaxUNMxcMxtlmh1F5OPiTj4W9kVrjdn/Kf+kL8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629265346; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=NIkKoB0k33jStdWcAolAqWeQwiSzI/mwPAXVzGZXuec=; b=HNjlaLHoS1wwZVNXx+LIAw/ZowihS5YO0RWd2l2P4X368L88htzg/L0OMWmo2dj6HdatZqNtuM2yw5GRggNhcm4pv9e0dK2QnDFcX176EeT5dW1FwENcGCkON2xeoz7eOr2WvO282SD9L1bE8wXGWXOeT1PXKgGeC6iAAiAG56A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79463+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629265346565180.94461599840145; Tue, 17 Aug 2021 22:42:26 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PVg1YY1788612x6KJa03Th7o; Tue, 17 Aug 2021 22:42:26 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.50435.1629265341708850809 for ; Tue, 17 Aug 2021 22:42:23 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="277283646" X-IronPort-AV: E=Sophos;i="5.84,330,1620716400"; d="scan'208";a="277283646" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 22:42:21 -0700 X-IronPort-AV: E=Sophos;i="5.84,330,1620716400"; d="scan'208";a="676909204" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.89.84]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 22:42:21 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran Subject: [edk2-devel] [edk2-libc Patch 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function. Date: Tue, 17 Aug 2021 22:42:01 -0700 Message-Id: <20210818054206.1223-5-michael.d.kinney@intel.com> In-Reply-To: <20210818054206.1223-1-michael.d.kinney@intel.com> References: <20210818054206.1223-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: RDgSIPoVv6I0a8pKf5QIhrZ8x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629265346; bh=8P1Qhrs3+n5ECZ6Bm7gauRUTl9uSc2qyna1MoJj9zNo=; h=Cc:Date:From:Reply-To:Subject:To; b=AyqfJ/+BB9+R/gWYwaKwwzzHtoQhUCTdvSSK2Mogd/vDhw4ZnilYS22co6AFCNbg83i nsRCnySe52uraT6uEs8ppOO0AU+Q+ex2AVKd7vAiaGts08Nbavt8/G/JY8uJ7EEDSG2Pq vif1VCEPi/n/X5lT4jCvea3f1+NWWBl+XsA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629265347666100021 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3549 Removing the ldtoa.c file from the INF removes the ldtoa() function from this library. The ldtoa() function is not used and when /WHOLEARCHIVE linker flag is enabled this unused function makes references to other functions that are not implemented and that generates a link failure. Removing the unused source file resolves the link failure. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/LibC/gdtoa/gdtoa.inf | 1 - 1 file changed, 1 deletion(-) diff --git a/StdLib/LibC/gdtoa/gdtoa.inf b/StdLib/LibC/gdtoa/gdtoa.inf index 08ef5e0..51def1c 100644 --- a/StdLib/LibC/gdtoa/gdtoa.inf +++ b/StdLib/LibC/gdtoa/gdtoa.inf @@ -52,7 +52,6 @@ =20 # Private interfaces interfacing to libc dtoa.c - ldtoa.c gdtoa.c =20 # private interfaces --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79463): https://edk2.groups.io/g/devel/message/79463 Mute This Topic: https://groups.io/mt/84966615/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-