From nobody Sat May 4 00:17:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79240+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79240+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1628831114; cv=none; d=zohomail.com; s=zohoarc; b=HiRLu8kINddiU0lUOpSF2d7DgAt/8ClolvGfRKU+/mWmJCaf7IDir9/L5z4j7V4QJhLpHNOJtyYEUyKv77SxX7fuFA6Ri3h2QqBY4KRcDgkrmAowfZsE2bIuspif1H6VfuSYPcD7ESssAxLtQ08CyO4cdvlHU8bredjqq2xnp5E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628831114; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=dWf5YXcNY4ANjxg7xvtD1H564I3HKnZOny93LnVoicQ=; b=gbv2xu3z2fhu8BmnTnCbagLIRWy5DHTk2p4W5HL8CpPHhyBuqFGehP3EqaS8lxpPTL+iIiqCsTtdeUxnow3SHfslQL/R49Wk0NaFEmGlnLK/dsTgZ7xloP67XKvsC1TiU0gxEjjGTuJ3OY8MkycVZBWdlARNB0glDjgiqDC7PR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79240+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1628831114435112.07024830762111; Thu, 12 Aug 2021 22:05:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5M12YY1788612xg10F8YsHxU; Thu, 12 Aug 2021 22:05:14 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.32751.1628831112888552588 for ; Thu, 12 Aug 2021 22:05:13 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 481ED1063; Thu, 12 Aug 2021 22:05:11 -0700 (PDT) X-Received: from u200856.usa.arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC8633F70D; Thu, 12 Aug 2021 22:05:10 -0700 (PDT) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: pete@akeo.ie, ardb+tianocore@kernel.org, leif@nuviainc.com, awarkentin@vmware.com, Sunny.Wang@arm.com, samer.el-haj-mahmoud@arm.com, Jeremy Linton Subject: [edk2-devel] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field Date: Fri, 13 Aug 2021 00:05:08 -0500 Message-Id: <20210813050508.28232-1-jeremy.linton@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com X-Gm-Message-State: pmikvPZOoSyHuGdeXYXf4LvWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1628831114; bh=nKDeffndLM/pVlk1/9EJ6SBjjhyt97xWTkOj4TVVML4=; h=Cc:Date:From:Reply-To:Subject:To; b=V50IvZzGt1A145caherxBJ8RC0pyRfv0/82IE5bWXKy3nqdP/Dc9kNPGiH8XsrEv7dQ 8vsuLKgZ39Lom95izqW5KUUJ7XtMn1XZb9EmRd90q6qo125XxxB947APplduOf8CjzMIS 7AWQyqPVtggr5pkR/j4HIZV3vT3XuEwdG90= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1628831116070100001 Content-Type: text/plain; charset="utf-8" Map->Operation is used to select whether a DMA region that is being bounced has the source buffer copied to it. Except Map->Operation isn't yet set, so the behavior is somewhat random. Instead use the passed in Operation parameter. Signed-off-by: Jeremy Linton --- EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c b/Em= beddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c index 9c8ef5bfb5..1aec86fffd 100644 --- a/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c +++ b/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c @@ -224,7 +224,7 @@ DmaMap ( goto FreeMapInfo; } =20 - if (Map->Operation =3D=3D MapOperationBusMasterRead) { + if (Operation =3D=3D MapOperationBusMasterRead) { CopyMem (Map->BufferAddress, (VOID *)(UINTN)HostAddress, *NumberOfBy= tes); } mCpu->FlushDataCache (mCpu, (UINTN)Map->BufferAddress, AllocSize, --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79240): https://edk2.groups.io/g/devel/message/79240 Mute This Topic: https://groups.io/mt/84857084/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-