From nobody Tue Feb 10 11:15:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79042+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79042+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1628613654; cv=none; d=zohomail.com; s=zohoarc; b=ZK0f65ywHS27EN2EWpFHz+sPmDFCSDoe34sd9Y3n+RlWAkZEs9CQDVwzzsUe+HCCwJ7QZqUmU6FHMMsaTwlorUnIFNMcAgBu5fXcdg2fIHY/dpRz3MJvtj0RWqujDQ8GaeWha+pXTGPZu2KpbbakOExSpbhIxexo80nzpkDUu5w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628613654; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=VySOw+DGlNgIJnlXJab9CZbBBroPmV80nDmHHnXwHdE=; b=GW1pM7qzmvC6bYm36OBPN0gsJW3OI47M4S7tsoFMMO4YCadAjdWcQPSOQEW1W60Jnt2idkvBYWVDYabcULlWkyOXRq8bPBMG36EK1IyObu7+g9NOwp6Jh93Mq5kaPb7YS9FqRks6eiU0BvOEyYlgvvs834zexIsa40EOyYCBpm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79042+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1628613654539863.0864799294136; Tue, 10 Aug 2021 09:40:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id MjLpYY1788612xXm0EtMouOF; Tue, 10 Aug 2021 09:40:54 -0700 X-Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web10.68.1628613653009596832 for ; Tue, 10 Aug 2021 09:40:53 -0700 X-Received: by mail-wm1-f45.google.com with SMTP id g138so1677178wmg.4 for ; Tue, 10 Aug 2021 09:40:52 -0700 (PDT) X-Gm-Message-State: 0l3wIl0clpKaCprxKwyITPzpx1787277AA= X-Google-Smtp-Source: ABdhPJywk8teI1y2yMSDNkL0DKT0bRhMBCnG3NOi/19qJZ+oZzWeX66Rs8fX0nPD4Jav/PodP6tObA== X-Received: by 2002:a05:600c:294a:: with SMTP id n10mr12351797wmd.67.1628613651548; Tue, 10 Aug 2021 09:40:51 -0700 (PDT) X-Received: from lmecxl0524.lme.st.com ([2a04:cec0:10c1:ef71:f5e6:d24:9eea:1973]) by smtp.gmail.com with ESMTPSA id i3sm3196261wmb.17.2021.08.10.09.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 09:40:51 -0700 (PDT) From: "Etienne Carriere" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Ilias Apalodimas , Leif Lindholm , Sami Mujawar , Sughosh Ganu , Thomas Abraham , Etienne Carriere Subject: [edk2-devel] [PATCH v3 5/6] Drivers/OpTee: address cast build warning issue in 32b mode Date: Tue, 10 Aug 2021 18:40:35 +0200 Message-Id: <20210810164036.15199-6-etienne.carriere@linaro.org> In-Reply-To: <20210810164036.15199-1-etienne.carriere@linaro.org> References: <20210810164036.15199-1-etienne.carriere@linaro.org> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,etienne.carriere@linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1628613654; bh=jdtFhA6ChWOwh2gF/53URAJSBMzNkeK+OJjOGeJEd0k=; h=Cc:Date:From:Reply-To:Subject:To; b=ndC5AXARWDMk9KOIYlUs9buCJYb85YIAYG55Df2Q4T74607YnFB8LOGHCrsydKDoKxw xeDc2BWpFTEShp1MYgGkf3nu2K0irGIOl6R14S6U+MjuLcURSPe2a30ofYcxa1+FTQxJh Npg6JLueJJicEUQH0eJmC46RQ3R0jiOAOHE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1628613655361100008 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use (UINTN) cast to cast physical or virtual address values to the pointer size before casting from/to a pointer value. Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Etienne Carriere --- No change since v2 No change since v1 --- Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 21 +++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c b/Drivers/OpTee/Opte= eRpmbPkg/OpTeeRpmbFvb.c index 6eb19bed0e..83c2750368 100644 --- a/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c +++ b/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c @@ -305,7 +305,8 @@ OpTeeRpmbFvbRead ( } } =20 - Base =3D (VOID *)Instance->MemBaseAddress + (Lba * Instance->BlockSize) = + Offset; + Base =3D (VOID *)(UINTN)Instance->MemBaseAddress + (Lba * Instance->Bloc= kSize) + + Offset; // We could read the data from the RPMB instead of memory // The 2 copies should already be identical // Copy from memory image @@ -387,7 +388,8 @@ OpTeeRpmbFvbWrite ( return Status; } } - Base =3D (VOID *)Instance->MemBaseAddress + Lba * Instance->BlockSize + = Offset; + Base =3D (VOID *)(UINTN)Instance->MemBaseAddress + (Lba * Instance->Bloc= kSize) + + Offset; Status =3D ReadWriteRpmb ( SP_SVC_RPMB_WRITE, (UINTN)Buffer, @@ -477,7 +479,8 @@ OpTeeRpmbFvbErase ( return EFI_INVALID_PARAMETER; } NumBytes =3D NumLba * Instance->BlockSize; - Base =3D (VOID *)Instance->MemBaseAddress + Start * Instance->BlockSiz= e; + Base =3D (VOID *)(UINTN)Instance->MemBaseAddress + + (Start * Instance->BlockSize); Buf =3D AllocatePool (NumLba * Instance->BlockSize); if (Buf =3D=3D NULL) { return EFI_DEVICE_ERROR; @@ -689,7 +692,7 @@ InitializeFvAndVariableStoreHeaders ( goto Exit; } // Install the combined header in memory - CopyMem ((VOID*)Instance->MemBaseAddress, Headers, HeadersLength); + CopyMem ((VOID*)(UINTN)Instance->MemBaseAddress, Headers, HeadersLength); =20 Exit: FreePool (Headers); @@ -747,14 +750,18 @@ FvbInitialize ( // Read the file from disk and copy it to memory ReadEntireFlash (Instance); =20 - FwVolHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)Instance->MemBaseAddress; + FwVolHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)(UINTN)Instance->MemBaseAd= dress; Status =3D ValidateFvHeader (FwVolHeader); if (EFI_ERROR (Status)) { // There is no valid header, so time to install one. DEBUG ((DEBUG_INFO, "%a: The FVB Header is not valid.\n", __FUNCTION__= )); =20 // Reset memory - SetMem64 ((VOID *)Instance->MemBaseAddress, Instance->NBlocks * Instan= ce->BlockSize, ~0UL); + SetMem64 ( + (VOID *)(UINTN)Instance->MemBaseAddress, + Instance->NBlocks * Instance->BlockSize, + ~0UL + ); DEBUG ((DEBUG_INFO, "%a: Erasing Flash.\n", __FUNCTION__)); Status =3D ReadWriteRpmb ( SP_SVC_RPMB_WRITE, @@ -827,7 +834,7 @@ OpTeeRpmbFvbInit ( mInstance.FvbProtocol.Write =3D OpTeeRpmbFvbWrite; mInstance.FvbProtocol.Read =3D OpTeeRpmbFvbRead; =20 - mInstance.MemBaseAddress =3D (EFI_PHYSICAL_ADDRESS)Addr; + mInstance.MemBaseAddress =3D (EFI_PHYSICAL_ADDRESS)(UINTN)Addr; mInstance.Signature =3D FLASH_SIGNATURE; mInstance.Initialize =3D FvbInitialize; mInstance.BlockSize =3D EFI_PAGE_SIZE; --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79042): https://edk2.groups.io/g/devel/message/79042 Mute This Topic: https://groups.io/mt/84797251/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-