From nobody Sun May 5 09:07:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+78913+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78913+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1628476074; cv=none; d=zohomail.com; s=zohoarc; b=ddbBhfJnTIBt9iJ3Cf1UQaOBZ/wXL6rt9lKSH3J/kRjwu1Lwdf2qehrA5Yt04oaIbmaSMu0NPY9i069ZEhU5yLouVA1lz/pjG904LdC3nAsxthqLiGRALi/MFQx4Hgs6IG6X3OHW/CGvmuvlhI3hGGa9HA15ij+Qcg3xdPYDBa8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628476074; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=QYF21tVSDvpuylupb3+LlLUD2rRWqvr5emgbR58sgrU=; b=AB69wzbZKsmbELnwlsqV2DJtJnW7Cqgqbjm5fzy6zVqfy3diXoAyupJSvqHimNbtjbW9RnWu2Cy6zR9ftQFlK4/1qvEDOg2CLIsAGwXz+5faDpXmTi0ajReb2emESe8DhYa4pbZjk0Yy3K+E5okYjQcuUoU/wvME2b5eGvee4MM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78913+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1628476074160720.7115274796805; Sun, 8 Aug 2021 19:27:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tdOzYY1788612xJ3DkYpRJno; Sun, 08 Aug 2021 19:27:53 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.17670.1628476072427400780 for ; Sun, 08 Aug 2021 19:27:52 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="194878634" X-IronPort-AV: E=Sophos;i="5.84,305,1620716400"; d="scan'208";a="194878634" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2021 19:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,305,1620716400"; d="scan'208";a="438779378" X-Received: from chinghux-desk1.gar.corp.intel.com ([10.5.215.161]) by orsmga002.jf.intel.com with ESMTP; 08 Aug 2021 19:27:49 -0700 From: "GregX Yeh" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Dandan Bi , Liming Gao Subject: [edk2-devel] [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay Date: Mon, 9 Aug 2021 10:27:32 +0800 Message-Id: <20210809022732.1753-1-gregx.yeh@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gregx.yeh@intel.com X-Gm-Message-State: 9mJDuA4wbgqpN0wtUEcrBfCtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1628476073; bh=l0iXaTTRR9YGIqUWIRM2cEq9Y/OnzfYIcc8AiFr+DFA=; h=Cc:Date:From:Reply-To:Subject:To; b=oh5mpuV6KwPLT93XXEbknQk5riCGuEzoDxXsqO0zY9axXS7VTKoFLa5lPZLTcL0tHIq Az3MkndLBXZeejaq9eTFxXwniNt9wJOR5bhT6c1D/00ZdyK+Wddw7Ax+uPw1l1Mh2i7cd 5sZThdC5MruUSi6RfBZOd6ZCa6WRebmESU0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1628476075139100002 Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D3525 After PciSegmentLib using Dynamic PCD for Pcie base address such long delay found in FSP. The root cause is some of the PCD service PPIs not shadowed to memory and flash cache may have been disabled in NotifyPhase stage. Solution is to shadow all PCD service PPIs to memory. Signed-off-by: GregX Yeh Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Reviewed-by: Jian J Wang --- MdeModulePkg/Universal/PCD/Pei/Pcd.c | 71 +++++++++++++++++++++++++++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/PCD/Pei/Pcd.c b/MdeModulePkg/Universal/= PCD/Pei/Pcd.c index 9c6346924f..f31e0be35f 100644 --- a/MdeModulePkg/Universal/PCD/Pei/Pcd.c +++ b/MdeModulePkg/Universal/PCD/Pei/Pcd.c @@ -1,7 +1,7 @@ /** @file All Pcd Ppi services are implemented here. =20 -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
(C) Copyright 2016 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -339,6 +339,75 @@ PcdPeimInit ( { EFI_STATUS Status; =20 + Status =3D PeiServicesRegisterForShadow (FileHandle); + if (Status =3D=3D EFI_ALREADY_STARTED) { + // + // This is now starting in memory, the second time starting. + // + EFI_PEI_PPI_DESCRIPTOR *OldPpiList; + EFI_PEI_PPI_DESCRIPTOR *OldPpiList2; + VOID *Ppi; + VOID *Ppi2; + + OldPpiList =3D NULL; + Status =3D PeiServicesLocatePpi ( + &gPcdPpiGuid, + 0, + &OldPpiList, + &Ppi + ); + ASSERT_EFI_ERROR (Status); + + if (OldPpiList !=3D NULL) { + Status =3D PeiServicesReInstallPpi (OldPpiList, &mPpiList[0]); + ASSERT_EFI_ERROR (Status); + } + + OldPpiList2 =3D NULL; + Status =3D PeiServicesLocatePpi ( + &gGetPcdInfoPpiGuid, + 0, + &OldPpiList2, + &Ppi2 + ); + ASSERT_EFI_ERROR (Status); + + if (OldPpiList2 !=3D NULL) { + Status =3D PeiServicesReInstallPpi (OldPpiList2, &mPpiList2[0]); + ASSERT_EFI_ERROR (Status); + } + + OldPpiList =3D NULL; + Status =3D PeiServicesLocatePpi ( + &gEfiPeiPcdPpiGuid, + 0, + &OldPpiList, + &Ppi + ); + ASSERT_EFI_ERROR (Status); + + if (OldPpiList !=3D NULL) { + Status =3D PeiServicesReInstallPpi (OldPpiList, &mPpiList[1]); + ASSERT_EFI_ERROR (Status); + } + + OldPpiList2 =3D NULL; + Status =3D PeiServicesLocatePpi ( + &gEfiGetPcdInfoPpiGuid, + 0, + &OldPpiList2, + &Ppi2 + ); + ASSERT_EFI_ERROR (Status); + + if (OldPpiList2 !=3D NULL) { + Status =3D PeiServicesReInstallPpi (OldPpiList2, &mPpiList2[1]); + ASSERT_EFI_ERROR (Status); + } + + return Status; + } + BuildPcdDatabase (FileHandle); =20 // --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78913): https://edk2.groups.io/g/devel/message/78913 Mute This Topic: https://groups.io/mt/84760812/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-