[edk2-devel] [edk2-platforms PATCH v5 0/2] Add BootDiscoveryPolicyUiLib

Grzegorz Bernacki posted 2 patches 2 years, 7 months ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/RaspberryPi.dec                                           |   2 -
Platform/RaspberryPi/RPi3/RPi3.dsc                                             |   9 +-
Platform/RaspberryPi/RPi4/RPi4.dsc                                             |  12 +--
Platform/RaspberryPi/RPi4/RPi4.fdf                                             |   1 +
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf                           |   3 +-
Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |   6 +-
Platform/RaspberryPi/Include/ConfigVars.h                                      |  12 +--
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr                        |  16 +--
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c                             |  11 +--
Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c               | 102 +++++++++++++++++---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni                        |  10 +-
MdeModulePkg/MdeModulePkg.dec                                                     |   9 ++
MdeModulePkg/MdeModulePkg.dsc                                                     |   2 +
MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf        |  52 +++++++
MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h                                   |  22 +++
MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c          | 160 ++++++++++++++++++++
MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni        |  18 +++
MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStrings.uni |  29 ++++
MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.Vfr     |  44 ++++++
19 files changed, 443 insertions(+), 77 deletions(-)
create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf
create mode 100644 MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h
create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c
create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni
create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStrings.uni
create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.Vfr
[edk2-devel] [edk2-platforms PATCH v5 0/2] Add BootDiscoveryPolicyUiLib
Posted by Grzegorz Bernacki 2 years, 7 months ago
This patchset extends Boot Maintenance Menu and allows to select
Boot Discovery Policy. Raspberry Pi platforms uses the variable to
connect specified class of devices on boot. This patchset also
removes efdc159e which has similar functionality.

Discussion on design can be found at:
https://edk2.groups.io/g/rfc/topic/rfc_boot_discovery_policy/82450628

Changes since v1:
- make 'Connect All' (0x2) default value for PcdBootDiscoveryPolicy
- initialize BootDiscoveryPolicy variable in platform code, if not found

Changes since v2:
- add missing local variable initialization

Changes since v3:
- add description to PcdBootDiscoveryPolicy

Changes since v4:
- fixed coding style
- add module to MdeModulePkg.dsc

Grzegorz Bernacki (3):
edk2:
  MdeModulePkg: Add BootDiscoveryPolicyUiLib.
edk2-platform
  Platform/RaspberryPi: Enable Boot Discovery Policy.
  Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"

 Platform/RaspberryPi/RaspberryPi.dec                                           |   2 -
 Platform/RaspberryPi/RPi3/RPi3.dsc                                             |   9 +-
 Platform/RaspberryPi/RPi4/RPi4.dsc                                             |  12 +--
 Platform/RaspberryPi/RPi4/RPi4.fdf                                             |   1 +
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf                           |   3 +-
 Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |   6 +-
 Platform/RaspberryPi/Include/ConfigVars.h                                      |  12 +--
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr                        |  16 +--
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c                             |  11 +--
 Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c               | 102 +++++++++++++++++---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni                        |  10 +-
 MdeModulePkg/MdeModulePkg.dec                                                     |   9 ++
 MdeModulePkg/MdeModulePkg.dsc                                                     |   2 +
 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf        |  52 +++++++
 MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h                                   |  22 +++
 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c          | 160 ++++++++++++++++++++
 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni        |  18 +++
 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStrings.uni |  29 ++++
 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.Vfr     |  44 ++++++
 19 files changed, 443 insertions(+), 77 deletions(-)
 create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf
 create mode 100644 MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h
 create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c
 create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni
 create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStrings.uni
 create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.Vfr

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78512): https://edk2.groups.io/g/devel/message/78512
Mute This Topic: https://groups.io/mt/84609665/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH v5 0/2] Add BootDiscoveryPolicyUiLib
Posted by Ard Biesheuvel 2 years, 7 months ago
On Mon, 2 Aug 2021 at 14:18, Grzegorz Bernacki <gjb@semihalf.com> wrote:
>
> This patchset extends Boot Maintenance Menu and allows to select
> Boot Discovery Policy. Raspberry Pi platforms uses the variable to
> connect specified class of devices on boot. This patchset also
> removes efdc159e which has similar functionality.
>
> Discussion on design can be found at:
> https://edk2.groups.io/g/rfc/topic/rfc_boot_discovery_policy/82450628
>
> Changes since v1:
> - make 'Connect All' (0x2) default value for PcdBootDiscoveryPolicy
> - initialize BootDiscoveryPolicy variable in platform code, if not found
>
> Changes since v2:
> - add missing local variable initialization
>
> Changes since v3:
> - add description to PcdBootDiscoveryPolicy
>
> Changes since v4:
> - fixed coding style
> - add module to MdeModulePkg.dsc
>
> Grzegorz Bernacki (3):
> edk2:
>   MdeModulePkg: Add BootDiscoveryPolicyUiLib.
> edk2-platform
>   Platform/RaspberryPi: Enable Boot Discovery Policy.
>   Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"
>

Pete, Andrei: any comments on this?

>  Platform/RaspberryPi/RaspberryPi.dec                                           |   2 -
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                             |   9 +-
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                             |  12 +--
>  Platform/RaspberryPi/RPi4/RPi4.fdf                                             |   1 +
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf                           |   3 +-
>  Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |   6 +-
>  Platform/RaspberryPi/Include/ConfigVars.h                                      |  12 +--
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr                        |  16 +--
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c                             |  11 +--
>  Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c               | 102 +++++++++++++++++---
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni                        |  10 +-
>  MdeModulePkg/MdeModulePkg.dec                                                     |   9 ++
>  MdeModulePkg/MdeModulePkg.dsc                                                     |   2 +
>  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf        |  52 +++++++
>  MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h                                   |  22 +++
>  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c          | 160 ++++++++++++++++++++
>  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni        |  18 +++
>  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStrings.uni |  29 ++++
>  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.Vfr     |  44 ++++++
>  19 files changed, 443 insertions(+), 77 deletions(-)
>  create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf
>  create mode 100644 MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h
>  create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c
>  create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni
>  create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStrings.uni
>  create mode 100644 MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.Vfr
>
> --
> 2.25.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78581): https://edk2.groups.io/g/devel/message/78581
Mute This Topic: https://groups.io/mt/84609665/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-