From nobody Mon Apr 29 07:15:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+78379+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78379+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1627570510; cv=none; d=zohomail.com; s=zohoarc; b=Xq7ePf5k5Eu30IBH4dfc6BoQ6CzagZNho1bpM2OqgidH82XX9qoHMtJrbroC2QQXj7zRQS2SjAqVg/i8/4KBzeR26P+0HjDYMmRNEaVPKG81rCG3s3LmPdgjpbrLHy3wHDwaGaT75xv2wJ3ZvP4e4K42TCpWOIqNhUatyKWTpv8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627570510; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=hd3XSkf1mAtZHvMEtnWoqb+f7pRKjMWJw/SKgNJPVL8=; b=dfPAett12VnBkL0kPASP8CD+oeqKRNxGGMxwqBgI9v4GbwJ+jT2/F9+SM/706FRPOQwh+UPc30Y9tJ7rOb2Nr+gV7kvZGUPvYLe/HH1T9MeyKQu+MHJ8Z8SQQ91Rxyz8EhKl1h+uLl/Py3H+M4xp3qvtMQXpuPIiIbioDW2Mvlk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78379+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1627570510965764.7654625916156; Thu, 29 Jul 2021 07:55:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CjcCYY1788612xoZZJR27dvu; Thu, 29 Jul 2021 07:55:10 -0700 X-Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mx.groups.io with SMTP id smtpd.web08.10766.1627570510085347304 for ; Thu, 29 Jul 2021 07:55:10 -0700 X-Received: by mail-pj1-f51.google.com with SMTP id j1so10666205pjv.3 for ; Thu, 29 Jul 2021 07:55:10 -0700 (PDT) X-Gm-Message-State: 6NPRIRExRvpaI6OZQxw45p1Cx1787277AA= X-Google-Smtp-Source: ABdhPJwAkBdiw1eybSCJp24M3oYsD9DFDIFpxu9a5nIKoeZNgE8lHrGADL51wCFYDIwCAZpKitqGpA== X-Received: by 2002:a63:4c03:: with SMTP id z3mr4129445pga.130.1627570509244; Thu, 29 Jul 2021 07:55:09 -0700 (PDT) X-Received: from localhost.localdomain (fp93c0ba2e.oski110.ap.nuro.jp. [147.192.186.46]) by smtp.googlemail.com with ESMTPSA id 20sm4198871pfi.170.2021.07.29.07.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:55:08 -0700 (PDT) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Takuto Naito , Agyeman Prince Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution Date: Thu, 29 Jul 2021 14:54:11 +0000 Message-Id: <20210729145411.23659-2-naitaku@gmail.com> In-Reply-To: <20210729145411.23659-1-naitaku@gmail.com> References: <20210729145411.23659-1-naitaku@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,naitaku@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1627570510; bh=gCy3rYDiKnePnp7ePO7CkQ12XKni3uF6JN8Lu7mcNAs=; h=Cc:Date:From:Reply-To:Subject:To; b=cZTlTfT2mqkg19nzOhBzS0ZMQ0pEXqpV3lVNFSyEkYVNyB41wDf6ZWkQUru8BqqnbzO CIBItM3U/yNwV7m5yRGG/6rDd4ifI224HM1JfhtICI4p3G1Knm1ebEgZKI65SLOuIEW7+ BbyTSOQqBbiSWil92GYhpdFvPP9lItin2ZA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1627570513253100001 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3514 PcdVideoHorizontalResolution and PcdVideoVerticalResolutio are set in the SimicsDxe module and consumed by the other module GraphicsConsoleDxe. In this case, the type of these PCDs should be Dynamic. Cc: Agyeman Prince Signed-off-by: Takuto Naito Reviewed-by: Michael D Kinney --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPc= d.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc index 251f46f812..88009b8f10 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc @@ -221,8 +221,6 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 !endif gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024 - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 =20 ###################################### @@ -238,6 +236,8 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024 + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 =20 ###################################### # Board Configuration --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78379): https://edk2.groups.io/g/devel/message/78379 Mute This Topic: https://groups.io/mt/84529697/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-