From nobody Sun May 5 04:41:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77841+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77841+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1626470325; cv=none; d=zohomail.com; s=zohoarc; b=cw6dUndwak6N0EGWx641yEGJcV69As0sBVb1wo00YiWLaHCqydB+s8RXMQygi+Z5We91cUwhPjMtfta27mddoEWiO8f/yOsuEoM/6oI7Rg/jR92HXt/zPsOlGbfTBvAjudV2mII3ptAr/3bUNKvThiIEJkiILFtLcpjtMpYYP0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626470325; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=DcP/NYZSbr98ZrHyprfMc5TfoFg1IULiVj+26QlZt7w=; b=dZPINWu3dSsJzz5RHh1ArIn13HrLNzme1b++aoeAqk7XXLqbEL/1Nl9O7RIqHqjHX6wYt5+5lYe24PwIMrRw3jzKrORmcpRWtMoxaD2BHQWSuliPWA7c3IRVkadpa0RyTaaghqqdoJPrDm0D9SbliYVpuiA4PUVAkOeHFThxt5w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77841+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1626470325560731.8783830161193; Fri, 16 Jul 2021 14:18:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id P7UkYY1788612xP5hPaFZBbq; Fri, 16 Jul 2021 14:18:45 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.382.1626470323909873709 for ; Fri, 16 Jul 2021 14:18:44 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10047"; a="207765458" X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="207765458" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 14:18:43 -0700 X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="431336934" X-Received: from fm73lab177-1.amr.corp.intel.com ([10.80.209.189]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 14:18:41 -0700 From: "Rodrigo Gonzalez del Cueto" To: devel@edk2.groups.io Cc: Rodrigo Gonzalez del Cueto , Jian J Wang , Jiewen Yao Subject: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion. Date: Fri, 16 Jul 2021 14:18:17 -0700 Message-Id: <20210716211817.263-1-rodrigo.gonzalez.del.cueto@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rodrigo.gonzalez.del.cueto@intel.com X-Gm-Message-State: 8aslIdeCbtVlB1YkqneOnFcqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1626470325; bh=2DXcptTGrEY2El6OpTRuCiXicK+d19n3WkkmCtSfS1g=; h=Cc:Date:From:Reply-To:Subject:To; b=o1nvju7MVHqstvILm9SmgWaRxJev+hrpXrwEvdZcny9SJ59NxJo4aQq6iT2aVvfFEsT zcqb8G0cj3ObkhWH5Q+tsGHrDq78+xBTzf1jzZMSrIm0E5KVCrCMFfeIw16bEFH9nt2Hp Hch7l5J2tla1uGFjQM5L3huxMZPHod0MhRw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1626470326133100002 Content-Type: text/plain; charset="utf-8" To follow the TCG CRB protocol specification, on every CRB TPM command completion the TPM should return to Idle state, regardless of the CRB Idle Bypass capability reported by the TPM device. See: TCG PC Client Device Driver Design Principles for TPM 2.0, Version 1.0, Rev 0.27 Signed-off-by: Rodrigo Gonzalez del Cueto Cc: Jian J Wang Cc: Jiewen Yao Reviewed-by: Jiewen Yao --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c b/SecurityPkg/= Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c index f1f8091683..34e3874a5b 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c @@ -310,7 +310,7 @@ PtpCrbTpmCommand ( // Command completed, but buffer is not enough // Status =3D EFI_BUFFER_TOO_SMALL; - goto GoReady_Exit; + goto GoIdle_Exit; } *SizeOut =3D TpmOutSize; // @@ -328,16 +328,6 @@ PtpCrbTpmCommand ( DEBUG ((EFI_D_VERBOSE, "\n")); ); =20 -GoReady_Exit: - // - // Goto Ready State if command is completed successfully and TPM support= IdleBypass - // If not supported. flow down to GoIdle - // - if (GetCachedIdleByPass () =3D=3D 1) { - MmioWrite32((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_RE= QUEST_COMMAND_READY); - return Status; - } - // // Do not wait for state transition for TIMEOUT_C // This function will try to wait 2 TIMEOUT_C at the beginning in next c= all. --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77841): https://edk2.groups.io/g/devel/message/77841 Mute This Topic: https://groups.io/mt/84258803/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-