From nobody Tue May 7 07:05:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77743+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77743+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1626168434; cv=none; d=zohomail.com; s=zohoarc; b=f6IDv0wL/dijyEI2gHKLRM6X4quSOhJbDS1+WYNyvfd2fTRN8mv3w+RztajanG8Fm40LySBJiNTJAaQ+TOftPzJthgzz8vxIfMogxrUc+x/8KHlUhN7pCXNtyPEDchkMZ3X4MUlg9JXMqlWp6gD7eO3N0ERfj2HltEDQLD8GHEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626168434; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=MvJTF4XM/+78Zz4ehbLSWRHvWfqGGHaojMG8D1QzJ4Y=; b=B2LF8SZZucmpqT+Q8iw18F90OCoJ3ajRkNOCeF5l5hfJjiEFY+NfikVPET+Y0FVnUpvtczyzBnVE2Jnbt3kpGSwa6hcjiN9CAia8yHeq9KblLU0vC3IMsfK4f1gGrtTl0QZKzP80SzPH/qrb1n0wHzNHBE7xkkPaOyMfq/qv7dc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77743+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1626168434762800.7105709836832; Tue, 13 Jul 2021 02:27:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xBUNYY1788612xWGw22UPK9m; Tue, 13 Jul 2021 02:27:09 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.2113.1626168428500440481 for ; Tue, 13 Jul 2021 02:27:08 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="197404476" X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="197404476" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 02:27:01 -0700 X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="502994045" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.209.47.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 02:27:01 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Jeremy Soller , Michael Kubacki , Benjamin Doron Subject: [edk2-devel] [edk2-platforms][PATCH V1] KabylakeOpenBoardPkg: Implement the PEI Reset Services Date: Tue, 13 Jul 2021 02:26:48 -0700 Message-Id: <20210713092648.2222-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: FDKdasnk91MHpQv9d5jaBSvtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1626168429; bh=p5KgJR8Ta6gG2/FDd7STbNqqiidZbSkH6YOuV6saDlw=; h=Cc:Date:From:Reply-To:Subject:To; b=WR7tk14N5+bnrlVoJdOnoR+MUu64j8wxZHUPL5AkxZnL+zGVsSZnt+936+YyoX5K7Kf eMCcT+Vb2fy4visPazQJcgBxocrDIhzxDNhbCfTXlJNogwSrDj3NJKYBWPeMCD3hjx8cL CtkxMkuO/uQO70bMZA6d9BTNd+DrFxzo/LE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1626168435833100002 Content-Type: text/plain; charset="utf-8" This change implements the ResetSystem and ResetSystem2 PEI services for KabylakeRvp3 and GalagoPro3. The invocation of PchInitializeReset() was missing from BoardInitLib. Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Jeremy Soller Cc: Michael Kubacki Cc: Benjamin Doron Reviewed-by: Chasel Chiu --- .../Library/BoardInitLib/PeiBoardInitPreMemLib.inf | 3 ++- .../BoardInitLib/PeiGalagoPro3InitPreMemLib.c | 8 +++++++- .../BoardInitLib/PeiMultiBoardInitPreMemLib.inf | 3 ++- .../Library/BoardInitLib/PeiBoardInitPreMemLib.inf | 3 ++- .../BoardInitLib/PeiKabylakeRvp3InitPreMemLib.c | 13 +++++++++++-- .../BoardInitLib/PeiMultiBoardInitPreMemLib.inf | 3 ++- 6 files changed, 26 insertions(+), 7 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardIn= itLib/PeiBoardInitPreMemLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/Galag= oPro3/Library/BoardInitLib/PeiBoardInitPreMemLib.inf index e4b783684f..d6c91cd2b9 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P= eiBoardInitPreMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P= eiBoardInitPreMemLib.inf @@ -1,7 +1,7 @@ ## @file # Component information file for PEI GalagoPro3 Board Init Pre-Mem Library # -# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2021 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -22,6 +22,7 @@ MemoryAllocationLib PcdLib SiliconInitLib + PchResetLib =20 [Packages] MinPlatformPkg/MinPlatformPkg.dec diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardIn= itLib/PeiGalagoPro3InitPreMemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Ga= lagoPro3/Library/BoardInitLib/PeiGalagoPro3InitPreMemLib.c index ca32ab2514..6bf77a2af0 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P= eiGalagoPro3InitPreMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P= eiGalagoPro3InitPreMemLib.c @@ -1,7 +1,7 @@ /** @file System 76 GalagoPro3 board pre-memory initialization. =20 -Copyright (c) 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -209,6 +209,12 @@ GalagoPro3BoardInitBeforeMemoryInit ( /// SiliconInit (); =20 + // + // Install PCH RESET PPI and EFI RESET2 PeiService + // + Status =3D PchInitializeReset (); + ASSERT_EFI_ERROR (Status); + return EFI_SUCCESS; } =20 diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardIn= itLib/PeiMultiBoardInitPreMemLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/= GalagoPro3/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.inf index d866f59338..fe31f42135 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P= eiMultiBoardInitPreMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P= eiMultiBoardInitPreMemLib.inf @@ -1,7 +1,7 @@ ## @file # Component information file for PEI GalagoPro3 Board Init Pre-Mem Library # -# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2021 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +24,7 @@ PcdLib SiliconInitLib MultiBoardInitSupportLib + PchResetLib =20 [Packages] MinPlatformPkg/MinPlatformPkg.dec diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Board= InitLib/PeiBoardInitPreMemLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/Kab= ylakeRvp3/Library/BoardInitLib/PeiBoardInitPreMemLib.inf index d0cdba666f..850fc51418 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib= /PeiBoardInitPreMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib= /PeiBoardInitPreMemLib.inf @@ -1,7 +1,7 @@ ## @file # Component information file for PEI KabylakeRvp3 Board Init Pre-Mem Libra= ry # -# Copyright (c) 2017 - 2020 Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2021 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -23,6 +23,7 @@ PcdLib SiliconInitLib EcLib + PchResetLib =20 [Packages] MinPlatformPkg/MinPlatformPkg.dec diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Board= InitLib/PeiKabylakeRvp3InitPreMemLib.c b/Platform/Intel/KabylakeOpenBoardPk= g/KabylakeRvp3/Library/BoardInitLib/PeiKabylakeRvp3InitPreMemLib.c index 8f2e036356..d34b0be3c7 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib= /PeiKabylakeRvp3InitPreMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib= /PeiKabylakeRvp3InitPreMemLib.c @@ -1,6 +1,6 @@ /** @file =20 -Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -28,6 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include +#include =20 #include "PeiKabylakeRvp3InitLib.h" =20 @@ -282,6 +283,8 @@ KabylakeRvp3BoardInitBeforeMemoryInit ( VOID ) { + EFI_STATUS Status; + if (LibPcdGetSku () =3D=3D BoardIdKabyLakeYLpddr3Rvp3) { KabylakeRvp3InitPreMem (); } else if (LibPcdGetSku () =3D=3D BoardIdSkylakeRvp3) { @@ -297,12 +300,18 @@ KabylakeRvp3BoardInitBeforeMemoryInit ( =20 GpioInitPreMem (); SioInit (); - =20 + /// /// Do basic PCH init /// SiliconInit (); =20 + // + // Install PCH RESET PPI and EFI RESET2 PeiService + // + Status =3D PchInitializeReset (); + ASSERT_EFI_ERROR (Status); + return EFI_SUCCESS; } =20 diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Board= InitLib/PeiMultiBoardInitPreMemLib.inf b/Platform/Intel/KabylakeOpenBoardPk= g/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.inf index a51712ac34..23fe6b6f03 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib= /PeiMultiBoardInitPreMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib= /PeiMultiBoardInitPreMemLib.inf @@ -1,7 +1,7 @@ ## @file # Component information file for PEI KabylakeRvp3 Board Init Pre-Mem Libra= ry # -# Copyright (c) 2017 - 2020 Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2021 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -25,6 +25,7 @@ SiliconInitLib MultiBoardInitSupportLib EcLib + PchResetLib =20 [Packages] MinPlatformPkg/MinPlatformPkg.dec --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77743): https://edk2.groups.io/g/devel/message/77743 Mute This Topic: https://groups.io/mt/84174637/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-