From nobody Wed May 8 03:11:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77723+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77723+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1626138635552987.5254734793756; Mon, 12 Jul 2021 18:10:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Wh7qYY1788612xHvxBw6UqL7; Mon, 12 Jul 2021 18:10:35 -0700 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web12.2932.1626138634380919640 for ; Mon, 12 Jul 2021 18:10:34 -0700 X-Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16D14wnO030883; Tue, 13 Jul 2021 01:10:33 GMT X-Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 39rmk268sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jul 2021 01:10:33 +0000 X-Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 4F30953; Tue, 13 Jul 2021 01:10:32 +0000 (UTC) X-Received: from G9W8674.americas.hpqcorp.net (16.220.49.0) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 13 Jul 2021 01:10:04 +0000 X-Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G9W8674.americas.hpqcorp.net (2002:10dc:3100::10dc:3100) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 13 Jul 2021 01:10:03 +0000 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Tue, 13 Jul 2021 01:10:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QCuDfsB06YiNCj+1Nj9K9nH2ewu6xnIM0hSIn8A5DOoRybgPxsuVEEECAvJuKgYV/y5c/8oECEVWY2cxhLw8Cvzo1T0Y9ncO7Yc5P7dtBqKbgKTQrvkKnG+C9kbMn7KJ9qFYdJscXfFFqfRQ6M5E03uDK3i6iG6XJy0XHyHTzq/knA+CPQiQ65uu8/jI5+JZ4rSXb8cfbqw8j1iWX9iELYsuF1iCWfjfDHkR3qs0VgYiiUhAKmE8c20kwDfTETeREYOZZ3iSKu/93t+YQ/NSRc4RJwKZFD1z4NXyDnfwbedy1nMv65c/W/2HndTL3LIGCj5GevL6DBh40JP26/Juiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HP8eeNK4X5zdnVljQCQcMDXdESluhHQUhRzaOoNc4ZE=; b=Dno+WobsOjXRD7Um/uLB5hqZhYwLVDdbiQmjD4eccAIfXt66LpxqP9enlD+w2dQyZrELQAxnd1d9u0NjsCL0tuyIdFzr+4SEynZDKiLY0KzW5OSXO2HO5ENHgZo0qmgtu43ZRXj9MG6NAnyWUzOl8NiycWNduWiEv62gmGR7KhiPVbDXc8hLHjfyIzMoynV4PIsGKPrXSOG2dWnCjjOYmCQXyaCdupO6as5+7hwiw910Wtv+743/Gaaun9q9IjHfktbY0Y2/MuoA9rSKSlZoXHxKz99+1m3Chz/raajx7iV2dadtHNpyRPE3c4q0SaWYWGi7zQ4VU7XFeWhFVYT/BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB1100.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7611::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Tue, 13 Jul 2021 01:10:02 +0000 X-Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a%5]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 01:10:02 +0000 From: "Daniel Schaefer" To: CC: Trammell Hudson , Daniel Schaefer , Jian J Wang , Hao A Wu , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before registering RAM disk protocol Date: Tue, 13 Jul 2021 09:09:31 +0800 Message-ID: <20210713010931.445739-2-daniel.schaefer@hpe.com> In-Reply-To: <20210713010931.445739-1-daniel.schaefer@hpe.com> References: <20210713010931.445739-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: SA9PR13CA0168.namprd13.prod.outlook.com (2603:10b6:806:28::23) To DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from localhost.localdomain (123.193.59.220) by SA9PR13CA0168.namprd13.prod.outlook.com (2603:10b6:806:28::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.10 via Frontend Transport; Tue, 13 Jul 2021 01:10:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5271e6a-f139-41c8-8fda-08d9459af136 X-MS-TrafficTypeDiagnostic: DF4PR8401MB1100: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: xNGTEc4Gh9qMC2nAnGBDy+ZFNTyPi1OO+byx/wjvniUcdNFQwaLSzQ24TctT4Bt2eBzZlxmi9kBWkvEId1RoAj2DIDLJRCgwWTu/06tKy0DGjSUGcUqhdkq1JF719nUzrYtD4b0P3/IMNFUgJI+PYcYokrhSPcYchb/ZUvI4Dn0G5EWjbqH+abrdQjvd4LOiZ+yNbpYQ0k22x/+/1Cgv6SfDrV3rKojf+qWJ2S9ZzCYY5YFP1oMW5L7PlGK5zsZ4cI7XFKrgv5WjKtUlLr3ASyZt7tJccOQD2YhorukdCTumEmyNHyYNva1scwiUHyOKn/YnkP7KV/cpBOUa9WE1J0N43kRTpPdq4NM/Cq7OWpUQdte11MyQC9+RElj+D6C/v/6zzvSiH+X7k8L342r5v1oko5b4MQTsptsjDwq4fm+qOF3RNFrrzjBqH9dGbynShkvcjm6ufhQI9rymIr5wVomSIQqG2mlTHHx5I/OO5L7RLqlJPcuJYb21ecZF6gyWmin+5UrhWG4OftCeVDOqSytc6gqd2/iR2MAVnfCWp8uTIFftspoRUvdYdngfGRWTK0ID6vof40o4LXIC7vlVNK89fmJDXSaFyEVmQXtIP8QstWE/e52PieNn+GfcCzmXpl6X+46SNeAp5mQfOZqGQGdma/WF2WHRIAbNSsV+ihbYLlzS4seESkLrQerWThO26OD98LXvgXZ2xCmhaU+NRQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0yz/HyBLh0lUpGgwMVlR/sUgKxDfsO7xBVO6QiAr0GFjRgX5FwlfvhypKmEp?= =?us-ascii?Q?XGlSWTR4rAYc79IOGSaY+SBfETNHXB4tF9z9sSZzaZ1VPfr2/2gjmAbfiOgv?= =?us-ascii?Q?4Djz2d69ZXILU+iI9lxpqSzB39rjuMYnu/mh4e2UdJQjcrBloePmOtb71UoY?= =?us-ascii?Q?+8rm1CP3DvWQ1By3jLV+vv/XLdbyJXKb4EI5gczuI9kbjORN2ekHbZvjFk6W?= =?us-ascii?Q?W5cUGlW0tDjKKuP3IRe8n+c0eBws+nGbLNCiHHtmw//kN8Y+aiNP4dcmJXIT?= =?us-ascii?Q?7ZUEX9xUaFWcYVPvA6N6/EN0Xc4CQI9Dppwal+gbjnzjONE1ynjUaQXIobDC?= =?us-ascii?Q?M2li3ljoO9FEYtYt7dXDSeuty3wPQBDU9/ky4nsOyriWHv/GBGlMPtg/yBqK?= =?us-ascii?Q?8nmGKsx3GvPXgjRdDY3EWUsXldVNflFxXknNZMPnOvXUP4RMTwKCULtjJKRD?= =?us-ascii?Q?MTI28pffvhNIlwRkrQwIaat4/4TSppY9pJ2eQwHwuHKosHu6WXAJsntxO6ON?= =?us-ascii?Q?pZMQMwz/QaPn2sTfoTRMCLuIcdictp5YuoWvnWsByTSuK0Zfj/npdb+CaIG1?= =?us-ascii?Q?iMb7ahBrGe9S4Wow/qitvlrO2YgTDTn/4whv2ais4bVYfqiVurObSQhPIMdM?= =?us-ascii?Q?f5KpnHTbpQvtKkv7uuW02AIHSfKxeVJrDxqdVweUiWT41EpSvs18tkVvJqm5?= =?us-ascii?Q?c2Edxk2hmHXS6p8PMJmu/wsZPI7YymziAO6ylUGAE5Hnn4nVpztXl7Q03Ukj?= =?us-ascii?Q?QCC1mTccLX64Q+I9JFQ8DgbQ1ZCK4nUbuA8Dfqabon1DFM8KGSeZmrpm0OTP?= =?us-ascii?Q?m4fHpJOrj4+YQKKFGZ+As1wUgBp3gkRZa1dGqakbWLmDJXb9duV20FVYNnZC?= =?us-ascii?Q?HGssT0YcBplcV2QrA7FOBIcX2oEsUE0X6nzsRvjJmV2e+tnrTTHaq/OPPLjR?= =?us-ascii?Q?7eXdvQT0j/5uiK4xvlJmU8QIYzXfxuXbhBdnZrm/s4fsCczdthr6dx0CcgZ1?= =?us-ascii?Q?tT5QEzImggUzmgkOqjiYX08H9Hjb2DRLg9mjhypiwQaerp5R+iHhwAZYpswg?= =?us-ascii?Q?c2NNc8UqCqoza4HL5TCc/fEOyPTGOIGgHUrXd0qTR8cxLqczTDpnbCMj8B/g?= =?us-ascii?Q?gMU89gBTXGR7lvHN/O/KNf4Jbcr2mUjjrmTEu8u2f3k/WJF/OuKaUHmgibed?= =?us-ascii?Q?hsqN+fp6F6pA1DJVnKnG2GOB8NwpWKTtPxDjRUxc+P6EWij/KFNuaWi2t3RG?= =?us-ascii?Q?7a1pkXAzEVYT24Xbk3ufac4Ilx1E1ceZd3rQiiPgvAuF/E0zBtWFWXIxdR01?= =?us-ascii?Q?FXQZFVTd2/UB+TWT5OUe+X1N?= X-MS-Exchange-CrossTenant-Network-Message-Id: c5271e6a-f139-41c8-8fda-08d9459af136 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 01:10:02.6769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nFOqSiW6luY94Xws12SxK8aGaccDQ4YfAV6xhM3qHips6kXX1VgekffaicF4ttVH/j7GnuVMfIBIb03dJd2pNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB1100 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: U4i4S0VrAnQpq8eovkW74fkgWgbWxUnO X-Proofpoint-GUID: U4i4S0VrAnQpq8eovkW74fkgWgbWxUnO X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: PrjBjBBKLarGFarExkkvQSfhx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1626138635; bh=bAHoPeIo7pyV4KSxiv5lA4BY9aYBdz757s8jzb6yt3c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=othu/GZurnnSbyw0XyFW1nkBEviLnLZvK9GroGXdpx+Swl8c556Gp8YCFDPNFRC9p9U yk9597b5rfAgd4PLgAg2tdGjlxeNPvKu8TKgVwZdPB4f9LA9tdeuJL33dfQ9Cr20xtXhZ jr3GFXzfuqVRt9jexUCtPqr0wxIGfEnTAcQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1626138636705100002 Content-Type: text/plain; charset="utf-8" From: Trammell Hudson This patch initializes the linked list RegisteredRamDisks in RamDiskDxeEntryPoint before the registration of gEfiRamDiskProtocolGuid with InstallMultipleProtocolInterfaces, allowing ramdisks to be created via a callback installed with RegisterProtocolNotify as soon as the protocol is registered. Without this, calling RamDisk->Register() in the callback causes a crash: ASSERT [RamDiskDxe] MdePkg/Library/BaseLib/LinkedList.c(75): List->ForwardL= ink !=3D ((void *) 0) Signed-off-by: Trammell Hudson Cc: Daniel Schaefer Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Zhichao Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c b/MdeMo= dulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c index fcbf4f117dc6..13e2aed87cef 100644 --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c @@ -154,6 +154,12 @@ RamDiskDxeEntryPoint ( goto ErrorExit; } =20 + // + // Initialize the list of registered RAM disks maintained by the driver + // before installing the protocol + // + InitializeListHead (&RegisteredRamDisks); + // // Install the EFI_RAM_DISK_PROTOCOL and RAM disk private data onto a // new handle @@ -170,11 +176,6 @@ RamDiskDxeEntryPoint ( goto ErrorExit; } =20 - // - // Initialize the list of registered RAM disks maintained by the driver - // - InitializeListHead (&RegisteredRamDisks); - Status =3D EfiCreateEventReadyToBootEx ( TPL_CALLBACK, RamDiskAcpiCheck, --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77723): https://edk2.groups.io/g/devel/message/77723 Mute This Topic: https://groups.io/mt/84169086/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-