From nobody Mon Nov 25 05:52:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77536+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77536+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1625605000; cv=none; d=zohomail.com; s=zohoarc; b=ib3AHsgWVH8+hOBq5S4Qbmaijwg+xNKzcUjDWk7GuzyMFWaCAf1gxbINW/OLh/wS9kQtAPJ+lA4ad74on3q+LIUSuI9AcS/dVUCof76vzvjUzuhP8lJ57TjcHq7NqkPbW4HbrwNuF8lRdyFA7AHz0jaQobVrck05Iy7Fg0PqJQQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625605000; h=Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=XAv+klEXNCfHiNYiBPiGFHaHtSlwy2U8ki7AW7NiLAA=; b=JMwMtHdKbdGucy0YwCKm9FRqJWqo9gbEiWdSloI3UBe1pKM4hQoDpiKw20Wcwq8YWE5oSMrosKNI/gfT5CGkqRat/LSr5SrJP22IVwti5Tx0tTS4jaDAEXw/7DtCGCY4qW7Fm6DZihMlPSFI12un/byXHO9jnANKqoYc6q1j0rA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77536+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1625605000054508.83430961161844; Tue, 6 Jul 2021 13:56:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hmYrYY1788612xwWfwLLDDA9; Tue, 06 Jul 2021 13:56:39 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.12356.1625604999090344275 for ; Tue, 06 Jul 2021 13:56:39 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3FBB139F; Tue, 6 Jul 2021 13:56:38 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.77.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2CB0F3F5A1; Tue, 6 Jul 2021 13:56:36 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Sami Mujawar Subject: [edk2-devel] [PATCH v2 3/4] .pytool/EccCheck: Check ecc_csv exists Date: Tue, 6 Jul 2021 21:55:40 +0100 Message-Id: <20210706205541.9176-4-Pierre.Gondois@arm.com> In-Reply-To: <20210706205541.9176-1-Pierre.Gondois@arm.com> References: <20210706205541.9176-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 6ejyICPsqChTC3MuuCAWWiDmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1625604999; bh=bhXz6005SsyEMpvFbkCnrREzNkgtV4kUg0McW3Zq7xo=; h=Date:From:Reply-To:Subject:To; b=D43AZWFY/zpQCcF0AOtB9zCDz1BiD5DzftDqE3IgXhgkHZM5zrq9F77+dx2uQfDISFX wP8IX6UkmyhRyL7Vdus4w4Nn9z6BBfghAi74g9Z03aPAxhTFwrQElxpTQsTUL88Sc+zI3 qks1WFlPkSX/iCidBGlvw+XOfjfpSq6K7Ds= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1625605000499100008 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois 'workspace_path' being an absolute path leads to 'ecc_csv' being an absolute path. Then it won't be found among 'file' as they are relative paths. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Sami Mujawar Signed-off-by: Pierre Gondois --- .pytool/Plugin/EccCheck/EccCheck.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/= EccCheck.py index fff317f23110..87f0e65a140f 100644 --- a/.pytool/Plugin/EccCheck/EccCheck.py +++ b/.pytool/Plugin/EccCheck/EccCheck.py @@ -206,11 +206,10 @@ class EccCheck(ICiBuildPlugin): =20 def ParseEccReport(self, ecc_diff_range: Dict[str, List[Tuple[int, int= ]]], workspace_path: str) -> None: ecc_log =3D os.path.join(workspace_path, "Ecc.log") - ecc_csv =3D "Ecc.csv" - file =3D os.listdir(workspace_path) + ecc_csv =3D os.path.join(workspace_path, "Ecc.csv") row_lines =3D [] ignore_error_code =3D self.GetIgnoreErrorCode() - if ecc_csv in file: + if os.path.exists(ecc_csv): with open(ecc_csv) as csv_file: reader =3D csv.reader(csv_file) for row in reader: --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77536): https://edk2.groups.io/g/devel/message/77536 Mute This Topic: https://groups.io/mt/84030567/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-