From nobody Mon Feb 9 12:25:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77211+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77211+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1624902237184717.8316757699843; Mon, 28 Jun 2021 10:43:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Q82eYY1788612xZlHuTbjGZm; Mon, 28 Jun 2021 10:43:56 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.80]) by mx.groups.io with SMTP id smtpd.web12.14901.1624902231284358566 for ; Mon, 28 Jun 2021 10:43:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=So09t68duKzNdYbv1SxOOg5DcaswyktrwbwJMaFMNN+ch6Kzi08OMFDNa6YnkamySzJKYjJAyH+TJy2gtc7h52LQ9yliKIfHhNzbwZAKIzewj0fVRZ1y0CHX5xTt9n5echkbJGcbUyu1dD9wJwxKFzJg9Nfl++Inkl8lGfj2rl1/qXMIH7Hg4+8Ioo14i2ex350BygHR6lGtKTOemTthCarow40IoldU+/b3cWylCuE4eBeOq1+Z/VKwxXod8WoJEkboJios2P8pL7y0uDz2oE1Fog0YeuNRJw5tGJAtA9HpBozOhCEYheNN2oAW04lkKniErv2IXXBupfCmDBB6IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=feKMnXykpClFn+Z1vy3jA1qLSrIH3miIPsLQ6vxuftw=; b=gS9omktqFgbmR1uhu4ZIqyN0iyvMJmbok96cxeIaJd9bwzghP6jK4XzguuzUENrlZNtq3Cb8kbtfdUEbYR6huXksfZ41je1wMiMCwebQvyRAB7zSg3H+8ngLsx1FrBS0COldUyIxGwdiK42EKMuo9IpoFNxKs6yjU1OMPRr0keQCm0nswImNgMWUxd437EKskpH/GE9ikTvKxnPxAkrA6X/EJMbjlXoIM7iRVE7BrE2+0wgpPwo+5fouJNF29Wsuefeo/G5iHCmztl9Iqzniv0r2jNVyhGDsLFaalX6Ln+zykxCAETAklRAWMWdICx9Cin0h202cuMVlSA4tpNo/0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM6PR12MB2714.namprd12.prod.outlook.com (2603:10b6:5:42::18) by DM6PR12MB4761.namprd12.prod.outlook.com (2603:10b6:5:75::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Mon, 28 Jun 2021 17:43:49 +0000 X-Received: from DM6PR12MB2714.namprd12.prod.outlook.com ([fe80::7df8:b0cd:fe1b:ae7b]) by DM6PR12MB2714.namprd12.prod.outlook.com ([fe80::7df8:b0cd:fe1b:ae7b%5]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 17:43:49 +0000 From: "Brijesh Singh via groups.io" To: devel@edk2.groups.io CC: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Eric Dong , Ray Ni , Rahul Kumar , Michael D Kinney , Liming Gao , Zhiguang Liu , Michael Roth , Brijesh Singh Subject: [edk2-devel] [RFC PATCH v4 24/27] OvmfPkg/MemEncryptSevLib: skip page state change for Mmio address Date: Mon, 28 Jun 2021 12:42:20 -0500 Message-ID: <20210628174223.1302-25-brijesh.singh@amd.com> In-Reply-To: <20210628174223.1302-1-brijesh.singh@amd.com> References: <20210628174223.1302-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0601CA0020.namprd06.prod.outlook.com (2603:10b6:803:2f::30) To DM6PR12MB2714.namprd12.prod.outlook.com (2603:10b6:5:42::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SN4PR0601CA0020.namprd06.prod.outlook.com (2603:10b6:803:2f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19 via Frontend Transport; Mon, 28 Jun 2021 17:43:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da9831c2-a768-48a7-a8cc-08d93a5c497c X-MS-TrafficTypeDiagnostic: DM6PR12MB4761: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 4X5RFDOj8Qo1VwFyoZMf7geauS73oCdM4Ep0X9CUTeqMFnAqDSx+T0lWQDs8lfBy9Zp2Nu7HKjTkUivi5aLGwzeSfrRQKSDrK5QQ5LIKalhjIUyoH9dZzBcw9kemOFskKGdnjl3xnxOQeLDobciRmC43gozh2+FtB8IPQa03F5Ona63wxj6MC1DrOETDPkVW1PZxrTXO2jcPDGKJeBcc/QbPpoL+xREQMA3ObosY44M+92wq6U9z3i/oUBJTDIoTtTVc9rWa3miL/YI7SuqDY/wVR8VdP60ruNDzflT4FgGxg07g4Ej724TslRdoKyRsdNQUOzrQgA12mLHj/1sz/EOWnPYQfFhZLYrYWFNGkyMhZSRrgC+rEEXfni/x1xOKQiiZhbs+fX6jPRbcA1qm2/ukaWzDrlN8zWRzBFxnMSNJjMKoNASMdBohAcn9iBJg2U9ADBWOSuTJatbMKcTkeDD5ucXiLZE9GzEUZYi0d3MLt8ive49PAMIH0VTzqkzkBzdF/03aG3bzmiYJhjOk4Kc54x0pgXzlrRMMbUZXlkulbxSQHQTw6FlDNRqpscQ74gYSR7j5GwQXdzrqolXIckZd+DY6xMSjXEQyYVCjFkrKofoZgK/cmZ5dJYIssfqBfCb22hX83/n+MRmCMGB+pcgZZlJoTA6ECtp4ijIb6+8eN5KR7UNSQAIJcbGsgckG1xLUoMWWSg74M8Nq4oa6cg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Bg4m3Fm0sEsFwPvedb96/mGNWqXY0eIyVa8qYkgJj9+0MFd+vLxS4gaF3w9L?= =?us-ascii?Q?CndRVa6vZK4graelfnKY3K0qteBNeSxwhQWlHeD8kL3mZp8u9yobeyRa0qKh?= =?us-ascii?Q?TvKElU3wucRQVn8BfsiS1aieVhAMVvQDvadHum5powubDfEMPWyP7XOSOuWC?= =?us-ascii?Q?hZPlc/p4OXsa2Eno3HCIlWDcJnwYy4YnB2S5sv2D6/phJvhAyJg81Slmneln?= =?us-ascii?Q?AK0/RkJs2QYoWCgprM9Wg/Olx8HQ4UPAVm8Z9oSMdDLD0bI8aUGn8wul/4IN?= =?us-ascii?Q?oBxux2WobgkUp7A52bQki1G4bmuA7c3SUrm6x2GxUZeyRnszaJ2lVHVpeFeO?= =?us-ascii?Q?mmXFvp8JaH35VfBId1TR0tJmbYc8uw2y3KSvUR/S59mO8vFgqdKhtqLPWlJh?= =?us-ascii?Q?dyTZG2Q1obizxMCaGo1qpCIwgxSUuQc+WnoZe+zkJcOyB3E96Ljbj1V8jFLq?= =?us-ascii?Q?/asXFwdPEfMh/Xu5Y5+YFknWaoho2nJ4OW8WAEuNK/EG8GJ9JPhty0LHrTz9?= =?us-ascii?Q?QHBfluSgnOFgbi43sXiG/AFUZb2sAh4SNm/9bFatVZjxrxub3EAUzSpe7It6?= =?us-ascii?Q?dsXkGPCETxLsoOPO9oR8fJL6cRX0KCQiBuCK+rF5tiZy0sPK9MxxKQPboofI?= =?us-ascii?Q?X7iT/m0D+TNcNVzEvfSN/+tAv9aC+Q4JWEqYJ59KaRL8C+w9I4oUjDpt8h/g?= =?us-ascii?Q?pYpGrs0cwUalN0GDdJN6JFOOft5E3a90s0GEXECETRlSuIIZf/yTyXta3EAh?= =?us-ascii?Q?+renFH9lfjk5cEn7FtQmxxrLP8imBd/NLhh61k0KvxV41k/U1ESkcTdXa0kg?= =?us-ascii?Q?HmkiUnn8+olUpnf6BlCVRGLXAYrgEAa6J1bqhAW64IJFGDYptJZkPrM+r3wY?= =?us-ascii?Q?GtoxQO4e8oVTGKyLNURgnccUWUUBoumXzBRklfW0/gGOF6PVLhE3i551hrml?= =?us-ascii?Q?jFzZEUErD7SeDJjo9VegTkiI9aUEYQaR8pr6EJxQt1QfqwjWCEyLk0b25Lmn?= =?us-ascii?Q?TYMCmDQvKv9pGmPWIDasxM0YEUhHNYgbf0sIFJ3A6TTvoSBFbxuQMhNnONOl?= =?us-ascii?Q?IufeHFe15BfVBUGZ9tjCDRRXgX7RDjVBtwx4gUIMaEeOf5X5z7Kc+YXm57AC?= =?us-ascii?Q?t5mjAradihpbR7KhAp/Pc262ixkgVzbH6eoy2vyRUpjbDDn0OFe20HPUmnup?= =?us-ascii?Q?N9T++/iXdb4ZK2OaMHSNEZuVTUE2GetXG4bNfZADUP/kq4HykseHXyjQ8VYl?= =?us-ascii?Q?36gbHjoKlCwhVTkzHA+v4wd6thQVxRYu9J+A4Lj+FLUgJkG1DPMxbU008bM1?= =?us-ascii?Q?kf9qK5WRXsq/TxTqwGNWr8uJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: da9831c2-a768-48a7-a8cc-08d93a5c497c X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2714.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 17:43:49.5583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8hkflphrp/YqINhsEaRG0YF/IzkNVYEO77dogbgJSpR6F7hMGesForOcgUNh/D4UwYupms/GfUfr39QkPAlEtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4761 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: gkjzeNRVinRemMcAawXZqTs2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1624902236; bh=jyiHvSwvC32UPqRSHNKdu5SZVTuSmxfI1b7acJnp2nQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Mp7Tu7M1tKGe3A9+C8SONYAc6nnpmrisUZoag32sm+UnC2Tg1OqIRQaEg64u+rJOInV /SjBjw5CFPFv6g0z+xJVCsO53a0zP6swFL+psE1hW/SY0n52LFnxU1ux4rhJaT2Md8+be lh88BjwvPvaydf3R7dbhuGYIi7s6j+t0l9I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The SetMemoryEncDec() is used by the higher level routines to set or clear the page encryption mask for system RAM and Mmio address. When SEV-SNP is active, in addition to set/clear page mask it also updates the RMP table. The RMP table updates are required for the system RAM address and not the Mmio address. Add a new parameter in SetMemoryEncDec() to tell whether the specified address is Mmio. If its Mmio then skip the page state change in the RMP table. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Signed-off-by: Brijesh Singh --- .../X64/PeiDxeVirtualMemory.c | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c= b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c index 56db1e4b6ecf..0bb86d768017 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c @@ -673,6 +673,7 @@ InternalMemEncryptSevCreateIdentityMap1G ( @param[in] Mode Set or Clear mode @param[in] CacheFlush Flush the caches before applying the encryption mask + @param[in] Mmio The physical address specified is Mm= io =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -688,7 +689,8 @@ SetMemoryEncDec ( IN PHYSICAL_ADDRESS PhysicalAddress, IN UINTN Length, IN MAP_RANGE_MODE Mode, - IN BOOLEAN CacheFlush + IN BOOLEAN CacheFlush, + IN BOOLEAN Mmio ) { PAGE_MAP_AND_DIRECTORY_POINTER *PageMapLevel4Entry; @@ -711,14 +713,15 @@ SetMemoryEncDec ( =20 DEBUG (( DEBUG_VERBOSE, - "%a:%a: Cr3Base=3D0x%Lx Physical=3D0x%Lx Length=3D0x%Lx Mode=3D%a Cach= eFlush=3D%u\n", + "%a:%a: Cr3Base=3D0x%Lx Physical=3D0x%Lx Length=3D0x%Lx Mode=3D%a Cach= eFlush=3D%u Mmio=3D%u\n", gEfiCallerBaseName, __FUNCTION__, Cr3BaseAddress, PhysicalAddress, (UINT64)Length, (Mode =3D=3D SetCBit) ? "Encrypt" : "Decrypt", - (UINT32)CacheFlush + (UINT32)CacheFlush, + (UINT32)Mmio )); =20 // @@ -760,7 +763,7 @@ SetMemoryEncDec ( // // The InternalSetPageState() is used for setting the page state in the = RMP table. // - if ((Mode =3D=3D ClearCBit) && MemEncryptSevSnpIsEnabled ()) { + if (!Mmio && (Mode =3D=3D ClearCBit) && MemEncryptSevSnpIsEnabled ()) { InternalSetPageState (PhysicalAddress, EFI_SIZE_TO_PAGES (Length), Sev= SnpPageShared, FALSE); } =20 @@ -998,7 +1001,8 @@ InternalMemEncryptSevSetMemoryDecrypted ( PhysicalAddress, Length, ClearCBit, - TRUE + TRUE, + FALSE ); } =20 @@ -1031,7 +1035,8 @@ InternalMemEncryptSevSetMemoryEncrypted ( PhysicalAddress, Length, SetCBit, - TRUE + TRUE, + FALSE ); } =20 @@ -1064,6 +1069,7 @@ InternalMemEncryptSevClearMmioPageEncMask ( PhysicalAddress, Length, ClearCBit, - FALSE + FALSE, + TRUE ); } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77211): https://edk2.groups.io/g/devel/message/77211 Mute This Topic: https://groups.io/mt/83850728/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-