From nobody Thu Dec 18 20:00:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77115+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77115+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1624656150; cv=none; d=zohomail.com; s=zohoarc; b=hSVMXIjGUiVUVoyACdAiNJ1JTIDByY+LTXm+Rb8WerF8HTi/6Q+FvAF43dg10t2joi6pZiCNbQNWjozHIehxP/6PYI/yEljs4R3Kn6hiElPZvC35wchG32TsAoml8gnHxND9vrNTDBgnfnFrNcy64DNqrnUNxuZ0woy+0eJByMg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624656150; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=HBLcSZPZXEbxqgHNsLWLvtrEQ5nRESsPg4AZPIK/RyA=; b=gXQcnLD4fSApESMp4h7wWIvaXvoyQUwHobA9XbrGEjVB7rT0bJd76JL6gAHgJ4AiLFro8S3fd2GTxmUOaHMiV/lPYGvbkyhQ0a1Ufe2cNRh/Be7EMf7o4aGD7UZLokA55ORZ0ESTSop73sMHKipEt0URvKLtxmFgVLEeTnV60Bs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77115+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1624656150803206.29487578349529; Fri, 25 Jun 2021 14:22:30 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id arpzYY1788612xiTyyXSn2kU; Fri, 25 Jun 2021 14:22:30 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.354.1624656149880246443 for ; Fri, 25 Jun 2021 14:22:29 -0700 X-Received: from localhost.localdomain (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 9BD9620B83DE; Fri, 25 Jun 2021 14:22:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9BD9620B83DE From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Agyeman Prince , Nate DeSimone Subject: [edk2-devel] [edk2-platforms][PATCH v4 18/41] SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs Date: Fri, 25 Jun 2021 17:20:57 -0400 Message-Id: <20210625212120.235-19-mikuback@linux.microsoft.com> In-Reply-To: <20210625212120.235-1-mikuback@linux.microsoft.com> References: <20210625212120.235-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: xtVETPcDLkXLecBkga8ozCjWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1624656150; bh=b1CBQFpWNTnI0/oSEW/5NpX/5WYevvgT7/CtxhnI4Pw=; h=Cc:Date:From:Reply-To:Subject:To; b=OHYEiebPrzOHgIyl9kTtj8kxQkHbhlNlXluJiF3HomQKJxk+qzV1vIFEd4bSPgj4+Vc MT1pJsfSR6iN563hWZMd1uif6jvExDDpkK3CyofQijakoV5Hs5S69Nr1Og1H6Mw73SgQD EBHazzPmlgy99dLsUwnqO/OceVc4QCuCRAc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. The previous PCDs are removed from Ich10Pkg.dec. Cc: Agyeman Prince Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.= c | 2 +- Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec = | 6 ------ Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchSpi= CommonLib.inf | 5 +++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLi= b/SpiCommon.c b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommo= nLib/SpiCommon.c index 3e7dffedfbe9..f2907ef53bfc 100644 --- a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= mmon.c +++ b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= mmon.c @@ -69,7 +69,7 @@ SpiProtocolConstructor ( SpiInstance->WritePermissi= on)); =20 // - SpiInstance->TotalFlashSize =3D PcdGet32(PcdFlashAreaSize); + SpiInstance->TotalFlashSize =3D PcdGet32 (PcdBiosSize); DEBUG ((DEBUG_INFO, "Total Flash Size : %0x\n", SpiInstance->TotalFlashS= ize)); return EFI_SUCCESS; } diff --git a/Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec b/Silicon/Intel/Simi= csIch10Pkg/Ich10Pkg.dec index 0eb2e5530c3a..8d395a8b4370 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec +++ b/Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec @@ -16,11 +16,5 @@ [Includes] =20 [Ppis] =20 -[Guids] - gEfiPchTokenSpaceGuid =3D { 0x89a1b278, 0xa1a1, 0x4df7, { 0xb1, 0x37, 0x= de, 0x5a, 0xd7, 0xc4, 0x79, 0x13 } } [Protocols] gEfiSmmSpiProtocolGuid =3D {0xbd75fe35, 0xfdce, 0x49d7, {0xa9, 0xdd, 0xb= 2, 0x6f, 0x1f, 0xc6, 0xb4, 0x37}} - -[PcdsFixedAtBuild] - gEfiPchTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFFE00000|UINT32|0x100000= 01 - gEfiPchTokenSpaceGuid.PcdFlashAreaSize|0x00200000|UINT32|0x10000002 \ No newline at end of file diff --git a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLi= b/BasePchSpiCommonLib.inf b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/Bas= ePchSpiCommonLib/BasePchSpiCommonLib.inf index df1da274a642..b5aa13c1c56d 100644 --- a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BaseP= chSpiCommonLib.inf +++ b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BaseP= chSpiCommonLib.inf @@ -20,6 +20,7 @@ [Sources] =20 [Packages] MdePkg/MdePkg.dec + IntelSiliconPkg/IntelSiliconPkg.dec SimicsIch10Pkg/Ich10Pkg.dec =20 [LibraryClasses] @@ -27,5 +28,5 @@ [LibraryClasses] DebugLib =20 [Pcd] - gEfiPchTokenSpaceGuid.PcdFlashAreaBaseAddress ## CONSUMES - gEfiPchTokenSpaceGuid.PcdFlashAreaSize ## CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress ## CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize ## CONSUMES --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77115): https://edk2.groups.io/g/devel/message/77115 Mute This Topic: https://groups.io/mt/83794800/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-