From nobody Tue Feb 10 11:14:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76945+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76945+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1624448504; cv=none; d=zohomail.com; s=zohoarc; b=MITsljtcFfywhDi3mequm/zQdVDdAiRydPqTPDoZXEuhS6Awi2GQXBmJMIW887CRheRemyD/23WDi6qizgWu8G43QH6HWXW7ZdWH9gqlYWn/iVBPzbuExVYuCd4j6shoWPKSfdEtn0OIAQJoxz9VSnumvSQJlJZNYnMe5EQkbXE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624448504; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=FpdD8DjtkVdVZJCx3ljxE2jXvHWUQmlIN606ep9MCsk=; b=D5/6X3unBnn5Fu6M4avc/zcbLMwDGLVzsRq8mYzt6EuFO0E2vv9X4LLwcbAn4QAW/ENaeSb9E73CeH43xdaAL7VLlyNi932qzq6ABuL6T9V2MT6FR+8TTukMF1g6rbzREIVaz2Gc5aGoc4G1yit8LEcbcJrebuJDRaTOdm7kTwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76945+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1624448504694630.7268591710067; Wed, 23 Jun 2021 04:41:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8bdpYY1788612xJnyPXX9uhr; Wed, 23 Jun 2021 04:41:44 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.6277.1624448498840992760 for ; Wed, 23 Jun 2021 04:41:39 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E82C31B; Wed, 23 Jun 2021 04:41:38 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.78.245]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 24E823F719; Wed, 23 Jun 2021 04:41:37 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, Sami Mujawar , Alexei Fedorov Cc: Akanksha Jain , Alexandru Elisei Subject: [edk2-devel] [PATCH v1 04/13] DynamicTablesPkg: AML code generation for a Package Date: Wed, 23 Jun 2021 12:40:29 +0100 Message-Id: <20210623114039.24491-5-Pierre.Gondois@arm.com> In-Reply-To: <20210623114039.24491-1-Pierre.Gondois@arm.com> References: <20210623114039.24491-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: e6at0wC7aPMZN5821bfj0oL0x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1624448504; bh=LAxLNeO2A88lE/JPSwuWNxBVSza50lEyx1FDbRfhZX0=; h=Cc:Date:From:Reply-To:Subject:To; b=wgn/u0vsikRQNWD1ZstCQLZ7q1vPCHhd0HyOCPVnZh07HmCaujrU47WVaEgCVaxUzPc +TAoJDbypiCrIzc7sdhc0GNRxY1MP3c+5zI0vsLTvyZBcH5iXFe4HkmCUMvmSCWwdd1o4 BOfTVk6+PfPmQjKw8iZB+44r8XedNyL4CGc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Add AmlCodeGenPackage() to generate AML code for declaring a Package() object. This function generates an empty package node. New elements can then be added to the package's variable argument list. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Common/AmlLib/CodeGen/AmlCodeGen.c | 82 ++++++++++++++++++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index 5d310f201319..ea9b73b464a4 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -1,7 +1,7 @@ /** @file AML Code Generation. =20 - Copyright (c) 2020, Arm Limited. All rights reserved.
+ Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -235,6 +235,86 @@ AmlCodeGenInteger ( return Status; } =20 +/** AML code generation for a Package object node. + + The package generated is empty. New elements can be added via its + list of variable arguments. + + @param [out] NewObjectNode If success, contains the created + Package object node. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. +**/ +STATIC +EFI_STATUS +EFIAPI +AmlCodeGenPackage ( + OUT AML_OBJECT_NODE ** NewObjectNode + ) +{ + EFI_STATUS Status; + AML_DATA_NODE * DataNode; + UINT8 NodeCount; + + if (NewObjectNode =3D=3D NULL) { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + DataNode =3D NULL; + NodeCount =3D 0; + + // Create an object node. + // PkgLen is 2: + // - one byte to store the PkgLength + // - one byte for the NumElements. + // Cf ACPI6.3, s20.2.5 "Term Objects Encoding" + // DefPackage :=3D PackageOp PkgLength NumElements PackageElementList + // NumElements :=3D ByteData + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_PACKAGE_OP, 0), + 2, + NewObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + return Status; + } + + // NumElements is a ByteData. + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeUInt, + &NodeCount, + sizeof (NodeCount), + &DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + goto error_handler; + } + + Status =3D AmlSetFixedArgument ( + *NewObjectNode, + EAmlParseIndexTerm0, + (AML_NODE_HEADER*)DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + goto error_handler; + } + + return Status; + +error_handler: + AmlDeleteTree ((AML_NODE_HEADER*)*NewObjectNode); + if (DataNode !=3D NULL) { + AmlDeleteTree ((AML_NODE_HEADER*)DataNode); + } + return Status; +} + /** AML code generation for a Name object node. =20 @param [in] NameString The new variable name. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76945): https://edk2.groups.io/g/devel/message/76945 Mute This Topic: https://groups.io/mt/83735653/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-