From nobody Tue Feb 10 04:08:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76896+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76896+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1624416778; cv=none; d=zohomail.com; s=zohoarc; b=GMGwmn2M0s3E8ffJ6AC7PZL+ZhQOFinVCXTRM1z7Kcco3rg6FdrK4zPqJdzh+vW0lIkXU6wqOYkc93os0xBVj6OruOapdXG8k4LoGiSmdpF3I+i5pHMJOY2o0JFUw+Kx19Ru4/+WemNJpAmgHYw5Z4ezT5MAaXSwmLFrK2gVjJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624416778; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=WzdCmmwXmRAdk+fwcseftt+FIW0JYQOBzhBGqx7DVXU=; b=euQgmVDZHhM5IVFr9m3A/QR8/dsDO6owP48WSvdo+GH41vs0dkUb/9JNtl+rsu2PBXmfC2fie07eT+YgJThOCblNGVJ5X8Z2EBQCMfohU801uzZQ6OZARAJzFR8f5cqNEXy9b+zpeQcX0OpCm9sNmLC6nw3/nIGZgCjDhLAHWQI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76896+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1624416778433278.13417440180433; Tue, 22 Jun 2021 19:52:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id U6RJYY1788612x7hekoLV8bt; Tue, 22 Jun 2021 19:52:58 -0700 X-Received: from mga11.intel.com (mga11.intel.com []) by mx.groups.io with SMTP id smtpd.web11.2469.1624416764968334886 for ; Tue, 22 Jun 2021 19:52:57 -0700 IronPort-SDR: rPDc2WCmfEpU6joJqODUtPXtju6Jkaa2+ONfO3DJBUy/Rv1PvVo7TAicUNoHVzUe946PExhrZo v1cB0qmDgO5A== X-IronPort-AV: E=McAfee;i="6200,9189,10023"; a="204175555" X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="204175555" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 19:52:57 -0700 IronPort-SDR: glNlOkx0cwoH4QXscyR0S2KDGScBQ4Kl8KHVdiqf8M9mFdvWbm0avUcuXMsNgTg9IY3erYInTO Oj8idLDH/ygw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="487138342" X-Received: from fieedk002.ccr.corp.intel.com ([10.239.158.144]) by orsmga001.jf.intel.com with ESMTP; 22 Jun 2021 19:52:55 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Maurice Ma , Guo Dong , Benjamin You Subject: [edk2-devel] [Patch V2 09/12] UefiPayloadPkg: Remove assert when reserve MMIO/IO resource for devices Date: Wed, 23 Jun 2021 10:52:32 +0800 Message-Id: <20210623025235.3311-10-zhiguang.liu@intel.com> In-Reply-To: <20210623025235.3311-1-zhiguang.liu@intel.com> References: <20210623025235.3311-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: mqSiJ0UFYvjC1Twfi8CJH3Btx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1624416778; bh=NNLiOnzOFQQNlD0SCkAXxsRDXqY2gvL1eDGUEQCYSBI=; h=Cc:Date:From:Reply-To:Subject:To; b=ErV56B1hbmTBYiIMWQwiVzm83eka0ANpnwiGVo3OPPlO8iuvIL6ZdMONqWtuayanNM0 /wQ1WNEi83DKj+Au3tQQ8248z94T8/Hq+Rt3Fz7C8b1epI5wgV8xHa+W/ro2xAfOEJYug VZbRvJWLZ6QS5J2BtihenNlMmZEbOnbBa3k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Some boot loader may already reserve MMIO/IO resource for IOAPIC and HPET, so remove the assert when reserve MMIO/IO resource for IOAPIC and HPET Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Reviewed-by: Guo Dong Signed-off-by: Zhiguang Liu --- UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c b/UefiPayloadPkg/Bl= SupportDxe/BlSupportDxe.c index ffd3427fb3..04e968a232 100644 --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c @@ -41,13 +41,12 @@ ReserveResourceInGcd ( ); if (EFI_ERROR (Status)) { DEBUG (( - DEBUG_ERROR, + DEBUG_WARN, "Failed to add memory space :0x%lx 0x%lx\n", BaseAddress, Length )); } - ASSERT_EFI_ERROR (Status); Status =3D gDS->AllocateMemorySpace ( EfiGcdAllocateAddress, GcdType, @@ -57,14 +56,20 @@ ReserveResourceInGcd ( ImageHandle, NULL ); - ASSERT_EFI_ERROR (Status); } else { Status =3D gDS->AddIoSpace ( GcdType, BaseAddress, Length ); - ASSERT_EFI_ERROR (Status); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_WARN, + "Failed to add IO space :0x%lx 0x%lx\n", + BaseAddress, + Length + )); + } Status =3D gDS->AllocateIoSpace ( EfiGcdAllocateAddress, GcdType, @@ -74,7 +79,6 @@ ReserveResourceInGcd ( ImageHandle, NULL ); - ASSERT_EFI_ERROR (Status); } return Status; } @@ -106,11 +110,9 @@ BlDxeEntryPoint ( // // Report MMIO/IO Resources // - Status =3D ReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0= xFEC00000, SIZE_4KB, 0, ImageHandle); // IOAPIC - ASSERT_EFI_ERROR (Status); + ReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEC00000, = SIZE_4KB, 0, ImageHandle); // IOAPIC =20 - Status =3D ReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0= xFED00000, SIZE_1KB, 0, ImageHandle); // HPET - ASSERT_EFI_ERROR (Status); + ReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFED00000, = SIZE_1KB, 0, ImageHandle); // HPET =20 // // Find the frame buffer information and update PCDs --=20 2.30.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76896): https://edk2.groups.io/g/devel/message/76896 Mute This Topic: https://groups.io/mt/83730187/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-