From nobody Thu May 2 20:23:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76553+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76553+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623776051; cv=none; d=zohomail.com; s=zohoarc; b=CBCPdQ3iz97vCrDvNcMACWM8248YwE/4dc/07wOFkZFuOLdVH4EEJQt8yW8nlU5QPNaGok9LeZgPuU2HX9YFhigz2jxCdcI/wLMxBmqijtGcahseZjzk7v+wR75QbqPi6WTJ6824z4kO+S/xwFHKfHaFw2aJu+vxPqvhUe2t84I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623776051; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZvCcg/j59MxQ7Tff9DYarX04d7sBSFFEynwtLO0ZQXs=; b=LvGXHk6icou6LfJZYvjXqyv6NECP1C3CDRq0aBcuhvaDoebt5WYIjcIhFikET0/Z65nfmL7w8I3s99R1AnpHEK7VdLywJjbF4qPRnbVOSv348TjFqMi1JnFmWNT3ZKwFJIZ7ZaMDYZQlFJoid5dN0TSlqyLaC9m7yzxHBg86IAo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76553+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623776050999588.0872613303225; Tue, 15 Jun 2021 09:54:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 2z8xYY1788612xI3lpwKzWYZ; Tue, 15 Jun 2021 09:54:10 -0700 X-Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web08.350.1623776050053029923 for ; Tue, 15 Jun 2021 09:54:10 -0700 X-Received: by mail-pj1-f41.google.com with SMTP id o10-20020a17090aac0ab029016e92770073so2609403pjq.5 for ; Tue, 15 Jun 2021 09:54:10 -0700 (PDT) X-Gm-Message-State: lsfBmgvDryE9JyzjUdcvMcPjx1787277AA= X-Google-Smtp-Source: ABdhPJw+AbwyC9zP65rXNy2FmnzefgS4wH0upsAHj6U2ScdmBYF5ulWWpu0CDj4u/KIOXSZ13boF5g== X-Received: by 2002:a17:90a:e512:: with SMTP id t18mr146290pjy.158.1623776049408; Tue, 15 Jun 2021 09:54:09 -0700 (PDT) X-Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id o16sm15492527pfu.75.2021.06.15.09.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 09:54:08 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Bret Barkelew Subject: [edk2-devel] [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Date: Tue, 15 Jun 2021 09:53:57 -0700 Message-Id: <20210615165357.1993-2-kuqin12@gmail.com> In-Reply-To: <20210615165357.1993-1-kuqin12@gmail.com> References: <20210615165357.1993-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623776050; bh=yFRMF6Gp00qPhK6ObZ2clEXufyOYg/maqrsyKGromc0=; h=Cc:Date:From:Reply-To:Subject:To; b=wtOV1i2evx3UQ3Kwj6iIAD84vnvzKLidXSBCrhDFW2XjNvwVq25nlaxEXzabnadnqTu FuXNOOc64yDU7ReAEeEuCPxX9rpILoHHLzwLRUF+vaLXopuUKMGfc1imz7EasecdILLkC xOVaGy2d34vaoyeoYObP3hoZoSr4qg+qel8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This change adds additional quotes to defer expansion in order to bring parity in cspell result. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Signed-off-by: Kun Qin Reviewed-by: Sean Brogan Reviewed-by: Bret Barkelew Reviewed-by: Liming Gao --- Notes: v2: - Added reviewed-by tags [Bret] - Added reviewed-by tag [Sean] - Added signed-off-by tag from Kun [Sean] .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/Spell= Check/SpellCheck.py index 9ad57632a6e8..05c471d91ba1 100644 --- a/.pytool/Plugin/SpellCheck/SpellCheck.py +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py @@ -134,7 +134,8 @@ class SpellCheck(ICiBuildPlugin): # relpath =3D os.path.relpath(abs_pkg_path) cpsell_paths =3D " ".join( - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_= check]) + # Double quote each path to defer expansion to cspell paramete= rs + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spel= l_check]) =20 # Make the config file config_file_path =3D os.path.join( --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76553): https://edk2.groups.io/g/devel/message/76553 Mute This Topic: https://groups.io/mt/83560569/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-