From nobody Mon Apr 29 04:02:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76517+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76517+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=9elements.com ARC-Seal: i=1; a=rsa-sha256; t=1623763386; cv=none; d=zohomail.com; s=zohoarc; b=WTfq+uYD0mNDLzaU80WkYy9CSyEA28W3gnT25tohsirFuKDJ4rc6Y2ciIcGJ4JRc5PZsrRrA/B+0waT8T/XYGXWz02+hqtLEcYdrtjgNkgYqhPgFtelldqZKz8al4hVhB5xtu6GECXQ4+wWEj2HBNMBlBUswkl3L+4O3d1F2PpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623763386; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=i92heVfRC4hAmUfyA+yCVoJY1S9F/D3JrmIFjbUP/vw=; b=n2p+Cn6SQqLQwHEmRdDAAqDekhMMcEanyl+hY983ix0i3aa0vbNU1C5PycAq1SKhI/jot8skFpyIGG7y2vNQPgOyA41tmND+3rTed5klaQxW7pU2ieS/o/gLUAqOkz9S5GJOkIE1JZdbkAw3y/UI5jpxEK18LrhRqOee2Qhh0u4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76517+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623763386488120.82758333856464; Tue, 15 Jun 2021 06:23:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id w7EqYY1788612xraW9V4ecxZ; Tue, 15 Jun 2021 06:23:06 -0700 X-Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mx.groups.io with SMTP id smtpd.web09.9052.1623763380209406115 for ; Tue, 15 Jun 2021 06:23:00 -0700 X-Received: by mail-ej1-f44.google.com with SMTP id hq2so441661ejc.2 for ; Tue, 15 Jun 2021 06:22:59 -0700 (PDT) X-Gm-Message-State: zNvuUU7PT0z2oPXJLWrIn6LHx1787277AA= X-Google-Smtp-Source: ABdhPJyt0KZhuallDfa1J7sWDn8RnrNdAXoDNezzG0QXfkBMpHK2W9xxinMVvQ0jFoCvrIWdjusDtg== X-Received: by 2002:a17:907:1b20:: with SMTP id mp32mr20875599ejc.495.1623763375880; Tue, 15 Jun 2021 06:22:55 -0700 (PDT) X-Received: from rudolphp-notebook.sr1.9esec.dev (ip-178-202-79-247.hsi09.unitymediagroup.de. [178.202.79.247]) by smtp.gmail.com with ESMTPSA id q5sm7433798ejc.117.2021.06.15.06.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 06:22:55 -0700 (PDT) From: "Patrick Rudolph" To: devel@edk2.groups.io Cc: maurice.ma@intel.com, guo.dong@intel.com, benjamin.you@intel.com Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing Date: Tue, 15 Jun 2021 15:22:54 +0200 Message-Id: <20210615132254.3364910-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,patrick.rudolph@9elements.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623763386; bh=y7kEjO+ezpBHnIcLy9mwfw5v5bH1HgxYN6Vf/tqtHuw=; h=Cc:Date:From:Reply-To:Subject:To; b=EfqbRwgpvNKEWdxw6LK+ab5OewrCNcQLuo/f7jfWpZJz9kBCKrvfjeO+BsmxoBbLhF8 Cqeb9VXDpGjr5UAV1VQ1k7sVBRQBu0D6jY1H0d6NlA/ghnJPR/hvdBJpQEbfZd0Mq+TjW 8Y0q+wB8Os5hePRWyRwfG+2LY0ylfOzoozQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Currently several DXE crash due to invalid memory resource settings. coreboot and slimbootloader provide an e820 compatible memory map, which doesn't work well with EDK2 as the e820 spec is missing MMIO regions. In e820 'reserved' could either mean "DRAM used by boot firmware" or "MMIO in use and not detectable by OS". Guess Top of lower usable DRAM (TOLUD) by walking memory ranges and then mark everything reserved below TOLUD as DRAM and everything reserved above TOLUD as MMIO. This fixes several assertions seen in PciHostBridgeDxe. Signed-off-by: Patrick Rudolph --- .../UefiPayloadEntry/UefiPayloadEntry.c | 187 +++++++++++++++++- .../UefiPayloadEntry/UefiPayloadEntry.h | 10 + 2 files changed, 194 insertions(+), 3 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPaylo= adPkg/UefiPayloadEntry/UefiPayloadEntry.c index 805f5448d9..d20e1a0862 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c @@ -7,10 +7,162 @@ =20 #include "UefiPayloadEntry.h" =20 +STATIC UINT32 TopOfLowerUsableDram =3D 0; + /** Callback function to build resource descriptor HOB =20 This function build a HOB based on the memory map entry info. + It creates only EFI_RESOURCE_MEMORY_MAPPED_IO and EFI_RESOURCE_MEMORY_R= ESERVED + resources. + + @param MemoryMapEntry Memory map entry info got from bootloader. + @param Params A pointer to ACPI_BOARD_INFO. + + @retval RETURN_SUCCESS Successfully build a HOB. + @retval EFI_INVALID_PARAMETER Invalid parameter provided. +**/ +EFI_STATUS +MemInfoCallbackMMIO ( + IN MEMROY_MAP_ENTRY *MemoryMapEntry, + IN VOID *Params + ) +{ + EFI_PHYSICAL_ADDRESS Base; + EFI_RESOURCE_TYPE Type; + UINT64 Size; + EFI_RESOURCE_ATTRIBUTE_TYPE Attribue; + ACPI_BOARD_INFO *AcpiBoardInfo; + + AcpiBoardInfo =3D (ACPI_BOARD_INFO *)Params; + if (AcpiBoardInfo =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + // + // Skip types already handled in MemInfoCallback + // + if (MemoryMapEntry->Type =3D=3D E820_RAM || MemoryMapEntry->Type =3D=3D = E820_ACPI) { + return RETURN_SUCCESS; + } + + if (MemoryMapEntry->Base =3D=3D AcpiBoardInfo->PcieBaseAddress) { + // + // MMCONF is always MMIO + // + Type =3D EFI_RESOURCE_MEMORY_MAPPED_IO; + } else if (MemoryMapEntry->Base < TopOfLowerUsableDram) { + // + // It's in DRAM and thus must be reserved + // + Type =3D EFI_RESOURCE_MEMORY_RESERVED; + } else if (MemoryMapEntry->Base < 0x100000000ULL && + MemoryMapEntry->Base >=3D TopOfLowerUsableDram) { + // + // It's not in DRAM, must be MMIO + // + Type =3D EFI_RESOURCE_MEMORY_MAPPED_IO; + } else { + Type =3D EFI_RESOURCE_MEMORY_RESERVED; + } + + Base =3D MemoryMapEntry->Base; + Size =3D MemoryMapEntry->Size; + + Attribue =3D EFI_RESOURCE_ATTRIBUTE_PRESENT | + EFI_RESOURCE_ATTRIBUTE_INITIALIZED | + EFI_RESOURCE_ATTRIBUTE_TESTED | + EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | + EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | + EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | + EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE; + + BuildResourceDescriptorHob (Type, Attribue, (EFI_PHYSICAL_ADDRESS)Base, = Size); + DEBUG ((DEBUG_INFO , "buildhob: base =3D 0x%lx, size =3D 0x%lx, type =3D= 0x%x\n", Base, Size, Type)); + + if (MemoryMapEntry->Type =3D=3D E820_NVS) { + BuildMemoryAllocationHob (Base, Size, EfiACPIMemoryNVS); + } else if (MemoryMapEntry->Type =3D=3D E820_UNUSABLE || + MemoryMapEntry->Type =3D=3D E820_DISABLED) { + BuildMemoryAllocationHob (Base, Size, EfiUnusableMemory); + } else if (MemoryMapEntry->Type =3D=3D E820_PMEM) { + BuildMemoryAllocationHob (Base, Size, EfiPersistentMemory); + } + + return RETURN_SUCCESS; +} + + +/** + Callback function to find TOLUD (Top of Lower Usable DRAM) + + Estimate where TOLUD (Top of Lower Usable DRAM) resides. The exact posi= tion + would require platform specific code. + + @param MemoryMapEntry Memory map entry info got from bootloader. + @param Params Not used for now. + + @retval RETURN_SUCCESS Successfully updated TopOfLowerUsableDram. +**/ +EFI_STATUS +FindToludCallback ( + IN MEMROY_MAP_ENTRY *MemoryMapEntry, + IN VOID *Params + ) +{ + // + // This code assumes that the memory map on this x86 machine below 4GiB = is continous + // until TOLUD. In addition it assumes that the bootloader provided memo= ry tables have + // no "holes" and thus the first memory range not covered by e820 marks = the end of + // usable DRAM. In addition it's assumed that every reserved memory regi= on touching + // usable RAM is also covering DRAM, everything else that is marked rese= rved thus must be + // MMIO not detectable by bootloader/OS + // + + // + // Skip memory types not RAM or reserved + // + if (MemoryMapEntry->Type =3D=3D E820_NVS || MemoryMapEntry->Type =3D=3D = E820_UNUSABLE || + MemoryMapEntry->Type =3D=3D E820_DISABLED || MemoryMapEntry->Type =3D= =3D E820_PMEM) { + return RETURN_SUCCESS; + } + + // + // Skip resources above 4GiB + // + if (MemoryMapEntry->Base >=3D 0x100000000ULL) { + return RETURN_SUCCESS; + } + + if ((MemoryMapEntry->Type =3D=3D E820_RAM) || + (MemoryMapEntry->Type =3D=3D E820_ACPI)) { + // + // It's usable DRAM. Update TOLUD. + // + if (TopOfLowerUsableDram < (MemoryMapEntry->Base + MemoryMapEntry->Siz= e)) { + TopOfLowerUsableDram =3D MemoryMapEntry->Base + MemoryMapEntry->Size; + } + } else { + // + // It might be reserved DRAM or MMIO. + // + // If it touches usable DRAM at Base assume it's DRAM as well, + // as it could be bootloader installed tables, TSEG, GTT, ... + // + if (TopOfLowerUsableDram =3D=3D MemoryMapEntry->Base) { + TopOfLowerUsableDram =3D MemoryMapEntry->Base + MemoryMapEntry->Size; + } + } + + return RETURN_SUCCESS; +} + + +/** + Callback function to build resource descriptor HOB + + This function build a HOB based on the memory map entry info. + Only add EFI_RESOURCE_SYSTEM_MEMORY. =20 @param MemoryMapEntry Memory map entry info got from bootloader. @param Params Not used for now. @@ -28,7 +180,15 @@ MemInfoCallback ( UINT64 Size; EFI_RESOURCE_ATTRIBUTE_TYPE Attribue; =20 - Type =3D (MemoryMapEntry->Type =3D=3D 1) ? EFI_RESOURCE_SYSTEM_MEMORY= : EFI_RESOURCE_MEMORY_RESERVED; + // + // Skip everything not known to be usable DRAM. + // It will be added later. + // + if (MemoryMapEntry->Type !=3D E820_RAM && MemoryMapEntry->Type !=3D E820= _ACPI) { + return RETURN_SUCCESS; + } + + Type =3D EFI_RESOURCE_SYSTEM_MEMORY; Base =3D MemoryMapEntry->Base; Size =3D MemoryMapEntry->Size; =20 @@ -40,7 +200,7 @@ MemInfoCallback ( EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE; =20 - if (Base >=3D BASE_4GB ) { + if (Base >=3D BASE_4GB) { // Remove tested attribute to avoid DXE core to dispatch driver to mem= ory above 4GB Attribue &=3D ~EFI_RESOURCE_ATTRIBUTE_TESTED; } @@ -48,6 +208,10 @@ MemInfoCallback ( BuildResourceDescriptorHob (Type, Attribue, (EFI_PHYSICAL_ADDRESS)Base, = Size); DEBUG ((DEBUG_INFO , "buildhob: base =3D 0x%lx, size =3D 0x%lx, type =3D= 0x%x\n", Base, Size, Type)); =20 + if (MemoryMapEntry->Type =3D=3D E820_ACPI) { + BuildMemoryAllocationHob (Base, Size, EfiACPIReclaimMemory); + } + return RETURN_SUCCESS; } =20 @@ -236,7 +400,16 @@ BuildHobFromBl ( EFI_PEI_GRAPHICS_DEVICE_INFO_HOB *NewGfxDeviceInfo; =20 // - // Parse memory info and build memory HOBs + // First find TOLUD + // + Status =3D ParseMemoryInfo (FindToludCallback, NULL); + if (EFI_ERROR(Status)) { + return Status; + } + DEBUG ((DEBUG_INFO , "Assuming TOLUD =3D 0x%x\n", TopOfLowerUsableDram)); + + // + // Parse memory info and build memory HOBs for Usable RAM // Status =3D ParseMemoryInfo (MemInfoCallback, NULL); if (EFI_ERROR(Status)) { @@ -289,6 +462,14 @@ BuildHobFromBl ( DEBUG ((DEBUG_INFO, "Create acpi board info guid hob\n")); } =20 + // + // Parse memory info and build memory HOBs for reserved DRAM and MMIO + // + Status =3D ParseMemoryInfo (MemInfoCallbackMMIO, &AcpiBoardInfo); + if (EFI_ERROR(Status)) { + return Status; + } + // // Parse platform specific information. // diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPaylo= adPkg/UefiPayloadEntry/UefiPayloadEntry.h index 2c84d6ed53..35ea23d202 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h @@ -38,6 +38,16 @@ #define GET_OCCUPIED_SIZE(ActualSize, Alignment) \ ((ActualSize) + (((Alignment) - ((ActualSize) & ((Alignment) - 1))) & ((= Alignment) - 1))) =20 + +#define E820_RAM 1 +#define E820_RESERVED 2 +#define E820_ACPI 3 +#define E820_NVS 4 +#define E820_UNUSABLE 5 +#define E820_DISABLED 6 +#define E820_PMEM 7 +#define E820_UNDEFINED 8 + /** Auto-generated function that calls the library constructors for all of t= he module's dependent libraries. --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76517): https://edk2.groups.io/g/devel/message/76517 Mute This Topic: https://groups.io/mt/83555387/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-