From nobody Sun Apr 28 18:54:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76428+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76428+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623474284; cv=none; d=zohomail.com; s=zohoarc; b=moRA2JnHbnLzsmiugtn/K8l7Vn9tUtaPiZJ5G3vugSg+uIRO1m7mbzRLyugKiMjUfQz4nBGIaPg5AFLXi++GQ5VkIJZn3MLq62jPBxK6dnZ/bnR+6r4knsZybVYrXlyYlqo5bGBlMP5GbHhE8Pe8IVrNYcNKn7MUPLOvrx+TWiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623474284; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7smB2DTwM2UDST31LzTs9tDsfkUFE1wmj1R0BmQpFXg=; b=Z1IlxRfFmx08eXPOnuxXOmkninDQGTivvznMPxGlqYJWnKG97IAOdB+nULA8agnDDxD2khTVwOXQPzW2UgqXIvQooa6Z58tGT1xbhfjAm9c1VgAUUGUbn99qBHrAf8PCz0UdilXsPh3/OQOpBWyz4dnQ4CVQkDJJ2xJMdErKvXI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76428+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623474284168502.38220314641217; Fri, 11 Jun 2021 22:04:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RQDiYY1788612xCwNX9sLbML; Fri, 11 Jun 2021 22:04:43 -0700 X-Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mx.groups.io with SMTP id smtpd.web09.2592.1623474283365324223 for ; Fri, 11 Jun 2021 22:04:43 -0700 X-Received: by mail-pj1-f44.google.com with SMTP id k5so6796622pjj.1 for ; Fri, 11 Jun 2021 22:04:43 -0700 (PDT) X-Gm-Message-State: 2MjhPtXyY6WjyOQK7VziAA36x1787277AA= X-Google-Smtp-Source: ABdhPJzvoz/a2DIS1y134UHu6SgezMVqVO7p2EQlu9qx5WGiKpcvurdghLr99y+CTqwOu++68m0ZOg== X-Received: by 2002:a17:902:778d:b029:119:3443:9ebd with SMTP id o13-20020a170902778db029011934439ebdmr2868116pll.45.1623474282614; Fri, 11 Jun 2021 22:04:42 -0700 (PDT) X-Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id n37sm6363485pfv.47.2021.06.11.22.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 22:04:42 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Date: Fri, 11 Jun 2021 22:04:31 -0700 Message-Id: <20210612050431.660-2-kuqin12@gmail.com> In-Reply-To: <20210612050431.660-1-kuqin12@gmail.com> References: <20210612050431.660-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623474283; bh=NHmDt/FiBWzRBkrYBDKG6kTvEGNQMmWM4QSoYfD6b4E=; h=Cc:Date:From:Reply-To:Subject:To; b=Ka98HYumbhArs/SSyJfdJBOX3H27b8vRjNcNWeBS/NIFgEPZVzrXoZHiAJtwlq3BWYA idVRJM/xT+a9ItfeaA6IZNDUg77AN2AnbuJAwRasEDetDIml05DIEmggRve142C3wcGOW 1J1uGF0kd3AzU4C4Sj3g51TpBldGL8A8TYo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This change adds additional quotes to defer expansion in order to bring parity in cspell result. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Reviewed-by: Bret Barkelew Reviewed-by: Sean Brogan --- .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/Spell= Check/SpellCheck.py index 43365441b91c..97b240ef747c 100644 --- a/.pytool/Plugin/SpellCheck/SpellCheck.py +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin): # relpath =3D os.path.relpath(abs_pkg_path) cpsell_paths =3D " ".join( - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_= check]) + # Double quote each path to defer expansion to cspell paramete= rs + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spel= l_check]) =20 # Make the config file config_file_path =3D os.path.join( --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76428): https://edk2.groups.io/g/devel/message/76428 Mute This Topic: https://groups.io/mt/83484917/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-