From nobody Sun Apr 28 00:16:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76400+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76400+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1623429503; cv=none; d=zohomail.com; s=zohoarc; b=T+IOjbLN9xwIB/ZsKpq2WXZ7TDnuiJPfiJrI1QrInMe6Gen5amtm2eZtUf6cU2p7PsnLLB/yp6B6/Xb+sYNhmJ9+ggP26kSPQHezpKEsOP2MdHk3Nrst9Fo4A/EMYhOBrffjBPdPJXlCD3LUo3NFu6C/mig1WGDdW0WnbPCXoHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623429503; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=XpK/I8BV5nLCmjzpQLj6Mj64G7J5SCtwUUo1Sdje4xM=; b=VpEddAYWn0j22MprPggvGOa9Lu6WcZJbqiQq0NzZgbCZQBr3aAGScCawZzKxh+gRbaLngDC3yTQh+kW0108kBuSG68z67HPHNRuv6DsnKP+dhP4e2SiHkKDosNbhKjxSA2UYtBgpdoVjoytUExR2EXrreWLj9T3giBr6W2dCvOM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76400+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 162342950363515.79237041203703; Fri, 11 Jun 2021 09:38:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id e2uqYY1788612xFCEicVU1ec; Fri, 11 Jun 2021 09:38:23 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.10839.1623429500921763798 for ; Fri, 11 Jun 2021 09:38:21 -0700 IronPort-SDR: fhtuozAMYxNuy2kTvKjdhlpDELXzAKEK8cfpwMQQ42QA1gAtpfAfUBVRAo6fp7MOvMP4Xpo1sM iu3/tOQsKhOg== X-IronPort-AV: E=McAfee;i="6200,9189,10012"; a="185252436" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="185252436" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 09:37:59 -0700 IronPort-SDR: +SGpg1HmcGG89/4MsBH8lmRXlBTzFFWf0zitZ3hVuUvwdZfO2qRP4H3sJ8zfyR/we3nUa4PGiG tibftGc5oCbg== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="441607046" X-Received: from svenur-desk1.amr.corp.intel.com ([10.9.69.84]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 09:37:59 -0700 From: "Sumana Venur" To: devel@edk2.groups.io Cc: Sumana Venur Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Date: Fri, 11 Jun 2021 09:37:44 -0700 Message-Id: <20210611163744.19368-1-sumana.venur@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sumana.venur@intel.com X-Gm-Message-State: 3QlBnHKoJq3VeqSAqUWIuuPUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623429503; bh=s5ShbGz6rOsQ3rWOpiQuHxA9zEmHglxjQxoms8U+ctw=; h=Cc:Date:From:Reply-To:Subject:To; b=w3IfTQ/cTJWE77BnjgVJgnVgpyEbOtFSsgNoGKXawYBfXVi7q3jhe9lY0qPSyaB8+tR yK+b072MSE2q4wu2HcV7Ym0KVcJLDz8MJx+avNAyWXcD8B/YEJvwRxSjenIBxNnEMq+7i kkz1ER+q/BQP0qw0t5+DhXGULh077R15TFI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2989 Long times spent on shadowing oprom from graphics card to system memory. We= are currently using 8 bit read cycles. This needs to be wider, at least 32bit reads to reduce the time for oprom s= hadow Signed-off-by: Sumana Venur --- MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModu= lePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c index c994ed5fe3..a981f93f43 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c @@ -521,9 +521,9 @@ LoadOpRomImage ( // PciDevice->PciRootBridgeIo->Mem.Read ( PciDevice->PciRootBridgeIo, - EfiPciWidthUint8, + EfiPciWidthUint32, RomBar, - (UINT32) RomImageSize, + (UINT32) RomImageSize/sizeof(UINT32), Image ); RomInMemory =3D Image; --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76400): https://edk2.groups.io/g/devel/message/76400 Mute This Topic: https://groups.io/mt/83472822/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-